[pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-18 Thread René Jochum
Also fixes a minor spelling error in changelog.Debian and extends the .gitignore to ignore build files. I've made this so i get a .changes file which i need for my dput usage. --- .gitignore | 7 +++ Makefile| 36 +++--

[pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Rene Jochum
Thanks again, comments inline. On 2018-04-19 10:16, Fabian Grünbichler wrote: >> @@ -52,23 +54,27 @@ install: PVE/RADOS.pm RADOS.so >> .PHONY: deb ${DEB} >> deb: ${DEB} >> ${DEB}: >> -rm -rf debian >> -mkdir debian >> -make DESTDIR=${CURDIR}/debian install >> -install -d -m 0755

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Fabian Grünbichler
thanks for this! one of the leftover packages which we haven't converted so far (for lack of recent changes). now that Alwin did some changes and is planning to do some more, it's probably a good idea to convert it. some comments inline (your patch also only applies when ignoring whitespace change

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Rene Jochum
On 2018-04-19 10:16, Fabian Grünbichler wrote: > some comments inline (your patch also only applies when ignoring > whitespace changes!) Hi Fabian, thank you for looking into it! Can you give me a tip on making patches that apply without ignoring white space changes? Will implement all the give

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Fabian Grünbichler
On Thu, Apr 19, 2018 at 11:02:44AM +0200, Rene Jochum wrote: > On 2018-04-19 10:16, Fabian Grünbichler wrote: > > some comments inline (your patch also only applies when ignoring > > whitespace changes!) > > > Hi Fabian, > > thank you for looking into it! Can you give me a tip on making patches

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Fabian Grünbichler
On Thu, Apr 19, 2018 at 11:31:08AM +0200, Rene Jochum wrote: > Thanks again, comments inline. > > On 2018-04-19 10:16, Fabian Grünbichler wrote: > >> @@ -52,23 +54,27 @@ install: PVE/RADOS.pm RADOS.so > >> .PHONY: deb ${DEB} > >> deb: ${DEB} > >> ${DEB}: > >> - rm -rf debian > >> - mkdir debi