Re: [pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Fabian Grünbichler
On Mon, Jul 15, 2019 at 11:26:17AM +0200, Thomas Lamprecht wrote: > Am 7/15/19 um 11:17 AM schrieb Dominik Csapak: > >> > >> and the case where some OSDs did not got yet "upgraded" to > >> ceph-volume/nautilus > >> but a new one was created cannot happen? > >> > > no it should not as the upgrade g

Re: [pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Thomas Lamprecht
Am 7/15/19 um 11:17 AM schrieb Dominik Csapak: >> >> and the case where some OSDs did not got yet "upgraded" to >> ceph-volume/nautilus >> but a new one was created cannot happen? >> > no it should not as the upgrade guide says > -8< > During the upgrade from Luminous to Nautilus it will n

Re: [pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Dominik Csapak
and the case where some OSDs did not got yet "upgraded" to ceph-volume/nautilus but a new one was created cannot happen? no it should not as the upgrade guide says -8< During the upgrade from Luminous to Nautilus it will not be possible to create a new OSD using a Luminous ceph-osd dae

Re: [pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Thomas Lamprecht
Am 7/15/19 um 11:10 AM schrieb Dominik Csapak: > On 7/15/19 10:48 AM, Thomas Lamprecht wrote: >> Wouldn't it be simpler do, instead of all above, just do a dir_glob_foreach >> on "/var/lib/ceph/osd/*" and read require_osd_release (not sure if that's >> enough as heuristic, but could be) and print t

Re: [pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Dominik Csapak
On 7/15/19 10:48 AM, Thomas Lamprecht wrote: Wouldn't it be simpler do, instead of all above, just do a dir_glob_foreach on "/var/lib/ceph/osd/*" and read require_osd_release (not sure if that's enough as heuristic, but could be) and print this out per OSD (so the user actually knows_which_ OSD(

Re: [pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Thomas Lamprecht
Am 7/15/19 um 10:20 AM schrieb Dominik Csapak: > do not warn in case there exist nautilus osds > since the upgrade has to be done by the time a user should add new > osds, it does not make sense to warn in that case > > Signed-off-by: Dominik Csapak > --- > PVE/CLI/pve5to6.pm | 3 ++- > 1 file c

[pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

2019-07-15 Thread Dominik Csapak
do not warn in case there exist nautilus osds since the upgrade has to be done by the time a user should add new osds, it does not make sense to warn in that case Signed-off-by: Dominik Csapak --- PVE/CLI/pve5to6.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pv