Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Emmanuel Kasper
On 09/19/2016 11:23 AM, Emmanuel Kasper wrote: > On 09/19/2016 10:38 AM, Caspar Smit wrote: >> Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault >> template and the w2k OSdefaults has a parent generic, doesn't that inherit >> all settings from generic? Why else does it

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Emmanuel Kasper
On 09/19/2016 10:38 AM, Caspar Smit wrote: > Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault > template and the w2k OSdefaults has a parent generic, doesn't that inherit > all settings from generic? Why else does it need a parent? > > As i read the code the 'w2k'

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Caspar Smit
Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault template and the w2k OSdefaults has a parent generic, doesn't that inherit all settings from generic? Why else does it need a parent? As i read the code the 'w2k' OSdefaults are: busType: 'ide' (from generic parent)

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Emmanuel Kasper
On 09/16/2016 03:11 PM, Caspar Smit wrote: > Hi, > > I'm assuming this commit will break the 'w2k' pveOS default (because the > scsihw will be inherited from generic): not really, because presetting a different kind of SCSI controller will not impact the _default_ controller which will still be

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-16 Thread Alexandre DERUMIER
I think that w2k don't support virtio-scsi driver. (same for linux 2.4) - Mail original - De: "Dominik Csapak" <d.csa...@proxmox.com> À: "pve-devel" <pve-devel@pve.proxmox.com> Envoyé: Vendredi 16 Septembre 2016 15:19:17 Objet: Re: [pve-devel] [PA

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-16 Thread Dominik Csapak
On 09/16/2016 03:11 PM, Caspar Smit wrote: Hi, I'm assuming this commit will break the 'w2k' pveOS default (because the scsihw will be inherited from generic): what will be broken? existing vms do not change, only newly created get a different default scsi controller so there is no

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-16 Thread Caspar Smit
Hi, I'm assuming this commit will break the 'w2k' pveOS default (because the scsihw will be inherited from generic): Here's a fix for that (sorry for not submitting a proper patch, i did a quick diff on the pvemanagerlib.js): @@ -17684,7 +17684,8 @@ addOS({ pveOS: 'w2k',

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-15 Thread Emmanuel Kasper
--- www/manager6/qemu/HDEdit.js | 4 www/manager6/qemu/OSDefaults.js | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index c86ab44..312b218 100644 --- a/www/manager6/qemu/HDEdit.js +++