Re: [pve-devel] [PATCH manager v2] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-26 Thread Dominik Csapak
great :), i like this one much better some problems though (sorry for not catching them earlier) the checkbox should probably not be there when editing an existing storage when editing a 'non-pve' ceph storage, it spits out the error: Uncaught TypeError: this[c._config.names.set] is not a funct

[pve-devel] [PATCH manager v2] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-26 Thread Thomas Lamprecht
Combine both dialogues. This not only helps to reuse code but also reduces storage choices from the Storage -> Add menu, and thus improves usability. Signed-off-by: Thomas Lamprecht --- changes v1 -> v2: * do not hide the monitor or username field when choosing the hyperconverged variant but t