Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2020-02-05 Thread Alwin Antreich
On Thu, Nov 14, 2019 at 03:01:37PM +0100, Thomas Lamprecht wrote: > On 11/14/19 6:30 AM, Dietmar Maurer wrote: > >> The main reason for this is to identify backups residing on an old backup > >> store like an archive. > >> > >> But I am open. Would you prefer having a manifest included in the ar

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 6:30 AM, Dietmar Maurer wrote: >> The main reason for this is to identify backups residing on an old backup >> store like an archive. >> >> But I am open. Would you prefer having a manifest included in the archive or >> as a separate file on the same storage? > > The backup archive

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Dietmar Maurer
> The main reason for this is to identify backups residing on an old backup > store like an archive. > > > > But I am open. Would you prefer having a manifest included in the archive or > as a separate file on the same storage? The backup archive already contains the full VM config. I thoug

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Marco Gabriel - inett GmbH
588 From: Dietmar Maurer Sent: Wednesday, November 13, 2019 4:42:28 PM To: PVE development discussion ; Marco Gabriel - inett GmbH Subject: Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option > IMHO this is the wrong way

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Dietmar Maurer
> IMHO this is the wrong way to store additional information about > the backup. I am thinking about adding a manifest.json file which may contain such information ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bi

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Dietmar Maurer
IMHO this is the wrong way to store additional information about the backup. > On 13 November 2019 15:02 Marco Gabriel wrote: > > > Signed-off-by: Marco Gabriel > --- > PVE/VZDump/Common.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Com

[pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Marco Gabriel
Signed-off-by: Marco Gabriel --- PVE/VZDump/Common.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..0a70b0c 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -213,6 +213,12 @@ my $confdesc = { type => 'st