What about just removing the brackets to pass the elements as multiple
parameters to push()?
iow.
a.push(1, 2, 3);
instead of
a.push([1, 2, 3]);
On Wed, Feb 03, 2016 at 12:11:45PM +0100, Emmanuel Kasper wrote:
> Using push here would add an array of elements instead of the elements.
> Seems
Using push here would add an array of elements instead of the elements.
Seems ExtJS6 can't cope with that.
This fix is needed for buttons and columns to be properly displayed when
loading the component.
---
www/manager6/grid/FirewallRules.js | 6 +++---
1 file changed, 3 insertions(+), 3
> - me.column1.push([
> + me.column1 = me.column1.concat([
removing the [ should do the job?
> {
> xtype: 'displayfield',
> fieldLabel: '',
> @@ -587,7 +587,7 @@ Ext.define('PVE.FirewallRules', {
> if (me.groupBtn) {
>
On 02/03/2016 02:57 PM, Dietmar Maurer wrote:
>> -me.column1.push([
>> +me.column1 = me.column1.concat([
>
> removing the [ should do the job?
>
yes it does the job and shortens the code
push() accepts n arguments
v2 on the way
___
pve-devel
