Re: [pve-devel] [PATCH qemu-server] Fix #2412: Missing VMs in pools

2019-10-14 Thread Thomas Lamprecht
On 10/11/19 1:13 PM, Fabian Grünbichler wrote: > the current situation is especially bad, since we vdisk_free unused > disks AFTER unlinking the config file, so the delay between unlinking > the config file, and removing from user.cfg/removing the firewall config > can be quite long.. that's a

Re: [pve-devel] [PATCH qemu-server] Fix #2412: Missing VMs in pools

2019-10-11 Thread Fabian Grünbichler
On October 11, 2019 11:55 am, Dominic Jäger wrote: > Between destroying a VM (unlink config file) and removing it from user.cfg > creating a new VM with the ID that is still in use in user.cfg was possible. > VMs could go missing as a consequence. > > Adding a lock solves this. This lock does not

[pve-devel] [PATCH qemu-server] Fix #2412: Missing VMs in pools

2019-10-11 Thread Dominic Jäger
Between destroying a VM (unlink config file) and removing it from user.cfg creating a new VM with the ID that is still in use in user.cfg was possible. VMs could go missing as a consequence. Adding a lock solves this. This lock does not interfere with the one in vm_destroy as they are held by the