Re: [pve-devel] [PATCH qemu-server 4/7] Add CustomCPUConfig for storing/parsing custom CPU models

2019-09-09 Thread Stefan Reiter
Thanks again for the thorough review, I'll try to address everything mentioned in v2. Some stuff inline for this patch in particular. On 9/9/19 11:53 AM, Fabian Grünbichler wrote: On September 2, 2019 4:27 pm, Stefan Reiter wrote: Inherits from SectionConfig to provide base parsing

Re: [pve-devel] [PATCH qemu-server 4/7] Add CustomCPUConfig for storing/parsing custom CPU models

2019-09-09 Thread Fabian Grünbichler
On September 2, 2019 4:27 pm, Stefan Reiter wrote: > Inherits from SectionConfig to provide base parsing infrastructure. > > Use with helper functions: > * config_from_file gives bless'd config > * get_model_by_name returns a "formatted" hash for a single CPU model > * config_to_file writes

[pve-devel] [PATCH qemu-server 4/7] Add CustomCPUConfig for storing/parsing custom CPU models

2019-09-02 Thread Stefan Reiter
Inherits from SectionConfig to provide base parsing infrastructure. Use with helper functions: * config_from_file gives bless'd config * get_model_by_name returns a "formatted" hash for a single CPU model * config_to_file writes changes back File reads are cached in a local hash. Signed-off-by: