Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-14 Thread Thomas Lamprecht
On 10/14/19 11:59 AM, Alwin Antreich wrote: > On Mon, Oct 14, 2019 at 11:44:59AM +0200, Thomas Lamprecht wrote: >> On 10/11/19 1:45 PM, Alwin Antreich wrote: >>> On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: On 10/11/19 12:02 PM, Alwin Antreich wrote: > On Fri, Oct 11,

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-14 Thread Alwin Antreich
On Mon, Oct 14, 2019 at 11:44:59AM +0200, Thomas Lamprecht wrote: > On 10/11/19 1:45 PM, Alwin Antreich wrote: > > On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: > >> On 10/11/19 12:02 PM, Alwin Antreich wrote: > >>> On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrot

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-14 Thread Thomas Lamprecht
On 10/11/19 1:45 PM, Alwin Antreich wrote: > On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: >> On 10/11/19 12:02 PM, Alwin Antreich wrote: >>> On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: On 10/10/19 3:58 PM, Alwin Antreich wrote: > Machine states th

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Alwin Antreich
On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: > On 10/11/19 12:02 PM, Alwin Antreich wrote: > > On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: > >> On 10/10/19 3:58 PM, Alwin Antreich wrote: > >>> Machine states that were created on snapshots with memory could

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Thomas Lamprecht
On 10/11/19 12:02 PM, Alwin Antreich wrote: > On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: >> On 10/10/19 3:58 PM, Alwin Antreich wrote: >>> Machine states that were created on snapshots with memory could not be >>> restored on rollback. The state volume was not activated so KV

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Alwin Antreich
On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: > On 10/10/19 3:58 PM, Alwin Antreich wrote: > > Machine states that were created on snapshots with memory could not be > > restored on rollback. The state volume was not activated so KVM couldn't > > load the state. > > > > This pa

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-10 Thread Thomas Lamprecht
On 10/10/19 3:58 PM, Alwin Antreich wrote: > Machine states that were created on snapshots with memory could not be > restored on rollback. The state volume was not activated so KVM couldn't > load the state. > > This patch removes the path generation on rollback. It uses the vmstate > and de-/act

[pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-10 Thread Alwin Antreich
Machine states that were created on snapshots with memory could not be restored on rollback. The state volume was not activated so KVM couldn't load the state. This patch removes the path generation on rollback. It uses the vmstate and de-/activates the state volume in vm_start. This in turn disal