Re: [pve-devel] [PATCH v3 widget-toolkit] add network selector widget

2019-06-12 Thread Tim Marx
> Dominik Csapak hat am 11. Juni 2019 um 16:58 > geschrieben: > > > high level looks ok, some comments inline > > On 6/11/19 2:04 PM, Tim Marx wrote: > > Signed-off-by: Tim Marx > > --- > > Makefile| 1 + > > form/NetworkSelector.js | 121 > > +++

Re: [pve-devel] [PATCH v3 widget-toolkit] add network selector widget

2019-06-11 Thread Dominik Csapak
high level looks ok, some comments inline On 6/11/19 2:04 PM, Tim Marx wrote: Signed-off-by: Tim Marx --- Makefile| 1 + form/NetworkSelector.js | 121 2 files changed, 122 insertions(+) create mode 100644 form/NetworkSele

[pve-devel] [PATCH v3 widget-toolkit] add network selector widget

2019-06-11 Thread Tim Marx
Signed-off-by: Tim Marx --- Makefile| 1 + form/NetworkSelector.js | 121 2 files changed, 122 insertions(+) create mode 100644 form/NetworkSelector.js diff --git a/Makefile b/Makefile index b9dc8b9..d12a4da 100644 --- a/Makefil