Re: [pve-devel] [RFC pve-common 0/4] Typetext generation

2015-09-22 Thread Dietmar Maurer
Applied, thanks. > Should we maybe add general support for hash-refs as `format` for > string types? Yes, I think that is a great idea. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC pve-common 0/4] Typetext generation

2015-09-22 Thread Dietmar Maurer
> I wonder though if it makes sense to then cache the parsed object somewhere > to avoid parsing the string twice? IMHO this makes code unnecessarily complex. ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [RFC pve-common 0/4] Typetext generation

2015-09-22 Thread Wolfgang Bumiller
> On September 22, 2015 at 8:03 AM Dietmar Maurer wrote: > > Should we maybe add general support for hash-refs as `format` for > > string types? > > Yes, I think that is a great idea. I wonder though if it makes sense to then cache the parsed object somewhere to avoid

[pve-devel] [RFC pve-common 0/4] Typetext generation

2015-09-21 Thread Wolfgang Bumiller
We have a lot of types which are really objects (comma separated lists of key-value pairs), which aren't always checked properly. This patch adds support to generate a typetext property from a schema. The intention is to specify a schema instead of a typetext and have the typetext generated, while