Re: [pve-devel] [RFC pve-manager] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-26 Thread Thomas Lamprecht
On 6/25/18 1:31 PM, Dominik Csapak wrote: > the code looks good and i'm all for doing this, thanks for the look! > but i do not really like how the endresult looks > > an improvement would be to put the checkbox more at the top, or in the footer > area? > it feels rather weird to have a

Re: [pve-devel] [RFC pve-manager] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-25 Thread Dominik Csapak
the code looks good and i'm all for doing this, but i do not really like how the endresult looks an improvement would be to put the checkbox more at the top, or in the footer area? it feels rather weird to have a checkbox at the bottom of the form which changes the items before it also i

[pve-devel] [RFC pve-manager] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-20 Thread Thomas Lamprecht
We have a growing list of storages we can add. RBD and the upcoming CephFS have additionally the difference between hyperconverged PVE managed and external managed one. This makes the list quite long and not very user friendly. This proposes to combine the both dialogues in a single one, with a