Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-25 Thread Thomas Lamprecht
On 5/23/19 9:22 PM, Fabian Grünbichler wrote: > for both vm_mon_cmd calls. under certain circumstances, the following > sequence of events can otherwise fail when live-migrating under load: > > S...source node > T...target node > > 0: migration is complete, handover from S to T starts > 1: S: log

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-25 Thread Thomas Lamprecht
On 5/24/19 10:39 PM, Fabian Grünbichler wrote: > On Fri, May 24, 2019 at 09:02:45PM +0200, Thomas Lamprecht wrote: >> On 5/24/19 8:37 PM, Fabian Grünbichler wrote: >>> On Fri, May 24, 2019 at 11:05:41AM +0200, Thomas Lamprecht wrote: On 5/24/19 10:52 AM, Dominik Csapak wrote: > On 5/24/19

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Fabian Grünbichler
On Fri, May 24, 2019 at 09:02:45PM +0200, Thomas Lamprecht wrote: > On 5/24/19 8:37 PM, Fabian Grünbichler wrote: > > On Fri, May 24, 2019 at 11:05:41AM +0200, Thomas Lamprecht wrote: > >> On 5/24/19 10:52 AM, Dominik Csapak wrote: > >>> On 5/24/19 9:52 AM, Thomas Lamprecht wrote: [... trimming a

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Thomas Lamprecht
On 5/24/19 8:37 PM, Fabian Grünbichler wrote: > On Fri, May 24, 2019 at 11:05:41AM +0200, Thomas Lamprecht wrote: >> On 5/24/19 10:52 AM, Dominik Csapak wrote: >>> On 5/24/19 9:52 AM, Thomas Lamprecht wrote: On 5/24/19 9:36 AM, Fabian Grünbichler wrote: > On Fri, May 24, 2019 at 08:24:17AM

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Fabian Grünbichler
On Fri, May 24, 2019 at 11:05:41AM +0200, Thomas Lamprecht wrote: > On 5/24/19 10:52 AM, Dominik Csapak wrote: > > On 5/24/19 9:52 AM, Thomas Lamprecht wrote: > >> On 5/24/19 9:36 AM, Fabian Grünbichler wrote: > >>> On Fri, May 24, 2019 at 08:24:17AM +0200, Dominik Csapak wrote: > LGTM, i intr

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Thomas Lamprecht
On 5/24/19 10:52 AM, Dominik Csapak wrote: > On 5/24/19 9:52 AM, Thomas Lamprecht wrote: >> On 5/24/19 9:36 AM, Fabian Grünbichler wrote: >>> On Fri, May 24, 2019 at 08:24:17AM +0200, Dominik Csapak wrote: LGTM, i introduced this seemingly sometime last year... (oops) the question re

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Dominik Csapak
On 5/24/19 9:52 AM, Thomas Lamprecht wrote: On 5/24/19 9:36 AM, Fabian Grünbichler wrote: On Fri, May 24, 2019 at 08:24:17AM +0200, Dominik Csapak wrote: LGTM, i introduced this seemingly sometime last year... (oops) the question remains why it sometimes takes so long for a rename to be propag

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Thomas Lamprecht
On 5/24/19 9:36 AM, Fabian Grünbichler wrote: > On Fri, May 24, 2019 at 08:24:17AM +0200, Dominik Csapak wrote: >> LGTM, i introduced this seemingly sometime last year... (oops) >> >> the question remains why it sometimes takes so long for a rename to >> be propagated > > the race window is actual

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-24 Thread Fabian Grünbichler
On Fri, May 24, 2019 at 08:24:17AM +0200, Dominik Csapak wrote: > LGTM, i introduced this seemingly sometime last year... (oops) > > the question remains why it sometimes takes so long for a rename to > be propagated the race window is actually very small - I guess it gets a bit bigger and thus t

Re: [pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-23 Thread Dominik Csapak
LGTM, i introduced this seemingly sometime last year... (oops) the question remains why it sometimes takes so long for a rename to be propagated in my opinion this violates the assumptions we make regarding ownership of files/vms since it seems here that nobody own the vm when this happens (the

[pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-23 Thread Fabian Grünbichler
for both vm_mon_cmd calls. under certain circumstances, the following sequence of events can otherwise fail when live-migrating under load: S...source node T...target node 0: migration is complete, handover from S to T starts 1: S: logically move VM config file from S to T via rename() 2: S: rena