> > No. The master branch doesn't contain it because it just triggers a DRBD
> > 9 bug and so wouldn't work anyway.
> Just wanted to tell you that the DRBD 9 bug has been fixed in the meantime;
> the DRBDmanage code will be done next, so the next (upcoming) releases of
> both should have a worki
Hi Dietmar,
> > > The problem is that it does not resize the underlying LVM volume.
> > >
> > > Do I need to install any drbdmanage updates/patches to make that work?
> >
> > I just scanned the drbdmanage sources, and the corresponding implementation
> > is empty (always return success)?
> >
>
> -#my $cmd = ['/sbin/lvextend', '-L', $size, $path];
> -#run_command($cmd, errmsg => "error resizing volume '$path'");
> +# FIXME if there's ever more than one volume in a resource
>
> not sure if we ever want to support multiple volumes inside one
> resource?
> Why would we want to d
> > > -my $path = $class->path($scfg, $volname);
> > > +die "illegal name '$name' - should be 'vm-*-*'\n"
> > > + if $name !~ m/^vm-\d+-/;
> > >
> > > And reason for above check? Or did you just copied that code from
> > > alloc_image?
> > Right. And that's why I changed the name - to keep
> > -my $path = $class->path($scfg, $volname);
> > +die "illegal name '$name' - should be 'vm-*-*'\n"
> > + if $name !~ m/^vm-\d+-/;
> >
> > And reason for above check? Or did you just copied that code from
> > alloc_image?
> Right. And that's why I changed the name - to keep it the same
> > Anyways, I tested the patch, and volume_resize() now returns without errors.
> > The problem is that it does not resize the underlying LVM volume.
> >
> > Do I need to install any drbdmanage updates/patches to make that work?
>
> I just scanned the drbdmanage sources, and the corresponding im
> > Please see attached a patch to implement "resize" for the DRBD backend.
> >
> > I hope it matches all your coding style guidelines;
> > feedback is welcome, of course.
>
> Please can you send patches inline? That way it is easier to review code
> and add comments. I copied the code for this p
> Anyways, I tested the patch, and volume_resize() now returns without errors.
> The problem is that it does not resize the underlying LVM volume.
>
> Do I need to install any drbdmanage updates/patches to make that work?
I just scanned the drbdmanage sources, and the corresponding implementation
> Please see attached a patch to implement "resize" for the DRBD backend.
>
> I hope it matches all your coding style guidelines;
> feedback is welcome, of course.
Please can you send patches inline? That way it is easier to review code
and add comments. I copied the code for this purpose - comme
Please see attached a patch to implement "resize" for the DRBD backend.
I hope it matches all your coding style guidelines;
feedback is welcome, of course.
Regards,
Phil
>From 4ceb4d737d4c604dcf99bbd46d60d731626e9781 Mon Sep 17 00:00:00 2001
From: root
Date: Mon, 3 Aug 2015 16:15:33 +0200
Subj
10 matches
Mail list logo
