Re: [pve-devel] applied: [PATCH qemu-server 2/2] destroy_vm: use write_config from our Config module to set an "empty" config

2019-10-18 Thread Thomas Lamprecht
On 10/18/19 11:36 AM, Fabian Grünbichler wrote: >> @@ -2663,7 +2661,7 @@ sub destroy_vm { >> }); >> >> if ($keep_empty_config) { >> -PVE::Tools::file_set_contents($conffile, "memory: 128\n"); >> +PVE::QemuConfig->write_config($vmid, "memory: 128\n"); > shouldn't that be > > PVE

Re: [pve-devel] applied: [PATCH qemu-server 2/2] destroy_vm: use write_config from our Config module to set an "empty" config

2019-10-18 Thread Fabian Grünbichler
On October 18, 2019 11:23 am, Thomas Lamprecht wrote: > brings us more in line with what we do in pve-container, also it's > good to not use file_set_contents directly if we have all those nice > wrapper interface methods to do things in a safe and guaranteed way. > > Signed-off-by: Thomas Lamprec

[pve-devel] applied: [PATCH qemu-server 2/2] destroy_vm: use write_config from our Config module to set an "empty" config

2019-10-18 Thread Thomas Lamprecht
brings us more in line with what we do in pve-container, also it's good to not use file_set_contents directly if we have all those nice wrapper interface methods to do things in a safe and guaranteed way. Signed-off-by: Thomas Lamprecht --- PVE/QemuServer.pm | 4 +--- 1 file changed, 1 insertion