Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-11 Thread Alexandre DERUMIER
already different between PMG && VE, if one day we want to change the code in Notify (add new interfaces types(vxlan,vrf,, add ifupdown2 related code, ...), we'll be sure that it'll not break PMG api. - Mail original - De: "Thomas Lamprecht" À: "pv

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-11 Thread Thomas Lamprecht
On 6/11/19 9:46 AM, Alexandre DERUMIER wrote: >>> I have send patches, but I don't have look at PMG currently. (I never have >>> used it to be honest) >>> (I have only move the network configuration part, and was only used in >>> Network API) > I have looked in PMG, > > seem that it shouldn't br

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-11 Thread Alexandre DERUMIER
ces file should be enough. Maybe this Network.pm api could be common too, but they are a difference on" use PMG::RESTEnvironment" - Mail original - De: "aderumier" À: "Thomas Lamprecht" Cc: "pve-devel" Envoyé: Vendredi 7 Juin 2019 15:19:48 Objet: Re

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-07 Thread Alexandre DERUMIER
was only used in Network API) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Vendredi 7 Juin 2019 12:13:39 Objet: Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments On 6/7/19 7:11 AM, Alexandre DERUMIER wrote:

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-07 Thread Thomas Lamprecht
On 6/7/19 7:11 AM, Alexandre DERUMIER wrote: >>> >>> As long as we have a clear dependency releationship between the >>> packages this could be OK. I.e., probably: >>> >>> common <- network <- manager >>>^ >>> `- qemu-server/container <-/ > > > Hi, > I ha

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-06 Thread Alexandre DERUMIER
- Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Cc: "Fabian Grünbichler" Envoyé: Jeudi 6 Juin 2019 14:58:27 Objet: Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments On 6/6/19 10:16 AM, Alexandre DERUMIER wrote: &g

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-06 Thread Alexandre DERUMIER
t" À: "pve-devel" , "aderumier" Cc: "Fabian Grünbichler" Envoyé: Jeudi 6 Juin 2019 14:58:27 Objet: Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments On 6/6/19 10:16 AM, Alexandre DERUMIER wrote: >>> On another note, is there any specific reaso

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-06 Thread Thomas Lamprecht
On 6/6/19 10:16 AM, Alexandre DERUMIER wrote: >>> On another note, is there any specific reason we have a double "Network" >>> in the module namespace? Or could we change it to >>> >>> PVE/Network.pm >>> PVE/Network/VlanPlugin.pm >>> ... > >>> and respective module name-path changes? As now, with

Re: [pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-06 Thread Alexandre DERUMIER
>>On another note, is there any specific reason we have a double "Network" >>in the module namespace? Or could we change it to >> >>PVE/Network.pm >>PVE/Network/VlanPlugin.pm >>... >>and respective module name-path changes? As now, with not much external >>code using this, it would be still relat

[pve-devel] applied: [PATCH pve-network 0/2] improvments

2019-06-05 Thread Thomas Lamprecht
On 6/6/19 8:20 AM, Alexandre Derumier wrote: > - fix multicast vxlan default mtu. (should be 50 bytes lower than physdev) > - clean status sub from Thomas comments > > Alexandre Derumier (2): > vxlanmulticast : fix mtu > cleanup status sub > > PVE/Network/Network.pm | 13