On 4/9/20 1:28 PM, Wolfgang Bumiller wrote: > v2 just has minor fixups to the previous series. > > Initial cover letter: > > There's probably more to come, and not all our settings are yet > automatically converted to cgroupv2 in `update_lxc_config`, but the one > most people probably run into is the cpuset one, so this at least let's > some containers start. > > Note that for systemd containers you also need to add the following raw > config entry: > > lxc.mount.auto: cgroup:rw:force > > Depending on how the non-systemd distros fare with that we might make > this either default or an option. > > I've also reorganized the cgroup path fetching functions a bit. The > `cgroup_mode()` call is actually not all that useful outside, since in > theory the hybrid layout allows you to choose which controllers are > in which cgroup. So this now contains a combined "fetch path & version > of controller X" helper method. > > The last patch should be viewed with `-w`, because a lot of it is > indentation. > > Wolfgang Bumiller (5): > config: whitelist lxc.cgroup2 raw keys > consider lxc.cgroup2.cpuset.cpus as explicit cpuset > cgroup: more generic get_cgroup_controllers function > support cpuset cgroupv2 controller > cgroup: use version returned from get_path() > > src/PVE/LXC.pm | 21 +-- > src/PVE/LXC/CGroup.pm | 322 +++++++++++++++++++++++++++--------------- > src/PVE/LXC/Config.pm | 2 +- > 3 files changed, 215 insertions(+), 130 deletions(-) >
applied series, with the s/Cgroup::/CGroup::/ fixup for 3/5, thanks! _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
