[pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-08 Thread Emmanuel Kasper
By default when no target storage is selected in the clone panel, the clone will use the same storage*s* as the source. This was not obvious to guess that from the panel. --- www/manager6/qemu/Clone.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/q

[pve-devel] [PATCH manager] Indentation fix

2017-02-08 Thread Emmanuel Kasper
--- www/manager6/qemu/Clone.js | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index f8b71b5..471a62a 100644 --- a/www/manager6/qemu/Clone.js +++ b/www/manager6/qemu/Clone.js @@ -244,12 +244,12 @@ Ext.define('

[pve-devel] Ack: Re: [PATCH storage 1/3] rbd: use 'rbd ls' without '-l' to find free names

2017-02-09 Thread Emmanuel Kasper
I tested this patch OK, and code looks good to me. On 02/03/2017 01:00 PM, Fabian Grünbichler wrote: > with more than a few images, 'rbd ls -l' gets rather slow > compared to a simple 'rbd ls'. since we only need to check > existing image names for finding a free one, the latter is > sufficient. >

Re: [pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-09 Thread Emmanuel Kasper
+ emptyText: gettext('Same as source'), On 02/08/2017 07:05 PM, Dietmar Maurer wrote: > I would like to avoid additional gettext entries if possible. > > Do we know the source storage? If so, can we set that storage as 'emptyText'? > Other ideas? We don't know the source storage*s*, w

[pve-devel] [RFC PATCH common] Fix example to latest RestHandler

2017-02-14 Thread Emmanuel Kasper
looking at the handle() sub from RestHandler.pm my $result = &$func($param); this parameters are not passed anymore --- README.dev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.dev b/README.dev index a97f1c8..f68c169 100644 --- a/README.dev +++ b/README.dev @@ -1

[pve-devel] [PATCH qemu-server] Improve error message when trying to shrink a volume, fix typo

2017-02-16 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a41e74f..a077ed7 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3049,7 +3049,7 @@ __PACKAGE__->register_method({ $newsize += $size if $ext;

[pve-devel] [PATCH cluster] Remove depency to libxml-parser-perl

2017-02-16 Thread Emmanuel Kasper
This xml parser was added to parser RHCM cluster.conf, we don't parse this anymore. --- data/PVE/Cluster.pm | 1 - debian/control.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 09ed5d7..39708c8 100644 --- a/data/PVE/Cluste

[pve-devel] [RFC PATCH qemu-server 3/4] Initial parsing of OVF files

2017-02-21 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 209 2 files changed, 210 insertions(+) create mode 100644

[pve-devel] [RFC PATCH qemu-server 4/4] Add a new command line option 'ovfcreate', to create VMs from an OVF manifest

2017-02-21 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ 1 file changed, 47 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..f431023 1007

[pve-devel] [RFC PATCH qemu-server 0/4] Initial support for creating VMs from OVF manifests

2017-02-21 Thread Emmanuel Kasper
finally the disk images) For testing I used the with the Windows IE Edge test VMWare machine from https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ Emmanuel Kasper (4): Force overwriting existing compressed man pages and symbolic links Add depency to libxml-simple-perl Initial

[pve-devel] [RFC PATCH qemu-server 1/4] Force overwriting existing compressed man pages and symbolic links

2017-02-21 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index d59af8c..95e647f 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [RFC PATCH qemu-server 2/4] Add depency to libxml-simple-perl

2017-02-21 Thread Emmanuel Kasper
XML::Simple provides a much cleaner output than XML::Parser, as XML::Parser tries to preserve everything in the document (line breaks) when we don't need this information. The current known limitation of XML::Simple is that it is not recommended for generating XMl, but this is not our aim. --- c

Re: [pve-devel] [PATCH manager] correctly set 'nowritecache' on zfsplugin

2017-02-22 Thread Emmanuel Kasper
On 02/22/2017 11:12 AM, Dominik Csapak wrote: > the logic was reversed, checking writecache enabled 'nowritecache', > now the logic is correct, setting 'nowritecache' if 'writecache' is > unchecked > > Signed-off-by: Dominik Csapak > --- > i think this is a better and more elegant approach to the

Re: [pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-27 Thread Emmanuel Kasper
On 02/22/2017 11:07 AM, Dominik Csapak wrote: > On 02/09/2017 04:13 PM, Emmanuel Kasper wrote: >> >> +emptyText: gettext('Same as source'), >> >> On 02/08/2017 07:05 PM, Dietmar Maurer wrote: >>> I would like to avoid additional gettext entr

[pve-devel] [RFC PATCH qemu-server v2 4/5] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-02-28 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ PVE/QemuServer/OVF.pm | 22 +- 2 files changed, 64 insertions(+), 5 deletion

[pve-devel] [RFC PATCH qemu-server v2 3/5] Initial parsing of OVF files

2017-02-28 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 217 2 files changed, 218 insertions(+) create mode 100644

[pve-devel] [RFC PATCH qemu-server v2 0/5] Initial support for OVF imports

2017-02-28 Thread Emmanuel Kasper
t in /test directory Emmanuel Kasper (5): Force overwriting existing compressed man pages and symbolic links Add depency to libxml-simple-perl Initial parsing of OVF files Add a new command line option 'ovfimport', to create VMs from an OVF manifest Add tests for

[pve-devel] [RFC PATCH qemu-server v2 1/5] Force overwriting existing compressed man pages and symbolic links

2017-02-28 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index d59af8c..95e647f 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [RFC PATCH qemu-server v2 5/5] Add tests for ovfimport function

2017-02-28 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports of VM from a VmWare Workstation export * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc i: they contain a VMDK header and the rest are null characters) --- tes

[pve-devel] [RFC PATCH qemu-server v2 2/5] Add depency to libxml-simple-perl

2017-02-28 Thread Emmanuel Kasper
XML::Simple provides a much cleaner output than XML::Parser, as XML::Parser tries to preserve everything in the document (line breaks) when we don't need this information. The current known limitation of XML::Simple is that it is not recommended for generating XMl, but this is not our aim. --- c

[pve-devel] [PATCH manager] Rename 'create' to 'isCreate' in pveWindowEdit and subclasses

2017-02-28 Thread Emmanuel Kasper
This fixes around 20 jslint type confusion warnings. Also reduce the scope and document jslint warnings along the way. No functional changes. --- www/manager6/ceph/Monitor.js | 4 ++-- www/manager6/ceph/OSD.js | 11 + www/manager6/ceph/Pool.js | 5 +

Re: [pve-devel] [PATCH 3/3] add qmimport command

2017-03-01 Thread Emmanuel Kasper
Hi Alexandre >>> If I missed something or something is unclear or does not work as >>> expected, just shout ;) > > Ok,I'll send a patch this way. I just wanted to avoid as much as possible > duplicate code. Are you working on this ? I guest at some point we will need this for importing the dis

[pve-devel] [PATCH qemu-server] Use backticks instead of single quotes in qm resize description

2017-03-01 Thread Emmanuel Kasper
Single quoted text in asciidoc is rendered in man pages with underlines, which makes the '+' symbol very similar to '+/-' Backticks are rendered with monospace text in HTML, normal text in man pages, and still readable in raw format. --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH manager] Do not translate IT terms which should be used 'as is' in every language

2017-03-01 Thread Emmanuel Kasper
for 'Initialize GPT' we use the alternate 'Initialize Disk with GPT' string which was already existing --- www/manager6/Utils.js| 4 ++-- www/manager6/grid/FirewallOptions.js | 4 ++-- www/manager6/lxc/Options.js | 2 +- www/manager6/node/Disks.js | 2 +- 4 files

Re: [pve-devel] [PATCH manager] add css fix for chrome >=56

2017-03-02 Thread Emmanuel Kasper
LGTM but can we include a link in the commit log to the sencha forum post discussing the issue ? On 03/02/2017 08:45 AM, Dominik Csapak wrote: > with chrome/chromium version 56, they changed the way how they calculate > height of text in input fields (now it is correct according to the > standard)

[pve-devel] [PATCH cluster] Require Sys.Audit to read the cluster configuration

2017-03-06 Thread Emmanuel Kasper
Up to now only root could see the corosync cluster config. Sys.Audit is the same permission required for reading the HA Config and the HA Resources Config. --- NB: a patch for the permission description in user management will folow data/PVE/API2/ClusterConfig.pm | 9 + 1 file changed, 9

[pve-devel] [PATCH docs] Document that Sys.Audit allows also to read cluster paramaters

2017-03-06 Thread Emmanuel Kasper
--- pveum.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index db196b5..6c35833 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -249,7 +249,7 @@ Node / System related privileges:: * `Sys.PowerMgmt`: Node power management (start, stop, reset, shutdown,

[pve-devel] [PATCH common 2/2] Fix #1270: properly read multiple search domains in /etc/resolv.conf

2017-03-08 Thread Emmanuel Kasper
--- src/PVE/INotify.pm | 2 +- test/inotify/resolv.conf_multiple_search | 5 + test/inotify/run_inotify_tests.pl| 16 +++- 3 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 test/inotify/resolv.conf_multiple_search diff --git a/sr

[pve-devel] [PATCH common 1/2] Document current handling of reading and updating resolv.conf

2017-03-08 Thread Emmanuel Kasper
also add unit tests for the two subroutines --- should the unit tests be added to make check target ? src/PVE/INotify.pm | 3 ++ test/inotify/resolv.conf_single_domain | 5 test/inotify/resolv.conf_single_search | 5 test/inotify/run_inotify_tests.pl | 50

Re: [pve-devel] [PATCH manager v2 1/2] Add a new renderer for displaying dates in a human readable way

2017-03-20 Thread Emmanuel Kasper
On 03/13/2017 12:52 PM, Wolfgang Bumiller wrote: > While writing the change log I was wondering why you chose a specific > format there. Isn't there a way to tell the browser to give you a locale > dependent somewhat sane format? Otherwise why care? Yes this makes sense, I will look if there are c

[pve-devel] [PATCH common] Add utility subroutine to get the fully qualified domain name of a host

2017-03-22 Thread Emmanuel Kasper
--- src/PVE/Tools.pm | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 69c8730..4815d61 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -4,7 +4,7 @@ use strict; use warnings; use POSIX qw(EINTR EEXIST EOPNOT

[pve-devel] [PATCH cluster] Use a real FQDN when defining the CommonName entry of SSL certs

2017-03-22 Thread Emmanuel Kasper
The proper way to set the fqdn is via /etc/hosts or via DNS -see hostname(1)- --- data/PVE/Cluster.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index ab57da9..e694d93 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/

[pve-devel] [PATCH common] Use "real" Fully Qualified Domain Name for setting the common name of a ssl cert

2017-03-22 Thread Emmanuel Kasper
Names CCing Fabian for review Emmanuel Kasper (1): Add utility subroutine to get the fully qualified domain name of a host src/PVE/Tools.pm | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) -- 2.1.4 ___ pve-devel mailing

[pve-devel] [PATCH docs] Fix path to block device when creating a file system on a thin volume

2017-03-23 Thread Emmanuel Kasper
The path component following /dev/ should be the volume group where the thin pool exists, not the name of the thin pool itself. (the fstab example underneath has this right) --- local-lvm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-lvm.adoc b/local-lvm.adoc inde

[pve-devel] [PATCH docs] Use 'light' here, because thin migh create confusion with lvm thin

2017-03-23 Thread Emmanuel Kasper
--- pve-storage-lvm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc index b337c86..72083b5 100644 --- a/pve-storage-lvm.adoc +++ b/pve-storage-lvm.adoc @@ -7,7 +7,7 @@ endif::wiki[] Storage pool type: `lvm` -LVM is a thin so

[pve-devel] [PATCH qemu-server v3 3/4] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-03-29 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ PVE/QemuServer/OVF.pm | 161 +- control.in| 2 +- 3 files changed

[pve-devel] [PATCH qemu-server v3 4/4] Add tests for ovfimport function

2017-03-29 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v3 2/4] Initial parsing of OVF files

2017-03-29 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 220 2 files changed, 221 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v3 1/4] Force overwriting existing compressed man pages and symbolic links

2017-03-29 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index cdb5aa0..9fc6cd8 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v3 0/4] Initial support for OVF import

2017-03-29 Thread Emmanuel Kasper
OVF manifests and a test script in /test directory Emmanuel Kasper (4): Force overwriting existing compressed man pages and symbolic links Initial parsing of OVF files Add a new command line option 'ovfimport', to create VMs from an OVF manifest Add tests for ovfimpor

Re: [pve-devel] [PATCH qemu-server v3 0/4] Initial support for OVF import

2017-03-30 Thread Emmanuel Kasper
Please ignore this patch serie, I did a mistake when rebasing ( patch 2 should not exist, and patch 3 should be split in two differents patches ) On 03/29/2017 04:53 PM, Emmanuel Kasper wrote: > This patch serie adds initial support for creating VMs from OVF > manifests, adding a new comman

[pve-devel] [PATCH qemu-server v4 1/5] Force overwriting existing compressed man pages and symbolic links

2017-03-30 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index cdb5aa0..9fc6cd8 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v4 2/5] Add a build dependency to libxml-libxml-perl, needed for OVF parsing

2017-03-30 Thread Emmanuel Kasper
XML::LibXML is being actively developed, and has 91 reverse depencies in Debian Stretch, no it should not go away. --- control.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/control.in b/control.in index d0601ac..7834e31 100644 --- a/control.in +++ b/control.in @@ -3,7 +3,7

[pve-devel] [PATCH qemu-server v4 3/5] Initial support for importing OVF virtual machines

2017-03-30 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 223 2 files changed, 224 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v4 4/5] Add tests for ovfimport function

2017-03-30 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v4 0/5] Initial support for OVF import

2017-03-30 Thread Emmanuel Kasper
changes since V3: * proper rebasing of patches * move the new build dependency in a separate patch Emmanuel Kasper (5): Force overwriting existing compressed man pages and symbolic links Add a build dependency to libxml-libxml-perl, needed for OVF parsing Initial support for importing OVF

[pve-devel] [PATCH qemu-server v4 5/5] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-03-30 Thread Emmanuel Kasper
Currently the following extracted parameters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ 1 file changed, 47 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..12d705c 100755 --- a/PVE/CL

[pve-devel] [PATCH common v2 1/2] Document current handling of reading and updating resolv.conf

2017-04-04 Thread Emmanuel Kasper
also add unit tests for the two subroutines --- src/PVE/INotify.pm | 3 + test/inotify/resolv.conf_multiple_search | 5 ++ .../resolv.conf_multiple_search_and_domain_first | 6 ++ .../resolv.conf_multiple_search_and_domain_last| 6 ++ test/inotif

[pve-devel] [PATCH common v2 0/2] Handle multiple search domains in the API

2017-04-04 Thread Emmanuel Kasper
Changes since V1: * improve the regexp to match only the first 'domain' entry * strip trailing white space in domain list NB: http://pve.proxmox.com/pipermail/pve-devel/2017-March/025803.html must be applied before as ssl key generation expects a single search entry Emmanuel

[pve-devel] [PATCH common v2 2/2] Fix #1234: allows multiple search domains to be set

2017-04-04 Thread Emmanuel Kasper
--- src/PVE/INotify.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 074f8b3..5f08439 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -539,11 +539,16 @@ sub read_etc_resolv_conf { my $nscount = 0;

Re: [pve-devel] [PATCH qemu-server v4 0/5] Initial support for OVF import

2017-04-11 Thread Emmanuel Kasper
Any feedback for this patch serie ? On 03/30/2017 04:51 PM, Emmanuel Kasper wrote: > changes since V3: > * proper rebasing of patches > * move the new build dependency in a separate patch > > Emmanuel Kasper (5): > Force overwriting existing compressed man pages and symbol

[pve-devel] [PATCH qemu-kvm 2/2] Disable building the qemu-guest-agent (binary + docs)

2017-04-11 Thread Emmanuel Kasper
This fixes a conflict when installing the qemu-guest-agent debian package, where our pve-qemu-kvm and the debian package both tried to install the usr/share/man/man8/qemu-ga.8.gz file --- debian/rules | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH qemu-kvm 1/2] Split the very long configure line to fit in 80 columns

2017-04-11 Thread Emmanuel Kasper
No functionnal changes --- debian/rules | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index ecacfa3..1d7d5c2 100755 --- a/debian/rules +++ b/debian/rules @@ -35,7 +35,15 @@ endif config.status: configure dh_testdir # Add

Re: [pve-devel] [PATCH common v2 2/2] Fix #1234: allows multiple search domains to be set

2017-04-11 Thread Emmanuel Kasper
h domains $searchdomains = $host_resolv_conf->{search}; > On Tue, Apr 04, 2017 at 03:26:24PM +0200, Emmanuel Kasper wrote: > > some short description of this commit would be nice here, especially > regarding the comments/questions below ;) > >> --- >> src/PVE/INotify.pm | 15

[pve-devel] [PATCH common v3 2/2] Fix #1234: allows multiple search domains to be set

2017-04-13 Thread Emmanuel Kasper
Changes: * multiple 'search' entries (up to 6) can be now read and added like the libc resolver * a 'search' entry list of more that 255 characters will be silently skipped, like the libc resolver When multiple 'domain' entries are defined, only the first one is matched, similar to previous b

[pve-devel] [PATCH common v3 1/2] Document current handling of reading and updating resolv.conf

2017-04-13 Thread Emmanuel Kasper
also add unit tests for the two subroutines --- src/PVE/INotify.pm| 3 + test/inotify/resolv.conf_empty_search | 5 ++ test/inotify/resolv.conf_long_search | 4 + test/inotify/resolv.conf_multiple_domain | 5 ++ test/inotify/res

[pve-devel] [PATCH common v3 0/2] Allow multiple base domains for DNS queries

2017-04-13 Thread Emmanuel Kasper
tains more than 255 characters * restore behaviour of multiple 'domain' entries are defined that the first one is matched, similar to previous behavious and libc. * add tests for these variations * use English so we can accessed named capture groups whith $LAST_PAREN_MATCH{$capture_name

Re: [pve-devel] back from holiday, I'll more time to work on proxmox

2017-04-18 Thread Emmanuel Kasper
On 04/16/2017 05:53 PM, Alexandre DERUMIER wrote: > Hi, > > I'm back from holiday, and I'll have a little bit more time now to work on > proxmox. > > Here some tasks I would like to work: > > > finish cloudinit integration: > https://github.com/Blub/pve-qemu-server/commits/cloudinit > > >

Re: [pve-devel] [PATCH manager] set default focus and default button for edit window

2017-04-19 Thread Emmanuel Kasper
Tested OK, and looks good to me. A nice improvement for power users. On 04/18/2017 04:55 PM, Dominik Csapak wrote: > this patch sets following defaults for the edit window: > > defaultFocus: 'field' > > sets the focus on the first field it finds in its child items, > works for most edit windows

[pve-devel] [PATCH qemu-server 0/2] Add qm diskimport command

2017-04-25 Thread Emmanuel Kasper
last month ( [PATCH qemu-server v4 0/5] Initial support for OVF import ) this should allows direct import of ovf compatible exports from other hypervisors. Emmanuel Kasper (2): Add DiskImport module to import external disk images into a VM Add new qm option 'diskimport' to import external d

[pve-devel] [PATCH qemu-server 1/2] Add DiskImport module to import external disk images into a VM

2017-04-25 Thread Emmanuel Kasper
Each disk passed as paramater is add as 'unused[n]' in the vm.conf (the default) or ide[n]|scsi[n]|sata[n] We rely on qemu-img(1) convert heuristics to detect the file type, as this works in most case. --- PVE/QemuServer/DiskImport.pm | 93 PVE/QemuServ

[pve-devel] [PATCH qemu-server 2/2] Add new qm option 'diskimport' to import external disk images

2017-04-25 Thread Emmanuel Kasper
The VM must be already existing, and the synthax is qm diskimport 421 -source minix204.img -storage pve4tank where 421 is an already existing VM --- PVE/CLI/qm.pm | 39 +++ 1 file changed, 39 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439

Re: [pve-devel] [PATCH qemu-server 0/2] Add qm diskimport command

2017-04-25 Thread Emmanuel Kasper
gt; On April 25, 2017 10:56:00 AM GMT+02:00, Emmanuel Kasper > wrote: >> This new qm command allows to add an external disk image as 'unused' >> disk >> to an existing VM. >> This idea from Alexandre has been discussed in this thread >> http://pve.proxmo

[pve-devel] [PATCH qemu-server] add description of read/writes statistics in vzdump output

2017-05-02 Thread Emmanuel Kasper
since this statistics are note really described, sometimes users miss that their slow backups are caused by slow reads --- PVE/VZDump/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index da3ee06..65ca09d 100644

Re: [pve-devel] [PATCH qemu-server 0/2] Add qm diskimport command

2017-05-02 Thread Emmanuel Kasper
On 04/27/2017 07:56 PM, Alexandre DERUMIER wrote: > Hi Emmanuel, > > I have tested both ovf and disk import with differents ovf found on the net, > > it's working fine for me. (We just need to add import of disks in import ovf) > > > >>> Combined with the OVF parser which was submitted to the

[pve-devel] [PATCH qemu-server v2 0/2] Add qm diskimport command

2017-05-02 Thread Emmanuel Kasper
ort * fix sparseinit/has_sparseinit and print_drive wrong names * test if the VM exists before trying to add something * rename $disk_entry to $drive_name as it the name we use most of the time in QemuServer.pm Emmanuel Kasper (2): Add DiskImport module to import external disk images into

[pve-devel] [PATCH qemu-server v2 1/2] Add DiskImport module to import external disk images into a VM

2017-05-02 Thread Emmanuel Kasper
Each disk passed as paramater is add as 'unused[n]' in the vm.conf (the default) or ide[n]|scsi[n]|sata[n] We rely on qemu-img(1) convert heuristics to detect the file type, as this works in most case. --- PVE/QemuServer/DiskImport.pm | 91 PVE/QemuServ

[pve-devel] [PATCH qemu-server v2 2/2] Add new qm option 'diskimport' to import external disk images

2017-05-02 Thread Emmanuel Kasper
The VM must be already existing, and the synthax is qm diskimport 421 -source minix204.img -storage pve4tank where 421 is an already existing VM --- PVE/CLI/qm.pm | 37 + 1 file changed, 37 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439d

Re: [pve-devel] [PATCH manager] ceph: init: allow pool deletion by default

2017-05-03 Thread Emmanuel Kasper
On 05/03/2017 11:45 AM, Fabian Grünbichler wrote: > set to false by default since Ceph > Kraken > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Ceph.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm > index 12ea28a..89b8eb5 100644 > --- a/PVE

Re: [pve-devel] [PATCH qemu-server v4 3/5] Initial support for importing OVF virtual machines

2017-05-04 Thread Emmanuel Kasper
>> +# tricky xpath >> +# @ means we filter the result query based on a the value of an item >> attribute ( @ = attribute) >> +# @ needs to be escaped to prevent Perl double quote interpolation >> +my $xpath_find_fileref = sprintf("/ovf:Envelope/ovf:DiskSection/\ >> +ovf:Disk[\@ovf:

[pve-devel] [PATCH qemu-server v5 3/5] Initial support for importing OVF virtual machines

2017-05-04 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 236 2 files changed, 237 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v5 2/5] Add a build dependency to libxml-libxml-perl, needed for OVF parsing

2017-05-04 Thread Emmanuel Kasper
XML::LibXML is being actively developed, and has 91 reverse depencies in Debian Stretch, no it should not go away. --- control.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/control.in b/control.in index d0601ac..7834e31 100644 --- a/control.in +++ b/control.in @@ -3,7 +3,7

[pve-devel] [PATCH qemu-server v5 5/5] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-05-04 Thread Emmanuel Kasper
Currently the following extracted parameters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 48 1 file changed, 48 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..5139b81 100755 --- a/PVE/C

[pve-devel] [PATCH qemu-server v5 1/5] Force overwriting existing compressed man pages and symbolic links

2017-05-04 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index e3df3e3..33cf0a3 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v5 0/5] Add qm ovfimport command

2017-05-04 Thread Emmanuel Kasper
contained in the current directory to prevent symlinks attacks. Emmanuel Kasper (5): Force overwriting existing compressed man pages and symbolic links Add a build dependency to libxml-libxml-perl, needed for OVF parsing Initial support for importing OVF virtual machines Add tests for

[pve-devel] [PATCH qemu-server v5 4/5] Add tests for ovfimport function

2017-05-04 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v3 0/2] Add qm diskimport command

2017-05-04 Thread Emmanuel Kasper
changes since v2: * when command lines parameters are mandatory, do not hide them behind switches Emmanuel Kasper (2): Add DiskImport module to import external disk images into a VM Add new qm option 'diskimport' to import external disk images PVE/CLI/qm.pm

[pve-devel] [PATCH qemu-server v3 1/2] Add DiskImport module to import external disk images into a VM

2017-05-04 Thread Emmanuel Kasper
Each disk passed as paramater is add as 'unused[n]' in the vm.conf (the default) or ide[n]|scsi[n]|sata[n] We rely on qemu-img(1) convert heuristics to detect the file type, as this works in most case. --- PVE/QemuServer/DiskImport.pm | 91 PVE/QemuServ

[pve-devel] [PATCH qemu-server v3 2/2] Add new qm option 'diskimport' to import external disk images

2017-05-04 Thread Emmanuel Kasper
The VM must be already existing, and the synthax is qm diskimport 421 minix204.img pve4tank where 421 is an already existing VM --- PVE/CLI/qm.pm | 37 + 1 file changed, 37 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..3a6cded 100755

[pve-devel] [PATCH qemu-server v4 1/3] Refactor the resolution of target disk format in own sub

2017-05-09 Thread Emmanuel Kasper
This will allow use to reuse the code in ImportDisk.pm. --- PVE/QemuServer.pm | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2fb419d..8ea411a 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -61

[pve-devel] [PATCH qemu-server v4 2/3] Add ImportDisk module to import external disk images into a VM

2017-05-09 Thread Emmanuel Kasper
Each disk passed as paramater is add as 'unused[n]' in the vm.conf (the default) or ide[n]|scsi[n]|sata[n] We rely on qemu-img(1) convert heuristics to detect the file type, as this works in most case. --- PVE/QemuServer/ImportDisk.pm | 96 PVE/QemuServ

[pve-devel] [PATCH qemu-server v4 0/3]

2017-05-09 Thread Emmanuel Kasper
switches Emmanuel Kasper (3): Refactor the resolution of target disk format in own sub Add ImportDisk module to import external disk images into a VM Add new qm option 'diskimport' to import external disk images PVE/CLI/qm.pm| 45 + PVE/Qem

[pve-devel] [PATCH qemu-server v4 3/3] Add new qm option 'diskimport' to import external disk images

2017-05-09 Thread Emmanuel Kasper
The VM must be already existing, and the synthax is qm diskimport 421 minix204.img pve4tank where 421 is an already existing VM --- PVE/CLI/qm.pm | 45 + 1 file changed, 45 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..ea3a0d

Re: [pve-devel] [PATCH qemu-server 0/2] Add qm diskimport command

2017-05-11 Thread Emmanuel Kasper
On 04/27/2017 07:56 PM, Alexandre DERUMIER wrote: > Hi Emmanuel, > > I have tested both ovf and disk import with differents ovf found on the net, > > it's working fine for me. (We just need to add import of disks in import ovf) > so I am done with the disk support to importovf, and I am looking

Re: [pve-devel] [PATCH qemu-server v4 3/3] Add new qm option 'diskimport' to import external disk images

2017-05-16 Thread Emmanuel Kasper
>> +completion => \&PVE::Storage::complete_storage_enabled, >> +optional => 0, >> +}, >> +format => { >> +type => 'string', >> +description => 'Target format', >> +enum => [ 'raw', 'qcow2', 'vmdk' ], > > I wonder why we al

[pve-devel] [PATCH manager] Fix #1386: track postfix daemon status via postfix@-

2017-05-17 Thread Emmanuel Kasper
--- PVE/API2/Services.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm index 3ddf5f56..1cbfe2c5 100644 --- a/PVE/API2/Services.pm +++ b/PVE/API2/Services.pm @@ -35,9 +35,16 @@ my $service_name_list = [ 'systemd-timesync

[pve-devel] [PATCH manager v2] Fix #1386: track postfix daemon status via postfix@-

2017-05-18 Thread Emmanuel Kasper
--- IMHO #1387 has a different scope. This patch here deals with fixing the default reporting when a the status of one of our default daemon is reported in a different unit. #1387 is about *manually* changing the default startup of a service to socket activation, and then not getting the proper s

[pve-devel] [PATCH qemu-server v5 1/3] Refactor the resolution of target disk format in own sub

2017-05-22 Thread Emmanuel Kasper
This will allow use to reuse the code in ImportDisk.pm. --- PVE/QemuServer.pm | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2fb419d..b5075d0 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm

[pve-devel] [PATCH qemu-server v5 0/3] Add qm importdisk command

2017-05-22 Thread Emmanuel Kasper
) * useful nitpicks from Thomas about code formatting v3 ceanges: * when command lines parameters are mandatory, do not hide them behind switches Emmanuel Kasper (3): Refactor the resolution of target disk format in own sub Add ImportDisk module to import external disk images into a VM Add new qm

[pve-devel] [PATCH qemu-server v5 3/3] Add new qm option 'diskimport' to import external disk images

2017-05-22 Thread Emmanuel Kasper
The VM must be already existing, and the syntax is qm diskimport 421 minix204.img pve4tank where 421 is an already existing VM --- PVE/CLI/qm.pm | 51 +++ 1 file changed, 51 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..7

[pve-devel] [PATCH qemu-server v5 2/3] Add ImportDisk module to import external disk images into a VM

2017-05-22 Thread Emmanuel Kasper
Each disk passed as paramater is add as 'unused[n]' in the vm.conf (the default) or ide[n]|scsi[n]|sata[n] We rely on qemu-img(1) convert heuristics to detect the file type, as this works in most case. --- PVE/QemuServer/ImportDisk.pm | 87 PVE/QemuServ

[pve-devel] [PATCH qemu-server v6 0/5] Add qm importovf command

2017-05-23 Thread Emmanuel Kasper
stResource element HostResources/ovf:href elements are uri paths components/url, so we test them with the according regexp. * Test if the disk image the OVF is refering to is contained in the current directory to prevent symlinks attacks. Emmanuel Kasper (5): Force overwritin

[pve-devel] [PATCH qemu-server v6 1/5] Force overwriting existing compressed man pages and symbolic links

2017-05-23 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 7d89454..f7452a6 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v6 5/5] Add a new command line option 'importovf', to create VMs from an OVF manifest

2017-05-23 Thread Emmanuel Kasper
Currently the following extracted parameters are used to create a VM: * VM name * Memory * Number of cores * Disks --- PVE/CLI/qm.pm | 69 +++ 1 file changed, 69 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 7c5b2c4..dde75a7

[pve-devel] [PATCH qemu-server v6 4/5] Add tests for parse_ovf function

2017-05-23 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v6 2/5] Add a build dependency to libxml-libxml-perl, needed for OVF parsing

2017-05-23 Thread Emmanuel Kasper
XML::LibXML is being actively developed, and has 91 reverse depencies in Debian Stretch, no it should not go away. --- control.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/control.in b/control.in index d0601ac..7834e31 100644 --- a/control.in +++ b/control.in @@ -3,7 +3,7

[pve-devel] [PATCH qemu-server v6 3/5] Initial support for importing OVF virtual machines

2017-05-23 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 236 2 files changed, 237 insertions(+) create mode 100644

Re: [pve-devel] [PATCH manager 3/3] add more verbose warning for node shutdown/reboot

2017-05-24 Thread Emmanuel Kasper
On 05/12/2017 12:14 PM, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > I'm open for better warning message suggestions :-) I would reuse the already localized gettext String "Stop all VMs and Containers". There was the bug report #1095 which you can close with your commit.

[pve-devel] [RFC PATCH] Do not internationalize 'Pools' when used in Ceph Context

2017-05-29 Thread Emmanuel Kasper
This is a Ceph domain term and should not be translated like OSD, ... Galician had "Virtual Groups" for Pools, which does not apply for Ceph Context. Also most languages were using 'Pools' anyway. --- www/manager6/node/Config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/w

[pve-devel] [PATCH manager 1/2] Adapt SafeDestroy component to be able to delete Ceph Pools

2017-05-29 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 1 + www/manager6/window/SafeDestroy.js | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index d1ada771..25d78f7b 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -613,

  1   2   3   4   5   6   7   8   9   10   >