[pve-devel] Ack: Re: [PATCH storage 1/3] rbd: use 'rbd ls' without '-l' to find free names

2017-02-09 Thread Emmanuel Kasper
I tested this patch OK, and code looks good to me. On 02/03/2017 01:00 PM, Fabian Grünbichler wrote: > with more than a few images, 'rbd ls -l' gets rather slow > compared to a simple 'rbd ls'. since we only need to check > existing image names for finding a free one, the latter is > sufficient.

Re: [pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-09 Thread Emmanuel Kasper
+ emptyText: gettext('Same as source'), On 02/08/2017 07:05 PM, Dietmar Maurer wrote: > I would like to avoid additional gettext entries if possible. > > Do we know the source storage? If so, can we set that storage as 'emptyText'? > Other ideas? We don't know the source storage*s*,

[pve-devel] [PATCH qemu-server] Improve error message when trying to shrink a volume, fix typo

2017-02-16 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a41e74f..a077ed7 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3049,7 +3049,7 @@ __PACKAGE__->register_method({ $newsize += $size if $ext;

[pve-devel] [PATCH cluster] Remove depency to libxml-parser-perl

2017-02-16 Thread Emmanuel Kasper
This xml parser was added to parser RHCM cluster.conf, we don't parse this anymore. --- data/PVE/Cluster.pm | 1 - debian/control.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 09ed5d7..39708c8 100644 ---

[pve-devel] [PATCH manager 2/3] Do not try to translate domain specific terms

2017-01-18 Thread Emmanuel Kasper
No one is translating DHCP in his/her own language. --- www/manager6/ceph/Config.js | 2 +- www/manager6/ceph/Pool.js | 2 +- www/manager6/ceph/Status.js | 2 +- www/manager6/dc/Health.js | 2 +- www/manager6/lxc/Network.js | 18 +- 5 files changed, 13 insertions(+), 13

[pve-devel] [PATCH manager 1/3] Remove duplicate strings

2017-01-18 Thread Emmanuel Kasper
--- www/manager6/Utils.js| 2 +- www/manager6/node/Config.js | 2 +- www/manager6/qemu/Options.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 180b283..40d2fe1 100644 --- a/www/manager6/Utils.js +++

[pve-devel] [PATCH manager 3/3] Remove redundant helper for login window

2017-01-18 Thread Emmanuel Kasper
the information is already provided by the label, the helper does not add meaningfull information here. --- www/manager6/ceph/Config.js| 2 +- www/manager6/window/LoginWindow.js | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/www/manager6/ceph/Config.js

[pve-devel] [PATCH manager 0/3] Reduce the number of required translations

2017-01-18 Thread Emmanuel Kasper
A side note: if you use an english technical term in your own language (DHCP, DNS) it probably does not need a translation. Emmanuel Kasper (3): Remove duplicate strings Do not try to translate domain specific terms Remove redundant helper for login window www/manager6/Utils.js

Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Emmanuel Kasper
On 01/16/2017 10:14 PM, Gustaf Ankarloo wrote: > Are there any plans of making a import function for OVA/OVF ? > I know it's doable with a lot of manual tinkering I have this somewhere in my todo list although it is not high priority at the momment. I would like to try to following approach: *

Re: [pve-devel] Question: open virtual appliance

2017-01-19 Thread Emmanuel Kasper
On 01/19/2017 07:46 AM, Alexandre DERUMIER wrote: > Hi, > > as a first step, I have send patch to import external disk image. > > now for ova import, > I think we need a method to extract files from ova (it's a simple tar file), > > then an xml parser to parse OVF descriptor > > Does somebody

[pve-devel] [PATCH manager v2 2/2] Split the Enable + name construct in two separate gettext strings

2017-01-18 Thread Emmanuel Kasper
This reduce the number of strings to translate. --- www/manager6/grid/FirewallOptions.js | 10 +- www/manager6/lxc/Options.js | 6 +++--- www/manager6/lxc/ResourceEdit.js | 2 +- www/manager6/qemu/ProcessorEdit.js | 2 +- 4 files changed, 10 insertions(+), 10

[pve-devel] [PATCH manager v2 1/2] Remove technical terms from content to be translated

2017-01-18 Thread Emmanuel Kasper
--- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js | 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/ha/ResourceEdit.js | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index

[pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Emmanuel Kasper
Mostly split out technical term who don't need to be translated outside of the gettext function paramater. --- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js| 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/grid/FirewallOptions.js | 10

Re: [pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-27 Thread Emmanuel Kasper
On 02/22/2017 11:07 AM, Dominik Csapak wrote: > On 02/09/2017 04:13 PM, Emmanuel Kasper wrote: >> >> +emptyText: gettext('Same as source'), >> >> On 02/08/2017 07:05 PM, Dietmar Maurer wrote: >>> I would like to avoid additional gettext entries if pos

[pve-devel] [RFC PATCH qemu-server v2 1/5] Force overwriting existing compressed man pages and symbolic links

2017-02-28 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index d59af8c..95e647f 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m

[pve-devel] [RFC PATCH qemu-server v2 5/5] Add tests for ovfimport function

2017-02-28 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports of VM from a VmWare Workstation export * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc i: they contain a VMDK header and the rest are null characters) ---

[pve-devel] [RFC PATCH qemu-server v2 3/5] Initial parsing of OVF files

2017-02-28 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 217 2 files changed, 218 insertions(+) create mode 100644

[pve-devel] [RFC PATCH qemu-server v2 0/5] Initial support for OVF imports

2017-02-28 Thread Emmanuel Kasper
Emmanuel Kasper (5): Force overwriting existing compressed man pages and symbolic links Add depency to libxml-simple-perl Initial parsing of OVF files Add a new command line option 'ovfimport', to create VMs from an OVF manifest Add tests for ovfimport function Makefile

[pve-devel] [RFC PATCH qemu-server v2 2/5] Add depency to libxml-simple-perl

2017-02-28 Thread Emmanuel Kasper
XML::Simple provides a much cleaner output than XML::Parser, as XML::Parser tries to preserve everything in the document (line breaks) when we don't need this information. The current known limitation of XML::Simple is that it is not recommended for generating XMl, but this is not our aim. ---

[pve-devel] [RFC PATCH qemu-server v2 4/5] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-02-28 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ PVE/QemuServer/OVF.pm | 22 +- 2 files changed, 64 insertions(+), 5

[pve-devel] [PATCH manager] Rename 'create' to 'isCreate' in pveWindowEdit and subclasses

2017-02-28 Thread Emmanuel Kasper
This fixes around 20 jslint type confusion warnings. Also reduce the scope and document jslint warnings along the way. No functional changes. --- www/manager6/ceph/Monitor.js | 4 ++-- www/manager6/ceph/OSD.js | 11 + www/manager6/ceph/Pool.js | 5 +

Re: [pve-devel] [PATCH manager] add css fix for chrome >=56

2017-03-02 Thread Emmanuel Kasper
LGTM but can we include a link in the commit log to the sencha forum post discussing the issue ? On 03/02/2017 08:45 AM, Dominik Csapak wrote: > with chrome/chromium version 56, they changed the way how they calculate > height of text in input fields (now it is correct according to the >

[pve-devel] [PATCH pve-docs 1/2] merge the good parts of the Backup wiki articke

2016-09-05 Thread Emmanuel Kasper
http://pve.proxmox.com/wiki/Backup_and_Restore had some good stuff missing from the reference documentation, so integrate this part in the reference documentation --- vzdump.adoc | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/vzdump.adoc

[pve-devel] [PATCH pve-docs 2/2] rewrite backup mode explaination for qemu

2016-09-05 Thread Emmanuel Kasper
* try to stress the data consistency implications before going to the technical implementation * reoderder chapter levels to be consistent with the rest of the page --- vzdump.adoc | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff

[pve-devel] [PATCH] add multicast DNS to the list of Macros

2016-09-05 Thread Emmanuel Kasper
multicast DNS allows to quickly access hosts without the need to configure a DNS server --- src/PVE/Firewall.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 22bf61d..9aa9be1 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@

[pve-devel] [PATCH pve-docs] Merge the best of the Linux Container wiki article

2016-09-06 Thread Emmanuel Kasper
Adding to FAQ as the pct documentation itself is not the best fit for this entry. --- pve-faq.adoc | 22 ++ 1 file changed, 22 insertions(+) diff --git a/pve-faq.adoc b/pve-faq.adoc index 11b30eb..d3f2c84 100644 --- a/pve-faq.adoc +++ b/pve-faq.adoc @@ -85,3 +85,25 @@

[pve-devel] [PATCH pve-docs 2/2] Fix "rock-it" containers typo

2016-09-08 Thread Emmanuel Kasper
--- pct.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pct.adoc b/pct.adoc index 9f4fde8..193b2f8 100644 --- a/pct.adoc +++ b/pct.adoc @@ -59,7 +59,7 @@ Our primary goal is to offer an environment as one would get from a VM, but without the additional overhead. We call

[pve-devel] [PATCH pve-docs 1/2] Explain how PVE containers use LXC in the FAQ.

2016-09-08 Thread Emmanuel Kasper
--- pve-faq.adoc | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/pve-faq.adoc b/pve-faq.adoc index bcb6160..8270909 100644 --- a/pve-faq.adoc +++ b/pve-faq.adoc @@ -86,7 +86,7 @@ recommended. | {pve} 1.x | Debian 5 (Lenny) | 2008-10 | 2012-03|

[pve-devel] [PATCH manager] Add link to terms glossary when adding an ACL

2016-09-08 Thread Emmanuel Kasper
This is especially needed to know what is the synthax of the Path input field --- www/manager6/dc/ACLView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/ACLView.js b/www/manager6/dc/ACLView.js index 35d768e..989aa99 100644 --- a/www/manager6/dc/ACLView.js

[pve-devel] [PATCH pve-docs] Fix PVE API URL

2016-09-08 Thread Emmanuel Kasper
--- pveum.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index 00f260a..6c4ef9a 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -213,7 +213,8 @@ by default). We use the following inheritance rules: What permission do I need?

Re: [pve-devel] [RFC PATCH manager 5/5] add efidisk button to add menu

2016-09-12 Thread Emmanuel Kasper
On 09/12/2016 12:02 PM, Dominik Csapak wrote: > this adds a new button "efi disk" to the > qemu hardware add menu the name "efi disk" is right if we refer to the technical implementation of the feature, but quite unfamiliar to real world PCs and EFI. Maybe a name like "EFI vars store" would be

[pve-devel] [PATCH manager] Bugfix Only set a content when we have a selection

2016-09-14 Thread Emmanuel Kasper
Removing a node via updateTree() would cause the selection to be lost temporary which in turn via the selectionchange listener would select an empty content. Now we only set a content if we have a selection. This fix a graphical glitch where a migrated VM would not be properly re-selected at its

[pve-devel] [PATCH manager v2] Bugfix Only set a content when we have a selection

2016-09-14 Thread Emmanuel Kasper
Removing a node via updateTree() would cause the selection to be lost temporary which in turn via the selectionchange listener would select an empty content. Now we only set a content if we have a selection. This fix a graphical glitch where a migrated VM would not be properly re-selected at its

[pve-devel] [PATCH qemu-server] Change default VM SCSI controller type from LSI to VirtIO-SCSI

2016-09-13 Thread Emmanuel Kasper
see https://bugzilla.proxmox.com/show_bug.cgi?id=1106 --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index df9932c..2836583 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -193,7 +193,7 @@ my $confdesc

Re: [pve-devel] [PATCH qemu-server] Change default VM SCSI controller type from LSI to VirtIO-SCSI

2016-09-13 Thread Emmanuel Kasper
please ignore this, wrong shoot On 09/13/2016 02:47 PM, Emmanuel Kasper wrote: > see https://bugzilla.proxmox.com/show_bug.cgi?id=1106 > --- > PVE/QemuServer.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.

[pve-devel] [PATCH docs] Add warning about using qcow2 images on a ZFS filesystem

2016-10-05 Thread Emmanuel Kasper
--- local-zfs.adoc | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index 9b682b9..1b9f682 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -254,6 +254,22 @@ can be used as cache. zpool replace -f +Using a directory

[pve-devel] [PATCH docs] Update the list of supported web browsers

2016-10-05 Thread Emmanuel Kasper
Also move the list of supported browsers from Installing Proxmox VE to the System Requirements chapter --- pve-installation.adoc| 3 +-- pve-system-requirements.adoc | 15 +++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/pve-installation.adoc

[pve-devel] [PATCH manager v3 0/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-06 Thread Emmanuel Kasper
Changes since v2: * create regexp in the PVE.Utils namespace. Previous version used the global namespace because all regexps were defined there. Emmanuel Kasper (2): Add regexp to match a bus entry in a VM config When adding a new hard disk, use the most used controller as suggested

[pve-devel] [PATCH manager v3 2/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-06 Thread Emmanuel Kasper
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and

[pve-devel] [PATCH manager v3 1/2] Add regexp to match a bus entry in a VM config

2016-10-06 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 2 ++ www/manager6/qemu/BootOrderEdit.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3c15135..060643a 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -103,6

[pve-devel] [PATCH manager v2 2/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-05 Thread Emmanuel Kasper
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and

[pve-devel] [PATCH manager v2 1/2] Add global regexp to match bus entry in a VM config

2016-10-05 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 2 ++ www/manager6/qemu/BootOrderEdit.js | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3c15135..3bf5188 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -63,6

[pve-devel] [PATCH manager 1/2] Move bus priority list to OSDefaults

2016-10-10 Thread Emmanuel Kasper
So a field container does not need to know if Linux likes SCSI. --- www/manager6/form/ControllerSelector.js | 8 www/manager6/qemu/OSDefaults.js | 12 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js

[pve-devel] [PATCH manager 2/2] Fix jslint warning: 'sortedList' is already defined

2016-10-10 Thread Emmanuel Kasper
sortedList was defined twice in the function remove the declaration at the beginning of function as declaring a var just before using it is more similar to the rest of code --- www/manager6/form/ControllerSelector.js | 1 - 1 file changed, 1 deletion(-) diff --git

[pve-devel] [PATCH pve-docs] Document that virtio-scsi is the recommended controller for PVE >= 4.3

2016-09-15 Thread Emmanuel Kasper
--- qm.adoc | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/qm.adoc b/qm.adoc index 375cc39..f77bd9d 100644 --- a/qm.adoc +++ b/qm.adoc @@ -122,18 +122,19 @@ on this controller. design, allowing higher throughput and a greater number of devices to be

[pve-devel] [PATCH manager 2/2] Use SCSI controller as default for l26 guests fix #1105

2016-09-15 Thread Emmanuel Kasper
NB: This is only for new created VMs. --- www/manager6/qemu/OSDefaults.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index 7ebfef0..dc13eeb 100644 --- a/www/manager6/qemu/OSDefaults.js +++

[pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-15 Thread Emmanuel Kasper
--- www/manager6/qemu/HDEdit.js | 4 www/manager6/qemu/OSDefaults.js | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index c86ab44..312b218 100644 --- a/www/manager6/qemu/HDEdit.js +++

[pve-devel] [PATCH manager] do not test for the cgmanager package in pveversion fix #1117

2016-09-21 Thread Emmanuel Kasper
the package has been removed from the list of lxcfs dependencies since 0.12-pve1 --- PVE/API2/APT.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index cf63c4c..3672053 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -534,7 +534,7 @@

[pve-devel] [PATCH docs] Add a new top level chapter on how to improve the reference documentation

2016-09-21 Thread Emmanuel Kasper
--- Makefile | 1 + index.adoc | 1 + pve-admin-guide.adoc | 2 ++ pve-improve.adoc | 37 + 4 files changed, 41 insertions(+) create mode 100644 pve-improve.adoc diff --git a/Makefile b/Makefile index 0acaedf..a8205b0 100644 ---

[pve-devel] [RFC manager] When adding a new hard disk, use the most used controller as suggested value

2016-09-21 Thread Emmanuel Kasper
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Emmanuel Kasper
On 09/19/2016 10:38 AM, Caspar Smit wrote: > Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault > template and the w2k OSdefaults has a parent generic, doesn't that inherit > all settings from generic? Why else does it need a parent? > > As i read the code the 'w2k'

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Emmanuel Kasper
On 09/16/2016 03:11 PM, Caspar Smit wrote: > Hi, > > I'm assuming this commit will break the 'w2k' pveOS default (because the > scsihw will be inherited from generic): not really, because presetting a different kind of SCSI controller will not impact the _default_ controller which will still be

[pve-devel] [PATCH manager 2/2] fix #1113 use a LSI controller for legacy OSes

2016-09-20 Thread Emmanuel Kasper
instead of setting virtio-scsi for all newly created VMs, pass the OS Optimal SCSI Controller to pveQemuCreateWizard which will add it as an hidden paramater just before POSTing the wizard data to the API. --- www/manager6/qemu/CreateWizard.js | 5 + www/manager6/qemu/OSDefaults.js | 9

[pve-devel] [PATCH manager 1/2] fix #1113: preserve LSI controller for legacy Oses

2016-09-20 Thread Emmanuel Kasper
The SCSI HW type handling will be made in the Wizard class, removing from here. --- www/manager6/qemu/HDEdit.js | 4 1 file changed, 4 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 312b218..c86ab44 100644 --- a/www/manager6/qemu/HDEdit.js +++

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

2016-09-19 Thread Emmanuel Kasper
On 09/19/2016 11:23 AM, Emmanuel Kasper wrote: > On 09/19/2016 10:38 AM, Caspar Smit wrote: >> Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault >> template and the w2k OSdefaults has a parent generic, doesn't that inherit >> all settings from g

Re: [pve-devel] [PATCH manager 0/7] new StatusView

2016-08-18 Thread Emmanuel Kasper
On 07/11/2016 03:46 PM, Dominik Csapak wrote: > this patch series changes the StatusView Panel > > this version has multiple advantages: > > uses space more efficiently > (two columns on node statusview) > makes information more readable > (grouping, spacing, progressbar with colors) > displays

Re: [pve-devel] [PATCH manager 3/7] add GuestStatusView and TemplateStatusView

2016-08-18 Thread Emmanuel Kasper
On 07/11/2016 03:46 PM, Dominik Csapak wrote: > this implements the new StatusView class for > guests and templates > > using the new pveStatusView, we do not split the status > panels per lxc/qemu, but for Template/Guest > > this makes more sense, since the information which lxc > and qemu

[pve-devel] [PATCH manager v2] Clear sensitive content when logging out fixes #1060

2016-08-18 Thread Emmanuel Kasper
The current position inside the Workspace is saved via the StateProvider separately thus this clearing operation do not lose the previous selection. As a side effect by calling setContent(null) on logout we also fix the following bug: when logging out while the Syslog tab of the Node panel was

[pve-devel] [PATCH manager v3] Clear sensitive content when logging out fixes #1060

2016-08-18 Thread Emmanuel Kasper
The current position inside the Workspace is saved via the StateProvider separately thus this clearing operation do not lose the previous selection. As a side effect by calling setContent(null) on logout we also fix the following bug: when logging out while the Syslog tab of the Node panel was

[pve-devel] [PATCH manager] Minor refactor for #1115 (reload grid after template download)

2016-09-28 Thread Emmanuel Kasper
Move the listener to the new window declaration to make it clear this listener is not bound to the current component --- www/manager6/storage/ContentView.js | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/www/manager6/storage/ContentView.js

Re: [pve-devel] [RFC manager] When adding a new hard disk, use the most used controller as suggested value

2016-09-28 Thread Emmanuel Kasper
On 09/22/2016 02:09 PM, Dietmar Maurer wrote: > I would not change the order when displaying the list. Just select > the default ... > the clist we sort here is actually only used for setting the value of the comboBox, we call setValue() on the first element of the list further down

Re: [pve-devel] [PATCH docs 3/3] add section about two factor authentication

2016-10-03 Thread Emmanuel Kasper
On 10/03/2016 10:44 AM, Wolfgang Bumiller wrote: > --- > Not sure if it makes sense to mention the apps here, but they do work > out of the box and are fairly wide spread, which shows users that > we're using standard methods and don't require custom tools. IMHO this makes sense as we save pve

[pve-devel] [PATCH docs v2 1/3] Move getting help section from system administration to introduction

2016-10-03 Thread Emmanuel Kasper
--- pve-intro.adoc | 2 ++ sysadmin.adoc | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pve-intro.adoc b/pve-intro.adoc index 15212c5..56d8dd3 100644 --- a/pve-intro.adoc +++ b/pve-intro.adoc @@ -195,6 +195,8 @@ Your benefit with {pve} * Huge active community * Low

[pve-devel] Explain how to improve the reference documentation (V2)

2016-10-03 Thread Emmanuel Kasper
changes since v1: * move content after help section to avoid duplicating the list of support channels * don't explain what we doc with the adoc files, refer to README.adoc * also mention the Developer Setup wiki article for people wanting to work the codebase

[pve-devel] [PATCH docs v2 3/3] Improve wording of getting help section for commercial support

2016-10-03 Thread Emmanuel Kasper
* list some advantages of the standard support * put a single link to improve call-to-action --- getting-help.adoc | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 0bb28a7..180a212 100644 --- a/getting-help.adoc +++

[pve-devel] [PATCH docs v2 2/3] Add sub chapter on how to improve the reference documentation

2016-10-03 Thread Emmanuel Kasper
--- pve-intro.adoc | 33 + 1 file changed, 33 insertions(+) diff --git a/pve-intro.adoc b/pve-intro.adoc index 56d8dd3..0431e09 100644 --- a/pve-intro.adoc +++ b/pve-intro.adoc @@ -240,3 +240,36 @@ The most notable change with version 4.0 was the move from OpenVZ

[pve-devel] [PATCH manager] fix #1115 reload storage grid after template download

2016-09-26 Thread Emmanuel Kasper
Refresh the grid after the template has been downloaded, instead of refreshing after the template has been selected. this fix a the problem that a newly Turnkey / PVE downloaded template would not be shown in the storage content grid after closing the task window ---

Re: [pve-devel] [PATCH manager] fix #1115 reload storage grid after template download

2016-09-26 Thread Emmanuel Kasper
On 09/26/2016 03:35 PM, Dietmar Maurer wrote: >> win.show(); >> +win.on('destroy', me.reload); >> me.close(); > > Sorry, but why does it make sense to reload a 'closed' window? > the reload function here will reload the store parent

[pve-devel] [PATCH manager v2] fix #1115 reload storage grid after template download

2016-09-26 Thread Emmanuel Kasper
Refresh the grid after the template has been downloaded, instead of refreshing after the template has been selected. this fix a the problem that a newly Turnkey / PVE downloaded template would not be shown in the storage content grid after closing the task window --- change since V1: * rename

Re: [pve-devel] pve-kernel

2016-10-19 Thread Emmanuel Kasper
On 10/19/2016 12:18 PM, Michael Rasmussen wrote: > On Wed, 19 Oct 2016 06:13:28 +0200 (CEST) > Dietmar Maurer wrote: > >> >> Something else changed? >> > Forgot to mention: I backported on my pve-develop machine so strictly > speaking it is not a valid backport since jessie

[pve-devel] [PATCH manager v2 1/2] Turn PVE.Utils into a singleton

2016-10-18 Thread Emmanuel Kasper
This will allow us to add contructed values ( regexp a = stringA + stringB ) into the constructor. Access to the PVE.Utils properties and methods stays the same. --- www/manager6/Utils.js | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js

[pve-devel] [PATCH manager v2 0/2] Remove global variables from Utils.js

2016-10-18 Thread Emmanuel Kasper
Changes since V1: * rebase * drop trailing coma fox in OsDefaults, as it was fixed in between Emmanuel Kasper (2): Turn PVE.Utils into a singleton Move globally defined regexpes into PVE.Utils www/manager6/Toolkit.js | 20 ++-- www/manager6/Utils.js | 82

Re: [pve-devel] [PATCH docs] Add subchapter documenting the startup/shutdown options

2016-10-18 Thread Emmanuel Kasper
On 10/18/2016 09:29 AM, Dietmar Maurer wrote: > applied. But we have the same feature for containers? Yes. A patch will follow for containers. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 2/2] Move globally defined regexpes into PVE.Utils

2016-10-18 Thread Emmanuel Kasper
Those globally defined regexpes were only used in Toolkit.js --- www/manager6/Toolkit.js | 20 +++--- www/manager6/Utils.js | 70 - 2 files changed, 44 insertions(+), 46 deletions(-) diff --git a/www/manager6/Toolkit.js

[pve-devel] [PATCH manager 0/4] Usability improvements for the HA edit resources windows

2016-10-19 Thread Emmanuel Kasper
A patch for pve-docs for the onlineHelp reference is on the way. Emmanuel Kasper (4): Move out custom css style for hints in css class and use it Close #1161: add hint when disabling a ha resource Use enable as adjective to match the Resource List panel Add onlineHelp www/css/ext6

[pve-devel] [PATCH docs] Add reference for onlineHelp for HA resource management

2016-10-19 Thread Emmanuel Kasper
--- ha-manager.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/ha-manager.adoc b/ha-manager.adoc index 582dfcc..d49a8c6 100644 --- a/ha-manager.adoc +++ b/ha-manager.adoc @@ -484,6 +484,7 @@ killing its process) * *after* you fixed all errors you may enable the service again

[pve-devel] [PATCH qemu-server] Close #351: add more info to backup log

2016-10-20 Thread Emmanuel Kasper
Before patch: INFO: exclude disk 'scsi1' (backup=no) INFO: skip unused drive 'local:401/vm-401-disk-3.raw' (not included into backup) INFO: skip unused drive 'local:401/vm-401-disk-1.raw' (not included into backup) After patch applied: INFO: include disk 'scsi0' local:401/vm-401-disk-4.qcow2

Re: [pve-devel] [PATCH qemu-server] Document shutdown behaviour when qemu-guest-agent is running

2016-10-17 Thread Emmanuel Kasper
On 10/17/2016 11:05 AM, Fabian Grünbichler wrote: > On Mon, Oct 17, 2016 at 10:52:26AM +0200, Emmanuel Kasper wrote: >> --- >> PVE/API2/Qemu.pm | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm

[pve-devel] [PATCH qemu-server] Document shutdown behaviour when qemu-guest-agent is running

2016-10-17 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ad7a0c0..f64a77c 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1858,8 +1858,10 @@ __PACKAGE__->register_method({ method => 'POST',

[pve-devel] [PATCH docs] Add a note referencing the qm man page for the shutdown internals

2016-10-17 Thread Emmanuel Kasper
--- Not 100% sure if these shutdown explaination belong to asciidoc or to the generated manu. qm.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qm.adoc b/qm.adoc index 3624e2f..5d711f7 100644 --- a/qm.adoc +++ b/qm.adoc @@ -464,6 +464,9 @@ start after those where the parameter is

[pve-devel] [PATCH manager] Fix #1144: set a default disk format for VM disk widgets

2016-10-25 Thread Emmanuel Kasper
Up to now Qemu Wizard, Clone, and Hard Disk Move components had a different idea of what should be the proposed format of a disk image. Make all them auto select qcow2. --- Not especially proud of using variable called "PVE.qemu.OSDefaults.generic.diskFormat" (39 characters) but can't find a

Re: [pve-devel] [PATCH manager] Fix #1144: set a default disk format for VM disk widgets

2016-10-25 Thread Emmanuel Kasper
On 10/25/2016 05:50 PM, Michael Rasmussen wrote: > On Tue, 25 Oct 2016 17:42:41 +0200 > Emmanuel Kasper <e.kas...@proxmox.com> wrote: > >> Up to now Qemu Wizard, Clone, and Hard Disk Move components had >> a different idea of what should be the proposed format >>

[pve-devel] [PATCH manager 3/4] Use enable as adjective to match the Resource List panel

2016-10-19 Thread Emmanuel Kasper
Since we describe a resource state, an adjective is also here a better match. --- www/manager6/ha/ResourceEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js index 46857dc..e220154 100644 ---

[pve-devel] [PATCH manager 4/4] Add onlineHelp

2016-10-19 Thread Emmanuel Kasper
--- www/manager6/ha/ResourceEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js index e220154..fcf62ec 100644 --- a/www/manager6/ha/ResourceEdit.js +++ b/www/manager6/ha/ResourceEdit.js @@ -1,6 +1,6 @@

[pve-devel] [PATCH manager 2/4] Close #1161: add hint when disabling a ha resource

2016-10-19 Thread Emmanuel Kasper
Disabling a HA resource/service means that this ressource will always be turned off. However some users though this disabling HA management for this VM, see http://pve.proxmox.com/pipermail/pve-user/2016-October/011024.html so we had a hint after clicking on the 'disable' checkbox, that the

[pve-devel] [PATCH manager 1/4] Move out custom css style for hints in css class and use it

2016-10-19 Thread Emmanuel Kasper
--- www/css/ext6-pve.css | 4 www/manager6/qemu/QemuBiosEdit.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index e72355b..c050aca 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -376,6 +376,10

[pve-devel] Disabling os-prober when installing on top of debian ?

2016-11-14 Thread Emmanuel Kasper
Hi The debian grub package has a dependency on os-prober which is known to corrupt the file systems of virtual machines. Basically os-prober tries to mount each block device available on the host, looking for other installed OS to create dualboot entries for grub. This does not play very well

[pve-devel] [PATCH docs] Explain start up and shutdown behaviour for containers

2016-11-17 Thread Emmanuel Kasper
Mostly imported from Wiki --- pct.adoc | 31 +++ 1 file changed, 31 insertions(+) diff --git a/pct.adoc b/pct.adoc index 67abec1..1c27878 100644 --- a/pct.adoc +++ b/pct.adoc @@ -574,6 +574,37 @@ individually * Redistribute backed up files according to new mount

[pve-devel] [PATCH docs] typo: s/salable/scalable/

2016-11-17 Thread Emmanuel Kasper
--- pve-storage-glusterfs.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-storage-glusterfs.adoc b/pve-storage-glusterfs.adoc index f12884a..af4b857 100644 --- a/pve-storage-glusterfs.adoc +++ b/pve-storage-glusterfs.adoc @@ -7,7 +7,7 @@ endif::wiki[] Storage pool

[pve-devel] [PATCH qemu-server] Add entry for windows 10 and 2016 support

2016-11-17 Thread Emmanuel Kasper
All special flags for Windows 8 and Windows 2012 (win8 type) are kept the same , since we set flags based on checking if /^win(\d+)$/ is greater than 6 or 7 --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index

[pve-devel] [PATCH manager] Add Windows 2016 as available ostype to select

2016-11-17 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 3 ++- www/manager6/qemu/OSTypeEdit.js | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index c824b97..8d5a598 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -63,7 +63,8

Re: [pve-devel] Disabling os-prober when installing on top of debian ?

2016-11-15 Thread Emmanuel Kasper
On 11/15/2016 08:24 AM, Fabian Grünbichler wrote: > On Mon, Nov 14, 2016 at 04:21:23PM +0100, Emmanuel Kasper wrote: >> Now I was wondering, should we add a dependency to our grub package in >> pve-manager ? We could also add a big red note in the installation >> documentation

[pve-devel] [PATCH manager] Fix #1186: do not run non installed commands

2016-10-28 Thread Emmanuel Kasper
Conditionnally add commands which are not: * Debian packages whith priority Essential or Important, * a dependency of pve-manager --- PVE/Report.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 89714b8..0d0eaa8 100644 ---

[pve-devel] [PATCH manager 1/3] Turn PVE.Utils into a singleton object

2016-10-12 Thread Emmanuel Kasper
This will allow us to add contructed values ( regexp a = stringA + stringB ) into the constructor. Access to the PVE.Utils properties and methods stays the same. The double curly brace at the end is due to a double opening curly brace when doing the declaration with Ext.define Not sure if

[pve-devel] [PATCH manager 2/3] Move globally defined regexpes into PVE.Utils

2016-10-12 Thread Emmanuel Kasper
Those globally defined regexpes were only used in Toolkit.js --- www/manager6/Toolkit.js | 20 +++--- www/manager6/Utils.js | 70 - 2 files changed, 44 insertions(+), 46 deletions(-) diff --git a/www/manager6/Toolkit.js

[pve-devel] [PATCH manager 3/3] Fix jslint warning about trailing comma

2016-10-12 Thread Emmanuel Kasper
--- www/manager6/qemu/OSDefaults.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index f2fc8f4..09190e0 100644 --- a/www/manager6/qemu/OSDefaults.js +++ b/www/manager6/qemu/OSDefaults.js @@ -71,7 +71,7 @@

[pve-devel] [PATCH docs] Update the qm command line example to use the new volume format

2016-10-13 Thread Emmanuel Kasper
Also since the command line is now longer, move the NIC creation to a separate command. --- qm.adoc | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index a0b6950..3624e2f 100644 --- a/qm.adoc +++ b/qm.adoc @@ -476,9 +476,16 @@ create and delete

[pve-devel] [PATCH docs] Add subchapter documenting the startup/shutdown options

2016-10-13 Thread Emmanuel Kasper
based on http://pve.proxmox.com/wiki/Virtual_Machine_Startup_and_Shutdown_Behavior --- NB: a related patch for Containers will follow. qm.adoc | 33 + 1 file changed, 33 insertions(+) diff --git a/qm.adoc b/qm.adoc index a30e7dc..a0b6950 100644 --- a/qm.adoc +++

[pve-devel] [PATCH qemu-server] Fix typo

2016-10-13 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 21fbebb..ad7a0c0 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1732,7 +1732,7 @@ __PACKAGE__->register_method({ optional => 1,

[pve-devel] [PATCH manager] make Win XP and Win 2003 use the same defaults as Win 2000

2016-10-10 Thread Emmanuel Kasper
(this means: rtl8139 as nic and lsi as hardware controller) XP & 2003 ISO E1000 drivers are missing or do not work with Qemu (source: https://pve.proxmox.com/wiki/Windows_2003_guest_best_practices) (source: https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes) The lsi SCSI controller was the

<    1   2   3   4   5   6   7   8   9   >