[pve-devel] [PATCH docs] Add a new top level chapter on how to improve the reference documentation

2016-09-21 Thread Emmanuel Kasper
--- Makefile | 1 + index.adoc | 1 + pve-admin-guide.adoc | 2 ++ pve-improve.adoc | 37 + 4 files changed, 41 insertions(+) create mode 100644 pve-improve.adoc diff --git a/Makefile b/Makefile index 0acaedf..a8205b0 100644 --- a/

[pve-devel] [PATCH manager] do not test for the cgmanager package in pveversion fix #1117

2016-09-21 Thread Emmanuel Kasper
the package has been removed from the list of lxcfs dependencies since 0.12-pve1 --- PVE/API2/APT.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index cf63c4c..3672053 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -534,7 +534,7 @@ _

[pve-devel] [RFC manager] When adding a new hard disk, use the most used controller as suggested value

2016-09-21 Thread Emmanuel Kasper
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and persona

[pve-devel] [PATCH manager] fix #1115 reload storage grid after template download

2016-09-26 Thread Emmanuel Kasper
Refresh the grid after the template has been downloaded, instead of refreshing after the template has been selected. this fix a the problem that a newly Turnkey / PVE downloaded template would not be shown in the storage content grid after closing the task window --- www/manager6/storage/ContentV

Re: [pve-devel] [PATCH manager] fix #1115 reload storage grid after template download

2016-09-26 Thread Emmanuel Kasper
On 09/26/2016 03:35 PM, Dietmar Maurer wrote: >> win.show(); >> +win.on('destroy', me.reload); >> me.close(); > > Sorry, but why does it make sense to reload a 'closed' window? > the reload function here will reload the store parent g

[pve-devel] [PATCH manager v2] fix #1115 reload storage grid after template download

2016-09-26 Thread Emmanuel Kasper
Refresh the grid after the template has been downloaded, instead of refreshing after the template has been selected. this fix a the problem that a newly Turnkey / PVE downloaded template would not be shown in the storage content grid after closing the task window --- change since V1: * rename rel

[pve-devel] [PATCH manager] Minor refactor for #1115 (reload grid after template download)

2016-09-28 Thread Emmanuel Kasper
Move the listener to the new window declaration to make it clear this listener is not bound to the current component --- www/manager6/storage/ContentView.js | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/

Re: [pve-devel] [RFC manager] When adding a new hard disk, use the most used controller as suggested value

2016-09-28 Thread Emmanuel Kasper
On 09/22/2016 02:09 PM, Dietmar Maurer wrote: > I would not change the order when displaying the list. Just select > the default ... > the clist we sort here is actually only used for setting the value of the comboBox, we call setValue() on the first element of the list further down

Re: [pve-devel] [PATCH docs 3/3] add section about two factor authentication

2016-10-03 Thread Emmanuel Kasper
On 10/03/2016 10:44 AM, Wolfgang Bumiller wrote: > --- > Not sure if it makes sense to mention the apps here, but they do work > out of the box and are fairly wide spread, which shows users that > we're using standard methods and don't require custom tools. IMHO this makes sense as we save pve use

[pve-devel] [PATCH docs v2 1/3] Move getting help section from system administration to introduction

2016-10-03 Thread Emmanuel Kasper
--- pve-intro.adoc | 2 ++ sysadmin.adoc | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pve-intro.adoc b/pve-intro.adoc index 15212c5..56d8dd3 100644 --- a/pve-intro.adoc +++ b/pve-intro.adoc @@ -195,6 +195,8 @@ Your benefit with {pve} * Huge active community * Low admin

[pve-devel] Explain how to improve the reference documentation (V2)

2016-10-03 Thread Emmanuel Kasper
changes since v1: * move content after help section to avoid duplicating the list of support channels * don't explain what we doc with the adoc files, refer to README.adoc * also mention the Developer Setup wiki article for people wanting to work the codebase

[pve-devel] [PATCH docs v2 3/3] Improve wording of getting help section for commercial support

2016-10-03 Thread Emmanuel Kasper
* list some advantages of the standard support * put a single link to improve call-to-action --- getting-help.adoc | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 0bb28a7..180a212 100644 --- a/getting-help.adoc +++ b/getti

[pve-devel] [PATCH docs v2 2/3] Add sub chapter on how to improve the reference documentation

2016-10-03 Thread Emmanuel Kasper
--- pve-intro.adoc | 33 + 1 file changed, 33 insertions(+) diff --git a/pve-intro.adoc b/pve-intro.adoc index 56d8dd3..0431e09 100644 --- a/pve-intro.adoc +++ b/pve-intro.adoc @@ -240,3 +240,36 @@ The most notable change with version 4.0 was the move from OpenVZ

[pve-devel] [PATCH docs] Add warning about using qcow2 images on a ZFS filesystem

2016-10-05 Thread Emmanuel Kasper
--- local-zfs.adoc | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index 9b682b9..1b9f682 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -254,6 +254,22 @@ can be used as cache. zpool replace -f +Using a directory s

[pve-devel] [PATCH docs] Update the list of supported web browsers

2016-10-05 Thread Emmanuel Kasper
Also move the list of supported browsers from Installing Proxmox VE to the System Requirements chapter --- pve-installation.adoc| 3 +-- pve-system-requirements.adoc | 15 +++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/pve-installation.adoc b/pve-installat

[pve-devel] [PATCH manager v2 1/2] Add global regexp to match bus entry in a VM config

2016-10-05 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 2 ++ www/manager6/qemu/BootOrderEdit.js | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3c15135..3bf5188 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -63,6 +63,

[pve-devel] [PATCH manager v2 2/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-05 Thread Emmanuel Kasper
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and persona

[pve-devel] [PATCH manager v2 0/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-05 Thread Emmanuel Kasper
* create a regexp object to match all bus properties entry and use this regexp in ControllerSelector and BootSelector * rename 'value' property to 'count' to fix jslint type mismatch warning Emmanuel Kasper (2): Add global regexp to match bus entry in a VM config When ad

[pve-devel] [PATCH manager v3 0/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-06 Thread Emmanuel Kasper
Changes since v2: * create regexp in the PVE.Utils namespace. Previous version used the global namespace because all regexps were defined there. Emmanuel Kasper (2): Add regexp to match a bus entry in a VM config When adding a new hard disk, use the most used controller as suggested

[pve-devel] [PATCH manager v3 2/2] When adding a new hard disk, use the most used controller as suggested value

2016-10-06 Thread Emmanuel Kasper
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and persona

[pve-devel] [PATCH manager v3 1/2] Add regexp to match a bus entry in a VM config

2016-10-06 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 2 ++ www/manager6/qemu/BootOrderEdit.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3c15135..060643a 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -103,6 +103

[pve-devel] [PATCH manager] make Win XP and Win 2003 use the same defaults as Win 2000

2016-10-10 Thread Emmanuel Kasper
(this means: rtl8139 as nic and lsi as hardware controller) XP & 2003 ISO E1000 drivers are missing or do not work with Qemu (source: https://pve.proxmox.com/wiki/Windows_2003_guest_best_practices) (source: https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes) The lsi SCSI controller was the defau

[pve-devel] [PATCH manager 1/2] Move bus priority list to OSDefaults

2016-10-10 Thread Emmanuel Kasper
So a field container does not need to know if Linux likes SCSI. --- www/manager6/form/ControllerSelector.js | 8 www/manager6/qemu/OSDefaults.js | 12 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manag

[pve-devel] [PATCH manager 2/2] Fix jslint warning: 'sortedList' is already defined

2016-10-10 Thread Emmanuel Kasper
sortedList was defined twice in the function remove the declaration at the beginning of function as declaring a var just before using it is more similar to the rest of code --- www/manager6/form/ControllerSelector.js | 1 - 1 file changed, 1 deletion(-) diff --git a/www/manager6/form/ControllerSe

[pve-devel] [PATCH manager 1/3] Turn PVE.Utils into a singleton object

2016-10-12 Thread Emmanuel Kasper
This will allow us to add contructed values ( regexp a = stringA + stringB ) into the constructor. Access to the PVE.Utils properties and methods stays the same. The double curly brace at the end is due to a double opening curly brace when doing the declaration with Ext.define Not sure if reinden

[pve-devel] [PATCH manager 2/3] Move globally defined regexpes into PVE.Utils

2016-10-12 Thread Emmanuel Kasper
Those globally defined regexpes were only used in Toolkit.js --- www/manager6/Toolkit.js | 20 +++--- www/manager6/Utils.js | 70 - 2 files changed, 44 insertions(+), 46 deletions(-) diff --git a/www/manager6/Toolkit.js b/www/manager6/Tool

[pve-devel] [PATCH manager 3/3] Fix jslint warning about trailing comma

2016-10-12 Thread Emmanuel Kasper
--- www/manager6/qemu/OSDefaults.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index f2fc8f4..09190e0 100644 --- a/www/manager6/qemu/OSDefaults.js +++ b/www/manager6/qemu/OSDefaults.js @@ -71,7 +71,7 @@ Ext.

[pve-devel] [PATCH docs] Add subchapter documenting the startup/shutdown options

2016-10-13 Thread Emmanuel Kasper
based on http://pve.proxmox.com/wiki/Virtual_Machine_Startup_and_Shutdown_Behavior --- NB: a related patch for Containers will follow. qm.adoc | 33 + 1 file changed, 33 insertions(+) diff --git a/qm.adoc b/qm.adoc index a30e7dc..a0b6950 100644 --- a/qm.adoc +++ b

[pve-devel] [PATCH qemu-server] Fix typo

2016-10-13 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 21fbebb..ad7a0c0 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1732,7 +1732,7 @@ __PACKAGE__->register_method({ optional => 1,

[pve-devel] [PATCH docs] Update the qm command line example to use the new volume format

2016-10-13 Thread Emmanuel Kasper
Also since the command line is now longer, move the NIC creation to a separate command. --- qm.adoc | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index a0b6950..3624e2f 100644 --- a/qm.adoc +++ b/qm.adoc @@ -476,9 +476,16 @@ create and delete vir

[pve-devel] [PATCH qemu-server] Document shutdown behaviour when qemu-guest-agent is running

2016-10-17 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ad7a0c0..f64a77c 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1858,8 +1858,10 @@ __PACKAGE__->register_method({ method => 'POST', protected

[pve-devel] [PATCH docs] Add a note referencing the qm man page for the shutdown internals

2016-10-17 Thread Emmanuel Kasper
--- Not 100% sure if these shutdown explaination belong to asciidoc or to the generated manu. qm.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qm.adoc b/qm.adoc index 3624e2f..5d711f7 100644 --- a/qm.adoc +++ b/qm.adoc @@ -464,6 +464,9 @@ start after those where the parameter is set

Re: [pve-devel] [PATCH qemu-server] Document shutdown behaviour when qemu-guest-agent is running

2016-10-17 Thread Emmanuel Kasper
On 10/17/2016 11:05 AM, Fabian Grünbichler wrote: > On Mon, Oct 17, 2016 at 10:52:26AM +0200, Emmanuel Kasper wrote: >> --- >> PVE/API2/Qemu.pm | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm

Re: [pve-devel] [PATCH docs] Add subchapter documenting the startup/shutdown options

2016-10-18 Thread Emmanuel Kasper
On 10/18/2016 09:29 AM, Dietmar Maurer wrote: > applied. But we have the same feature for containers? Yes. A patch will follow for containers. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 0/2] Remove global variables from Utils.js

2016-10-18 Thread Emmanuel Kasper
Changes since V1: * rebase * drop trailing coma fox in OsDefaults, as it was fixed in between Emmanuel Kasper (2): Turn PVE.Utils into a singleton Move globally defined regexpes into PVE.Utils www/manager6/Toolkit.js | 20 ++-- www/manager6/Utils.js | 82

[pve-devel] [PATCH manager v2 1/2] Turn PVE.Utils into a singleton

2016-10-18 Thread Emmanuel Kasper
This will allow us to add contructed values ( regexp a = stringA + stringB ) into the constructor. Access to the PVE.Utils properties and methods stays the same. --- www/manager6/Utils.js | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js b/www/m

[pve-devel] [PATCH manager v2 2/2] Move globally defined regexpes into PVE.Utils

2016-10-18 Thread Emmanuel Kasper
Those globally defined regexpes were only used in Toolkit.js --- www/manager6/Toolkit.js | 20 +++--- www/manager6/Utils.js | 70 - 2 files changed, 44 insertions(+), 46 deletions(-) diff --git a/www/manager6/Toolkit.js b/www/manager6/Tool

Re: [pve-devel] pve-kernel

2016-10-19 Thread Emmanuel Kasper
On 10/19/2016 12:18 PM, Michael Rasmussen wrote: > On Wed, 19 Oct 2016 06:13:28 +0200 (CEST) > Dietmar Maurer wrote: > >> >> Something else changed? >> > Forgot to mention: I backported on my pve-develop machine so strictly > speaking it is not a valid backport since jessie natively runs kernel >

[pve-devel] [PATCH manager 0/4] Usability improvements for the HA edit resources windows

2016-10-19 Thread Emmanuel Kasper
A patch for pve-docs for the onlineHelp reference is on the way. Emmanuel Kasper (4): Move out custom css style for hints in css class and use it Close #1161: add hint when disabling a ha resource Use enable as adjective to match the Resource List panel Add onlineHelp www/css/ext6

[pve-devel] [PATCH manager 3/4] Use enable as adjective to match the Resource List panel

2016-10-19 Thread Emmanuel Kasper
Since we describe a resource state, an adjective is also here a better match. --- www/manager6/ha/ResourceEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js index 46857dc..e220154 100644 --- a/www/manager6/h

[pve-devel] [PATCH manager 4/4] Add onlineHelp

2016-10-19 Thread Emmanuel Kasper
--- www/manager6/ha/ResourceEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js index e220154..fcf62ec 100644 --- a/www/manager6/ha/ResourceEdit.js +++ b/www/manager6/ha/ResourceEdit.js @@ -1,6 +1,6 @@ Ext.d

[pve-devel] [PATCH manager 2/4] Close #1161: add hint when disabling a ha resource

2016-10-19 Thread Emmanuel Kasper
Disabling a HA resource/service means that this ressource will always be turned off. However some users though this disabling HA management for this VM, see http://pve.proxmox.com/pipermail/pve-user/2016-October/011024.html so we had a hint after clicking on the 'disable' checkbox, that the checkb

[pve-devel] [PATCH manager 1/4] Move out custom css style for hints in css class and use it

2016-10-19 Thread Emmanuel Kasper
--- www/css/ext6-pve.css | 4 www/manager6/qemu/QemuBiosEdit.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index e72355b..c050aca 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -376,6 +376,10

[pve-devel] [PATCH docs] Add reference for onlineHelp for HA resource management

2016-10-19 Thread Emmanuel Kasper
--- ha-manager.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/ha-manager.adoc b/ha-manager.adoc index 582dfcc..d49a8c6 100644 --- a/ha-manager.adoc +++ b/ha-manager.adoc @@ -484,6 +484,7 @@ killing its process) * *after* you fixed all errors you may enable the service again +[[ha_ma

[pve-devel] [PATCH qemu-server] Close #351: add more info to backup log

2016-10-20 Thread Emmanuel Kasper
Before patch: INFO: exclude disk 'scsi1' (backup=no) INFO: skip unused drive 'local:401/vm-401-disk-3.raw' (not included into backup) INFO: skip unused drive 'local:401/vm-401-disk-1.raw' (not included into backup) After patch applied: INFO: include disk 'scsi0' local:401/vm-401-disk-4.qcow2 INFO:

[pve-devel] [PATCH manager] Fix #1144: set a default disk format for VM disk widgets

2016-10-25 Thread Emmanuel Kasper
Up to now Qemu Wizard, Clone, and Hard Disk Move components had a different idea of what should be the proposed format of a disk image. Make all them auto select qcow2. --- Not especially proud of using variable called "PVE.qemu.OSDefaults.generic.diskFormat" (39 characters) but can't find a bett

Re: [pve-devel] [PATCH manager] Fix #1144: set a default disk format for VM disk widgets

2016-10-25 Thread Emmanuel Kasper
On 10/25/2016 05:50 PM, Michael Rasmussen wrote: > On Tue, 25 Oct 2016 17:42:41 +0200 > Emmanuel Kasper wrote: > >> Up to now Qemu Wizard, Clone, and Hard Disk Move components had >> a different idea of what should be the proposed format >> of a disk image. >>

[pve-devel] [PATCH manager] Fix #1186: do not run non installed commands

2016-10-28 Thread Emmanuel Kasper
Conditionnally add commands which are not: * Debian packages whith priority Essential or Important, * a dependency of pve-manager --- PVE/Report.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 89714b8..0d0eaa8 100644 --- a/

[pve-devel] Disabling os-prober when installing on top of debian ?

2016-11-14 Thread Emmanuel Kasper
Hi The debian grub package has a dependency on os-prober which is known to corrupt the file systems of virtual machines. Basically os-prober tries to mount each block device available on the host, looking for other installed OS to create dualboot entries for grub. This does not play very well whe

Re: [pve-devel] Disabling os-prober when installing on top of debian ?

2016-11-15 Thread Emmanuel Kasper
On 11/15/2016 08:24 AM, Fabian Grünbichler wrote: > On Mon, Nov 14, 2016 at 04:21:23PM +0100, Emmanuel Kasper wrote: >> Now I was wondering, should we add a dependency to our grub package in >> pve-manager ? We could also add a big red note in the installation >> documentation

[pve-devel] [PATCH docs] Explain start up and shutdown behaviour for containers

2016-11-17 Thread Emmanuel Kasper
Mostly imported from Wiki --- pct.adoc | 31 +++ 1 file changed, 31 insertions(+) diff --git a/pct.adoc b/pct.adoc index 67abec1..1c27878 100644 --- a/pct.adoc +++ b/pct.adoc @@ -574,6 +574,37 @@ individually * Redistribute backed up files according to new mount point

[pve-devel] [PATCH docs] typo: s/salable/scalable/

2016-11-17 Thread Emmanuel Kasper
--- pve-storage-glusterfs.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-storage-glusterfs.adoc b/pve-storage-glusterfs.adoc index f12884a..af4b857 100644 --- a/pve-storage-glusterfs.adoc +++ b/pve-storage-glusterfs.adoc @@ -7,7 +7,7 @@ endif::wiki[] Storage pool t

[pve-devel] [PATCH manager] Add Windows 2016 as OsType

2016-11-17 Thread Emmanuel Kasper
? Less options to choose -> faster choice -> better use experience Emmanuel Kasper (1): Add Windows 2016 as available ostype to select www/manager6/Utils.js | 3 ++- www/manager6/qemu/OSTypeEdit.js | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) --

[pve-devel] [PATCH qemu-server] Add entry for windows 10 and 2016 support

2016-11-17 Thread Emmanuel Kasper
All special flags for Windows 8 and Windows 2012 (win8 type) are kept the same , since we set flags based on checking if /^win(\d+)$/ is greater than 6 or 7 --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index d228

[pve-devel] [PATCH manager] Add Windows 2016 as available ostype to select

2016-11-17 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 3 ++- www/manager6/qemu/OSTypeEdit.js | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index c824b97..8d5a598 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -63,7 +63,8 @

Re: [pve-devel] [PATCH manager] Add Windows 2016 as OsType

2016-11-28 Thread Emmanuel Kasper
Any comments on this ? On 11/17/2016 03:03 PM, Emmanuel Kasper wrote: > The following add Win2016 as an OS to choose in > the wizard, grouping it with Windows10. > > Qemu flags for Windows 10 and 2016 are the same > as Windows8, this separate type is mainly > for ease of use

[pve-devel] [RFC qemu-server] If a VM is offline, catch the netcat timeout with a user friendly message

2016-11-30 Thread Emmanuel Kasper
This error message replaces the error: TASK ERROR: command '/bin/nc6 -l -p 5900 -w 10 -e '/usr/bin/ssh -T -o BatchMode=yes 192.168.16.75 /usr/sbin/qm vncproxy 401 2>/dev/null'' failed: exit code 1 as seen in the task list. It is not currently possible to test if a VM is running or not for the wh

[pve-devel] [PATCH docs] Add General Settings sub chapter

2016-11-30 Thread Emmanuel Kasper
We will use this to document the first tab of the Create CT wizard. Also move the priviledged/unpriviledge explanation here, since the related checkbox will be placed in this tab. --- pct.adoc | 70 1 file changed, 44 insertions(+),

[pve-devel] [PATCH manager] Add the possibility to create an unprivileged container at creation time in the GUI.

2016-11-30 Thread Emmanuel Kasper
The setting is afterwards displayed as a read only option in the option time --- www/manager6/lxc/CreateWizard.js | 6 ++ www/manager6/lxc/Options.js | 7 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizar

[pve-devel] [PATCH manager] fix trailing coma for jslint

2016-11-30 Thread Emmanuel Kasper
--- www/manager6/lxc/CreateWizard.js | 2 +- www/manager6/lxc/Options.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index 7c4a722..bd6090d 100644 --- a/www/manager6/lxc/CreateWizard.js +++ b/www/

[pve-devel] [PATCH manager] Add online help for startup/shutdown order and LXC general settings

2016-12-01 Thread Emmanuel Kasper
--- www/manager6/lxc/CreateWizard.js | 1 + www/manager6/qemu/StartupEdit.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index bd6090d..df2b633 100644 --- a/www/manager6/lxc/CreateWizard.js +++ b/www/manager6/lxc/CreateW

[pve-devel] [PATCH docs] Add a chapter explaining how online help is added to the GUI

2016-12-01 Thread Emmanuel Kasper
--- README.adoc | 24 1 file changed, 24 insertions(+) diff --git a/README.adoc b/README.adoc index 5e1c36c..18afecc 100644 --- a/README.adoc +++ b/README.adoc @@ -239,6 +239,30 @@ text: For example, block headers can be used to add file names/paths to file content list

[pve-devel] [PATCH manager 2/3] Pass a panelOnlineHelp to get a help button for LXC Start/Shutdown options

2016-12-01 Thread Emmanuel Kasper
--- www/manager6/lxc/Options.js | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index 2df93a9..7670342 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -42,8 +42,10 @@ Ext.define('PVE.l

[pve-devel] [PATCH manager 3/3] Remove last extra comma

2016-12-01 Thread Emmanuel Kasper
also whitespace / indent cleanup --- www/manager6/lxc/Options.js | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index 7670342..9edcb05 100644 --- a/www/manager6/lxc/Options.js +++ b/

[pve-devel] [PATCH manager 1/3] Add optional parameter panelOnlineHelp

2016-12-01 Thread Emmanuel Kasper
this widget and its containing InputPanel can be used by both QEMU/LXC so we need to be able to pass the onlineHelp as the instantiation step --- www/manager6/qemu/StartupEdit.js | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/StartupEdit.js b/www/manage

[pve-devel] [PATCH pve-container] Do not skip unprivileged config parameter when restoring a container

2016-12-01 Thread Emmanuel Kasper
This allows to keep the parameter when restoring from a backup. --- src/PVE/LXC/Create.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 1f1ece1..11bc00d 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -114,

[pve-devel] [PATCH manager v2 0/3] Refactor StartupEdit as generic component

2016-12-05 Thread Emmanuel Kasper
changes since V1: * creates a generic StartupEdit component instead of using the qemu widget with LXC * rename parameter panelOnlineHelp to onlineHelp because the previous naming scheme was unclear Emmanuel Kasper (3): Turn the qemu StartupEdit widget into a generic component Add online help

[pve-devel] [PATCH manager v2 3/3] fix jslint confusion warning

2016-12-05 Thread Emmanuel Kasper
ExtJS components accept for the items property either a single component or an array of components which generates a jslint type confusion warning. --- www/manager6/window/StartupEdit.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/www/manager6/window/StartupEdit.js b/www

[pve-devel] [PATCH manager v2 1/3] Turn the qemu StartupEdit widget into a generic component

2016-12-05 Thread Emmanuel Kasper
and use this component for Qemu. --- www/manager6/Makefile | 2 +- www/manager6/qemu/Options.js | 5 ++- www/manager6/qemu/StartupEdit.js | 85 - www/manager6/window/StartupEdit.js | 87 ++ 4 files chang

[pve-devel] [PATCH manager v2 2/3] Add online help for start/shutdown for containers

2016-12-05 Thread Emmanuel Kasper
--- www/manager6/lxc/Options.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index a77c194..1c39b4b 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -43,7 +43,10 @@ Ext.define('PVE.lxc

[pve-devel] [PATCH manager 1/2] Convert the VMIDSelector to a generic GuestIDSelector

2016-12-13 Thread Emmanuel Kasper
This allows to display a 'CT', a 'VM', or a 'CT/VM' label to be displayed, depending on the context. Currently when restoring a CT backup or creating a CT via the wizard, we are asked to enter a *VM* ID, which is confusing. --- www/manager6/Makefile| 2 +- www/manager6/form/Gues

[pve-devel] [PATCH manager 2/2] reduce scope of jslint warnings to the problematic statement

2016-12-13 Thread Emmanuel Kasper
also remove it from qemu/Clone.js since it validates OK --- www/manager6/lxc/CreateWizard.js | 8 +++- www/manager6/qemu/Clone.js| 1 - www/manager6/qemu/CreateWizard.js | 5 +++-- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/m

[pve-devel] [PATCH qemu-server] Display volumes options in log when doing a volume backup

2016-12-13 Thread Emmanuel Kasper
Output before this patch INFO: include disk 'scsi0' 'file=pve4tank:vm-402-disk-1' Output after this patch: INFO: include disk 'scsi0' 'file=pve4tank:vm-402-disk-1,cache=writethrough,discard=on,size=64G' we're mainly intersted by the volume size here, it was requested in #351 --- PVE/VZDump/Qemu

[pve-devel] [PATCH manager 2/2] Rename filterFn to vmtypeFilter

2016-12-15 Thread Emmanuel Kasper
since we have now two filters defined it makes sense to use a separate name here --- www/manager6/grid/BackupView.js | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js index 1de5323..a924c0a 100644 ---

[pve-devel] [PATCH manager 1/2] Filter by default the displayed guest backups fix #1161

2016-12-15 Thread Emmanuel Kasper
This add a default filter which is executed on store initial load, so we display only the backups matching our ID. --- www/manager6/grid/BackupView.js | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/Ba

[pve-devel] [PATCH manager 2/4] Use the AfterAPICall to reload ourself after adding an OSD

2016-12-20 Thread Emmanuel Kasper
pass the reload function with its context as a parameter (a closure) --- www/manager6/ceph/OSD.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 3e1935a..a9b6fdb 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager

[pve-devel] [PATCH qemu-server v2] Display volume size in log when doing a volume backup

2016-12-20 Thread Emmanuel Kasper
Output before this patch INFO: include disk 'scsi0' 'file=pve4tank:vm-402-disk-1' Output after this patch: INFO: include disk 'scsi0' 'file=pve4tank:vm-402-disk-1' 64G we're mainly intersted by the volume size here, it was requested in #351 --- changes since V1: * only display the volume size if

[pve-devel] [PATCH manager 0/4] Reload properly Ceph OSD grid after OSD operations

2016-12-20 Thread Emmanuel Kasper
Currently you need to reload manually the OSD list after adding/removing OSDs. This patch serie allows the GUI to do that automatically. ccing Dominik for review Emmanuel Kasper (4): Add a new property afterAPICall to Edit Window Use the AfterAPICall to reload ourself after adding an OSD

[pve-devel] [RFC PATCH manager 4/4] Replace nested ternary operators with if/else statements

2016-12-20 Thread Emmanuel Kasper
--- www/manager6/window/Edit.js | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Edit.js b/www/manager6/window/Edit.js index c29b97b..f990865 100644 --- a/www/manager6/window/Edit.js +++ b/www/manager6/window/Edit.js @@ -201,8 +201,24 @@ Ex

[pve-devel] [PATCH manager 3/4] Fix reload of grid when removing an OSD

2016-12-20 Thread Emmanuel Kasper
The grid reload was happening too early because it should happen after the Task associated to the Window has been executed. --- www/manager6/ceph/OSD.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index a9b6fdb..05abc2

[pve-devel] [PATCH manager 1/4] Add a new property afterAPICall to Edit Window

2016-12-20 Thread Emmanuel Kasper
The main aim of this new parameter is to allow a refresh of a GridPanel *after* the task window has been closed, and not after Edit Window is closed which is often two early. --- www/manager6/window/Edit.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/window/Edit.js b/ww

[pve-devel] [PATCH manager] Fix a race conditon provoking the error no such file '/pve-storage-content'

2016-12-21 Thread Emmanuel Kasper
(NB: the error was only displayed intermittently in the browser console) The reload call could try a store reload before the store has a defined url. The call here is useless since the initial display of the storage selector compoment will call setStorage() to pass an url to the store and load it.

[pve-devel] [PATCH RFC manager v2 4/4] Replace nested ternary operators with if/else statements

2016-12-22 Thread Emmanuel Kasper
--- www/manager6/window/Edit.js | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Edit.js b/www/manager6/window/Edit.js index 36ef7b6..def5519 100644 --- a/www/manager6/window/Edit.js +++ b/www/manager6/window/Edit.js @@ -201,8 +201,21 @@ Ext.d

[pve-devel] [PATCH manager v2 2/4] Use afterTaskProgress to reload ourself after adding an OSD

2016-12-22 Thread Emmanuel Kasper
pass the reload function with its context as a parameter (a closure) --- www/manager6/ceph/OSD.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 3e1935a..23626f9 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager

[pve-devel] [PATCH manager v2 3/4] Fix reload of grid when removing an OSD

2016-12-22 Thread Emmanuel Kasper
The grid reload was happening too early because it should happen after the Task associated to the Window has been executed. --- www/manager6/ceph/OSD.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 23626f9..0c6f20

[pve-devel] [PATCH manager v2 1/4] Add a new property afterTaskProgress to Edit Window

2016-12-22 Thread Emmanuel Kasper
The main aim of this new parameter is to allow a refresh of a GridPanel *after* the task window has been closed, and not after Edit Window is closed which is often two early. --- www/manager6/window/Edit.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/window/Edit.js b/ww

[pve-devel] [PATCH manager v2 0/4] Add a new parameter afterTaskProgress to pveWindowEdit

2016-12-22 Thread Emmanuel Kasper
operators rewrite after feedback from d.csapak@ Emmanuel Kasper (4): Add a new property afterTaskProgress to Edit Window Use afterTaskProgress to reload ourself after adding an OSD Fix reload of grid when removing an OSD Replace nested ternary operators with if/else statements www/manager6

[pve-devel] [PATCH manager] HA: Add a warning/info message for HA setups < 3 votes fix: #1228

2016-12-29 Thread Emmanuel Kasper
--- www/manager6/ha/ResourceEdit.js | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js index 4dc7474..06dda10 100644 --- a/www/manager6/ha/ResourceEdit.js +++ b/www/manager6/ha/

[pve-devel] [PATCH manager] Reload the BackupView after the BackupTask has been closed

2017-01-02 Thread Emmanuel Kasper
The reload() function of the Backup View is passed with its context to the Backup Window, which passes it further to a listener in the Backup Task. --- www/manager6/grid/BackupView.js | 3 ++- www/manager6/window/Backup.js | 11 +++ 2 files changed, 9 insertions(+), 5 deletions(-) diff

[pve-devel] [PATCH manager v3 0/2] Fix reloading of Ceph Grid when adding/removing OSDs

2017-01-03 Thread Emmanuel Kasper
change since v3: * instead of passing the reload function to the TaskWindow, hide the action window and really close it when the background task has completed. Emmanuel Kasper (2): Hide the Edit window when we start a background task Reload the Ceph OSDTree afer adding an OSD www

[pve-devel] [PATCH manager v3 1/2] Hide the Edit window when we start a background task

2017-01-03 Thread Emmanuel Kasper
We closed the Edit window too early, so listeners set to the 'close' event would reload the underlying grid before the action successfully completed on the server side. --- www/manager6/window/Edit.js | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/www/man

[pve-devel] [PATCH manager v3 2/2] Reload the Ceph OSDTree afer adding an OSD

2017-01-03 Thread Emmanuel Kasper
--- www/manager6/ceph/OSD.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 3e1935a..af96741 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -373,6 +373,7 @@ Ext.define('PVE.node.CephOsdTree', {

[pve-devel] [PATCH docs 1/2] Improve cluster note deletion operation

2017-01-04 Thread Emmanuel Kasper
* do not add `pvecm status` when we talk about `pvecm nodes` * do not say twice to login to a cluster member node for the same command set * move the big danger warning in the middle of operations, so it might not be skipped --- pvecm.adoc | 59 +++--

[pve-devel] [PATCH docs 2/2] Document the difference between Virtio SCSI and Virtio SCSI single

2017-01-04 Thread Emmanuel Kasper
Also make sure we use the same case in the GuI: VirtIO, and explain why IO Thread requires a specific controller option. --- qm.adoc | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/qm.adoc b/qm.adoc index 85b939a..ec57f01 100644 --- a/qm.adoc +++ b/qm.adoc

[pve-devel] [PATCH docs v2] Document the difference between Virtio SCSI and Virtio SCSI single

2017-01-04 Thread Emmanuel Kasper
Also make sure we use the same case in the GuI: VirtIO, and explain why IO Thread requires a specific controller option. --- changes since v1: use underscores for italics, not hyphens do not add a paragraph break inside a list qm.adoc | 18 -- 1 file changed, 12 insertions(+), 6

[pve-devel] [PATCH manager v2] Reload the grid list of backups after the backup task completion

2017-01-05 Thread Emmanuel Kasper
This allows visual feedback for first time users doing a backup. --- change the way we reload by hiding the backup window instead of passing aroung the reload() function www/manager6/grid/BackupView.js | 7 ++- www/manager6/window/Backup.js | 12 ++-- 2 files changed, 16 insertions

[pve-devel] [PATCH manager] Update French translation

2017-01-11 Thread Emmanuel Kasper
+++ b/po/fr.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Wed Jan 11 10:58:53 2017\n" -"PO-Revision-Date: 2016-04-07 13:14+0100\n" +"PO-Revision-Date: 2017-01-11 16:17+01

[pve-devel] [PATCH manager v2] Update French translation

2017-01-12 Thread Emmanuel Kasper
uot;PO-Revision-Date: 2016-04-07 13:14+0100\n" +"PO-Revision-Date: 2017-01-12 09:40+0100\n" "Last-Translator: Emmanuel Kasper \n" "Language-Team: French\n" "Language: fr\n" @@ -30,7 +30,7 @@ msgstr "/chemin/repertoire/" #: ../www/manager6/lxc/R

[pve-devel] [PATCH manager 8/9] Use qcow2 as default disk format for clones fix: #1144

2017-01-12 Thread Emmanuel Kasper
When using a file based storage, qcow2 has more features as raw, this is why we recommend it for clones, similarly to when adding new disk images. --- www/manager6/qemu/Clone.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index af088b

[pve-devel] [PATCH manager 3/9] Disable the submit button based on whole form validity

2017-01-12 Thread Emmanuel Kasper
Until now we disabled the submit button, based on the feature API call where we tested if the selected VM, and its snapshot can be used as the source of a clone. This had the following problems: * the feature test for copy clone / linked clone always returned true, since the passed paramaters we

<    1   2   3   4   5   6   7   8   9   10   >