[pve-devel] [PATCH 1/2] Add documentation header

2015-07-22 Thread Emmanuel Kasper
--- www/manager5/data/ObjectStore.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager5/data/ObjectStore.js b/www/manager5/data/ObjectStore.js index 03d0c7a..935f922 100644 --- a/www/manager5/data/ObjectStore.js +++ b/www/manager5/data/ObjectStore.js @@ -1,3 +1,8 @@ +/* This sto

[pve-devel] Fix Display of Datacenter options

2015-07-22 Thread Emmanuel Kasper
Hello ! This patch serie fixes the display of options in the Datacenter config panel. Emmanuel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 2/2] ext5migrate: replace call to private ExtJS function getRoot()

2015-07-22 Thread Emmanuel Kasper
getRoot() semantics changed with ExtJS5. To avoid further annoyances when ExtJS6 is around the corner, replace the call to this private method, set rootProperty in the ObjectStore call, and use the value of rootProperty to filter out the content of the server answer. --- www/manager5/data/ObjectS

[pve-devel] Improving the consistency of color schemes in PVE GUI

2015-07-28 Thread Emmanuel Kasper
Hello For the current 4.0 we have three different color codes to indicate that a KVM / LXC / physical node is nonrunning vs running: -- CURRENT STATUS Non running / Running LXCGrey / Red Clu

[pve-devel] [PATCH] remove debugging traces

2015-07-28 Thread Emmanuel Kasper
--- www/manager/dc/Summary.js | 3 --- www/manager5/dc/Summary.js | 3 --- 2 files changed, 6 deletions(-) diff --git a/www/manager/dc/Summary.js b/www/manager/dc/Summary.js index 9a210a3..b0f8b32 100644 --- a/www/manager/dc/Summary.js +++ b/www/manager/dc/Summary.js @@ -81,9 +81,6 @@ Ext.define

[pve-devel] Regression with latest qemu and iothreads option ?

2015-07-28 Thread Emmanuel Kasper
Hi I am using kvm --version QEMU emulator version 2.3.92 I have noticed if you select the iothread option in the disk options of your KVM, KVM hangs in a very nasty way: the kvm processes starts, the qm manager reports the machine as running but actually it is not: it is not possible to attach a

[pve-devel] [PATCH] Move subscription tab to the outmost right of the node tab panel

2015-07-29 Thread Emmanuel Kasper
This brings consistency with the datacenter tab panel. --- www/manager/node/Config.js | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/www/manager/node/Config.js b/www/manager/node/Config.js index ff6d225..61bb4b2 100644 --- a/www/manager/node/Config.js +++ b/

[pve-devel] [PATCH] ext5migrate: set buttons property directly instead of calling applyIf

2015-07-29 Thread Emmanuel Kasper
It seems that in ExtJS5 the prototype of the Window component already sets some default values to me.buttons and me.layout, hence calling applyIf on these properties will silently fail. me.layout is already set to 'auto' by the framework, we don't need to set that anymore. --- www/manager5/window

[pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Emmanuel Kasper
It seems according to http://pve.proxmox.com/pipermail/pve-user/2015-July/008954.html some users get confused about this field. --- www/manager/lxc/CreateWizard.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager/lxc/CreateWizard.js b/www/manager/lxc/CreateWizar

Re: [pve-devel] Regression with latest qemu and iothreads option ?

2015-08-03 Thread Emmanuel Kasper
Hi On 07/30/2015 09:03 AM, Alexandre DERUMIER wrote: > This is fixed in qemu 2.4rc3 > I confirm can our pve-qemu-kvm package in version 2.4-1 has this fixed. Thanks for the update ! Emmanuel ___ pve-devel mailing list pve-devel@pve.proxmox.com htt

[pve-devel] [PATCH] ext5migrate: handle the case when a component's data is in the config object

2015-08-03 Thread Emmanuel Kasper
In ExtJS5 when we use the following call (taken from OptionView.js) Ext.applyIf(me, { items: { xtype: 'pveKVComboBox', data: data, } }); the data property is not available via me.data, but via me.config.data. So we need to h

[pve-devel] (no subject)

2015-08-03 Thread Emmanuel Kasper
So I tried to enhance this patch based on the mailing list suggestions. It might be a small thing, but if 1 user asks publicly for the signification of this field, probably there are 10 others behind who don't dare to ask ... ___ pve-devel mailing lis

[pve-devel] [PATCH v2] Usability: enhance password label in LXC wizzard

2015-08-03 Thread Emmanuel Kasper
Do not hardcode the name of the admin user, instead move it to a stub function which we can enhance when our templates provide the necessary meta information. --- www/manager/lxc/CreateWizard.js | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager/lxc/CreateWizar

Re: [pve-devel] [PATCH] ext5migrate: handle the case when a component's data is in the config object

2015-08-03 Thread Emmanuel Kasper
On 08/03/2015 04:22 PM, Dietmar Maurer wrote: >> the data property is not available via me.data, but via me.config.data. >> So we need to handle this in the parent class. > > So why do we need both cases? > > + data : me.data || me.config.data > > Isn't it enough to do: > > +

[pve-devel] References to the Java Applet console

2015-08-04 Thread Emmanuel Kasper
Hi I see we still have references to the java applet in Utils.js and VNConsole.js Should we keep them or do we want to remove them ? Emmanuel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] updated PVE 4.0 packages on pvetest

2015-08-04 Thread Emmanuel Kasper
On 08/04/2015 04:35 PM, Alexandre DERUMIER wrote: >>> Maybe qemu-2.4 has introduced something which makes it incompatible with >>> previous versions of qemu? > > Yes, maybe. > > do you have tried qemu 2.4 on top of 2.4 ? > I tried nested KVM virtualization with qemu 2.4, and "it works here"

[pve-devel] [PATCH] ext5migrate: pass configuration to KVCombBox via config object

2015-08-05 Thread Emmanuel Kasper
Since ExtJS5, when doing such a declaration, Ext.applyIf(me, { items: { xtype: 'pveKVComboBox', comboItems: data, } }); the comboItems property is passed in the parent class as a config object, instead of being directly avail

[pve-devel] Fix PVE Combobox to work with ExtJS5

2015-08-18 Thread Emmanuel Kasper
Hi This patch serie allows our Key-Value Combobox to work with ExtJS5. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 2/3] ext5migrate: do not set a custome idProperty for the KeyValue model

2015-08-18 Thread Emmanuel Kasper
ExtJS refuses with version to have an id set to an empty string, hence we can't use our "key" property as a custom idProperty (an empty string for key is ok for us, and is used to set back a PVE property to its default value) We always access the KeyValues entities via their Key property, so this

[pve-devel] [PATCH 3/3] Declare data object in one statement when we want to delete a parameter

2015-08-18 Thread Emmanuel Kasper
Also add missing formatting --- www/manager5/form/KVComboBox.js | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager5/form/KVComboBox.js b/www/manager5/form/KVComboBox.js index 77bf8f4..8b66dfc 100644 --- a/www/manager5/form/KVComboBox.js +++ b/www/manager5/form

[pve-devel] [PATCH 1/3] Since ExtJS5, when doing such a declaration,

2015-08-18 Thread Emmanuel Kasper
Ext.applyIf(me, { items: { xtype: 'pveKVComboBox', comboItems: data, } }); the comboItems property is passed in the parent class as a config object, instead of being directly available via this.comboItems Since using a config

[pve-devel] [PATCH v2 1/3] ext5migrate: pass the items we want in the ComboBox as a config property

2015-08-18 Thread Emmanuel Kasper
Since ExtJS5, when doing such a declaration, Ext.applyIf(me, { items: { xtype: 'pveKVComboBox', comboItems: data, } }); the comboItems property is passed in the parent class as a config object, instead of being directly avail

[pve-devel] [PATCH v2 3/3] Declare data object in one statement when we want to delete a parameter

2015-08-18 Thread Emmanuel Kasper
Also add missing formatting --- www/manager5/form/KVComboBox.js | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager5/form/KVComboBox.js b/www/manager5/form/KVComboBox.js index 77bf8f4..8b66dfc 100644 --- a/www/manager5/form/KVComboBox.js +++ b/www/manager5/form

[pve-devel] v2 Fix PVE Combobox to work with ExtJS5

2015-08-18 Thread Emmanuel Kasper
Add missing commit message summary line to first patch. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 2/3] ext5migrate: do not set a custome idProperty for the KeyValue model

2015-08-18 Thread Emmanuel Kasper
ExtJS refuses with version to have an id set to an empty string, hence we can't use our "key" property as a custom idProperty (an empty string for key is ok for us, and is used to set back a PVE property to its default value) We always access the KeyValues entities via their Key property, so this

[pve-devel] [PATCH 1/2] ext5migrate: enable striped row, it now works with ExtJS5

2015-08-18 Thread Emmanuel Kasper
--- www/manager5/dc/Log.js | 2 +- www/manager5/dc/Tasks.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager5/dc/Log.js b/www/manager5/dc/Log.js index 75eccb0..385823b 100644 --- a/www/manager5/dc/Log.js +++ b/www/manager5/dc/Log.js @@ -30,7 +30,7 @@ Ext.define(

[pve-devel] [PATCH 2/2] ext5migrate: move setting the Panel title into the class properties

2015-08-18 Thread Emmanuel Kasper
Ext.applyIf(me, { title: gettext('Search') }); in initComponent() is not safe anymore with ExtJS5. Since the 'title' property is existing at that stage (even if with a null or undefined value), Ext.applyIf will not update it. --- www/manager5/grid/ResourceGrid.js | 6 ++ 1 file ch

Re: [pve-devel] [PATCH v2 3/3] Declare data object in one statement when we want to delete a parameter

2015-08-18 Thread Emmanuel Kasper
> On 08/18/2015 10:36 AM, Emmanuel Kasper wrote: > > Also add missing formatting > > --- > > www/manager5/form/KVComboBox.js | 9 - > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/www/manager5/form/KVComboBox.js > >

[pve-devel] [PATCH] Typo in create_rootfs() subroutine

2015-08-24 Thread Emmanuel Kasper
--- src/PVE/LXC/Create.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 9cb52e3..fa59fcb 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -184,7 +184,7 @@ sub create_rootfs { my $old_conf = PVE::LXC:

[pve-devel] [PATCH] Remove Java applet from list of available console viewers.

2015-08-25 Thread Emmanuel Kasper
We already did this for ExtJS4, just copying from there --- www/manager5/dc/OptionView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager5/dc/OptionView.js b/www/manager5/dc/OptionView.js index 043c7fd..3a98bce 100644 --- a/www/manager5/dc/OptionView.js +++ b/www/ma

[pve-devel] [PATCH] Pass the list of of combobox items as a property

2015-08-25 Thread Emmanuel Kasper
The original fix using a config Object was a bit overkill, this works well too , requires less code in the child classes, and is more consistent with rest of the code we have. --- www/manager5/form/KVComboBox.js | 12 ++-- www/manager5/form/LanguageSelector.js| 4 +--- www/

[pve-devel] [PATCH pve-container] Add handling for "arch" and "ostype" options in update_pct_config()

2015-08-25 Thread Emmanuel Kasper
Without this patch, restoring a vzdump backup fails. --- src/PVE/LXC.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index d1a4ea6..05ab166 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1090,7 +1090,8 @@ sub update_pct_config {

[pve-devel] [PATCH pve-container] Correct package name in sub update_ipconfig()

2015-08-26 Thread Emmanuel Kasper
--- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 5e21df6..e59a4ce 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1381,7 +1381,7 @@ sub hotplug_net { sub update_ipconfig { my ($vmid, $conf, $opt, $eth, $newnet,

Re: [pve-devel] [PATCH pve-container] Add handling for "arch" and "ostype" options in update_pct_config()

2015-08-26 Thread Emmanuel Kasper
e_pct_config with those options) , but maybe takes some time, this will be my first real dive in Perl ! >> On August 25, 2015 at 2:55 PM Emmanuel Kasper wrote: >> >> >> Without this patch, restoring a vzdump backup fails. >> --- >> src/PVE/LXC.pm | 6 --

Re: [pve-devel] [PATCH pve-container] Add handling for "arch" and "ostype" options in update_pct_config()

2015-08-27 Thread Emmanuel Kasper
On 08/27/2015 09:02 AM, Dietmar Maurer wrote: >> OK I will try to look at that (do not call update_pct_config >> with those options) , but maybe takes some time, this will be my first >> real dive in Perl ! > > I guess this is already fixed with: > > https://git.proxmox.com/?p=pve-container.git;a

[pve-devel] Unable to restore container backup with vzdump command

2015-08-27 Thread Emmanuel Kasper
Hi I am trying to restore a vzdump backup with the following command: vzrestore /var/lib/vz/dump/vzdump-lxc-104-2015_08_27-11_45_22.tar.lzo 100 I am always getting the error: vzrestore /var/lib/vz/dump/vzdump-lxc-104-2015_08_27-11_45_22.tar.lzo 100 can't lock container 100 even though there is

Re: [pve-devel] Unable to restore container backup with vzdump command

2015-08-27 Thread Emmanuel Kasper
Answering to self: we use now "pct restore" pct restore 100 /var/lib/vz/dump/vzdump-lxc-104-2015_08_27-11_45_22.tar.lzo On 08/27/2015 12:31 PM, Emmanuel Kasper wrote: > Hi > > I am trying to restore a vzdump backup with the following command: > vzrestore /var/lib/

[pve-devel] [PATCH pve-manager] ext5migrate: adapt Backup items to new KVCombobox parent class

2015-08-31 Thread Emmanuel Kasper
This allows the Backup to work with ExtJS5 --- www/manager5/form/BackupModeSelector.js| 17 + www/manager5/form/CompressionSelector.js | 17 + www/manager5/form/DayOfWeekSelector.js | 11 ++- www/manager5/form/EmailNotificationSelector.

[pve-devel] [PATCH pve-storage] Correct manpage examples to newer syntax

2015-08-31 Thread Emmanuel Kasper
--- pvesm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvesm b/pvesm index 60e71dc..6c16568 100755 --- a/pvesm +++ b/pvesm @@ -232,10 +232,10 @@ To get the filesystem path for a use: =head1 EXAMPLES # scan iscsi host for available targets - pvesm scan iscsi + pves

[pve-devel] [PATCH pve-lxc] Enhange pct man page with DESCRIPTION, EXAMPLES, FILES, SEE ALSO

2015-09-01 Thread Emmanuel Kasper
--- src/pct | 53 +++-- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/src/pct b/src/pct index 6821ea3..155650d 100755 --- a/src/pct +++ b/src/pct @@ -159,7 +159,7 @@ __END__ =head1 NAME -pct - Tool to manage Linux Containers on

[pve-devel] [PATCH v2 pve-lxc] Enhance pct man page with DESCRIPTION, EXAMPLES, FILES, SEE ALSO sections

2015-09-01 Thread Emmanuel Kasper
--- src/pct | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/src/pct b/src/pct index 6821ea3..f1a3d0a 100755 --- a/src/pct +++ b/src/pct @@ -159,7 +159,7 @@ __END__ =head1 NAME -pct - Tool to manage Linux Containers on Pro

[pve-devel] [RFC pve-container] Do not abort a backup when detecting a mountpoint, but give a warning

2015-09-01 Thread Emmanuel Kasper
At the momment we abort the vzdump backup of a container which contain mount points. IIRC Currently mount points won't be backed up because: A) we call the tar command with --on-filesystem option ( this will exclude: mp0: /home,mp=/home bind mounts ) and B) PVE::LXC::attach_loops works with $di

[pve-devel] [PATCH pve-container] Convert to disksize to GB after reading the config file

2015-09-02 Thread Emmanuel Kasper
This fixes a bug when calling pct restore a vzdump backup: we store the rootfs size in KB, but create_disks expects that a GB parameter. So the restore was failing trying to create something of a Petabyte image. Formatting '/var/lib/vz/images/110/vm-110-disk-1.raw', fmt=raw size=4503599627370496

[pve-devel] [PATCH pve-manager] Fix package path to startup and shutdown subroutines

2015-09-07 Thread Emmanuel Kasper
--- PVE/API2/Nodes.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 268ae01..1528fc6 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1240,7 +1240,7 @@ __PACKAGE__->register_method ({ if ($d->{t

[pve-devel] [PATCH pve-manager] Update vzdump man page for use with LXC containers

2015-09-07 Thread Emmanuel Kasper
--- PVE/CLI/vzdump.pm | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/PVE/CLI/vzdump.pm b/PVE/CLI/vzdump.pm index f812815..e3b02a6 100755 --- a/PVE/CLI/vzdump.pm +++ b/PVE/CLI/vzdump.pm @@ -33,7 +33,7 @@ vzdump - backup utility for virtual machine vzdu

[pve-devel] [PATCH pve-manager] Rename onboot and startup parameters to follow vm.conf synthax

2015-09-08 Thread Emmanuel Kasper
This fixes the problem of containers not autostarting with onboot=1 --- PVE/API2/Nodes.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 3ccbe88..f4bda13 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1147,10 +1147,10

[pve-devel] [PATCH pve-container] Don't die in vm_shutdown when we have no errors

2015-09-09 Thread Emmanuel Kasper
This fixes bugzilla entry: https://bugzilla.proxmox.com/show_bug.cgi?id=707 --- src/PVE/API2/LXC/Status.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index 761a3c8..5e5e116 100644 --- a/src/PVE/API2/LXC/Status.pm +++

[pve-devel] [PATCH pve-manager] Update vzdump man page for 4.0 (LXC containers , KVM live backup)

2015-09-10 Thread Emmanuel Kasper
--- PVE/CLI/vzdump.pm | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/PVE/CLI/vzdump.pm b/PVE/CLI/vzdump.pm index e3b02a6..e363f25 100755 --- a/PVE/CLI/vzdump.pm +++ b/PVE/CLI/vzdump.pm @@ -51,17 +51,23 @@ rsync copies changed files. After that, the VM is star

[pve-devel] [PATCH pve-manager] Use comma to split vmid list when building the crontab vzdump command

2015-09-10 Thread Emmanuel Kasper
This fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=706 --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 138986e..78ef6e6 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -1279,7 +1279,7 @@ sub command_line { my $c

[pve-devel] [PATCH pve-manager] pvesh man page

2015-09-10 Thread Emmanuel Kasper
--- bin/Makefile | 8 +++- bin/pvesh| 46 ++ 2 files changed, 53 insertions(+), 1 deletion(-) diff --git a/bin/Makefile b/bin/Makefile index 56c9f1a..fd865ca 100644 --- a/bin/Makefile +++ b/bin/Makefile @@ -26,7 +26,9 @@ CLI_MANS =

[pve-devel] [PATCH pve-manager rebased] pvesh man page

2015-09-10 Thread Emmanuel Kasper
--- bin/Makefile | 8 +++- bin/pvesh| 46 ++ 2 files changed, 53 insertions(+), 1 deletion(-) diff --git a/bin/Makefile b/bin/Makefile index 2f0962a..9cfeafe 100644 --- a/bin/Makefile +++ b/bin/Makefile @@ -24,7 +24,9 @@ CLI_MANS =

[pve-devel] [PATCH pve-manager] Allow typeahead selection of Firewall macros

2015-09-16 Thread Emmanuel Kasper
This fixes the bug: https://bugzilla.proxmox.com/show_bug.cgi?id=677 Remarks: * allowBlank is already set in the class definition * The value of the comboBox can be either '' after the component initial load, or 'null' if the user selected a macro and cleans the field afterwards. This is the reaso

[pve-devel] [PATCH pve-manager] Allow email adresses with a top level domain of up to 63 characters

2015-09-16 Thread Emmanuel Kasper
This patch allows email adresses of the form john.public@company.hamburg This fixes the bug: https://bugzilla.proxmox.com/show_bug.cgi?id=716 Note that this patch only deals will the client side validation, a patch to update the server side validation will follow. Implementation: Just copied the

[pve-devel] [PATCH pve-common] Allow top level devel domain name up to 63 characters in email adresses

2015-09-17 Thread Emmanuel Kasper
This corrects the server side validation, and fixes the bug: https://bugzilla.proxmox.com/show_bug.cgi?id=716 --- src/PVE/JSONSchema.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index cb2d56e..dbe2e35 100644 --- a/src/PVE

[pve-devel] [PATCH v2 pve-manager] Allow email adresses with a top level domain of up to 63 characters

2015-09-18 Thread Emmanuel Kasper
This patch allows email adresses of the form john.public@company.hamburg This fixes the bug: https://bugzilla.proxmox.com/show_bug.cgi?id=716 Note that this patch only deals will the client side validation, a separate deals with the server side validation (http://pve.proxmox.com/pipermail/pve-deve

[pve-devel] [PATCH pve-container] When destroying a container, remove bind mounts and block devices from the list of volumes to delete.

2015-09-22 Thread Emmanuel Kasper
--- src/PVE/LXC.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 3c77c5b..afff9fe 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1294,6 +1294,12 @@ sub destroy_lxc_container { foreach_mountpoint($conf, sub { my ($ms, $mountpoin

Re: [pve-devel] [PATCH v2 pve-manager] Allow email adresses with a toplevel domain of up to 63 characters

2015-09-30 Thread Emmanuel Kasper
> Hi > > Please, let me to do a question: > > Several mail servers require auth for accept a message (for after send > it to > addressee), so my question is if is possible add this option in PVE GUI. > (and if is possible, also choose a port number, and a SSL/TLS connection) > > Notes: > 1)All p

[pve-devel] [PATCH pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

2015-10-05 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck (at the moment ext4) * the -y flag ensures that the filesystem can be fixed automcaticall in a non-interactive session * the -f flag forces a filesystem check if it detected as clean --- src/PVE/CLI/pct.pm | 46 +++

[pve-devel] [PATCH pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

2015-10-06 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck (at the moment ext4) * the -y flag ensures that the filesystem can be fixed automcatically in a non-interactive session * the -f flag forces a filesystem check even if the fs seems clean --- src/PVE/CLI/pct.pm | 46

[pve-devel] [PATCH pve-container] Typo in resize_vm subroutine

2015-10-06 Thread Emmanuel Kasper
--- src/PVE/API2/LXC/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index c363850..cd1a9cd 100644 --- a/src/PVE/API2/LXC/Config.pm +++ b/src/PVE/API2/LXC/Config.pm @@ -252,7 +252,7 @@ __PACKAGE__->register_metho

[pve-devel] add pct fcsk command

2015-10-07 Thread Emmanuel Kasper
Changed: usei PVE::LXC::lock_container() instead of managing the lock ourselves ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v3 pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

2015-10-07 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck (at the moment ext4) * the -y flag ensures that the filesystem can be fixed automcatically in a non-interactive session * the -f flag forces a filesystem check even if the fs seems clean --- src/PVE/CLI/pct.pm | 42

[pve-devel] add pct fcsk command

2015-10-12 Thread Emmanuel Kasper
Changed: * add option to check extra mount points, but skip bind mounts * add -l option to fsck to lock the device during fsck, preventing multiple fsck to be run on the same device ( idea taken from systemd fsck service) ___ pve-devel mailing list pve

[pve-devel] [PATCH v4 pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

2015-10-12 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck (at the moment ext4) * the -y flag ensures that the filesystem can be fixed automcatically in a non-interactive session * the -f flag forces a filesystem check even if the fs seems clean --- src/PVE/CLI/pct.pm | 65

Re: [pve-devel] [PATCH v4 pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

2015-10-12 Thread Emmanuel Kasper
> I don't think parsing and bind-mount check need to be part of the 'if' > clause. Checking in case of the rootfs, too, doesn't harm, and you might > want to be able to put a rootfs on a block device, too. (Though this > currently doesn't seem to be possible). > > Also, while you do want to skip

[pve-devel] [PATCH pve-container] Add new pct fsck command to check the mountpoints of a container

2015-10-14 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck * the -a flag ensures that the filesystem can be fixed without any questions * the -f flag forces a filesystem check even if the fs seems clean (flags similar to what the fsck systemd unit uses) --- src/PVE/CLI/pct.pm | 85

[pve-devel] pct fsck command

2015-10-14 Thread Emmanuel Kasper
changed: * include direct block devices in devices to check * but skip zfs datasets * lock the container earlier ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-container] Add new pct fsck command to check the mountpoints of a container

2015-10-14 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck * the -a flag ensures that the filesystem can be fixed without any questions * the -f flag forces a filesystem check even if the fs seems clean (flags similar to what the fsck systemd unit uses) --- src/PVE/CLI/pct.pm | 85

[pve-devel] [PATCH v3 pve-container] Add new pct fsck command to check the mountpoints of a container

2015-10-14 Thread Emmanuel Kasper
* the filesystem specific command will be called automatically by fsck * the -a flag ensures that the filesystem can be fixed without any questions * the -f flag forces a filesystem check even if the fs seems clean (flags similar to what the fsck systemd unit uses) --- src/PVE/CLI/pct.pm | 83

[pve-devel] add new pct fsck command

2015-10-14 Thread Emmanuel Kasper
changed: * correct formatting in sub do_fsck() ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager] Force setting the Macro combobox to an empty string when the user erases the content

2015-10-15 Thread Emmanuel Kasper
This fixes https://bugzilla.proxmox.com/show_bug.cgi?id=756 --- www/manager/grid/FirewallRules.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager/grid/FirewallRules.js b/www/manager/grid/FirewallRules.js index 17f5411..990656e 100644 --- a/www/manager/grid/FirewallRules.js +++ b/w

Re: [pve-devel] [PATCH pve-manager] Force setting the Macro combobox to an empty string when the user erases the content

2015-10-15 Thread Emmanuel Kasper
On 10/15/2015 01:37 PM, Dietmar Maurer wrote: > Would this also fix the bug - please can you test? Just tested, this fixes the bug too. > diff --git a/www/manager/grid/FirewallRules.js > b/www/manager/grid/FirewallRules.js > index 17f5411..1f65cb5 100644 > --- a/www/manager/grid/FirewallRules.js

[pve-devel] [PATCH] Add new pvereport command

2015-10-22 Thread Emmanuel Kasper
--- bin/Makefile | 10 +-- bin/pvereport | 89 +++ 2 files changed, 97 insertions(+), 2 deletions(-) create mode 100755 bin/pvereport diff --git a/bin/Makefile b/bin/Makefile index 9cfeafe..827e30d 100644 --- a/bin/Makefile +++ b/bin/M

Re: [pve-devel] [PATCH] Add new pvereport command

2015-10-27 Thread Emmanuel Kasper
On 10/27/2015 07:43 AM, Dietmar Maurer wrote: > applied, comment inline: > >> --- /dev/null >> +++ b/bin/pvereport >> @@ -0,0 +1,89 @@ >> +#!/usr/bin/perl >> + >> +use strict; >> +use warnings; >> +use PVE::pvecfg; >> + >> +($> == 0 ) || die "please run as root\n"; >> + >> +my @general = ('hostnam

[pve-devel] [PATCH trivial qemu-server] Don't create unused empty /etc/qemu-server directory

2015-10-27 Thread Emmanuel Kasper
--- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index 21324f1..e47f5fb 100644 --- a/Makefile +++ b/Makefile @@ -79,7 +79,6 @@ PKGSOURCES=qm qm.1.gz qm.1.pod qmrestore qmrestore.1.pod qmrestore.1.gz qmextrac .PHONY: install install: ${PKGSOURCES} insta

[pve-devel] empty /etc/qemu-server/ directory

2015-10-27 Thread Emmanuel Kasper
Hi I noticed while poking aroung /etc, that the qemu-server package creates an empty /etc/qemu-server directory but never uses it, since we always store stuff in /etc/pve/qemu-server I assume it is safe to remove it ? ___ pve-devel mailing list pve-d

[pve-devel] [PATCH pve-manager] Pretty format the output of multiple files in a directory

2015-10-28 Thread Emmanuel Kasper
Also, don't "cat" non existing files --- bin/pvereport | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/bin/pvereport b/bin/pvereport index 514cc9a..91fdb36 100755 --- a/bin/pvereport +++ b/bin/pvereport @@ -3,19 +3,39 @@ use

[pve-devel] [PATCH v2 pve-manager] Pretty format the output of multiple files in a directory

2015-10-29 Thread Emmanuel Kasper
Also, don't "cat" non existing files --- bin/pvereport | 42 ++ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/bin/pvereport b/bin/pvereport index 514cc9a..42e87cc 100755 --- a/bin/pvereport +++ b/bin/pvereport @@ -3,19 +3,31 @@ use strict;

[pve-devel] enhance pvereport display

2015-10-29 Thread Emmanuel Kasper
Changed from V1: use PVE::Tools::dir_glob_foreach Changed from V2: add regexp for openvz vm.conf files ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v3 pve-manager] Pretty format the output of multiple files in a directory

2015-10-29 Thread Emmanuel Kasper
Also, don't "cat" non existing files --- bin/pvereport | 42 ++ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/bin/pvereport b/bin/pvereport index 514cc9a..0e2fb3d 100755 --- a/bin/pvereport +++ b/bin/pvereport @@ -3,19 +3,31 @@ use strict;

[pve-devel] [PATCH pve-manager 1/2] Move pvereport functionality into API2 package

2015-11-03 Thread Emmanuel Kasper
--- PVE/API2/Makefile | 1 + PVE/API2/Report.pm | 105 + bin/pvereport | 95 +--- 3 files changed, 108 insertions(+), 93 deletions(-) create mode 100644 PVE/API2/Report.pm diff --git a/PVE/AP

[pve-devel] [PATCH pve-manager 2/2] Add REST endpoint for /report call

2015-11-03 Thread Emmanuel Kasper
--- PVE/API2/Nodes.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 41baca0..8ee5164 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -25,6 +25,7 @@ use PVE::APLInfo; use PVE::HA::Config; use PVE::QemuServer; us

[pve-devel] add /report to PVE API2

2015-11-03 Thread Emmanuel Kasper
Changes since v1: Add Report.pm to PVE:: pacakge hierarchy instead of PVE::API2 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-manager 1/2] Move pvereport functionality into a separate PVE package

2015-11-03 Thread Emmanuel Kasper
--- PVE/Makefile | 1 + PVE/Report.pm | 105 ++ bin/pvereport | 95 ++-- 3 files changed, 108 insertions(+), 93 deletions(-) create mode 100644 PVE/Report.pm diff --git a/PVE/Makefile b/PV

[pve-devel] [PATCH v2 pve-manager 2/2] Add REST endpoint for /report call

2015-11-03 Thread Emmanuel Kasper
--- PVE/API2/Nodes.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 41baca0..4a61cc7 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -22,6 +22,7 @@ use PVE::Storage; use PVE::Firewall; use PVE::LXC; use PVE::AP

[pve-devel] [PATCH v3 pve-manager 2/2] Add REST endpoint for /report call

2015-11-03 Thread Emmanuel Kasper
--- PVE/API2/Nodes.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 41baca0..fb05863 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -22,6 +22,7 @@ use PVE::Storage; use PVE::Firewall; use PVE::LXC; use PVE::AP

[pve-devel] add /report to PVE API

2015-11-03 Thread Emmanuel Kasper
change since V2: correct wrong function call after package being move to different dir ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v3 pve-manager 1/2] Move pvereport functionality into a separate PVE package

2015-11-03 Thread Emmanuel Kasper
--- PVE/Makefile | 1 + PVE/Report.pm | 105 ++ bin/pvereport | 95 ++-- 3 files changed, 108 insertions(+), 93 deletions(-) create mode 100644 PVE/Report.pm diff --git a/PVE/Makefile b/PV

[pve-devel] [PATCH pve-manager 1/2] Use protected mode to be able to execute root system commands

2015-11-05 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- PVE/API2/Nodes.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 70f4bbb..9b7bb9f 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1137,6 +1137,7 @@ __PACKAGE__->register_method({ permissi

[pve-devel] [PATCH pve-manager 2/2] Add report modal window, containing pvereport content

2015-11-05 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager/node/Subscription.js | 73 1 file changed, 73 insertions(+) diff --git a/www/manager/node/Subscription.js b/www/manager/node/Subscription.js index ac4d2f4..9e54335 100644 --- a/www/manager/node

[pve-devel] [PATCH qemu-server] Don't treat serial devices as a local resource if they point to a socket.

2015-11-09 Thread Emmanuel Kasper
Close: https://bugzilla.proxmox.com/show_bug.cgi?id=470 --- PVE/QemuServer.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a109ea9..2c43556 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -558,7 +558,7 @@ my $serialdes

[pve-devel] [PATCH pve-manager] update build infrastucture to be able to develop with Ext6

2015-11-10 Thread Emmanuel Kasper
--- PVE/ExtJSIndex6.pm | 263 PVE/Makefile| 2 +- PVE/Service/pveproxy.pm | 22 ++-- defines.mk | 2 +- www/Makefile| 2 +- www/ext6/Makefile | 40 www/manager5/Readme.md | 21 ++--

[pve-devel] Initial work for ExtJS6

2015-11-12 Thread Emmanuel Kasper
This patch serie changes allows the GUI to at least load with Ext6 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 1/3] Add mime type for woff2 fonts, also update mime type for ttf fonts

2015-11-12 Thread Emmanuel Kasper
application/font-woff2 is still in discussion but works in main three browsers This is needed for ExtJS6, which includes some woff2 fonts ttf font mime type is taken from the official IANA assignment, and works as well in main three browsers --- PVE/HTTPServer.pm | 5 - 1 file changed, 4 inse

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: Replace deprecated function which is missing in Ext6

2015-11-12 Thread Emmanuel Kasper
See http://docs.sencha.com/extjs/5.1/5.1.0-apidocs/#!/api/Ext.container.Container-method-doLayout This allows the pve manager to load --- www/manager5/Workspace.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager5/Workspace.js b/www/manager5/Workspace.js inde

[pve-devel] [PATCH pve-manager 2/3] Switch to triton theme as default theme in ExtJS6

2015-11-12 Thread Emmanuel Kasper
--- PVE/ExtJSIndex6.pm | 2 +- www/ext6/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/ExtJSIndex6.pm b/PVE/ExtJSIndex6.pm index f7449c8..0604fc2 100644 --- a/PVE/ExtJSIndex6.pm +++ b/PVE/ExtJSIndex6.pm @@ -12,7 +12,7 @@ sub get_index { Proxmox

Re: [pve-devel] [Feature request] add disk for lxc from the API and WebUI

2015-11-12 Thread Emmanuel Kasper
On 11/12/2015 04:01 PM, lyt_yudi wrote: > hi,all > > current, add disk for the lxc from cli. like this > > # cat /etc/pve/lxc/100.conf > arch: amd64 > cpulimit: 2 > cpuunits: 1024 > hostname: test > memory: 2048 > net0: > bridge=vmbr0,hwaddr=F2:07:24:D6:DE:28,ip=172.16.1.100/12,name=eth0,type=ve

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: move class static properties out of initComponent()

2015-11-16 Thread Emmanuel Kasper
This fixes the Auth realm selection while login with ExtJS6 --- www/manager6/form/RealmComboBox.js | 55 +- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/www/manager6/form/RealmComboBox.js b/www/manager6/form/RealmComboBox.js index 34b417d..7e

[pve-devel] [PATCH pve-manager 1/3] ext6migrate: force an empty array as default value for filters

2015-11-16 Thread Emmanuel Kasper
Without this, filters.add() in line 73 file fails --- www/manager6/grid/ObjectGrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/grid/ObjectGrid.js b/www/manager6/grid/ObjectGrid.js index cd135a1..8513709 100644 --- a/www/manager6/grid/ObjectGrid.js +++ b/www/

[pve-devel] [PATCH pve-manager 2/3] ext6migrate: move static class properties out of initComponent()

2015-11-16 Thread Emmanuel Kasper
Besides fitting more with the declarative style of ExtJS, this has the interesting side effect of allowing comboboxes to work with ExtJS6 --- www/manager6/form/KVComboBox.js | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/www/manager6/form/KVComboBox.js b/www/manager

<    3   4   5   6   7   8   9   10   >