[pve-devel] [Patch V4 2/6] Add config parameter 'source'.

2018-05-08 Thread Wolfgang Link
This parameter is useful for restoring the replication status. It is also corrected if it is missing or wrong. --- PVE/ReplicationConfig.pm | 6 ++ PVE/ReplicationState.pm | 5 + 2 files changed, 11 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 51cf

[pve-devel] [Patch V4 4/6] Get snapshots when no state is available.

2018-05-08 Thread Wolfgang Link
With this patch we can restore the state of a state less job. It may happen that there are more replication snapshots, because no job state is known can not delete any snapshot. Existing multiple replication-snapshot happens when a node fails in middel of a replication and then the VM is moved to a

[pve-devel] [Patch V4 3/6] Delete replication snapshots only if last_sync is not 0.

2018-05-08 Thread Wolfgang Link
If last_sync is 0, the VM configuration has been stolen (either manually or by HA restoration). Under this condition, the replication snapshot should not be deleted. This snapshot is used to restore replication state. If the last_snap is greater than 0 and does not match the snap name it must be a

[pve-devel] [Patch V4 6/6] Swap source and target in replication config, if VM was stolen.

2018-05-08 Thread Wolfgang Link
--- PVE/ReplicationState.pm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 0851195..60e009b 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -254,8 +254,16 @@ sub job_status {

[pve-devel] [Patch V4 5/6] Add function: swap source and target in replication config

2018-05-08 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index b6cd514..063299e 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -258,6 +258,24 @@ sub delete_job { lock($code

[pve-devel] [Patch V5 guest-common] pversr recover state

2018-05-09 Thread Wolfgang Link
This patch series allows to restore a replica without status. A HA migration ends in a lost state, even a manual configuration movement generates this behavior. This patch series also fixes the problem of cleanup without status. [PATCH V5] 0006-Add error message in case the state is not recover

[pve-devel] [Patch V5 guest-common 1/7] Cleanup for stateless jobs.

2018-05-09 Thread Wolfgang Link
If a VM configuration has been manually moved or recovered by HA, there is no status on this new node. In this case, the replication snapshots still exist on the remote side. It must be possible to remove a job without status, otherwise, a new replication job on the same remote node will fail and t

[pve-devel] [Patch V5 guest-common 4/7] Get snapshots when no state is available.

2018-05-09 Thread Wolfgang Link
With this patch we can restore the state of a state less job. It may happen that there are more replication snapshots, because no job state is known can not delete any snapshot. Existing multiple replication-snapshot happens when a node fails in middel of a replication and then the VM is moved to a

[pve-devel] [Patch V5 guest-common 3/7] Delete replication snapshots only if last_sync is not 0.

2018-05-09 Thread Wolfgang Link
If last_sync is 0, the VM configuration has been stolen (either manually or by HA restoration). Under this condition, the replication snapshot should not be deleted. This snapshot is used to restore replication state. If the last_snap is greater than 0 and does not match the snap name it must be a

[pve-devel] [Patch V5 guest-common 5/7] Add function: swap source and target in replication config

2018-05-09 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index b6cd514..eb98f78 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -258,6 +258,19 @@ sub delete_job { lock($code); }

[pve-devel] [Patch V5 guest-common 6/7] Swap source and target in replication config, if VM was stolen.

2018-05-09 Thread Wolfgang Link
--- PVE/ReplicationState.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 0851195..2851b62 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -254,8 +254,17 @@ sub job_status {

[pve-devel] [Patch V5 guest-common 2/7] Add config parameter 'source'.

2018-05-09 Thread Wolfgang Link
This parameter is useful for restoring the replication status. It is also corrected if it is missing or wrong. --- PVE/ReplicationConfig.pm | 6 ++ PVE/ReplicationState.pm | 5 + 2 files changed, 11 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 51cf

[pve-devel] [Patch V5 guest-common 7/7] Add lock to pervent lost update.

2018-05-09 Thread Wolfgang Link
--- PVE/ReplicationState.pm | 102 +--- 1 file changed, 53 insertions(+), 49 deletions(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 2851b62..1613e8f 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -240,67

[pve-devel] [PATCH 1/2] Simplify image/template upload check.

2018-05-13 Thread Wolfgang Link
All storage's witch are able to store images must have a path. --- PVE/API2/Storage/Status.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index ab07146..afb8dcc 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/St

[pve-devel] [PATCH 2/2] Fix typo.

2018-05-13 Thread Wolfgang Link
--- PVE/API2/Storage/Status.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index afb8dcc..e62fdc3 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Status.pm @@ -334,7 +334,7 @@ __PACKAGE__->register_metho

Re: [pve-devel] [PATCH 1/2] Simplify image/template upload check.

2018-05-14 Thread Wolfgang Link
'type' => 'glusterfs', 'server' => '127.0.0.1' > Dietmar Maurer hat am 14. Mai 2018 um 08:48 geschrieben: > > > AFAIK this is not really true with glusterfs? > > > On May 14, 2018 a

[pve-devel] [PATCH] Handel connection check timeouts.

2018-05-15 Thread Wolfgang Link
--- PVE/Storage/CIFSPlugin.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index 1670a5c..9532508 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -218,7 +218,8 @@ sub check_connection { };

[pve-devel] [PatchV2 storage] Handel connection check timeouts.

2018-05-16 Thread Wolfgang Link
--- PVE/Storage/CIFSPlugin.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index 1670a5c..724fb1f 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -218,7 +218,8 @@ sub check_connection { };

[pve-devel] [PATCH storage] Make check_connection less costly.

2018-05-16 Thread Wolfgang Link
This command will only check the needed share and do not query the hole server shares. This reduce the answer time and also has the benefit we check the credentials on this share and not on the server. --- PVE/Storage/CIFSPlugin.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[pve-devel] [PATCH qemu-server] Improve error message of shared storage connection check.

2018-05-18 Thread Wolfgang Link
Now you see if the storage plugin support it, extra information about the error. --- PVE/QemuMigrate.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 27cf7e3..55a5554 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @

[pve-devel] Make storage offline message more informative.

2018-05-18 Thread Wolfgang Link
There are several reasons why storage could be offline. With this series, it is possible to make the offline message more informative. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [Patch container] Improve error message of shared storage connection check.

2018-05-18 Thread Wolfgang Link
Now you see if the storage plugin support it, extra information about the error. --- src/PVE/LXC/Migrate.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 1364b8d..e380bd8 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/

[pve-devel] [Patch storage 2/2] Improve error message.

2018-05-18 Thread Wolfgang Link
Now we get all errors from the cifs client and also if the client program fails. --- PVE/Storage/CIFSPlugin.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index 724fb1f..c1a0a0d 100644 --- a/PVE/Storage/CIFSPlugin.

[pve-devel] [Patch storage 1/2] Improve error message of shared storage connection check.

2018-05-18 Thread Wolfgang Link
Now you see if the storage plugin support it, extra information about the error. --- PVE/Storage.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index d733380..b900a4e 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -914,9 +914,8 @@ s

[pve-devel] [Patch storage] fix #1770: allow ex/import linked clones.

2018-05-18 Thread Wolfgang Link
We encode the base-volume-name in the volname what is not needed. On ex/import we need the correct dataset name. --- PVE/Storage/ZFSPoolPlugin.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index fd63d94..32

[pve-devel] [Patch guest-common] set last_sync_snapname after a job restored.

2018-05-22 Thread Wolfgang Link
The replication need the last_sync_snapname to clean up the last snapshot after the replication run done. If this is not correctly set the snapshot will exist until the next run. --- PVE/Replication.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Replication.pm b/PVE/Replication.pm ind

[pve-devel] [Patch container 2/2] Mark CT as a template after rename volumes.

2018-05-23 Thread Wolfgang Link
If a rename fails, the CT should not mark as a template. --- src/PVE/API2/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index bce5fa3..c016b44 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1168,13 +1

[pve-devel] [Patch container 1/2] Also rename MP when CT is converted to template.

2018-05-23 Thread Wolfgang Link
Mountpoints should use the same names as rootfs when they converted to a template. So we also renamed MP. --- src/PVE/LXC.pm | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 4f9674d..928234a 100644 --- a/src

[pve-devel] [Patch V2 container 1/2] template create: handle mountpoints besides rootfs

2018-05-30 Thread Wolfgang Link
we only handled the special rootfs mount so creating a template from a container with additional mountpoint did not work correctly. Use foreach_mountpoint to create a base vdisk for all mount points after checking if the storage supports it --- Patch V2: reword commit message as t.lamprech

[pve-devel] [Patch V2 container 2/2] Mark CT as a template after rename volumes.

2018-05-30 Thread Wolfgang Link
If a rename fails, the CT should not mark as a template. --- src/PVE/API2/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index bce5fa3..c016b44 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1168,13 +1

Re: [pve-devel] [Patch V2 container 1/2] template create: handle mountpoints besides rootfs

2018-05-30 Thread Wolfgang Link
> applied series, thanks. > > Some non directly related problems I found during testing these: > > * If I set the RO (readonly) flag of a mountpoint from a template > the respective MP's size will set to '0T'. This behavior I can't confirm! Tested on ZFS and thin-lvm. > * If I set RO of a MP all

[pve-devel] [Patch container] fix #1792: Do not assign vars in conditional statement

2018-06-05 Thread Wolfgang Link
If a variable is defined and assigned in a conditional statement, it is not defined behavior in Perl. For more inforamtion about this behavior see https://perldoc.perl.org/perlsyn.html#Statement-Modifiers "NOTE: The behaviour of a my, state, or our modified with a statement modifier conditional o

[pve-devel] [Patch container] fix #1778: check storage support templates

2018-06-06 Thread Wolfgang Link
LXC can only create templates on storages which support linked clones. To prevent this, we will check before we convert to a template if the storage support this. --- src/PVE/API2/LXC.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index

[pve-devel] [PATCH] Use enums for smbvers to prevent incorrect input

2018-06-06 Thread Wolfgang Link
--- PVE/Storage/CIFSPlugin.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index cb7c844..2124c87 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -104,8 +104,9 @@ sub properties { m

[pve-devel] [Patch V2 container] fix #1778: check if storage support templates

2018-06-06 Thread Wolfgang Link
LXC can only create templates on storages which support linked clones. To prevent this, we will check before we convert to a template if the storage support this. --- src/PVE/API2/LXC.pm | 9 + 1 file changed, 9 insertions(+) [Patch V2] change formatting rename var fix grammar diff --git

Re: [pve-devel] [PATCH] Use enums for smbvers to prevent incorrect input

2018-06-06 Thread Wolfgang Link
> Thomas Lamprecht hat am 6. Juni 2018 um 15:51 > geschrieben: > > > On 6/6/18 1:23 PM, Wolfgang Link wrote: > > --- > > PVE/Storage/CIFSPlugin.pm | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/PVE/Storage/CIFSPl

[pve-devel] [RFC pve-storage] Add feature property 'lxc_clone'

2018-06-07 Thread Wolfgang Link
LXC and Qemu have different clone requirements. Since LXC has no qcow2 support, there is no possibility to create a linked clone on directory storage. --- PVE/Storage/LvmThinPlugin.pm | 1 + PVE/Storage/RBDPlugin.pm | 1 + PVE/Storage/ZFSPlugin.pm | 1 + PVE/Storage/ZFSPoolPlugin.pm | 1 +

[pve-devel] Make check for linked clones more nuanced

2018-06-07 Thread Wolfgang Link
Qemu can use qcow2 format to make linked clones. LXC we do not have this, and so there is no way to make linked clone on directory storage. With the 'lxc_clone' feature property we can distinguish between LXC and QEMU. ___ pve-devel mailing list pve-de

[pve-devel] [RFC container] Handle lined clone check in clone_vm call

2018-06-07 Thread Wolfgang Link
The check if storage support linked clones should make in the call 'clone_vm' and not in the template. The storage feature property 'lxc_clone' will show if storage can provide linked clones. --- src/PVE/API2/LXC.pm | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/s

[pve-devel] [Patch storage] use mkdir option in CIFS instead always create dir

2018-06-13 Thread Wolfgang Link
see commit c7616abcb278e2b888febc082b557f60676fc376 --- PVE/Storage/CIFSPlugin.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index ff24c8d..ffd16e3 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.p

[pve-devel] [installer] Allow more than 26 SCSI disk devices.

2018-07-02 Thread Wolfgang Link
Some customers have more than 26 devices, for example, if they use multipath on a DAS box. In the Linux Documentation admin-guide/devices.txt is written 256 SCSI disk devices are possible. Signed-off-by: Wolfgang Link --- proxinstall | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [pve-devel] [PATCH storage 2/2] storage add: always extract password from parameters

2018-07-02 Thread Wolfgang Link
Reviewed and tested. Everything work and it looks OK to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/3] ui/storage: cifs: only allow entering a password if user is set

2018-07-02 Thread Wolfgang Link
Reviewed and tested. Everything work and it looks OK to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server v2 1/2] move disk: simplify and remove progress output

2018-07-02 Thread Wolfgang Link
Tested everything work and it looks OK to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [qemu-server] fix #1829 check cloud-init disk format.

2018-07-03 Thread Wolfgang Link
Directory storage support raw and qcow2 format. It is not good to implicitly set the cloud-init format and ignore the selected format. Signed-off-by: Wolfgang Link --- PVE/API2/Qemu.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2

[pve-devel] [manager] remove 'btrfs' as OSD fstype.

2018-08-30 Thread Wolfgang Link
btrfs is deprecated since Luminous and it will no more be tested. If btrfs is used, you have to add an extra parameter to ceph.conf to allow ceph-disk to activate btrfs OSD's. In our default config this is not the case. From Luminous release note [1]: "We no longer test the FileStore ceph-osd ba

[pve-devel] [PATCH] Dev docu: Add build prerequisites

2018-09-03 Thread Wolfgang Link
--- README.dev | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.dev b/README.dev index 92f1e74..6b48b20 100644 --- a/README.dev +++ b/README.dev @@ -45,7 +45,8 @@ liblzma-dev dosfstools mtools libxen-dev libfuse-dev corosync-dev \ libcpg-dev libquorum-dev libcmap-dev

[pve-devel] [RFC manager] Storage: remove unreferend images in storage contendview

2018-10-05 Thread Wolfgang Link
If an image on storage has not referenced to any guest config, we can safely delete it on the GUI. Images that are marked as unused in the config are referred. This call can't be in the storage because of cycles dependencies. --- PVE/API2/Nodes.pm | 86 ++

[pve-devel] Preparation to merge multiple snapshot formats.

2018-10-23 Thread Wolfgang Link
At the moment we have three different implementations for snapshots names. pve-snapshot-name, pve-lxc-snapshot-name and direct in pvesm import/export. This patch is the preparation to remove them and only use instead one function 'pve-snapshot-id'. ___

[pve-devel] [common 2/2] Extend the JSON format schema with pve_base_snapshot.

2018-10-23 Thread Wolfgang Link
A base snapshot can be a replication snapshot or a normal snapshot. Normal snapshots use the format configid. --- src/PVE/JSONSchema.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 3f14875..d9e4f3d 100644 --- a/src/PVE/JSONS

[pve-devel] [common 1/2] merge pve-snapshot-name and pve-lxc-snapshot-name to pve-snapshot-id.

2018-10-23 Thread Wolfgang Link
This format was two time declared in PVE::LXC::Config and PVE::QemuServer. --- src/PVE/JSONSchema.pm | 17 + 1 file changed, 17 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index fb58ad3..3f14875 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSche

Re: [pve-devel] [PATCH common 1/3] fix #1963: don't do day-time related math on time stamps

2018-10-31 Thread Wolfgang Link
Tested with this fixup command and it works like as should. > Wolfgang Bumiller hat am 31. Oktober 2018 um 11:33 > geschrieben: > > > On Wed, Oct 31, 2018 at 10:54:16AM +0100, Wolfgang Bumiller wrote: > > Since our schedules are usually written in local time, we > > cannot actually perform cal

[pve-devel] [RFC_V2 manager] Storage: remove guest images in storage contendview

2018-11-08 Thread Wolfgang Link
If an image on storage has not referenced to any guest or replication config, we can safely delete it on the GUI. Also, if a config exists on another node, we can delete it too. But if an image has a encoded in the image name and a guest exists in the cluster with this VMID then it must a lost im

[pve-devel] [RFC_V3] Storage: remove guest images in storage contendview

2018-11-12 Thread Wolfgang Link
[V2 -> V3] Remove rescan and replication check as Dietmar suggest. Move logic in pve-storage. Use the API path normal storage deletion. [V1 -> V2] Do not remove images if a config exists. Check replication config if the image is used by it. ___ pve-de

[pve-devel] [storage] Add option check if the image can safely remove

2018-11-12 Thread Wolfgang Link
If an image has a encoded in the image name and the guest does not exist in the cluster we can safely delete it on the GUI. Also, if a config exists on another node and the storage is local we can delete it too. In all other cases, a rescan must manual performed to add it back to the guest confi

[pve-devel] [manager] Allow delete image from storage ContentView.

2018-11-12 Thread Wolfgang Link
--- www/manager6/storage/ContentView.js | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 0661065d..b74d2c14 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/C

[pve-devel] [manager V4] Allow delete image from storage ContentView.

2018-11-13 Thread Wolfgang Link
--- www/manager6/storage/ContentView.js | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 0661065d..b74d2c14 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/C

[pve-devel] [storage V4] Add option check if the image can safely remove

2018-11-13 Thread Wolfgang Link
If an image has a encoded in the image name and the guest does not exist in the cluster we can safely delete it on the GUI. Also, if a config exists on another node and the storage is local we can delete it too. In all other cases, a rescan must manual performed to add it back to the guest confi

[pve-devel] [RFC_V4] Storage: remove guest images in storage contendview

2018-11-13 Thread Wolfgang Link
[V3 -> V4] Manager patch in V4 is unchanged Add check if $vmid($ownervm) is undef Use localnode instead node from the API to cover the case of localhost Split the error message into two messages to make the error more understandable for the user. [V2 -> V3] Remove rescan and replication check as

[pve-devel] [manager 2/6] Add function storageIsShared

2018-11-21 Thread Wolfgang Link
This function extracts the shared flag of the storage state. --- www/manager6/data/ResourceStore.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/data/ResourceStore.js b/www/manager6/data/ResourceStore.js index 0a36dee2..ff1dc46f 100644 --- a/www/manager6/data/ResourceS

[pve-devel] [manager 5/6] Move removeButton in a variable

2018-11-21 Thread Wolfgang Link
The move is necessary to hide the removeButton. --- www/manager6/storage/ContentView.js | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 0661065d..8716fba3 100644 --- a/

[pve-devel] [manager 4/6] Add imagedestroy to SafeDestroy

2018-11-21 Thread Wolfgang Link
--- www/manager6/window/SafeDestroy.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index f89d0fa7..8b17093f 100644 --- a/www/manager6/window/SafeDestroy.js +++ b/www/manager6/window/SafeDestroy.js @@ -157,6 +157,8 @

[pve-devel] [manager 1/6] Add parameter storage shared

2018-11-21 Thread Wolfgang Link
So we know in the content call if storage is shared. This is used by removeImageButton. --- PVE/API2Tools.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2Tools.pm b/PVE/API2Tools.pm index 7b4c425a..7527b42b 100644 --- a/PVE/API2Tools.pm +++ b/PVE/API2Tools.pm @@ -120,6 +120,7 @@ sub

[pve-devel] [RFC_V5] Storage: remove guest images in storage contendview

2018-11-21 Thread Wolfgang Link
[V4 -> V5] Completely implement this feature in the frontend. [V3 -> V4] Manager patch in V4 is unchanged Add check if $vmid($ownervm) is undef Use localnode instead node from the API to cover the case of localhost Split the error message into two messages to make the error more understandable f

[pve-devel] [manager 3/6] Add function guestNode

2018-11-21 Thread Wolfgang Link
This function extracts the node where the guest resists. --- www/manager6/data/ResourceStore.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/data/ResourceStore.js b/www/manager6/data/ResourceStore.js index ff1dc46f..5b8690e5 100644 --- a/www/manager6/data/ResourceStore

[pve-devel] [manager 6/6] Add imageRemoveButton

2018-11-21 Thread Wolfgang Link
If an image has a encoded in the image name and the guest does not exist in the cluster we can delete it on the GUI. Also, if a config exists on another node and the storage is local we can delete. In all other cases, it is not allowed to delete it. For safety reason the safe remove windows ar

[pve-devel] [manager V2] Add imageRemoveButton

2018-11-22 Thread Wolfgang Link
If an image has a encoded in the image name and the guest does not exist in the cluster we can delete it on the GUI. Also, if a config exists on another node and the storage is local we can delete. In all other cases, it is not allowed to delete it. For safety reason the safe remove windows ar

[pve-devel] [PATCH] Fix dmesg command

2019-01-02 Thread Wolfgang Link
--- qm-pci-passthrough.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index f51dbcc..a347e31 100644 --- a/qm-pci-passthrough.adoc +++ b/qm-pci-passthrough.adoc @@ -93,7 +93,7 @@ Finally reboot to bring the changes into eff

[pve-devel] [PATCH] update pve software stack

2019-02-26 Thread Wolfgang Link
Make boxes round to fit in Proxmox corporate design. Add pve-ha-crm. pve-ha-lrm alone makes no sense. Add essential user tools pveam pvesr vzdump. --- images/pve-software-stack.tt | 79 +--- 1 file changed, 45 insertions(+), 34 deletions(-) diff --git a/ima

[pve-devel] [PATCH] Add support for Citrix Hypervisor blockdev.

2019-03-06 Thread Wolfgang Link
Citrix Hypervisor use as blockdev path /dev/xvd<[a-z]><\d> It makes sense for Proxmox Mail Gateway to run on Citrix Hypervisor. Citrix Hypervisor recent XenServer. --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index f2414db..f0cc731

[pve-devel] [PATCH] Fix: #1381 properties in the send stream

2019-03-06 Thread Wolfgang Link
Add properties flag for including the properties in the send stream. With the flag, we do not brack the current behavior and give the user who like to sync their properties the capability to send them. --- pve-zsync | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[pve-devel] [installer PATCHV2] Add support for Citrix Hypervisor blockdev.

2019-03-06 Thread Wolfgang Link
Citrix Hypervisor use as blockdev path /dev/xvd<[a-z]><\d> It makes sense for Proxmox Mail Gateway to run on Citrix Hypervisor. Citrix Hypervisor recent XenServer. --- proxinstall | 3 +++ 1 file changed, 3 insertions(+) diff --git a/proxinstall b/proxinstall index f2414db..33c5765 100755 --- a/

[pve-devel] [storage] fix #2154: Buggy "pvesm status" output

2019-04-01 Thread Wolfgang Link
Remove "zpool import" because there is no need for it. zpool list will import the pool if it is not imported. Anyway also there is no situation where Proxmox VE framework will export a pool. So there should no need to import a pool in the code logic. If an error occurs, the error output will he

[pve-devel] [PATCH manager 1/2] Supplementary Ceph installation summary

2019-04-07 Thread Wolfgang Link
Add installation node for the other participant Ceph Node. --- www/manager6/ceph/CephInstallWizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index bd50bf81..b704a39b 100644 --- a/www/manag

[pve-devel] [PATCH manager 2/2] cleanup format.

2019-04-07 Thread Wolfgang Link
--- www/manager6/ceph/CephInstallWizard.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index b704a39b..93aad7fa 100644 --- a/www/manager6/ceph/CephInstallWizard.js +++ b/www/manager6/ceph/C

[pve-devel] [PATCH qemu-server] fix #1829: Cloudinit ignore format parameter

2019-04-16 Thread Wolfgang Link
When a Cloudinit image is created, we allow choosing the format as parameter. So, the parameter should also be taken into account. The default for Cloudinit will stay qcow2 on directory storages. --- PVE/API2/Qemu.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/P

[pve-devel] [PATCH storage] fix #2154: Buggy "pvesm status" output

2019-04-16 Thread Wolfgang Link
Improve error output. --- PVE/Storage/ZFSPoolPlugin.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index 4f16351..9ba3999 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++ b/PVE/Storage/ZFSPoolPlugin.pm @@ -52

[pve-devel] [PATCH guest-common] increase max reading replication state file size.

2019-04-16 Thread Wolfgang Link
In this file, the error of a failed job will also be stored. The default 32768 bytes are not very much. This file is on the local filesystem so there is no filesystem size restrictions like in /etc/pve. --- PVE/ReplicationState.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[pve-devel] [PATCH V2 guest-common] increase max reading replication state file size.

2019-04-17 Thread Wolfgang Link
In this file, the error of a failed job will also be stored. The default 32768 bytes are not very much. This file is on the local filesystem so there is no filesystem size restrictions like in /etc/pve. --- V2: remove comment change size representation PVE/ReplicationState.pm | 2 +- 1 file

[pve-devel] [PATCH] Add check by starting a VM, if Host have engough Cores for VM.

2014-11-14 Thread Wolfgang Link
From: root Signed-off-by: root --- PVE/QemuServer.pm |6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 02bf404..9aea9ee 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2588,6 +2588,12 @@ sub config_to_command { my $cores =

[pve-devel] [PATCH 2/2] Fix Socket

2014-11-16 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- PVE/QemuServer.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9aea9ee..3dfe1b4 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2589,7 +2589,7 @@ sub config_to_command { my

[pve-devel] [PATCH 1/2] Add check by starting a VM, if Host have engough Cores for VM.

2014-11-16 Thread Wolfgang Link
From: root Signed-off-by: Wolfgang Link --- PVE/QemuServer.pm |6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 02bf404..9aea9ee 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2588,6 +2588,12 @@ sub config_to_command { my

[pve-devel] [PATCH] Add Check: If host has enough real CPUs for starting VM, to prevent a Qemu CPU emualtion!

2014-11-17 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- PVE/QemuServer.pm |7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 02bf404..26c6c76 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2588,6 +2588,13 @@ sub config_to_command { my $cores

[pve-devel] [PATCH] Bug#579:

2014-11-17 Thread Wolfgang Link
add check if START Parameter is set in FILE: /etc/default/pve-manager If START="no" NO VM will start if pve-manager start is called If START!="no" or not present, VMs will use the boot_at_start Flag Signed-off-by: Wolfgang Link --- bin/init.d/pve-manager |4 +++

[pve-devel] [PATCH 2/2] now if the QMP command starts with guest-+ , it will bind dynamicly to the VMID.qga socket.

2014-11-25 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- PVE/QMPClient.pm | 54 + PVE/QemuServer.pm | 16 +--- 2 files changed, 39 insertions(+), 31 deletions(-) diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm index 9674d00..b5684b6 100755 --- a/PVE

[pve-devel] [PATCH 1/2] This are the condensed changes form http://pve.proxmox.com/pipermail/pve-devel/2013-March/006913.html is added to see the orgin work!

2014-11-25 Thread Wolfgang Link
From: Alexandre Derumier "This patch series add code to send command to quest guest agent. The procotol is qmp, so I have reuse as much as possible the current qmpclient the only big difference is that we can't pass an id to a request, so we must send a guest-sync command with an id before the

[pve-devel] [PATCH] Fix in PVE::QemuServer::snapshot_create

2014-12-03 Thread Wolfgang Link
remove the freezefs flag. If Qemu Guest Agent flag is set in config the vm filesystem will always be frozen. also remove param freezefs in PVE::API2 snapshot, because there is no use for it. Signed-off-by: Wolfgang Link --- PVE/API2/Qemu.pm |7 +-- PVE/QemuServer.pm |8

[pve-devel] [PATCH] add fence_pve to debian/rules

2014-12-04 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- debian/rules |1 + 1 file changed, 1 insertion(+) diff --git a/debian/rules b/debian/rules index e9d4758..5b61377 100755 --- a/debian/rules +++ b/debian/rules @@ -34,6 +34,7 @@ lpar \ manual \ netio \ ovh\ +pve

[pve-devel] [PATCH] Add qga freeze in vzdump in snapshot mode

2014-12-08 Thread Wolfgang Link
it will freeze the filesystem to provide consistents. Signed-off-by: Wolfgang Link --- PVE/VZDump/QemuServer.pm | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index fd36c69..2c62de3 100644 --- a/PVE

[pve-devel] [PATCH] Add qga freeze in vzdump in snapshot mode

2014-12-09 Thread Wolfgang Link
it will freeze the filesystem to provide consistents. Signed-off-by: Wolfgang Link --- PVE/VZDump/QemuServer.pm | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index fd36c69..b9edea1 100644 --- a/PVE

[pve-devel] [PATCH] implement the command get_link_status to qemu-kve paket. so you can call per QMP. this funktion is not implemented in monitor. this command return the state of the given nic to che

2014-12-11 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- debian/patches/add-qmp-get-link-status.patch | 98 ++ debian/patches/series|1 + 2 files changed, 99 insertions(+) create mode 100644 debian/patches/add-qmp-get-link-status.patch diff --git a/debian/patches

[pve-devel] [PATCH] Add to config the nic flag link_down=[0|1] also enable nic link if the Flag is set in the config. we use to verify the result the qemu extension get_link_status from or pachtes.

2014-12-22 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- PVE/API2/Qemu.pm | 57 +++-- PVE/QemuServer.pm | 22 - 2 files changed, 76 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 066726d..f3fe3e6 100644

[pve-devel] [PATCH] implement the disconnect nic button on the network edit pannel.

2014-12-22 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- www/manager/Parser.js |5 + www/manager/qemu/NetworkEdit.js |8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manager/Parser.js b/www/manager/Parser.js index 11fbe49..3494637 100644 --- a/www/manager/Parser.js

Re: [pve-devel] backup lock

2014-12-22 Thread Wolfgang Link
Can you pleas post me your version of PVE. pveversion -v because I can't reproduce it at my machine, not on the gui and not at cli. how do you cancel the job manually? Regrades Wolfgang > On December 23, 2014 at 6:36 AM lyt_yudi wrote: > > > > > 在 2014年12月23日,下午1:20,lyt_yudi 写道: > > >

[pve-devel] [PATCH] Change check for better understanding!

2014-12-29 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- PVE/QemuServer.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index cb84f42..9ef186e 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3724,7 +3724,7 @@ sub vm_stop { eval

[pve-devel] [PATCH] Fix backup failure at shutdown.

2014-12-30 Thread Wolfgang Link
This fix include a new function of vzdump. Now you can call vzdump -stop and the backup will be aborted. Also if the pve-manager init script stop the process, vzdump -stop will called. Signed-off-by: Wolfgang Link --- PVE/API2/VZDump.pm |4 PVE/VZDump.pm | 55

[pve-devel] [PATCH] Fix: root can now be disabled in GUI.

2015-01-06 Thread Wolfgang Link
Signed-off-by: Wolfgang Link --- PVE/AccessControl.pm |7 --- 1 file changed, 7 deletions(-) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index db85d08..29dba39 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -356,8 +356,6 @@ sub check_user_enabled

[pve-devel] RFC for ACME DNS Challenge

2019-10-14 Thread Wolfgang Link
This series also includes a new GIT repository on proxdev. The path is staff/wl/pve-acme. The acme_sh project is used as DNS API plugin systems. So we can reuse the already defiend plugins. I deside to install the complett acme_sh scrips so somwone could use it for alternative use. I'm not sure a

[pve-devel] [common 1/9] Add dynamic plugin lookup for ACME

2019-10-14 Thread Wolfgang Link
The dynamic approach reduces failure if new plugins will included. --- src/PVE/ACME.pm| 4 src/PVE/ACME/Challenge.pm | 8 src/PVE/ACME/StandAlone.pm | 4 3 files changed, 16 insertions(+) diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm index 38a14a5..da4cbcc 100644

[pve-devel] [manager 2/6] Pass parameters for use in plugin.

2019-10-14 Thread Wolfgang Link
The node config is required to determine the plugin and possibly to pass plugin specific parameters. --- PVE/API2/ACME.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/API2/ACME.pm b/PVE/API2/ACME.pm index b1bb6261..2c05db9b 100644 --- a/PVE/API2/ACME.pm +++ b/PVE/

<    1   2   3   4   5   6   7   8   9   10   >