[pve-devel] [RFC_V3 qemu-server 0/3] This is the implementation for storage replica in LXC.

2017-04-24 Thread Wolfgang Link
snapshot config handling and include it in pve-guest-common. Wolfgang Link (3): Insert new properties in the Qemu config for the PVE Replica. Integrate replica in the qemu migration. Destroy all remote and local replication datasets when a VM will destroyed. PVE/API2/Qemu.pm | 45

[pve-devel] [RFC_V3 pve-container 2/3] Integrate storage replica in lxc migration.

2017-04-24 Thread Wolfgang Link
Now it is possible to migrate a CT when replica is enabled. It will reduce replication to an minimal amount. --- src/PVE/LXC/Migrate.pm | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index

[pve-devel] [PATCH qemu-server] Fix freeze_needed

2017-07-31 Thread Wolfgang Link
We want freeze the filesystem if the vmstate is not saved, because when we save the state we need not to freeze the filesystem. --- PVE/QemuConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index e327482..e2fa2ba 100644 ---

[pve-devel] [PATCH pve-storage] We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too.

2017-08-23 Thread Wolfgang Link
--- PVE/CLI/pvesm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..6b37c05 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,7 +183,7 @@ __PACKAGE__->register_method ({ base => {

[pve-devel] [PATCH] Add force parameter for delete replica job.

2017-06-08 Thread Wolfgang Link
This parameter is helpful if an unsolvable situation occurs or the vmconfig was delete manually. --- PVE/API2/ReplicationConfig.pm | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/PVE/API2/ReplicationConfig.pm

[pve-devel] [PATCH] Remove debug output

2017-06-08 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index 3ca01c86..eb880fda 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -144,8 +144,6 @@ __PACKAGE__->register_method ({ } } - print

[pve-devel] Small fixes for replica

2017-06-08 Thread Wolfgang Link
Small fixes for replica [PATCH 1/2] Permit set parent_snapname if it is not set. [PATCH 2/2] Fix: list_images returns now a array of hashes so adopt ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH 2/2] Fix: list_images returns now a array of hashes so adopt the code.

2017-06-08 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index 13ef2730..5e57ac48 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -133,9 +133,10 @@ __PACKAGE__->register_method ({ foreach my $storeid

[pve-devel] [PATCH 1/2] Permit set parent_snapname if it is not set.

2017-06-08 Thread Wolfgang Link
--- PVE/Replication.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 9aad67d8..ab55c9bf 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -135,7 +135,8 @@ sub remote_prepare_local_job { push @$cmd, @$volumes if

[pve-devel] [pve-guest-common 1/2] get_jobid

2017-06-09 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 01e7206..b4f0fe9 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -209,6 +209,20 @@ sub check_for_existing_jobs {

[pve-devel] [qemu-server] Qemu implement migration on replicated storage.

2017-06-09 Thread Wolfgang Link
--- PVE/QemuMigrate.pm | 77 -- 1 file changed, 69 insertions(+), 8 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index bf756a6..a303851 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -13,6 +13,9 @@ use

[pve-devel] [pve-container] LXC implement migration on replicated storage

2017-06-09 Thread Wolfgang Link
--- src/PVE/LXC/Migrate.pm | 76 ++ 1 file changed, 70 insertions(+), 6 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 2f0244b..cfca82c 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -10,6

[pve-devel] [pve-guest-common 2/2] set_remote_state

2017-06-09 Thread Wolfgang Link
--- PVE/ReplicationState.pm | 19 +++ 1 file changed, 19 insertions(+) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index be5cf5f..086d62f 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -92,4 +92,23 @@ sub replication_snapshot_name {

[pve-devel] [pve-manager] pvesr set_state

2017-06-09 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index f64a3103..ca8cd59c 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -288,6 +288,38 @@ __PACKAGE__->register_method ({ return

[pve-devel] Migration with replica enable

2017-06-09 Thread Wolfgang Link
This allows to migrate a guest offline, when replica is enabled for this guest. It will only migrate the delta of the storage. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-guest-common 1/5] PVE::ReplicationConfig::find_local_replication_job - new helper

2017-06-20 Thread Wolfgang Link
On 06/20/2017 10:50 AM, Dietmar Maurer wrote: Signed-off-by: Dietmar Maurer --- PVE/ReplicationConfig.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 845d9c3..1e813dd 100644 ---

[pve-devel] [PATCH qemu-server] Change target in replication-state when replication direction is switched.

2017-06-21 Thread Wolfgang Link
This is necessary to avoid a full sync which will fail because the disk already exists. --- PVE/QemuMigrate.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 8e541bf..0c931c5 100644 --- a/PVE/QemuMigrate.pm +++

[pve-devel] [PATCH pve-docs] Documentation for Storage Replication.

2017-06-26 Thread Wolfgang Link
--- pvesr.adoc | 160 - 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a/pvesr.adoc b/pvesr.adoc index e307d0d..9acb8ae 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -6,7 +6,7 @@ pvesr(1) NAME -pvesr - Proxmox VE

[pve-devel] [PATCH pve-guest-common 2/2] Delete unused states.

2017-06-26 Thread Wolfgang Link
Delete all state object, which has no config entry and not updated in the last 24 hours. --- PVE/ReplicationState.pm | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 952d474..ba9d0e1

[pve-devel] [PATCH pve-guest-common 1/2] Add function delete_state

2017-06-26 Thread Wolfgang Link
This function can be used if a state will not longer needed, like if you delete a job. --- PVE/ReplicationState.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 6a743a3..952d474 100644 ---

[pve-devel] Clean up state file

2017-06-26 Thread Wolfgang Link
This patches cleanup the unused stateobj in the state file. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [RFC pve-common] improve error handling.

2017-05-22 Thread Wolfgang Link
Get more information about the function where a timeout occurs. --- src/PVE/Tools.pm | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index f84855d..d3034de 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -88,7 +88,18

[pve-devel] [RFC_V2 pve-common] improve error handling.

2017-05-22 Thread Wolfgang Link
Get more information about the function where a timeout occurs. --- src/PVE/Tools.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index f84855d..df78bb3 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -26,6 +26,7 @@ use

Re: [pve-devel] [PATCH v3 pve-manager 01/23] pvesr: add pve storage replication tool

2017-05-31 Thread Wolfgang Link
On 05/30/2017 03:19 PM, Dietmar Maurer wrote: Just added code to configure jobs. Replication itself is not implemented. Signed-off-by: Dietmar Maurer --- PVE/API2/Cluster.pm | 7 ++ PVE/API2/Makefile | 2 + PVE/API2/Nodes.pm | 7

Re: [pve-devel] [PATCH v3 pve-manager 16/23] PVE::Replication::replicate - implement replicate

2017-05-31 Thread Wolfgang Link
Comment inline On 05/30/2017 03:20 PM, Dietmar Maurer wrote: diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ee0b841b..d235b49d 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -219,12 +219,138 @@ sub prepare { return $last_snapshots; } -sub replicate { -my

[pve-devel] [PATCH pve-manager] Untaint the content of pve-replication-state.json.

2017-05-31 Thread Wolfgang Link
JSON::decode will not untaint the raw text, so we get problems with the last_sync, which we use many times in the code with open3. --- PVE/Replication.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 0787..ce0c863f 100644

[pve-devel] [PATCH pve-manager 1/4] Set $running to 0 if undef.

2017-06-02 Thread Wolfgang Link
check_running returns if the guest is not running undef. In the logfunc we get a undefined warning. To avoid this we can set it to 0. --- PVE/Replication.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ae3b771d..ae486e16 100644 ---

[pve-devel] [PATCH pve-guest-common 2/2] Add check if target exists.

2017-06-02 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 15 +++ 1 file changed, 15 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 87b3710..1a30e81 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -193,6 +193,13 @@ sub guest_exists { } +sub

[pve-devel] [PATCH pve-guest-common 1/2] Add check if guest exists.

2017-06-02 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 15 +++ 1 file changed, 15 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 092c497..87b3710 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -186,6 +186,13 @@ sub check_for_existing_jobs {

[pve-devel] [PATCH pve-manager 3/4] Add a message that deletion a job will take some time.

2017-06-02 Thread Wolfgang Link
--- PVE/API2/ReplicationConfig.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm index 0095bf37..e1623f73 100644 --- a/PVE/API2/ReplicationConfig.pm +++ b/PVE/API2/ReplicationConfig.pm @@ -211,6 +211,7 @@

[pve-devel] [PATCH pve-manager] Add checks when job is created.

2017-06-02 Thread Wolfgang Link
We must know if the target and guest exists to avoid creation faulty jobs. --- PVE/API2/ReplicationConfig.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm index e1623f73..d067356f 100644 --- a/PVE/API2/ReplicationConfig.pm

[pve-devel] [PATCH pve-manager 4/4] Remove guest form replication.cfg it no vms exists.

2017-06-02 Thread Wolfgang Link
--- PVE/Replication.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ae486e16..c0f80778 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -90,8 +90,11 @@ sub job_status { die "internal error - not

[pve-devel] Add job creation checks.

2017-06-02 Thread Wolfgang Link
This checks be should in plugin because they can differ on replication type. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/4] add systemd.timer for pve run

2017-06-02 Thread Wolfgang Link
--- bin/init.d/Makefile | 4 +++- bin/init.d/pvesr.service | 5 + bin/init.d/pvesr.timer | 11 +++ debian/postinst | 4 4 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 bin/init.d/pvesr.service create mode 100644 bin/init.d/pvesr.timer

Re: [pve-devel] [PATCH pve-guest-common 2/2] Add check if target exists.

2017-06-02 Thread Wolfgang Link
And what is about the cross cluster replication? I tried to make it generic. On 06/02/2017 12:10 PM, Dietmar Maurer wrote: +sub target_exists { +my ($class, $target) = @_; + +my $nodelist = PVE::Cluster::get_members(); + +return defined($nodelist->{$target}); +} + This function is

[pve-devel] [PATCH] Remove $vmid form ssh prepare and finalize command.

2017-06-07 Thread Wolfgang Link
--- PVE/Replication.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 37642f57..e0cf02f0 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -116,7 +116,7 @@ sub remote_prepare_local_job { my ($ssh_info, $jobid,

Re: [pve-devel] replica problems

2017-06-01 Thread Wolfgang Link
On 06/01/2017 11:01 AM, Dominik Csapak wrote: hi, i tested the replica patches a bit and noticed following problems: 1. when we have a job with a failcount > 0, we can't delete/disable the job (only manually deleting from /etc/pve/replication.cfg works) This is not implemented yet 2. the

[pve-devel] [PATCHV2 pve-manager Add job creation checks] Add job creation checks.

2017-06-06 Thread Wolfgang Link
We must know if the target and guest exists to avoid creation faulty jobs. --- PVE/API2/ReplicationConfig.pm | 9 + 1 file changed, 9 insertions(+) V2 remove the abstraction in pve-guest- common and check directly. diff --git a/PVE/API2/ReplicationConfig.pm

Re: [pve-devel] [qemu-server 5/5] PVE/QemuMigrate.pm - use PVE::QemuServer::foreach_volid

2017-06-13 Thread Wolfgang Link
See comment inline. On 06/13/2017 08:38 AM, Dietmar Maurer wrote: Signed-off-by: Dietmar Maurer --- PVE/QemuMigrate.pm | 42 +- 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm

[pve-devel] [PATCH pve-container] Add a migration lock to avoid a replication on rollback-time.

2017-06-12 Thread Wolfgang Link
--- src/PVE/API2/LXC/Snapshot.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC/Snapshot.pm b/src/PVE/API2/LXC/Snapshot.pm index d3c1d8e..47da325 100644 --- a/src/PVE/API2/LXC/Snapshot.pm +++ b/src/PVE/API2/LXC/Snapshot.pm @@ -257,7 +257,13 @@

[pve-devel] Make snapshot rollback work with storage replication.

2017-06-12 Thread Wolfgang Link
We remove all local replication snapshots. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-guest-common] Make rollback compatible with storage replica.

2017-06-12 Thread Wolfgang Link
If we rollback we have to clean up all local replication snapshots. --- PVE/AbstractConfig.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm index 08cbb6a..9e2165d 100644 --- a/PVE/AbstractConfig.pm +++ b/PVE/AbstractConfig.pm @@

[pve-devel] [PATCH qemu-server] Add a migration lock to avoid a replication on rollback-time.

2017-06-12 Thread Wolfgang Link
--- PVE/API2/Qemu.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 54db5ab..b5b183f 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3394,7 +3394,12 @@ __PACKAGE__->register_method({

[pve-devel] Add unused disks to get_replicated_volumes

2017-06-12 Thread Wolfgang Link
With this patch all unused disk witch are in the config will also returned when get_replicated_volumes is called. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [qemu-container] Add unused mountpoints.

2017-06-12 Thread Wolfgang Link
We will also replicate unused volumes which are in the config. --- PVE/QemuConfig.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index 8a8cb5b..ab93aea 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -99,6 +99,15 @@ sub

[pve-devel] [pve-container] Add unused mountpoints.

2017-06-12 Thread Wolfgang Link
We will also replicate unused volumes which are in the config. --- src/PVE/LXC/Config.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index fc3a283..fc08172 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1279,6

Re: [pve-devel] [qemu-container] Add unused mountpoints.

2017-06-13 Thread Wolfgang Link
On 06/13/2017 08:44 AM, Dietmar Maurer wrote: On 06/12/2017 04:01 PM, Dietmar Maurer wrote: +# add 'unusedX' volumes to volhash +foreach my $key (keys %$conf) { + my $value = $conf->{$key}; + if ($key =~ m/^unused/) { + my $drive =

Re: [pve-devel] [qemu-container] Add unused mountpoints.

2017-06-12 Thread Wolfgang Link
On 06/12/2017 04:01 PM, Dietmar Maurer wrote: +# add 'unusedX' volumes to volhash +foreach my $key (keys %$conf) { + my $value = $conf->{$key}; + if ($key =~ m/^unused/) { + my $drive = PVE::QemuServer::parse_drive($key, $value); AFAIR $value is already a volid,

Re: [pve-devel] [RFC_V3 pve-storage 6/8] This patch will include storage asynchronous replication.

2017-05-07 Thread Wolfgang Link
ationTools; > > + > > +use warnings; > > +use strict; > > + > > +use PVE::Tools qw(run_command); > > +use PVE::Cluster; > > +use PVE::QemuConfig; > > +use PVE::LXC::Config; > > +use PVE

Re: [pve-devel] [RFC_V3 pve-cluster] Add storage_replication_network to datacenter.cfg

2017-05-07 Thread Wolfgang Link
though it is a good idea to make a separate replica network. So the user can separate the network when they often migrate large VMs. > > On April 24, 2017 at 5:15 PM Wolfgang Link <w.l...@proxmox.com> wrote: > > > > > > This parameter will define the netwo

[pve-devel] [PATCH V3 qemu-server] Remove guest states to ensure no old states are exists

2017-06-27 Thread Wolfgang Link
--- PVE/API2/Qemu.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) PATCH V2 Move delete_guest_states to ensure all checks are past. PATCH V3 Move return diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index da5f5b1..324e802 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm

[pve-devel] [PATCH V3 qemu-server] Remove guest states to ensure no old states are exists

2017-06-27 Thread Wolfgang Link
--- PVE/API2/Qemu.pm | 6 ++ 1 file changed, 6 insertions(+) PATCH V2 Move delete_guest_states to ensure all checks are past. PATCH V3 Move delete_guest_states to ensure all checks are past and config is lock. diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index da5f5b1..182af53 100644

Re: [pve-devel] [PATCH qemu-server] Remove guest states to ensure no old states are exists

2017-06-27 Thread Wolfgang Link
On 06/27/2017 12:57 PM, Dietmar Maurer wrote: PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index da5f5b1..cf21afb 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -449,6 +449,9 @@ __PACKAGE__->register_method({

[pve-devel] [PATCH V2 qemu-server] Remove guest states to ensure no old states are exists

2017-06-27 Thread Wolfgang Link
--- PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) PATCH V2 Move delete_guest_states to ensure all checks are past. diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index da5f5b1..87e618a 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -586,6 +586,9 @@

[pve-devel] [PATCH pve-guest-common] Add new function delete_guest_states.

2017-06-27 Thread Wolfgang Link
--- PVE/ReplicationState.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 5401db6..5e72d6e 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -147,6 +147,18 @@ sub record_job_start {

[pve-devel] [PATCH qemu-server] Remove guest states to ensure no old states are exists

2017-06-27 Thread Wolfgang Link
--- PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index da5f5b1..cf21afb 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -449,6 +449,9 @@ __PACKAGE__->register_method({ $rpcenv->check_pool_exist($pool); }

Re: [pve-devel] RFC bump Version to 2.8.0 OpenvSwitch

2017-09-14 Thread Wolfgang Link
intro/install/dpdk/ Debian has only 16.11.1 in stretch. > I had sent a patch some months ago > > https://pve.proxmox.com/pipermail/pve-devel/2017-April/026089.html > > It's only add support to dpdk, but don't enable it by default, so I think > it's quite safe. > > >

[pve-devel] [PATCH V5 pve-common 2/2] Extend the JSON format schema with pve-base-snapshot.

2017-09-18 Thread Wolfgang Link
A base snapshot can be a replication snapshot or a normal snapshot. --- src/PVE/JSONSchema.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 996aef2..2ed5b9a 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@

[pve-devel] [PATCH V5 pve-storage] Use a json format instead of hard code regex.

2017-09-18 Thread Wolfgang Link
--- PVE/CLI/pvesm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..57d10f4 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,7 +183,7 @@ __PACKAGE__->register_method ({ base => {

[pve-devel] [PATCH V5 pve-container] Move option 'pve-lxc-snapshot-name' to PVE::JSONSchema.

2017-09-18 Thread Wolfgang Link
Rename pve-lxc-snapshot-name to pve-snapshotname to have a unified name schema. --- src/PVE/API2/LXC.pm | 4 ++-- src/PVE/API2/LXC/Snapshot.pm | 12 ++-- src/PVE/LXC/Config.pm| 6 -- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/PVE/API2/LXC.pm

[pve-devel] [PATCH V5 qemu-server] Move option 'pve-snapshot-name' to PVE::JSONSchema.

2017-09-18 Thread Wolfgang Link
To avoid update problems rename pve-snapshot-name to pve-snapshotname. --- PVE/API2/Qemu.pm | 16 PVE/QemuServer.pm | 8 +--- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 66ffc07..761120c 100644 ---

[pve-devel] [PATCH V5 pve-common 1/2] merge pve-snapshot-name and pve-lxc-snapshot-name to pve-snapshotname.

2017-09-18 Thread Wolfgang Link
This format was two time declared in PVE::LXC::Config and PVE::QemuServer. It is necessary to call the new option different to avoid upgrade problems. --- src/PVE/JSONSchema.pm | 17 + 1 file changed, 17 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm

[pve-devel] [PATCH V5 pve-manager] Adjust the option name to a new name scheme.

2017-09-18 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index 7da94404..1ed3d535 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -75,7 +75,7 @@ __PACKAGE__->register_method ({ minimum => 0,

[pve-devel] Adapt regex in pvesm import/export.

2017-09-18 Thread Wolfgang Link
We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too. [PATCH V2] Use JSON schema instead of hardcoding. [PATCH V3 pve-storage] Correct typo. [PATCH V4] Make base snapshot more specific. [PATCH V5] Merge pve-lxc-snapshot-name and

[pve-devel] [PATCH pve-manager] Clean up unnecessary code.

2017-09-19 Thread Wolfgang Link
The jobid is already parsed by the file parser. --- PVE/API2/Replication.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index 15499508..f396615d 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -60,8 +60,6 @@ sub

Re: [pve-devel] [PATCH V5 qemu-server] Move option 'pve-snapshot-name' to PVE::JSONSchema.

2017-09-21 Thread Wolfgang Link
> Wolfgang Bumiller <w.bumil...@proxmox.com> hat am 21. September 2017 um 09:25 > geschrieben: > > > On Mon, Sep 18, 2017 at 11:52:48AM +0200, Wolfgang Link wrote: > > To avoid update problems rename pve-snapshot-name to pve-snapshotname. > > When not renamin

[pve-devel] [PATCH pve-guest-common] Add logfunc in storage_migration.

2017-10-10 Thread Wolfgang Link
This will redirect export and import output to the correct log, instead of paring it into the syslog. --- PVE/Replication.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..c25ed44 100644 --- a/PVE/Replication.pm

[pve-devel] [PATCH pve-storage] Add logfung in storage_migrate

2017-10-10 Thread Wolfgang Link
The log function is used by storage replication to redirect the output in the correct log. --- PVE/Storage.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b226082..94be04e 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -536,7

[pve-devel] Add logfunc to storage_migrate.

2017-10-10 Thread Wolfgang Link
This redirect the output form pvesm export to the correct log instead of the syslog. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager V3 1/2] Indentation cleanup.

2017-10-17 Thread Wolfgang Link
--- PVE/API2/Replication.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index f396615d..38449892 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -77,15 +77,15 @@ sub run_jobs { my

[pve-devel] [PATCH guest-common V3] Remove noerr form replication.

2017-10-17 Thread Wolfgang Link
We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..0650726 100644 --- a/PVE/Replication.pm +++

[pve-devel] PVE Replica email notification on failure.

2017-10-17 Thread Wolfgang Link
Now you get a email if a replication job fail. The mail is only send the first time, when a job switched from ok state in error state. No more notification will come when a job with error state retry to sync. [PATCH manager V2] Indentation cleanup. Small clenup like W.Bumiller has suggested.

[pve-devel] [PATCH manager V3 2/2] Send an email when a replication job fails.

2017-10-17 Thread Wolfgang Link
A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27

[pve-devel] [PATCH guest-common V2] Remove noerr form replication.

2017-10-17 Thread Wolfgang Link
We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..2b3df36 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@

[pve-devel] [PATCH manager V2 1/2] Indentation cleanup.

2017-10-17 Thread Wolfgang Link
--- PVE/API2/Replication.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index f396615d..38449892 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -77,15 +77,15 @@ sub run_jobs { my

[pve-devel] PVE Replica email notification on failure.

2017-10-17 Thread Wolfgang Link
[PATCH manager V2] Indentation cleanup. Small clenup like W.Bumiller has suggested. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager V2 2/2] Send an email when a replication job fails.

2017-10-17 Thread Wolfgang Link
A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27

[pve-devel] PVE Replica Email notification on failure.

2017-10-13 Thread Wolfgang Link
Now you get a email if a replication job fail. The mail is only send the first time, when a job switched from ok state in error state. No more notification will come when a job with error state retry to sync. ___ pve-devel mailing list

[pve-devel] [PATCH guest-common] Send email when a replication job fails.

2017-10-13 Thread Wolfgang Link
A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27

[pve-devel] [PATCH guest-common] Remove noerr form replication.

2017-10-13 Thread Wolfgang Link
We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..2b3df36 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@

[pve-devel] [PATCH] Exclude .zfs folder which is located on zfs subvolume.

2017-09-06 Thread Wolfgang Link
The .zfs snapdir is usually hidden, but if it is set to "visible", we can back it up. This increases the amount of backup space and makes restoration impossible. We will exclude only the .zfs in the root of the mountponit and in all other volumes which are mounted in the container. This applies

[pve-devel] Adapt regex in pvesm import/export.

2017-09-12 Thread Wolfgang Link
We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too. [PATCH V2] Use JSON schema instead of hardcoding. [PATCH V3 pve-storage] Correct typo. [PATCH V4] Make base snapshot more specific. ___

[pve-devel] [PATCH V4 pve-common] Extend the JSON format schema with pve_base_snapshot.

2017-09-12 Thread Wolfgang Link
A base snapshot can be a replication snapshot or a normal snapshot. Normal snapshots use the format configid. --- src/PVE/JSONSchema.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 3295599..501f0fa 100644 ---

[pve-devel] [PATCH V4 pve-storage] Use json format instead of hard code regex.

2017-09-12 Thread Wolfgang Link
--- PVE/CLI/pvesm.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..12e68fc 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,8 +183,7 @@ __PACKAGE__->register_method ({ base => {

[pve-devel] [PATCH 2/4] Change dependency.

2017-09-13 Thread Wolfgang Link
The new Package libopenvswitch need not libssl-dev package. Libssl1.1 ok and will not install a new package. Libssl-dev is need for the libopenvswitch. --- pvepatches/remove-unneeded-from-control.patch | 17 + 1 file changed, 17 insertions(+) diff --git

[pve-devel] [PATCH 3/4] Remove unneeded packages.

2017-09-13 Thread Wolfgang Link
--- pvepatches/remove-unneeded-from-control.patch | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/pvepatches/remove-unneeded-from-control.patch b/pvepatches/remove-unneeded-from-control.patch index 7d68ae8..ddf8ac4 100644 ---

[pve-devel] RFC bump Version to 2.8.0 OpenvSwitch

2017-09-13 Thread Wolfgang Link
To build the package "make download" must be called first. openvswitch tarball is not included. This series bump the openvswitch version to 2.8.0. Fix an unsightly dependency in the deb package. Remove new packages wich are not supported by us. ___

[pve-devel] [PATCH V6 common 1/2] merge pve-snapshot-name and pve-lxc-snapshot-name to pve-snapshot-name.

2017-09-25 Thread Wolfgang Link
This format was two time declared in PVE::LXC::Config and PVE::QemuServer. --- src/PVE/JSONSchema.pm | 17 + 1 file changed, 17 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 3295599..5b1d59e 100644 --- a/src/PVE/JSONSchema.pm +++

[pve-devel] [PATCH V6 common 2/2] Extend the JSON format schema with pve_base_snapshot.

2017-09-25 Thread Wolfgang Link
A base snapshot can be a replication snapshot or a normal snapshot. Normal snapshots use the format configid. --- src/PVE/JSONSchema.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 5b1d59e..fdf8119 100644 ---

[pve-devel] [PATCH V6 qemu-server] Move option 'pve-snapshot-name' to PVE::JSONSchema.

2017-09-25 Thread Wolfgang Link
--- PVE/QemuServer.pm | 6 -- 1 file changed, 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2b6fda9..bd4f6cd 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -62,12 +62,6 @@ PVE::JSONSchema::register_standard_option('pve-qm-stateuri', { optional => 1,

[pve-devel] [PATCH V6 container] Move option 'pve-lxc-snapshot-name' to PVE::JSONSchema.

2017-09-25 Thread Wolfgang Link
Rename pve-lxc-snapshot-name to pve-snapshot-name to have a unified name schema. --- src/PVE/API2/LXC.pm | 4 ++-- src/PVE/API2/LXC/Snapshot.pm | 12 ++-- src/PVE/LXC/Config.pm| 6 -- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git

[pve-devel] [PATCH V6 storage] Use a json format instead of hard code regex.

2017-09-25 Thread Wolfgang Link
--- PVE/CLI/pvesm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..57d10f4 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,7 +183,7 @@ __PACKAGE__->register_method ({ base => {

[pve-devel] [PATCH guest-common] Send email when a replication job fails.

2017-10-03 Thread Wolfgang Link
A email notification will be send for each job when the job fails. This message will continued as long the job is failing. --- PVE/Replication.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..0075b45 100644 ---

Re: [pve-devel] [PATCH guest-common] Send email when a replication job fails.

2017-10-03 Thread Wolfgang Link
> Philip Abernethy <p.aberne...@proxmox.com> hat am 3. Oktober 2017 um 10:20 > geschrieben: > > > On Tue, Oct 03, 2017 at 09:55:06AM +0200, Wolfgang Link wrote: > > A email notification will be send for each job when the job fails. > > This message will con

[pve-devel] [PATCH V2 pve-storage] Use json format instead of hard code regex.

2017-08-24 Thread Wolfgang Link
--- PVE/CLI/pvesm.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..66ae955 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,8 +183,7 @@ __PACKAGE__->register_method ({ base => {

[pve-devel] Adapt regex in pvesm import/export.

2017-08-24 Thread Wolfgang Link
We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too. [PATCH V2 pve-storage] Use JSON schema instead of hardcoding. ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH pve-common] Extend JSON format schema with pve_base_snapshot.

2017-08-24 Thread Wolfgang Link
--- src/PVE/JSONSchema.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 3295599..92d60b9 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -163,6 +163,17 @@ sub pve_verify_vmid { return $vmid; }

[pve-devel] Adapt regex in pvesm import/export.

2017-08-25 Thread Wolfgang Link
We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too. [PATCH V2 pve-storage] Use JSON schema instead of hardcoding. [PATCH V3 pve-storage] Correct typo. ___ pve-devel mailing list

[pve-devel] [pve-container] Exclude .zfs dir on vzdump

2017-09-01 Thread Wolfgang Link
The .zfs snapdir is normally hidden, but when it is set to 'visible' we back it up. On restore vzdump try to write .zfs dir what is always read only. --- src/PVE/VZDump/LXC.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index

Re: [pve-devel] ha and zfs replication bug

2017-11-22 Thread Wolfgang Link
Hi Alexandre, > Is it a bug or an expected behaviour ? At the moment this is expected behavior. When a HA migration is done the source is offline, so we can't migrate the actual state of this replica job. The replica try to sync a full image what will not work because the image exists on the

<    2   3   4   5   6   7   8   9   10   >