Re: [Pvfs2-developers] the halloween bug fixed

2007-10-05 Thread Murali Vilayannur
Awesome! Great job, Sam! Perhaps, you could also crossport the hash table fixes also along with the fix for this? thanks! Murali On 10/5/07, Sam Lang <[EMAIL PROTECTED]> wrote: > > The halloween bug (what I'm calling it -- its been haunting us for a > while now) is that we're adding address refere

[Pvfs2-developers] Re: the halloween bug fixed

2007-10-05 Thread Sam Lang
On Oct 5, 2007, at 12:14 PM, Sam Lang wrote: On Oct 5, 2007, at 10:49 AM, Sam Lang wrote: The obvious and easy fix is to have bmi-tcp return true from DROP_ADDR_QUERY for all address references. As far as I can tell, the only thing we save by keeping them around is a little memory al

[Pvfs2-developers] Re: the halloween bug fixed

2007-10-05 Thread Sam Lang
On Oct 5, 2007, at 10:49 AM, Sam Lang wrote: The obvious and easy fix is to have bmi-tcp return true from DROP_ADDR_QUERY for all address references. As far as I can tell, the only thing we save by keeping them around is a little memory allocation (the socket gets closed either way).

Re: [Pvfs2-developers] the halloween bug fixed

2007-10-05 Thread Rob Ross
Well done Sam; thanks for tracking this one down. -- Rob Sam Lang wrote: The halloween bug (what I'm calling it -- its been haunting us for a while now) is that we're adding address references to the bmi address list, and never removing them. In the prelude state machine, we make a BMI_set_

[Pvfs2-developers] the halloween bug fixed

2007-10-05 Thread Sam Lang
The halloween bug (what I'm calling it -- its been haunting us for a while now) is that we're adding address references to the bmi address list, and never removing them. In the prelude state machine, we make a BMI_set_info(addr, BMI_INC_ADDR_REF) call, which iterates through all the addr