Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-12-01 Thread Sam Lang
On Nov 30, 2006, at 6:11 PM, Murali Vilayannur wrote: Hi Sam, Looks good. It fixes the I/O errors on ppc64, right? Check it in! Also check in the things that I had sent you earlier (changing ssize_t * to a size_t *) if you deem necessary. I changed them all too longs as you suggested. The fi

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Murali Vilayannur
Hi Sam, Looks good. It fixes the I/O errors on ppc64, right? Check it in! Also check in the things that I had sent you earlier (changing ssize_t * to a size_t *) if you deem necessary. thanks! Murali On 11/30/06, Sam Lang <[EMAIL PROTECTED]> wrote: woops. Sorry about that. -sam On Nov 30

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Sam Lang
woops. Sorry about that. -sam ppc64-slang-fixes.patch Description: Binary data On Nov 30, 2006, at 5:52 PM, Sam Lang wrote: Hi Murali, I think you're on the right track, it looks like its a casting problem from int to long, but the bug appears to be in the nr_segs parameter passed

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Sam Lang
Hi Murali, I think you're on the right track, it looks like its a casting problem from int to long, but the bug appears to be in the nr_segs parameter passed to wait_for_io and then copy_iovec_from_user. The attached patch fixes the error, as well as changes all the unsigned long variab

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Sam Lang
I'm able to reproduce this on ppc64 with both 2.6.0 and HEAD, so the branch you're using turns out not to be the issue. I'll work with Murali (try his patch :-)) to get this fixed. -sam On Nov 30, 2006, at 1:06 PM, kyle schochenmaier wrote: On Nov 30, 2006, at 11:40 AM, Sam Lang wrote:

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread kyle schochenmaier
On Nov 30, 2006, at 11:40 AM, Sam Lang wrote: Hi Kyle, I don't have a fix for your problem yet, but I think the message about "Please make sure that the pvfs2-client is running" is erroneous. The real error is the pvfs_bufmap_copy_iovec_from_user error. I'll look at this tomorrow and

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Murali Vilayannur
Hi guys, drat..there have been so many bugs in the bufmap.c code lately. This must be some data type overflow or something.. Can you try the attached patch and see if it helps.. As an aside, how do we make gcc complain if types don't match perfectly? I am surprised how a size_t* and a ssize_t * pa

Re: [Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Sam Lang
Hi Kyle, I don't have a fix for your problem yet, but I think the message about "Please make sure that the pvfs2-client is running" is erroneous. The real error is the pvfs_bufmap_copy_iovec_from_user error. Also, did you pull from CVS using the pvfs-2-6-0 release tag? If not, the co

[Pvfs2-developers] bufmap_copy_iovec errors?

2006-11-30 Thread Kyle Schochenmaier
I was able to get the client finally built and mounted this morning for 2.6.0-cvs, and ran across this problem whenever trying to write/read through the vfs to the mount: *I'm running a biarch debian-ppc64 setup on the client, which has worked in the past on 2.5-cvs. pvfs2_bufmap_copy_iovec_fr