[pypy-commit] pypy popen2-removal: Use subprocess instead of the deprecated popen2 inside posix.popen(). The 'signal' and 'select' modules are included in the tests as they're imported by subprocess.

[jphalip]

Author: Julien Phalip <jpha...@gmail.com>
Branch: popen2-removal
Changeset: r60893:82e23579d3e9
Date: 2013-02-05 21:12 -0800
http://bitbucket.org/pypy/pypy/changeset/82e23579d3e9/

Log:    Use subprocess instead of the deprecated popen2 inside
        posix.popen(). The 'signal' and 'select' modules are included in the
        tests as they're imported by subprocess.

diff --git a/pypy/module/posix/app_posix.py b/pypy/module/posix/app_posix.py
--- a/pypy/module/posix/app_posix.py
+++ b/pypy/module/posix/app_posix.py
@@ -140,7 +140,7 @@
 
         Open a pipe to/from a command returning a file object."""
 
-        from popen2 import MAXFD
+        from subprocess import MAXFD
         import os, gc
 
         def try_close(fd):
diff --git a/pypy/module/posix/test/test_posix2.py 
b/pypy/module/posix/test/test_posix2.py
--- a/pypy/module/posix/test/test_posix2.py
+++ b/pypy/module/posix/test/test_posix2.py
@@ -14,7 +14,7 @@
 import signal
 
 def setup_module(mod):
-    usemodules = ['binascii', 'posix', 'struct', 'rctime']
+    usemodules = ['binascii', 'posix', 'struct', 'rctime', 'signal', 'select']
     if os.name != 'nt':
         usemodules += ['fcntl']
     else:
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
http://mail.python.org/mailman/listinfo/pypy-commit