Author: Brian Kearns <bdkea...@gmail.com>
Branch:
Changeset: r61311:46b70943f54b
Date: 2013-02-16 04:28 -0500
http://bitbucket.org/pypy/pypy/changeset/46b70943f54b/
Log: wrap the exception in signals_exit
diff --git a/pypy/interpreter/miscutils.py b/pypy/interpreter/miscutils.py
--- a/pypy/interpreter/miscutils.py
+++ b/pypy/interpreter/miscutils.py
@@ -20,10 +20,10 @@
def signals_enabled(self):
return True
- def enable_signals(self):
+ def enable_signals(self, space):
pass
- def disable_signals(self):
+ def disable_signals(self, space):
pass
def getallvalues(self):
diff --git a/pypy/module/__pypy__/interp_signal.py
b/pypy/module/__pypy__/interp_signal.py
--- a/pypy/module/__pypy__/interp_signal.py
+++ b/pypy/module/__pypy__/interp_signal.py
@@ -1,6 +1,6 @@
def signals_enter(space):
- space.threadlocals.enable_signals()
+ space.threadlocals.enable_signals(space)
def signals_exit(space, w_ignored1=None, w_ignored2=None, w_ignored3=None):
- space.threadlocals.disable_signals()
+ space.threadlocals.disable_signals(space)
diff --git a/pypy/module/__pypy__/test/test_signal.py
b/pypy/module/__pypy__/test/test_signal.py
--- a/pypy/module/__pypy__/test/test_signal.py
+++ b/pypy/module/__pypy__/test/test_signal.py
@@ -3,18 +3,6 @@
from pypy.module.thread.test.support import GenericTestThread
-class TestThreadSignal:
- spaceconfig = dict(usemodules=['__pypy__', 'thread'])
-
- def test_exit_twice(self, space):
- from pypy.module.__pypy__.interp_signal import signals_exit,
signals_enter
- signals_exit(space)
- try:
- raises(KeyError, signals_exit, space)
- finally:
- signals_enter(space)
-
-
class AppTestMinimal:
spaceconfig = dict(usemodules=['__pypy__'])
@@ -28,6 +16,14 @@
class AppTestThreadSignal(GenericTestThread):
spaceconfig = dict(usemodules=['__pypy__', 'thread', 'signal', 'time'])
+ def test_exit_twice(self):
+ from __pypy__ import thread
+ thread._signals_exit()
+ try:
+ raises(KeyError, thread._signals_exit)
+ finally:
+ thread._signals_enter()
+
def test_enable_signals(self):
import __pypy__, thread, signal, time
diff --git a/pypy/module/thread/threadlocals.py
b/pypy/module/thread/threadlocals.py
--- a/pypy/module/thread/threadlocals.py
+++ b/pypy/module/thread/threadlocals.py
@@ -1,4 +1,5 @@
from rpython.rlib import rthread
+from pypy.interpreter.error import OperationError
class OSThreadLocals:
@@ -54,14 +55,18 @@
def signals_enabled(self):
return rthread.get_ident() in self._signalsenabled
- def enable_signals(self):
+ def enable_signals(self, space):
ident = rthread.get_ident()
old = self._signalsenabled.get(ident, 0)
self._signalsenabled[ident] = old + 1
- def disable_signals(self):
+ def disable_signals(self, space):
ident = rthread.get_ident()
- new = self._signalsenabled[ident] - 1
+ try:
+ new = self._signalsenabled[ident] - 1
+ except KeyError:
+ raise OperationError(space.w_KeyError, space.wrap(
+ "cannot disable signals in thread not enabled for signals"))
if new > 0:
self._signalsenabled[ident] = new
else:
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
http://mail.python.org/mailman/listinfo/pypy-commit
