Re: [pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread wlavrijsen
Hi Amaury, Bah, isinstance(x, (int,long)) is not RPython. isinstance(x, int) or isinstance(x, long) should be used instead. yes, that got me further. There was one more fix needed, done by Armin. Back in business now, thanks all! Best regards, Wim -- wlavrij...@lbl.gov--+1

Re: [pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread Amaury Forgeot d'Arc
2012/3/14 : > [translation:ERROR]  TypeError': issubclass() arg 1 must be a class > [translation:ERROR]     .. v2364 = simple_call((builtin_function_or_method > isinstance), r_0, ((, ))) > [translation:ERROR]     .. '(pypy.rlib.rarithmetic:139)is_valid_int' > [translation:ERROR] Processing block:

Re: [pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread wlavrijsen
Hi Anto, uhm, it's possible that these are related to the recent changes by Christian about int/long on win64. If they break the translation, we should revert them. I was first thinking that it's just a warning, but further downstream, the translation still fails for me (translation of default

Re: [pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread Antonio Cuni
On 03/14/2012 06:11 PM, wlavrij...@lbl.gov wrote: > Hi Anto, > > thanks, default at least seems to work (so far), other than a couple: > > [annrpython:WARNING] (pypy.objspace.std.objspace:148)wrap__str at 0x43e7eb0> op=0/ isinstance(., > long) is not RPython > > warnings. I'll merge again and s

Re: [pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread wlavrijsen
Hi Anto, thanks, default at least seems to work (so far), other than a couple: [annrpython:WARNING] op=0/ isinstance(., long) is not RPython warnings. I'll merge again and see where that gets me. :) Best regards, Wim -- wlavrij...@lbl.gov--+1 (510) 486 6411--www.lav

Re: [pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread Antonio Cuni
Hi Wim, On 03/14/2012 05:53 PM, wlavrij...@lbl.gov wrote: > Hi, > > the new "mixin" base classes for the new W_StringObject hierarchy are > missing a "_mixin_=True" statement, leading to the error message below. > > I added those statements (also needed in the mixin base class), but that > still

[pypy-dev] base class hierarchy for string objects breaks translation

2012-03-14 Thread wlavrijsen
Hi, the new "mixin" base classes for the new W_StringObject hierarchy are missing a "_mixin_=True" statement, leading to the error message below. I added those statements (also needed in the mixin base class), but that still was not enough to get the translation much further. Ideas, fix? Thank