[pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107

2017-06-24 Thread RonnyPfannschmidt
Hi everyone, after investigating the issue i pretty much had to deduce that a horrible mistake happened while doing the python3 port, and the write method was a complete and broken mess ever since working only by accident on ascii inputs any sane fix needs a break in api and so i propose deprecat

Re: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107

2017-06-24 Thread Florian Schulze
Could this issue be related, or even be the same? https://github.com/tox-dev/tox/issues/426 Regards, Florian Schulze On 24 Jun 2017, at 15:39, RonnyPfannschmidt wrote: > Hi everyone, > > after investigating the issue i pretty much had to deduce that a > horrible mistake happened while doing the

Re: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107

2017-06-24 Thread Bruno Oliveira
Hi Ronny, Not sure about removing as it will break things that are working even if by accident. I don't see any problem about deprecating it and warning about not using it in new code. Cheers On Sat, Jun 24, 2017 at 10:39 AM RonnyPfannschmidt < [email protected]> wrote: > Hi every

Re: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107

2017-06-24 Thread RonnyPfannschmidt
nope, terminalwriter is a different ruin Am 24.06.2017 um 16:50 schrieb Florian Schulze: > Could this issue be related, or even be the same? > https://github.com/tox-dev/tox/issues/426 > > Regards, > Florian Schulze > > > On 24 Jun 2017, at 15:39, RonnyPfannschmidt wrote: > >> Hi everyone, >>

Re: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107

2017-06-24 Thread holger krekel
Hi Bruno, Ronny, On Sat, Jun 24, 2017 at 14:51 +, Bruno Oliveira wrote: > Hi Ronny, > > Not sure about removing as it will break things that are working even if by > accident. I don't see any problem about deprecating it and warning about > not using it in new code. ... maybe simply document

Re: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107

2017-06-24 Thread Bruno Oliveira
On Sat, Jun 24, 2017 at 2:31 PM holger krekel wrote: > ... maybe simply documenting the new methods (write_bytes/write_text i > guess) > and not mentioning the old methods anymore but not removing/changing them. > That has happened several times and i think it's a good approach. > I agree, but i

[pytest-dev] removing py.path.svn* - since its unmaintained and broken since years

2017-06-24 Thread RonnyPfannschmidt
hi all, i'd like to remove that code - its broken since years and im not aware of anyone wanting to fix/maintain it as it is now a deadweight i'd like to see it removed -- Ronny ___ pytest-dev mailing list [email protected] https://mail.python.org

Re: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years

2017-06-24 Thread Bruno Oliveira
Is it giving maintenance problems? On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt < [email protected]> wrote: > hi all, > > i'd like to remove that code - its broken since years and im not aware > of anyone wanting to fix/maintain it > as it is now a deadweight i'd like to see it

Re: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years

2017-06-24 Thread RonnyPfannschmidt
its dead code nobody wants to fix, as such its about the same as a unpaid debt incurring interests Am 24.06.2017 um 20:27 schrieb Bruno Oliveira: > Is it giving maintenance problems? > > On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt > > wrote: > >

Re: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years

2017-06-24 Thread Bruno Oliveira
Giving that, we could just announce that it is unsupported, leave all tests out (or mark them as xfail). I agree that there's no point having it around if it is giving us headaches, but no point also on removing them if it is working out for some people. On Sat, Jun 24, 2017 at 4:35 PM RonnyPfann

Re: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years

2017-06-24 Thread RonnyPfannschmidt
its not working since years, that's why i'd like to remove it Am 24.06.2017 um 21:38 schrieb Bruno Oliveira: > Giving that, we could just announce that it is unsupported, leave all > tests out (or mark them as xfail). > > I agree that there's no point having it around if it is giving us > headac

Re: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years

2017-06-24 Thread Bruno Oliveira
Oh right, I think the tests have been skipped for some time now right? In that case I guess removing the functionality and test cases might make some sense. On Sat, Jun 24, 2017 at 4:44 PM RonnyPfannschmidt < [email protected]> wrote: > its not working since years, that's why i'd l