Re: [pytest-dev] mark fix-up major milestone, please review

Hi Ronny, On Mon, Mar 19 2018, Ronny Pfannschmidt wrote: > Hi everyone, > > in https://github.com/pytest-dev/pytest/pull/3317 i introduced a new way to > store marks and aslo consistently use it (this fixed a few bugs pytest > dragged along since years) I've spent a while reading the PR but to b

Re: [pytest-dev] mark fix-up major milestone, please review

2018-03-20 9:18 GMT+01:00 Floris Bruynooghe : > Hi Ronny, > > On Mon, Mar 19 2018, Ronny Pfannschmidt wrote: > > > Hi everyone, > > > > in https://github.com/pytest-dev/pytest/pull/3317 i introduced a new > way to > > store marks and aslo consistently use it (this fixed a few bugs pytest > > dragg

Re: [pytest-dev] Fixture ordering and scopes

On Sat, Mar 17, 2018 at 6:38 PM Floris Bruynooghe wrote: > > I'm still not following this, I'm probably being silly. You have 4 > autouse session-scoped fixtures but with a dependecy chain as > my_db_setup -> my_setup_logging -> setup_logging and then an unrelated > db_setup. What am I missing

Re: [pytest-dev] Fixture ordering and scopes

On Tue, Mar 20 2018, Bruno Oliveira wrote: > On Sat, Mar 17, 2018 at 6:38 PM Floris Bruynooghe wrote: > >> >> I'm still not following this, I'm probably being silly. You have 4 >> autouse session-scoped fixtures but with a dependecy chain as >> my_db_setup -> my_setup_logging -> setup_logging an

Re: [pytest-dev] Fixture ordering and scopes

On Tue, Mar 20, 2018 at 10:45 AM Floris Bruynooghe wrote: > On Tue, Mar 20 2018, Bruno Oliveira wrote: > > > > @pytest.fixture(scope='session', autouse=True) > > def my_setup_logging(log_setup): pass > > > > @pytest.fixture(scope='session', autouse=True) > > def my_db_setup(my_setup_logging, db_s

Re: [pytest-dev] mark fix-up major milestone, please review

On Tue, Mar 20 2018, Ronny Pfannschmidt wrote: > 2018-03-20 9:18 GMT+01:00 Floris Bruynooghe : >> On Mon, Mar 19 2018, Ronny Pfannschmidt wrote: >> > I also did deprecate markinfo attributes, >> > so everyone using them will get deprecation warnings. >> >> That's a lot of people probably. How lon

Re: [pytest-dev] mark fix-up major milestone, please review

2018-03-20 15:07 GMT+01:00 Floris Bruynooghe : > On Tue, Mar 20 2018, Ronny Pfannschmidt wrote: > > > 2018-03-20 9:18 GMT+01:00 Floris Bruynooghe : > >> On Mon, Mar 19 2018, Ronny Pfannschmidt wrote: > >> > I also did deprecate markinfo attributes, > >> > so everyone using them will get deprecatio

Re: [pytest-dev] mark fix-up major milestone, please review

On 20 Mar 2018, at 15:07, Floris Bruynooghe wrote: On Tue, Mar 20 2018, Ronny Pfannschmidt wrote: 2018-03-20 9:18 GMT+01:00 Floris Bruynooghe : On Mon, Mar 19 2018, Ronny Pfannschmidt wrote: I also did deprecate markinfo attributes, so everyone using them will get deprecation warnings. Tha

Re: [pytest-dev] mark fix-up major milestone, please review

just a quick note - the markers pr as far as i understood it does not qualify for a 4.0 since the basci apis are bckward compatible and work as expected, if we would make it 4.0 worthy, then by dropping the old cruft -- Ronny 2018-03-20 16:03 GMT+01:00 Florian Schulze : > On 20 Mar 2018, at 15:0

Re: [pytest-dev] mark fix-up major milestone, please review

On 20 Mar 2018, at 16:11, Ronny Pfannschmidt wrote: just a quick note - the markers pr as far as i understood it does not qualify for a 4.0 since the basci apis are bckward compatible and work as expected, if we would make it 4.0 worthy, then by dropping the old cruft In my opinion the chang

Re: [pytest-dev] mark fix-up major milestone, please review

again - please show me those changes! -- Ronny 2018-03-20 19:33 GMT+01:00 Florian Schulze : > On 20 Mar 2018, at 16:11, Ronny Pfannschmidt wrote: > > just a quick note - the markers pr as far as i understood it does not >> qualify for a 4.0 since the basci apis are bckward compatible and work as

Re: [pytest-dev] Fixture ordering and scopes

Howdy! On Thu, Mar 15, 2018 at 6:42 PM Bruno Oliveira wrote: > I opened up a PR which > does sort parameters by scope while keeping the relative order of fixtures > of same scope intact, and the test suite passes without failures so if the > curre