Re: [Python-3000] [Python-3000-checkins] r54588

Hello, Sorry if I am wrong, but it seems to me that the change in r54588 has a problem: http://mail.python.org/pipermail/python-3000-checkins/2007-March/000433.html - in the normal case, the return value is INCREF'ed twice - in the error case, Py_INCREF(NULL) is called... One easy way to correct

Re: [Python-3000] [Python-3000-checkins] r54588

On 3/29/07, Amaury Forgeot d'Arc <[EMAIL PROTECTED]> wrote: > Hello, > > Sorry if I am wrong, but it seems to me that the change in r54588 has a > problem: > http://mail.python.org/pipermail/python-3000-checkins/2007-March/000433.html > - in the normal case, the return value is INCREF'ed twice > -

Re: [Python-3000] [Python-3000-checkins] r54588

Thanks Amaury! I've submitted your fix: Committed revision 54609. (Brett's fix would require an additional DECREF when NotImplemented is returned, so Amaury's version is better. I bet a compiler can rearrange the code so that the INCREF code is shared. :-) --Guido On 3/29/07, Brett Cannon <[EMAI