Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Christian Heimes
Guido van Rossum wrote: > - change PyString's repr() to return "b'...'" > - change PyBytes's repr() to return "buffer(b'...')" > - change parser so that b"..." returns PyString, not PyBytes I'll take the three steps. They sound like low hanging fruits even for a noob like me. I expect to have a wo

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Gregory P. Smith
> - add missing methods to PyBytes (for list, see the PEP and compare to > what's already there) > - remove buffer API from PyUnicode I'll take these two with a goal of having them done by the end of the week. -gps ___ Python-3000 mailing list Python-3

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Bill Janssen
I think I can spend some time on the 3K SSL support, but I've been waiting till the "bytes" work settles down. Sounds like I should keep waiting a bit more? Or have the C APIs already settled? Bill ___ Python-3000 mailing list [email protected] ht

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Guido van Rossum
On 10/8/07, Bill Janssen <[EMAIL PROTECTED]> wrote: > I think I can spend some time on the 3K SSL support, but I've been > waiting till the "bytes" work settles down. Sounds like I should > keep waiting a bit more? Or have the C APIs already settled? The C APIs haven't quite settled down yet, bu

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Brett Cannon
On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: [SNIP] > PS. Is there anyone who understands test_urllib2net and can fix it? > It's been failing for weeks (maybe months) now. I don't understand it but I fixed it in r58378. =) When ftplib.FTP was converted over to Py3K it was given a defa

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Guido van Rossum
On 10/8/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > [SNIP] > > PS. Is there anyone who understands test_urllib2net and can fix it? > > It's been failing for weeks (maybe months) now. > > I don't understand it but I fixed it in r58378. =)

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Guido van Rossum
On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > - remove locale support from PyString > - remove compatibility with PyUnicode from PyString > - remove compatibility with PyString from PyUnicode I'll tackle these myself by Friday, unless someone else beats me to it. -- --Guido van Rossu

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Brett Cannon
On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > On 10/8/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > [SNIP] > > > PS. Is there anyone who understands test_urllib2net and can fix it? > > > It's been failing for weeks (maybe mon

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Guido van Rossum
On 10/8/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > On 10/8/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > > On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > > [SNIP] > > > > PS. Is there anyone who understands test_urllib2ne

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Brett Cannon
On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > On 10/8/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > > On 10/8/07, Brett Cannon <[EMAIL PROTECTED]> wrote: > > > > On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > > >

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Neal Norwitz
On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > On 10/7/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > - remove locale support from PyString > > - remove compatibility with PyUnicode from PyString > > - remove compatibility with PyString from PyUnicode > > I'll tackle these myself by

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Oleg Broytmann
On Mon, Oct 08, 2007 at 12:51:59PM -0700, Guido van Rossum wrote: > Cool. Though how do you know it was really latin1? Is there anything > standardized about the encoding used by FTP? There is no. Russian users, e.g., use all encodings - koi8-r, cp1251, utf-8; cp1251 is the most popular here, o

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Alexandre Vassalotti
On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > - remove buffer API from PyUnicode > - change PyString's repr() to return "b'...'" > - change PyBytes's repr() to return "buffer(b'...')" I got patches for these. I plan to submit them for review after doing more testing to make sure they w

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Guido van Rossum
Cool. Just notice that you haven't been following protocol -- Christian Heimes volunteered to do these too. :-) On 10/8/07, Alexandre Vassalotti <[EMAIL PROTECTED]> wrote: > On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > - remove buffer API from PyUnicode > > - change PyString's repr(

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Alexandre Vassalotti
On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > Cool. Just notice that you haven't been following protocol -- > Christian Heimes volunteered to do these too. :-) Oops, sorry Christian for taking yours. -- Alexandre ___ Python-3000 mailing list

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Brett Cannon
On 10/8/07, Alexandre Vassalotti <[EMAIL PROTECTED]> wrote: > On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > Cool. Just notice that you haven't been following protocol -- > > Christian Heimes volunteered to do these too. :-) > > Oops, sorry Christian for taking yours. See http://bugs.

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Alexandre Vassalotti
On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > - change indexing and iteration over PyString to return ints, not > 1-char PyStrings I will try do this one. -- Alexandre ___ Python-3000 mailing list [email protected] http://mail.python.or

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Christian Heimes
Alexandre Vassalotti wrote: > On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: >> Cool. Just notice that you haven't been following protocol -- >> Christian Heimes volunteered to do these too. :-) > > Oops, sorry Christian for taking yours. I've submitted my patch a few hours ago. I wasn't

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Christian Heimes
Brett Cannon wrote: > See http://bugs.python.org/issue1247 for Christian's patch. Maybe you > can do a code review of Christian's work, Alexandre? And if you want > to be really brave you could maybe even do the commit yourself. =) I'm not happy with: static const char *quote_prefix = "buf

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Guido van Rossum
On 10/8/07, Christian Heimes <[EMAIL PROTECTED]> wrote: > Alexandre Vassalotti wrote: > > On 10/8/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > >> Cool. Just notice that you haven't been following protocol -- > >> Christian Heimes volunteered to do these too. :-) > > > > Oops, sorry Christian f

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Alexandre Vassalotti
Ah! In my review, I was going to suggest you that: while (*quote_prefix) *p++ = *quote_prefix++; -- Alexandre On 10/8/07, Christian Heimes <[EMAIL PROTECTED]> wrote: > I'm not happy with: > > static const char *quote_prefix = "buffer(b'"; > p = PyUnicode_AS_UNICODE(v); > for

Re: [Python-3000] PEP 3137 plan of attack

2007-10-08 Thread Marcin ‘Qrczak’ Kowalczyk
Dnia 09-10-2007, Wt o godzinie 01:29 +0200, Christian Heimes pisze: > I'm not happy with: > > static const char *quote_prefix = "buffer(b'"; > p = PyUnicode_AS_UNICODE(v); > for (i=0; i *p++ = quote_prefix[i]; > } strlen in a loop is bad for performance. I would do: