[issue7728] test_timeout should use "find_unused_port" helper

R. David Murray added the comment: Thanks. Committed in r78014, r78015, r78016, and r78017. -- nosy: +r.david.murray resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue7712] Add a context manager to change cwd in test.test_support and run the test suite in a temp dir.

Ezio Melotti added the comment: Here is a patch based on the previous patches and some discussion. I still have to test it better and add a few comments, but it should be almost ok. -- Added file: http://bugs.python.org/file16146/issue7712.diff ___

[issue7864] Deprecation markers in unittest docs are unclear

Justin Lebar added the comment: Oh, I see. I still think a complete sentence would be helpful here, although now that I understand that the colon doesn't mean "use instead" I suppose I'm less confused... -- ___ Python tracker

[issue7864] Deprecation markers in unittest docs are unclear

Ezio Melotti added the comment: > The deprecation warning is confusing, since it appears to suggest that > failUnless is also deprecated. That's exactly what the warning is saying: failUnless() is deprecated since version 3.1. assertTrue and assert_ are ok. -- nosy: +ezio.melotti res

[issue7864] Deprecation markers in unittest docs are unclear

New submission from Justin Lebar : The documentation for assertTrue/assert_/failUnless reads: assertTrue(expr, msg=None) assert_(expr, msg=None) failUnless(expr, msg=None) ... Deprecated since version 3.1: failUnless(). The deprecation warning is confusing, since it appears to suggest t

[issue7588] unittest.TestCase.shortDescription isn't short anymore

Jean-Paul Calderone added the comment: I agree that changing the result object is a better way to implement this feature: if the results object wants to report things by *name*, not *description*, then it should get the test's *name*, not rely on changing the meaning of the test's description

[issue7501] python -m unittest path_to_suite_function errors

Jean-Paul Calderone added the comment: Sounds like one. As far as the trial behavior goes, "trial foo.test_suite" won't work, but "trial foo" will call "foo.test_suite", if one is defined. -- nosy: +exarkun ___ Python tracker

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

Benjamin Peterson added the comment: I'd prefer for the magic context manager to be returned. -- nosy: +benjamin.peterson ___ Python tracker ___ _

[issue7861] 2to3: "import foo" -> "from . import foo"

Benjamin Peterson added the comment: Well, you'll just have to wait for the next version of 2.6 to be released then. -- resolution: -> out of date status: open -> closed ___ Python tracker

[issue7853] on __exit__(), exc_value does not contain the exception.

Benjamin Peterson added the comment: BTW, I'm not going to backport this fix, since the implementation does carry over well to 2.6. Additionally, it is probably an unacceptable change of behavior in a bug fix release. -- ___ Python tracker

[issue7863] platform module doesn't detect Windows 7

Brian Curtin added the comment: Here's a patch which fixes this on trunk. 2.6/3.1 is a different story as there doesn't appear to be a way to get the platform type to differentiate workstation/server. #7766 is what makes it easy on trunk, but it's a new feature and isn't backported. Thoughts

[issue7712] Add a context manager to change cwd in test.test_support and run the test suite in a temp dir.

Changes by Florent Xicluna : -- title: Add a context manager to change cwd in test.test_support -> Add a context manager to change cwd in test.test_support and run the test suite in a temp dir. ___ Python tracker

[issue7712] Add a context manager to change cwd in test.test_support

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file15951/temp_cwd_decorator_v2.diff ___ Python tracker ___ ___ Python-bugs-l

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

Antoine Pitrou added the comment: > I'm not sure what such a test would prove, e.g. on 64-bit Mac OS X, > platform.machine() return 'i386'. That could be mapped to 'x86'... You're right. There doesn't seem to be much consistency accross platforms. > Note that 'x86_64' is just a 'x86' compatibl

[issue7780] unittest: allow an 'import_path' as an alternative to 'top_level_dir' in test discover

Michael Foord added the comment: My suggestion is that test discovery should first try the argument as a directory. If that fails try it as a dotted name by importing it. If the import succeeds discovery can start from the directory containing the imported package. If a module rather than a p

[issue7799] unittest returning standard_tests from load_tests in module fails

Michael Foord added the comment: Fixed in revision 78010. -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker ___

[issue7863] platform module doesn't detect Windows 7

Brian Curtin added the comment: Note that this will also need the Workstation check that 6.0 has right above this, because both Windows 7 and Windows Server 2008 R2 are version 6.1.x. Also of note is that sys.getwindowsversion (renamed as GetVersionEx here) has been expanded to make use of th

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

Marc-Andre Lemburg added the comment: Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > The test could simply check that platform.machine() never returns "x86" when > sys.maxsize is greater than 2**32. > (and it would even be platform-agnostic) I'm not sure what such a test wo

[issue7863] platform module doesn't detect Windows 7

Ezio Melotti added the comment: Confirmed on Python 2.7a2. -- nosy: +brian.curtin, ezio.melotti priority: -> normal stage: -> test needed type: -> behavior versions: +Python 2.7 ___ Python tracker __

[issue7863] platform module doesn't detect Windows 7

Changes by Antoine Pitrou : -- nosy: +lemburg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue7863] platform module doesn't detect Windows 7

New submission from Adal Chiriliuc : Running python 32 bit on Windows 7 64 bit: >>> import platform >>> platform.platform() 'Windows-post2008Server-6.1.7600' Should be corrected to display 'Windows-7-6.1.7600' Fix: >elif maj == 6: >if min == 0: ># ...

[issue7501] python -m unittest path_to_suite_function errors

Michael Foord added the comment: So it's a feature request then... -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue7501] python -m unittest path_to_suite_function errors

Robert Collins added the comment: Its a common convention in zope.testing, trial, testtools, bzr, ... -- ___ Python tracker ___ ___ Py

[issue7588] unittest.TestCase.shortDescription isn't short anymore

Michael Foord added the comment: The problem this fix was trying to fix was that if you provide a docstring for your test then the test name is ommitted in the report. This could be fixed in the _TextTestResult instead - changing the getDescription() method to always include str(test). -

[issue7862] fileio.c: ValueError vs. IOError with impossible operations

Changes by Antoine Pitrou : -- nosy: +amaury.forgeotdarc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue7852] [PATCH] Drop "Computer" from "Apple Computer" in plistlib

Wang Chun added the comment: plutil is a command shipped with every Mac. See the example in my original post. -- ___ Python tracker ___ __

[issue7501] python -m unittest path_to_suite_function errors

Michael Foord added the comment: What made you think that would work? In your example foo.test_suite is neither a test nor a suite but a function. -- ___ Python tracker ___

[issue7030] Update version{added, changed} entries in py3k unittest docs

Ezio Melotti added the comment: You should thank Georg for those, I just fixed the examples in r77968. ;) -- stage: needs patch -> committed/rejected ___ Python tracker ___ _

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Barry, I'm sorry, I only now noticed this line in your compilation on 10.5: /Users/barry/projects/python/python26/Modules/readline.c:41: error: conflicting types for 'completion_matches' This problem was introduced by a patch in issue4204. See my comments

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ned Deily added the comment: It's not a configuration bug. All current python.org python installers are built with MACOSX_DEPLOYMENT_TARGET=10.3 and with the 10.4u SDK to allow one installer to work on systems from 10.3.9 through 10.6. -- nosy: +ned.deily ___

[issue7856] cannot decode from or encode to big5 \xf9\xd8

Roumen Petrov added the comment: > That iconv supports it is not convincing, ... GNU libc is not convincing . What you talking about ? -- nosy: +rpetrov ___ Python tracker ___ _

[issue7030] Update version{added, changed} entries in py3k unittest docs

Michael Foord added the comment: assertSameElements doc issue fixed in revision 77997. Also improved example for assertRaises as a context manager and added versionadded to the test skipping section. Revisions 77999-78002. Thanks for sorting the version changed / added in the Py3k docs Ezio.

[issue4722] _winreg.QueryValue fault while reading mangled registry values

Changes by Brian Curtin : Removed file: http://bugs.python.org/file15960/issue4722.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue7862] fileio.c: ValueError vs. IOError with impossible operations

New submission from Stefan Krah : I think that certain FileIO methods should raise IOError instead of ValueError when a file operation is attempted with the wrong mode. The methods of IOBase are documented to raise IOError in these situations. >>> import io >>> f = io.open("testfile", "w") >>>

[issue7852] [PATCH] Drop "Computer" from "Apple Computer" in plistlib

Changes by Ezio Melotti : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: This is a configuration bug: /Users/barry/projects/python/python26/Modules/readline.c -o build/temp.macosx-10.3-ppc-2.6 ... Why is it trying to build using macosx-10.3 target? I bet if you specify MACOSX_DEPLOYMENT_TARGET=10.5 on the ./configure line it wi

[issue7852] [PATCH] Drop "Computer" from "Apple Computer" in plistlib

Zvezdan Petkovic added the comment: Also, on a Mac computer: - start Xcode 3.2.1 and select Help->Developer Documentation - type in the search box in the top right corner "property list" - the second hit is "Property List Programming Guide"; click on it - the second page gives the same example

[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

Terry J. Reedy added the comment: The doc begins "30.12. dis — Disassembler for Python bytecode The dis module supports the analysis of Python bytecode by disassembling it. Since there is no Python assembler, this module defines the Python assembly language. The Python bytecode which this modu

[issue7852] [PATCH] Drop "Computer" from "Apple Computer" in plistlib

Zvezdan Petkovic added the comment: How about this example from Mac OS X Reference Library "Property List Programming Guide": http://developer.apple.com/mac/library/documentation/Cocoa/Conceptual/PropertyLists/QuickStartPlist/QuickStartPlist.html Perhaps the fact that Apple officially changed

[issue7861] 2to3: "import foo" -> "from . import foo"

Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Barry A. Warsaw added the comment: This worked fine on OS X 10.6, but failed on OS X 10.5: gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/Users/barry/projects/python/python26/./Include -I/Users/barry/projects/python/python26/./Mac/Include -I. -IInclude -I./I

[issue7861] 2to3: "import foo" -> "from . import foo"

Thomas Spura added the comment: #2446 should be related to this one. -- nosy: +David Wolever ___ Python tracker ___ ___ Python-bugs-li

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

Marc-Andre Lemburg added the comment: The patch looks ok. Since we are emulating the Unix uname() function here, we might as well mimic its inconsistencies. Note that platform.machine() and platform.processor() are not really very reliable ways of determining the machine type or processor. -

[issue7861] 2to3: "import foo" -> "from . import foo"

Changes by Ezio Melotti : -- nosy: +benjamin.peterson, ezio.melotti, mark.dickinson priority: -> normal stage: -> needs patch type: compile error -> feature request ___ Python tracker _

[issue7807] test_macostools fails on OS X 10.6: no attribute 'FSSpec'

Zvezdan Petkovic added the comment: This seems to be a 64-bit issue. The 32-bit build passes this test. >>> echo ${TESTPYTHON} ${TESTPROG} ${TESTOPTS} /Users/zvezdan/opt/snapshot/2.6.5/bin/python -E -tt /Users/zvezdan/opt/snapshot/2.6.5/lib/python2.6/test/test_macostools.py -l -uall >>> ${TE

[issue6715] xz compressor support

Changes by Éric Araujo : -- nosy: +Merwok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue5689] please support lzma compression as an extension and in the tarfile module

Changes by Éric Araujo : -- nosy: +Merwok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue7861] 2to3: "import foo" -> "from . import foo"

New submission from Thomas Spura : My custom setup / testcase for testing the transition "import foo" -> "from . import foo": mkdir -p test/sub touch test/sub/__init__.py touch test/__init__.py cat >> test/__init__.py << EOF import sub EOF cat >> test.py << EOF import test EOF This won't wor

[issue6715] xz compressor support

Antoine Pitrou added the comment: There's a Python binding for some lzma lib here: https://launchpad.net/pyliblzma -- ___ Python tracker ___ _

[issue5341] A selection of spelling errors and typos throughout source

Éric Araujo added the comment: Additional note to help reviewing: I changed occurrences of the form “builtin x” to “built-in function x” not because I think the noun “builtin” is incorrect, as you may guess from my first message in this thread, but because it seemed more readable for beginner

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

Antoine Pitrou added the comment: The test could simply check that platform.machine() never returns "x86" when sys.maxsize is greater than 2**32. (and it would even be platform-agnostic) -- ___ Python tracker

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

Antoine Pitrou added the comment: It's also inconsistent with Linux behaviour: >>> import sys >>> sys.maxsize 2147483647 >>> import platform >>> platform.machine() 'x86_64' >>> platform.architecture() ('32bit', 'ELF') (on a Python compiled with "-m32" on a 64-bit Linux) -- nosy: +pit

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

Changes by Antoine Pitrou : -- nosy: +lemburg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue7250] wsgiref.handlers.CGIHandler caches os.environ, leaking info between requests

Guido van Rossum added the comment: Phillip, can you fix this in 2.6, 2.7, 3.1 and trunk? (There are certain rules for merging fixes between branches but I don't recall the details. Contact Benjamin or another active core developer via IRC if you need help.) -- nosy: +gvanrossum

[issue7847] Remove 'python -U' or document it

Barry A. Warsaw added the comment: trunk: r77992 py26: r77993 -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue7852] [PATCH] Drop "Computer" from "Apple Computer" in plistlib

Ezio Melotti added the comment: I did a quick search and couldn't find any reference about this change, the examples in the apple doc still use 'Apple Computer'. Do you have any reference that says that the correct doctype (now) uses only 'Apple'? -- nosy: +ezio.melotti priority: ->

[issue7847] Remove 'python -U' or document it

Barry A. Warsaw added the comment: Martin, thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue7847] Remove 'python -U' or document it

Barry A. Warsaw added the comment: Good point Georg. See updated patch. -- Added file: http://bugs.python.org/file16144/7847-2.patch ___ Python tracker ___ _

[issue7860] 32-bit Python on 64-bit Windows reports incorrect architecture

New submission from Brian Curtin : When running 32-bit Python on a 64-bit version of Windows, therefore running the process in WOW64 mode, platform.machine returns a misleading value. When running in WOW64, the processor architecture is masked to appear as "x86" when the machine is actually "A

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

Raymond Hettinger added the comment: Too clever by far. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7858] os.utime(file, (0, 0, )) fails on on vfat, but doesn't fail immediately

Damien Elmes added the comment: I'm afraid I don't have a Windows build environment handy, but a quick look at the function in question seems to indicate that is the problem. Thanks for the quick reply! -- ___ Python tracker

[issue7858] os.utime(file, (0, 0, )) fails on on vfat, but doesn't fail immediately

Antoine Pitrou added the comment: Looks like a missing "goto done" in posix_utime(), posixmodule.c, line 2805. Could you test the following patch? -- keywords: +patch nosy: +pitrou priority: -> normal stage: -> needs patch type: -> behavior versions: +Python 2.7, Python 3.1, Python

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

Antoine Pitrou added the comment: Indeed. In that case, I am all for it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue5677] Serious interpreter crash and/or arbitrary memory leak using .read() on writable file

Antoine Pitrou added the comment: The patch was committed in r77989 (trunk) and r77990 (2.6). Thank you Stefan! -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

Florent Xicluna added the comment: right, but it could return a wrapper object which receives the exception on __exit__. -- ___ Python tracker ___ __

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

Antoine Pitrou added the comment: You can't get the exception before it is even raised... -- nosy: +pitrou ___ Python tracker ___ ___

[issue7859] support "with self.assertRaises(SomeException) as exc:" syntax

New submission from Florent Xicluna : It would be useful to get the actual exception in order to introspect its attributes. (See some potential uses in "test_dict") -- components: Tests messages: 98882 nosy: flox priority: normal severity: normal status: open title: support "with self.

[issue850997] mbcs encoding ignores errors

Changes by Ezio Melotti : -- nosy: +ezio.melotti versions: +Python 2.7, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue5677] Serious interpreter crash and/or arbitrary memory leak using .read() on writable file

Changes by Stefan Krah : Added file: http://bugs.python.org/file16141/add-readable-writable3.patch ___ Python tracker ___ ___ Python-bugs-list

[issue6760] patch to subprocess docs to better explain Popen's 'args' argument

R. David Murray added the comment: Thanks for catching that. Fixed r77987 r77988. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue7844] Add -3 warning for absolute imports.

Changes by Ezio Melotti : -- nosy: +ezio.melotti priority: -> normal stage: -> needs patch type: -> feature request ___ Python tracker ___ _

[issue5498] Can SGMLParser properly handle tags?

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue6760] patch to subprocess docs to better explain Popen's 'args' argument

Chris Rebert added the comment: One problem with the 3.x versions: the raw_input() should be input(). -- ___ Python tracker ___ ___ Py

[issue7858] os.utime(file, (0, 0, )) fails on on vfat, but doesn't fail immediately

New submission from Damien Elmes : It seems like you can't set a modtime of 0 on a vfat partition. This may not be a valid thing to do, but it took me a long time to figure out it was a bad thing, as the error doesn't appear until the next time the error flag is checked: >>> os.utime("testfil

[issue7857] test_logging fails

Florent Xicluna added the comment: You may use the decorator @unittest.skip("see issue #7857") for these tests, until it's fixed. (or @unittest.expectedFailure, if you want to run them anyway) http://docs.python.org/dev/library/unittest.html#unittest.skip -- _

[issue5498] Can SGMLParser properly handle tags?

Changes by Ezio Melotti : -- priority: -> normal resolution: -> invalid stage: test needed -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue7857] test_logging fails

Vinay Sajip added the comment: Further update done to disable listening tests for now (r77986). Will try to investigate these - the trouble is, they work on my system :-( -- status: pending -> open ___ Python tracker

[issue7857] test_logging fails

Vinay Sajip added the comment: Fix checked into trunk with following changes: - use of test_support.find_unused_port() - if connection is refused, a finally clause shuts down the server thread. Marked as pending awaiting testing of these changes on buildbots. -- resolution: -> fix

[issue5677] Serious interpreter crash and/or arbitrary memory leak using .read() on writable file

Antoine Pitrou added the comment: > I wonder if the ValueError in fileio.c is intentional: I don't know, but this would be the subject of a separate issue anyway. -- ___ Python tracker

[issue5677] Serious interpreter crash and/or arbitrary memory leak using .read() on writable file

Stefan Krah added the comment: Ok, I'll fix that. Perhaps I should also remove the comment in err_mode(). I wonder if the ValueError in fileio.c is intentional: >>> import io >>> f = io.open("testfile", "w") >>> f.write("xxx") 3 >>> f.read() Traceback (most recent call last): File "", line 1

[issue7857] test_logging fails

Florent Xicluna added the comment: It could take benefit of "test_support.find_unused_port". -- components: +Library (Lib) keywords: +buildbot nosy: +flox ___ Python tracker ___

[issue7857] test_logging fails

New submission from Antoine Pitrou : First, listening and/or connecting often fails. Second, the test should use try/finally to release all resources even in case of failure. This is breaking most buildbots currently: http://www.python.org/dev/buildbot/trunk/ [snip] test_listen_config_1_ok (

[issue5677] Serious interpreter crash and/or arbitrary memory leak using .read() on writable file

Antoine Pitrou added the comment: Oh and the following line shouldn't be needed: data = b'xxx' if 'b' in mode else u'xxx' Since old-style file objects always take bytestrings (it's harmless, though, because the unicode string will be implicitly converted). -- ___

[issue5677] Serious interpreter crash and/or arbitrary memory leak using .read() on writable file

Stefan Krah added the comment: Thanks Antoine, I fixed both issues. -- Added file: http://bugs.python.org/file16140/add-readable-writable2.patch ___ Python tracker ___ __