[issue7712] Add a context manager to change cwd in test.test_support and run the test suite in a temp dir.

2010-02-18 Thread Ezio Melotti
Ezio Melotti ezio.melo...@gmail.com added the comment: Ported to py3k in r78214. I will think about the cleanups later, they are not so important right now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7712

[issue5604] imp.find_module() mixes UTF8 and MBCS

2010-02-18 Thread Florent Xicluna
Florent Xicluna la...@yahoo.fr added the comment: Still an issue for some buildbot: http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/1487 http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/1491 It is loosely related with #7712, because now the tests

[issue7956] unittest.Testcase assertDictContainsSubset with integer keys

2010-02-18 Thread Michael Newman
New submission from Michael Newman michael.b.new...@gmail.com: The attached example unit test file shows that assertDictContainsSubset cannot handle error messages that need to show integer keys. Below is the output of the test suite, where test_mixed_keys_fail has an error (code mistake),

[issue7942] Inconsistent error types/messages for __len__ (and __nonzero__) between old and new-style classes

2010-02-18 Thread Paul Boddie
Paul Boddie p...@boddie.org.uk added the comment: Actually, in the issue reported, the initial problem occurs in the evaluation of an object in a boolean context (and the subsequent problem occurs with an explicit len invocation):

[issue7633] decimal.py: type conversion in context methods

2010-02-18 Thread Stefan Krah
Stefan Krah stefan-use...@bytereef.org added the comment: It looks good (I agree on number_class), but I'd change these: - Add raiseit=True to context.copy_decimal() - Remove wrong comment from context.is_infinite() - Add _convert_other(a, raiseit=True) to context.logical_invert() -

[issue5604] imp.find_module() mixes UTF8 and MBCS

2010-02-18 Thread Ezio Melotti
Ezio Melotti ezio.melo...@gmail.com added the comment: Also the test has a few problems: 1) the keys of known_locales are lowercase, but locale_encoding = locale.getpreferredencoding() can return uppercase encodings (e.g. UTF-8); 2) this masks another error: the b'\xe4' is not a valid utf-8

[issue7950] subprocess.Popen documentation should contain a good warning about the security implications when using shell=True

2010-02-18 Thread Christoph Neuroth
Christoph Neuroth christoph.neur...@googlemail.com added the comment: You're right, that has been improved in regard to how you can do it instead. However, I still think it lacks to mention the security risk involved - compare this to e.g. os.tempnam(), which has a warning in a red box.

[issue7950] subprocess.Popen documentation should contain a good warning about the security implications when using shell=True

2010-02-18 Thread Eric Smith
Eric Smith e...@trueblade.com added the comment: If you want to generate some more discussion, I suggest you close this issue and reopen the other one, since that has more people on the nosy list. -- ___ Python tracker rep...@bugs.python.org

[issue7950] subprocess.Popen documentation should contain a good warning about the security implications when using shell=True

2010-02-18 Thread Christoph Neuroth
Christoph Neuroth christoph.neur...@googlemail.com added the comment: Good idea :) -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7950 ___

[issue6760] patch to subprocess docs to better explain Popen's 'args' argument

2010-02-18 Thread Christoph Neuroth
Christoph Neuroth christoph.neur...@googlemail.com added the comment: As recommended by eric.smith on #7950, I'd like to suggest further extending the documentation to include a security warning about (quite easily) possible code injection bugs when using the shell=True parameter (similar to

[issue7633] decimal.py: type conversion in context methods

2010-02-18 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: Tweaked some doctests in r78218: - add integer argument doctest for logical_invert - fix integer literals with a leading zero for the other logical_*** methods, since they're illegal in Python 3. Merged to py3k in r78219. Thanks,

[issue7957] Tutorial issue regarding the sys module

2010-02-18 Thread Ronald Oussoren
Ronald Oussoren ronaldousso...@mac.com added the comment: That's odd, they should exist and do for me: Python 2.6.4 (r264:75821M, Oct 27 2009, 19:48:32) [GCC 4.0.1 (Apple Inc. build 5493)] on darwin Type help, copyright, credits or license for more information. import sys sys.ps1 ' '

[issue7958] test_platform failure on OS X 10.6

2010-02-18 Thread Mark Dickinson
New submission from Mark Dickinson dicki...@gmail.com: With a 64-bit debug non-framework builds of the trunk and py3k, on OS X 10.6, I'm consistently getting the following failure in test_platform: trunk dickinsm$ ./python.exe Lib/test/regrtest.py -uall test_platform test_platform [18064 refs]

[issue7957] Tutorial issue regarding the sys module

2010-02-18 Thread Lucian Ursu
Lucian Ursu lucian_u...@yahoo.com added the comment: Then it must be an issue with my Python. This is what I get. import sys dir(sys) ['__displayhook__', '__doc__', '__excepthook__', '__name__', '__package__', '__stderr__', '__stdin__', '__stdout__', '_clear_type_cache', '_current_frames',

[issue7958] test_platform failure on OS X 10.6

2010-02-18 Thread Ronald Oussoren
Ronald Oussoren ronaldousso...@mac.com added the comment: This test seems to trigger an issue in site.py, adding '-v' to the code that starts the interpreter in test_platform.py gives the following output (amongst a lot more text that doesn't seem to be relevant): 'import site' failed;

[issue6040] bdist_msi does not deal with pre-release version

2010-02-18 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: The problem is that the version number goes into the MSI ProductVersion property, which MUST be numeric, or else Windows will refuse to install the package. So this is not just an arbitrary choice (at least not by bdist_msi). I'm not sure

[issue5839] RegOpenKeyEx key failed on Vista 64Bit with return 2

2010-02-18 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Closing because of lack of feedback. -- nosy: +loewis resolution: - out of date status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5839

[issue7955] TextIOWrapper Buffering Inconsistent Between _io and _pyio

2010-02-18 Thread Andrew McNabb
Andrew McNabb amcn...@mcnabbs.org added the comment: This seems like a common need (particularly for stdout and stderr), and setting `stdout._CHUNK_SIZE = 1` is relying on an implementation detail. 1) Can the documentation for TextIOWrapper be updated to clearly describe this extra buffering

[issue7955] TextIOWrapper Buffering Inconsistent Between _io and _pyio

2010-02-18 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: I agree this deserves documentation. I'm not convinced it's a common need, though. Usually you either use stdin/stdout in binary mode or in text mode, but you don't interleave both quite frequently. -- assignee: - georg.brandl

[issue7955] TextIOWrapper Buffering Inconsistent Between _io and _pyio

2010-02-18 Thread Andrew McNabb
Andrew McNabb amcn...@mcnabbs.org added the comment: I would imagine that this would come up in most programs that read data from a pipe or from a socket (which are binary data) and then output to stdout or stderr. I ran across the problem in my first non-trivial port to Python 3, and it

[issue1540] Refleak tests: test_doctest and test_gc are failing

2010-02-18 Thread Jeremy Hylton
Jeremy Hylton jhyl...@gmail.com added the comment: I'm trying to figure out the attached script. If I run Python 3.0, the script doesn't run because of the undefined gc.DEBUG_OBJECTS. If I just remove that, the script runs without error. Does that mean the problem is fixed? Or is running

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

2010-02-18 Thread Eric Smith
Eric Smith e...@trueblade.com added the comment: At the language summit we okay'd using ctypes in the tests for standard lib modules, specifically for this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1578269

[issue7956] unittest.Testcase assertDictContainsSubset with integer keys

2010-02-18 Thread Michael Foord
Michael Foord mich...@voidspace.org.uk added the comment: Thanks for reporting this. I can fix this particular error easily by repr'ing the keys. In the process I've found another fun way of killing this assert method: one = ''.join(chr(i) for i in range(255)) two = u'\uFFFD'

[issue7959] ctypes memory leak

2010-02-18 Thread Thomas Heller
New submission from Thomas Heller thel...@ctypes.org: This little script 'ctypes-leak.py' leaks memory: import gc from ctypes import * PROTO = WINFUNCTYPE(None) class Test(object): def func(self): pass def __init__(self): self.v = PROTO(self.func) while 1: try:

[issue7960] test.support.captured_output has invalid docstring example

2010-02-18 Thread Michael Newman
New submission from Michael Newman michael.b.new...@gmail.com: test.support.captured_output is not covered in the online documents: http://docs.python.org/3.1/library/test.html http://docs.python.org/dev/py3k/library/test.html However, it does have a docstring in C:\Python31\Lib\test\support.py

[issue7961] Py3k: decoding empty bytestring with invalid encoding throws no error

2010-02-18 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: Specifically, the behaviour comes from an early check for empty strings in the PyUnicode_FromEncodedObject function: /* Convert to Unicode */ if (len == 0) { Py_INCREF(unicode_empty); v = (PyObject *)unicode_empty;

[issue7434] pprint doesn't know how to print a namedtuple

2010-02-18 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Will ponder this a bit more but will likely close this specific request (leaving open the possibility of a more general rewrite of pprint). -- assignee: - rhettinger priority: - low versions: +Python 2.7, Python

[issue7961] Py3k: decoding empty bytestring with invalid encoding throws no error

2010-02-18 Thread Ori Avtalion
Ori Avtalion o...@avtalion.name added the comment: OK. The attached patch removes the empty string check before decoding. I'm not sure where tests should go, since I can only find them in Lib/test/ and this is not a library change. -- keywords: +patch Added file:

[issue1726687] Bug found in datetime for Epoch time = -1

2010-02-18 Thread Alexander Belopolsky
Alexander Belopolsky alexander.belopol...@gmail.com added the comment: I wonder: with year bounds being checked in gettmarg() and mktime accepting arbitrary values for the rest of the tm structure members (at least it appears to on my Mac), is it possible trigger mktime argument out of range?

[issue7961] Py3k: decoding empty bytestring with invalid encoding throws no error

2010-02-18 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: Thanks for the patch. Rather than remove that optimization entirely, I'd consider pushing it into PyUnicode_Decode. All tests (whether for the standard library or for the core) go into Lib/test, so that would be the right place.

[issue7961] Py3k: decoding empty bytestring with invalid encoding throws no error

2010-02-18 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: I take that back: test_codecs_errors isn't the right function to add these tests to. I actually don't see any current tests for invalid codecs. Part of the problem would be coming up with an invalid codec name in the first place: as I

[issue7961] Py3k: decoding empty bytestring with invalid encoding throws no error

2010-02-18 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: And PyUnicode_Decode doesn't look up the encoding in the registry either: that's somewhere in PyCodec_Decode. I'm going to butt out now and leave this to those who know the code better. :) --

[issue7961] Py3k: decoding empty bytestring with invalid encoding throws no error

2010-02-18 Thread Ori Avtalion
Ori Avtalion o...@avtalion.name added the comment: Ignoring the custom utf-8/latin-8 conversion functions, the actual checking if a codec exists is done in Python/codecs.c's PyCodec_Decode. Is that where I should move the aforementioned optimization to? Is it safe to assume that the decoded

[issue2736] datetime needs an epoch method

2010-02-18 Thread Alexander Belopolsky
Alexander Belopolsky alexander.belopol...@gmail.com added the comment: Victor, As you explain in your own documentation, the proposed method is equivalent to ``(time.mktime(self.timetuple()), self.microsecond)``, so all it does is replacing a less than a one-liner. Moreover, I am not sure

[issue7963] Misleading error message from object(arg)

2010-02-18 Thread Alexander Belopolsky
New submission from Alexander Belopolsky alexander.belopol...@gmail.com: object(1) Traceback (most recent call last): File stdin, line 1, in module TypeError: object.__new__() takes no parameters This is misleading because object.__new__() takes one parameter: object.__new__(object)

[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2010-02-18 Thread Vlastimil Brom
Vlastimil Brom vlastimil.b...@gmail.com added the comment: Thanks for fixing the argument positions; unfortunately, it seems, there might be some other problem, that makes my code work differently than the builtin re; it seems, in the character classes the ignorcase flag is ignored somehow:

[issue7250] wsgiref.handlers.CGIHandler caches os.environ, leaking info between requests

2010-02-18 Thread Phillip J. Eby
Phillip J. Eby p...@telecommunity.com added the comment: What sort of test did you have in mind? To test the desired outcome, it seems we'd need to poison os.environ, reload wsgiref.handlers, remove the poison, and then make sure it didn't get in. That seems a bit like overkill (as well as

[issue3132] implement PEP 3118 struct changes

2010-02-18 Thread Meador Inge
Meador Inge mead...@gmail.com added the comment: Mark, I think a lot of this discussion needs to go back to python-dev; with luck, we can get some advice and clarifications from the PEP authors there. So the next step is to kick off a thread on python-dev summarizing the

[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2010-02-18 Thread Matthew Barnett
Matthew Barnett pyt...@mrabarnett.plus.com added the comment: issue2636-20100219.zip is a new version of the regex module. The regex module should give the same results as the re module for backwards compatibility. The ignorecase bug is now fixed. This new version releases the GIL when

[issue7951] Should str.format allow negative indexes when used for __getitem__ access?

2010-02-18 Thread Matthew Barnett
Matthew Barnett pyt...@mrabarnett.plus.com added the comment: On a related note, this doesn't work either: {-1}.format(x, y, z) Traceback (most recent call last): File pyshell#3, line 1, in module {-1}.format(x, y, z) KeyError: '-1' It could return z. It also rejects a leading '+', but

[issue1540] Refleak tests: test_doctest and test_gc are failing

2010-02-18 Thread Jeremy Hylton
Jeremy Hylton jhyl...@gmail.com added the comment: I spent some time to understand the example script today. The specific issue is that a set of objects get put into the list of unreachable objects with finalizers (both Immutable and Finalizer instances). When Cycle's __dict__ is cleared,

[issue7900] posix.getgroups() failure on Mac OS X

2010-02-18 Thread Michael Foord
Michael Foord mich...@voidspace.org.uk added the comment: I'm not seeing the same issue on my Macbook Pro. I can get all this info from my desktop machine (Mac Pro) when I return from PyCon. -- ___ Python tracker rep...@bugs.python.org

[issue1540] Refleak tests: test_doctest and test_gc are failing

2010-02-18 Thread Jeremy Hylton
Jeremy Hylton jhyl...@gmail.com added the comment: One last thought on this bug. The problem is that after we try to delete garbage, we really can't know much about the state of the objects in the finalizers list. If any of the objects that are cleared end up causing a finalizer to run,

[issue7005] ConfigParser does not handle options without values

2010-02-18 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. fdr...@acm.org added the comment: Patch and documentation merged to the py3k branch (r78233). Work on this is complete. -- resolution: - accepted stage: - committed/rejected status: open - closed type: - feature request ___

[issue7904] urlparse.urlsplit mishandles novel schemes

2010-02-18 Thread Senthil Kumaran
Senthil Kumaran orsent...@gmail.com added the comment: Fixed in the r78234 and merged back to other branches. I fell back to RFC's definition of scheme, as anything before the ://. I did not see the need to add s3 specifically as a valid scheme type, because s3 itself is not registered a