Éric Araujo mer...@netwok.org added the comment:
Note: Your patch fixes distutils, but in distutils2 dir_util is gone, use of
its functions replaced by shutil calls or duplicated code with, I’m afraid, the
same isdir/mkdir race condition. I wonder how we could add tests for that
instead.
Éric Araujo mer...@netwok.org added the comment:
instead of waiting for user reports*
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9281
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +merwok, orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8136
___
___
Python-bugs-list
Alexandre Vassalotti alexan...@peadrop.com added the comment:
I have fixed some style nits in your patch. It would be nice to have tests for
the different control paths in instantiate(). But, I realize that would be a
bit annoying.
Apart from that, the patch looks good.
--
Added
Alexandre Vassalotti alexan...@peadrop.com added the comment:
LGTM
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9268
___
___
Python-bugs-list
New submission from Eli Bendersky eli...@gmail.com:
Running:
py3d -m trace -C . --listfuncs trace_target.py
Where py3d points to a freshly compiled Python 3 trunk interpreter, results in
an error:
functions called:
Traceback (most recent call last):
File
Sarth Calhoun whiddersh...@gmail.com added the comment:
Have the same problem. Well, tried to install the 10.3 version over my 64-bit
installation and that had no effect. Not sure how to get IDLE working.
--
nosy: +Sarth.Calhoun
___
Python tracker
Georg Brandl ge...@python.org added the comment:
I don't think a deepcopy of the environment is necessary here. environ.copy()
is just fine. Other than that, I agree with Eric.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
Changes by Kevin Dwyer kevin.p.dw...@gmail.com:
--
nosy: +kevindication
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1327971
___
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +merwok, r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue963906
___
___
Ned Deily n...@acm.org added the comment:
@Sarth: Odd, works for me. Using the standard GUI installer on a
64-bit-capable machine running 10.6.4, I first installed the 10.5 2.7
metapackage and verified that both IDLE.app and /usr/local/bin/idle2.7 fail.
Then, even without manually deleting
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +l0nwlf, merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1685453
___
___
Python-bugs-list mailing
New submission from Antoine Pitrou pit...@free.fr:
os.environ has the same repr as os.environb, that is, it looks as though it's a
mapping of bytes to bytes, while it's a mapping of str to str.
repr(os.environ)[:50]
environ({b'TMP': b'/tmp/', b'XAUTHORITY': b'/var/r
repr(os.environb)[:50]
Éric Araujo mer...@netwok.org added the comment:
I wonder if this bug should be reopened. This behavior does not seem right to
me:
parsing 'merwok'
expected ('merwok', '')
got ('', 'merwok')
parsing 'merwok w...@rusty'
expected ('', 'w...@rusty')
got ('', 'merwok...@rusty')
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1025395
___
___
Python-bugs-list mailing
Eli Bendersky eli...@gmail.com added the comment:
The fix is simple one-liner, so here's a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file18038/issue9282.1.patch
___
Python tracker rep...@bugs.python.org
Stefan Krah stefan-use...@bytereef.org added the comment:
ldd return value check committed in r82927, r82928, r82929 and r82930.
Thanks for reporting this!
--
status: open - closed
___
Python tracker rep...@bugs.python.org
New submission from Dirkjan Ochtman dirk...@ochtman.nl:
The fix for issue4050 broke some of my doctests. Minimal test:
import doctest, inspect
def test():
'''
def x(): pass
inspect.getsource(x)
'def x(): pass\\n'
'''
doctest.run_docstring_examples(test, globals())
This
Changes by Antoine Pitrou pit...@free.fr:
--
priority: normal - critical
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9284
___
___
Stefan Krah stefan-use...@bytereef.org added the comment:
Matt, if you still follow this: Does this problem exist in 2.6/2.7/NetBSD?
I think this should be set to pending.
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
After chatting with Dirkjan, I misunderstood the impact of the patch. It only
occurs when inspect.getsource() is called from a doctest, which isn't a very
common situation.
--
priority: critical - normal
Benjamin Peterson benja...@python.org added the comment:
I'm going to close this because these are mostly incompatible changes that are
too late.
--
nosy: +benjamin.peterson
resolution: - rejected
status: open - closed
___
Python tracker
New submission from Giampaolo Rodola' g.rod...@gmail.com:
A patch including tests is in attachment.
Example usage:
from cProfile import profile
@profile
... def factorial(n):
... n = abs(int(n))
... if n 1:
... n = 1
... x = 1
... for i in range(1, n+1):
...
Mark Sapiro m...@msapiro.net added the comment:
parsing 'merwok'
expected ('merwok', '')
got ('', 'merwok')
I think ('', 'merwok') is the correct result. I think most if not all MUAs/MTAs
will interpret an address without an '@', albeit invalid, as a local-part in
the local domain,
Dirkjan Ochtman dirk...@ochtman.nl added the comment:
Here's a test case that doesn't require doctest trickery:
import inspect, linecache
fn, source = 'test', 'def x(): pass\n'
getlines = linecache.getlines
def monkey(filename, module_globals=None):
if filename == fn:
return
Éric Araujo mer...@netwok.org added the comment:
Thank you for the reply. The problem is that parseaddr is designed to not fail
IIUC, that’s why it may return empty strings. Client code has to check for
these values instead of catching an exception—a mere style issue, weren’t it
for the
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Alexandre,
I am not sure your change form PyObject_Size(args) to Py_SIZE(args) is correct.
As far as I can tell, args come from pickle machine stack without any type
checks. The equivalent code in 2.x cPickle uses
R. David Murray rdmur...@bitdance.com added the comment:
Ezio, it looks like your test for issue 7310 uses exactly the same algorithm as
the code itself does, and thus did not detect this breakage.
--
nosy: +ezio.melotti, r.david.murray
___
Python
New submission from Éric Araujo mer...@netwok.org:
This behavior does not seem right to me:
parsing 'merwok'
expected ('merwok', '')
got ('', 'merwok')
parsing 'merwok w...@rusty'
expected ('', 'w...@rusty')
got ('', 'merwok...@rusty')
(Generated with a small script just doing a
Éric Araujo mer...@netwok.org added the comment:
Copied my inquiry and part of your reply in #9286.
--
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1409460
___
New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp:
Hello. In OtherFileTests.testOpenDir(test_file), if we run this test
in Lib/test, __file__ becomes test_file.py, so os.path.dirname(__file__)
becomes . I think it is better to use os.path.abspath to get valid folder
path for
Éric Araujo mer...@netwok.org added the comment:
Thanks for the report. I have had exceptions in distutils2 tests because of
this exact same thing; my fix was to use “os.path.dirname(__file__) or
os.curdir”. I’ll change that if people more knowledgeable than me say your fix
is better :)
R. David Murray rdmur...@bitdance.com added the comment:
I'm assigning this to myself so I don't lose it. I'll need to incorporate the
intent of the tests and logic into email6. And yes I set 3.3 on
purpose...email6 won't be in 3.2 and I don't want to spend the cycles figuring
out whether
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Applied the patches to the test files for 2.6.5 without patching header.py and
got one failure.
FAIL: test_i18nheader_unicode (email.test.test_email.TestRFC2047)
I also expected a failure from the equivalent test for test_email_renamed,
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Committed in r82931 with small changes based on comments here and on IRC:
1. Annotations are separated from disassembly by spaces without '|'.
2. Made a small improvement to the annotation alignment algorithm. Excessively
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Add Michael Foord to nosy list as he raised #1462106 which refers to #1115886
where msg24154 states fixed this in r54204. Can this be closed?
--
nosy: +BreamoreBoy, michael.foord
versions: +Python 3.2 -Python 2.7, Python 3.1
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
resolution: - fixed
stage: unit test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9268
Michael Foord mich...@voidspace.org.uk added the comment:
On Python 2.6.5:
os.path.splitext('.cshrc')
('.cshrc', '')
I believe this can be closed.
--
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
Stefan Krah stefan-use...@bytereef.org added the comment:
The usage of char in bp_bool will not work if char is unsigned. Hopefully
that is the cause.
--
keywords: +patch
nosy: +skrah
Added file: http://bugs.python.org/file18041/bp_bool.patch
___
Changes by Stefan Krah stefan-use...@bytereef.org:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9277
___
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
I am merging in the nosy list from issue9079 after we had a lengthy discussion
there and on IRC about the best way to share code between stdlib extension
modules.
For the issue9079, we decided to bring the shared code
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
stage: committed/rejected - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9012
___
Reid Kleckner r...@mit.edu added the comment:
I don't imagine this is going into 2.7.0 at this point, so I ported the patch
to py3k. I also added support to check_output for the timeout parameter and
added docs for all of the methods/functions that now take a timeout in the
module.
The
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
It seems that this has been fixed in the py3k branch (r78942). Now both bytes
and unicode are accepted. Can someone check?
--
nosy: +amaury.forgeotdarc
stage: - needs patch
___
Python
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Could the patch be reworked for 3.2?
--
nosy: +BreamoreBoy
versions: +Python 3.2 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1682942
Stefan Krah stefan-use...@bytereef.org added the comment:
'sizeof y' is obviously wrong now in the memcpy. Next attempt.
--
Added file: http://bugs.python.org/file18043/bp_bool2.patch
___
Python tracker rep...@bugs.python.org
Changes by Stefan Krah stefan-use...@bytereef.org:
Removed file: http://bugs.python.org/file18041/bp_bool.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9277
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Could someone please review this patch to typeobject.c.
--
components: +Extension Modules -None
nosy: +BreamoreBoy
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6, Python 3.0
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Drop 2.7 as that's now gone. See also #6952.
--
nosy: +BreamoreBoy
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1699259
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Drop 2.7 as it's gone. See also #1699259.
--
nosy: +BreamoreBoy
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6952
Dirkjan Ochtman dirk...@ochtman.nl added the comment:
Because doctest also monkeypatches linecache, and without monkeypatching
linecache this also fails in 2.6.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9284
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Changed type to behaviour as I see many references to bugs, hence the changes
to versions. This is a massive patch and will be a substancial amount of work
if anyone wishes to take it on.
--
nosy: +BreamoreBoy
type: feature
Reid Kleckner r...@mit.edu added the comment:
I think you forgot to svn add pytime.c before making the diff.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9079
___
R. David Murray rdmur...@bitdance.com added the comment:
Oh, right, I remember that now. Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9284
___
Stefan Krah stefan-use...@bytereef.org added the comment:
[Marc-Andre]
Why not just make the casts in those cases explicit instead of
using Py_CHARMASK ?
I agree that this would be the cleanest solution. It's harder to get
someone to review a larger patch though.
Antoine, I understood that
Mark Lawrence breamore...@yahoo.co.uk added the comment:
The patch adds one line and moves one line in fileobject.c. The rest of the
patch is new tests. I've successfully applied the patch on Windows and the
tests were fine. Can someone kindly repeat the tests on OS X as this is where
the
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I've run an eye over this and don't see any problems, particularly in the light
of msg101043. Only 2.7 is affected as the fix has been backported from py3k.
Please can we go forward with this.
--
nosy: +BreamoreBoy
versions:
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Just a prod in case it has gone under the radar.
--
nosy: +BreamoreBoy
versions: +Python 3.2 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1755841
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Looking at the comments here msg104801 seems like more work needs to be done on
the patch.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1777134
Mark Lawrence breamore...@yahoo.co.uk added the comment:
OP has stated it's ok to close.
--
nosy: +BreamoreBoy
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1200
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I believe 3.2 is still open for new features.
--
nosy: +BreamoreBoy
versions: +Python 3.2 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1343
Alexandre Vassalotti alexan...@peadrop.com added the comment:
The args argument is always a tuple created with Pdata_poptuple(). You can add
an explicit type check. If this check fails a RuntimeError should be raised,
because this would indicate a programming error in pickle.
--
Mark Lawrence breamore...@yahoo.co.uk added the comment:
The attached patch files are small and look ok to me. Could someone with
socket experience please give a yes or no.
--
nosy: +BreamoreBoy
versions: -Python 2.7
___
Python tracker
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Could someone please review these patches as they stand. Will any rework of
the patches be needed to get them into 3.2?
--
nosy: +BreamoreBoy
versions: +Python 3.2 -Python 2.7, Python 3.1
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
As the patch provides some performance increase which has already been proven
to work in 2.6, could we get this into 3.2? I say this because I understand
that performance was degraded in py3k, could this be one of the reasons why?
Mark Lawrence breamore...@yahoo.co.uk added the comment:
@Christian: have you any interest in keeping this open or can it be closed,
gien that the last comment was 2 1/2 years ago?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I suggest that this is closed unless anyone shows an active interest in it.
--
nosy: +BreamoreBoy
status: open - pending
versions: +Python 3.2, Python 3.3 -Python 2.7, Python 3.1
___
Python
Mark Lawrence breamore...@yahoo.co.uk added the comment:
@Antoine: do you wish to try and take this forward?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1943
___
Benjamin Peterson benja...@python.org added the comment:
r82934
--
nosy: +benjamin.peterson
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9280
___
Changes by Éric Araujo mer...@netwok.org:
--
assignee: tarek - merwok
nosy: +titus
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8253
___
___
Changes by Éric Araujo mer...@netwok.org:
--
assignee: tarek - merwok
nosy: +titus
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8252
___
___
Éric Araujo mer...@netwok.org added the comment:
Quick update: I have done a basic part of this, but Tarek explained to me the
real usefulness of this command, i.e. provide build and installation options
for third-party code (for the same purposes that get_config_var in Python’s
sysconfig). I
Éric Araujo mer...@netwok.org added the comment:
Tarek also answered my questions.
1) 4) build and install options should be defined and checked only once, in
configure. build and install would inherit from this class and get their option
from it.
3) I switched to using
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Indeed. Replacing issue9079a.diff now.
--
Added file: http://bugs.python.org/file18045/issue9079a.diff
___
Python tracker rep...@bugs.python.org
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file: http://bugs.python.org/file18034/issue9079a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9079
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
2.7 is not gone. It has entered an extended maintenance period. During this
period, 2.7.x releases will incorporate bug fixes but will not get any new
features. This particular issue is arguably a bug. I think
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
assignee: - belopolsky
resolution: - accepted
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1706039
Changes by Éric Araujo mer...@netwok.org:
--
dependencies: +update mkpkg to latest coding standards
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8252
___
Éric Araujo mer...@netwok.org added the comment:
I’m assigning this bug to myself as part of my work on #8252. Dan, I’ll sort
the various fixes in your patch and replay them incrementally. I’ll be pleased
to work with you if you have time (find me in #distutils or through email), if
you don’t
New submission from Éric Araujo mer...@netwok.org:
I made a doc patch in a followup to
http://mail.python.org/pipermail/python-dev/2010-July/102011.html
--
assignee: d...@python
components: Documentation
files: improve-check.diff
keywords: needs review, patch
messages: 110606
nosy:
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file18046/improve-check.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9288
___
Changes by Éric Araujo mer...@netwok.org:
Added file: http://bugs.python.org/file18047/disambiguate-option-cmdoption.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9288
___
Éric Araujo mer...@netwok.org added the comment:
Adding people listed for the testing interest area in the maintainers file.
--
nosy: +giampaolo.rodola, michael.foord, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8910
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +d...@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6722
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Closing as outdated since 2.7 has been release with some mimetools usage left.
--
resolution: - out of date
stage: - committed/rejected
status: open - closed
versions: +Python 2.7 -Python 2.6, Python 3.0
Changes by Éric Araujo mer...@netwok.org:
--
assignee: georg.brandl - d...@python
nosy: +d...@python
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4819
___
Éric Araujo mer...@netwok.org added the comment:
Assigning to myself. Not sure if I’ll do the logging idea Tarek suggested or an
option to the configure command (#8252).
--
assignee: tarek - merwok
stage: - needs patch
type: behavior - feature request
versions: +Python 2.5, Python
Éric Araujo mer...@netwok.org added the comment:
Some useful tips to make patches: http://www.python.org/dev/patches/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8538
___
Terry J. Reedy tjre...@udel.edu added the comment:
Looking at the 2.x code, that is the obvious fix. I think this ready to commit.
--
stage: - commit review
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
Changes by Éric Araujo mer...@netwok.org:
--
assignee: - r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9286
___
___
Éric Araujo mer...@netwok.org added the comment:
Thanks for your help proposal Ulrik. If I understand the documentation
correctly, docstrings should contain enough usage information but not too much.
In pkgutil, some examples and long explanations could be removed after you move
them to the
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Committed issue5180b.diff with minor additions in r82937 (r82938 for 3.1):
1. Added an assert that args is a tuple in instantiate() with an explanation
why it is true.
2. Added a test for the other code branch
Éric Araujo mer...@netwok.org added the comment:
Other useful advice:
http://docs.pythonsprints.com/core_development/beginners#building-the-documentation
http://docs.python.org/documenting/
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Wrong link, sorry everyone for the noise:
http://docs.pythonsprints.com/core_development/beginners.html#building-the-documentation
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
In py3k.diff, the changes to argparse and new test cases look good to me. I
don’t know why you’ve added hasattr tests in test_argparse.py.
--
stage: unit test needed - patch review
title: [argparse] Subcommands not printed in the same
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Upon further investigation, I am no longer convinced that reduce cycles are
necessarily fatal to pickling. I am attaching a script testcycle.py that
allows creating cycles using various containers. It takes the name of
Mark Lawrence breamore...@yahoo.co.uk added the comment:
This is quite clearly marked as a feature request and hence is 3.2. If you
wish to change it go ahead, but who's going to do the work?
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
I’m working on the files section alongside the metadata section (#8252. I will
wait for resources, since it’s much more controversial. I’ll clean up mkpkg
(see #8591) before updating it to support the new sections.
--
dependencies:
New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp:
test_long_key fails on win2k + python2.x.
==
ERROR: test_long_key (__main__.LocalWinregTests)
1 - 100 of 104 matches
Mail list logo