[issue10358] Doc styles for print should only use dark colors

2010-11-09 Thread Georg Brandl
Georg Brandl added the comment: I agree and will add a print-media stylesheet. -- nosy: +georg.brandl ___ Python tracker ___ ___ Pyth

[issue10380] AttributeError: 'module' object has no attribute 'exc_traceback'

2010-11-09 Thread Georg Brandl
Georg Brandl added the comment: sys.exc_traceback is deprecated, please use sys.exc_info(). Also note that this tracker is not a place to get help; the python-list mailing list (a.k.a. comp.lang.python newsgroup) is the right place for that. -- nosy: +georg.brandl resolution: -> inv

[issue10378] Typo in results of help(divmod)

2010-11-09 Thread Richard Fuhr
Richard Fuhr added the comment: OK, thanks for the clarification. I am new to Python. Sent from my iPod On Nov 9, 2010, at 3:54 PM, Andreas Stührk wrote: > > Andreas Stührk added the comment: > > __builtin__ is the correct name for the module (see > http://docs.python.org/library/__buil

[issue10380] AttributeError: 'module' object has no attribute 'exc_traceback'

2010-11-09 Thread Peda Venkateswarlu Pola
New submission from Peda Venkateswarlu Pola : As we have some new requirements in standard logging, We have written wrapper logger. This includes find caller which gives information about filename , line number , class name and method name. As i found that python logger doesn't give class name

[issue10379] locale.format() input regression

2010-11-09 Thread Eric Smith
Changes by Eric Smith : -- assignee: -> d...@python components: +Documentation nosy: +d...@python ___ Python tracker ___ ___ Python-b

[issue10379] locale.format() input regression

2010-11-09 Thread Eric Smith
Eric Smith added the comment: I agree the documentation isn't terribly clear on what a "%char specifier" or "whole format string" is. FWIW, this is also a 3.1 and greater issue. -- versions: +Python 3.1, Python 3.2 ___ Python tracker

[issue2522] locale.format() problems with decimal separator

2010-11-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I mean issue 10379 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue2522] locale.format() problems with decimal separator

2010-11-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Hmm. See bug 10379 for fallout from this change. I'm not saying it should be reverted but see that issue for further discussion. -- nosy: +barry ___ Python tracker

[issue10379] locale.format() input regression

2010-11-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Hmm. So I guess the answer is to use locale.format_string() instead. But the documentation for locale.format() is not entirely clear about the prohibition on trailing text. -- ___ Python tracker

[issue10379] locale.format() input regression

2010-11-09 Thread Eric Smith
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue10379] locale.format() input regression

2010-11-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Okay, so line 187 of locale.py has this test: if not match or len(match.group())!= len(percent): the problematic part is the len test. When format string is '%.0f KB' match.group() is '%.0f' but of course percent is the full string. This seems like a b

[issue10379] locale.format() input regression

2010-11-09 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: This was changed by issue2522 on purpose; no suffix is allowed in locale.format(). -- nosy: +amaury.forgeotdarc, r.david.murray ___ Python tracker _

[issue10378] Typo in results of help(divmod)

2010-11-09 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> invalid status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue10351] Add autocompletion for keys in dictionaries

2010-11-09 Thread Andreas Stührk
Changes by Andreas Stührk : -- nosy: +Trundle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue10378] Typo in results of help(divmod)

2010-11-09 Thread Andreas Stührk
Andreas Stührk added the comment: __builtin__ is the correct name for the module (see http://docs.python.org/library/__builtin__.html, especially the note at the end which is the cause of the confusion), hence this is not a bug. -- nosy: +Trundle _

[issue10379] locale.format() input regression

2010-11-09 Thread Barry A. Warsaw
New submission from Barry A. Warsaw : @mission[~:1001]% python2.7 -c "import locale; print locale.format('%.0f KB', 100)" Traceback (most recent call last): File "", line 1, in File "/usr/lib/python2.7/locale.py", line 189, in format "format specifier, %s not valid") % repr(percent)) Va

[issue4471] IMAP4 missing support for starttls

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is an updated STARTTLS patch for py3k. -- stage: -> patch review type: -> feature request versions: +Python 3.2 -Python 2.6 Added file: http://bugs.python.org/file19562/imaptls.patch ___ Python tracker

[issue4471] IMAP4 missing support for starttls

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: The shutdown change was committed in r86383. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue4471] IMAP4 missing support for starttls

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've committed some of the remote tests in r86380, which also helped me fix a bug in login() in 3.x. -- nosy: +pitrou ___ Python tracker ___ __

[issue10378] Typo in results of help(divmod)

2010-11-09 Thread Richard Fuhr
Richard Fuhr added the comment: I had a typo in my own bug report that was reporting a typo; what I intended to say was the following ( the q should not have been there at the end ) When running Python 2.7 if you invoke help(divmod) the first line of the resulting help displays Help on bui

[issue10378] Typo in results of help(divmod)

2010-11-09 Thread Richard Fuhr
New submission from Richard Fuhr : When running Python 2.7 if you invoke help(divmod) the first line of the resulting help displays Help on built-in function divmod in module __builtin__: but I believe that the name of the module is __builtins__ so the line should say Help on built-in func

[issue1195] Problems on Linux with Ctrl-D and Ctrl-C during raw_input

2010-11-09 Thread Vetoshkin Nikita
Vetoshkin Nikita added the comment: Confirming that issue is present in latest svn checkout and Ralf's fix helps. -- nosy: +nvetoshkin ___ Python tracker ___

[issue7978] SocketServer doesn't handle syscall interruption

2010-11-09 Thread Vetoshkin Nikita
Vetoshkin Nikita added the comment: Any news on this? Could we possibly apply patch as is? If I'm not mistaken timeout issue is the only one left unresolved. About timeout. The most elegant way, would be to use select's syscall timeout parameter, but man 2 select says: "On Linux, select()

[issue10022] Emit more information in decoded SSL certificates

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Fixed in r86369. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue1926] NNTPS support in nntplib

2010-11-09 Thread Andrew Vant
Andrew Vant added the comment: On 9 Nov 2010 at 18:59, Antoine Pitrou wrote: > I have committed the patch in r86365, and I've made usenetrc > False by default in r86366. Thanks for contributing! Woot. I thank you. Regarding usenetrc, the NNTP.login and NNTP.starttls documentation assumed it

[issue10070] 2to3 wishes for already-2to3'ed files

2010-11-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: And I still don't understand the rationale for this request. Can you please post an example Python module that has this markup you are asking for, so I can show you how to achieve what you want without the markup? --

[issue9199] distutils upload command crashes when displaying server response

2010-11-09 Thread Phillip J. Eby
Phillip J. Eby added the comment: Confirmed - issue10367 is not a dupe. This bug was that a *successful* upload would crash; issue10367 occurs only in the HTTPError case, and isn't fixed by this issue's patch. Reclosing this and reopening 10367. -- stage: commit review -> committed/

[issue10367] "python setup.py sdist upload --show-response" can fail with "UnboundLocalError: local variable 'result' referenced before assignment"

2010-11-09 Thread Phillip J. Eby
Phillip J. Eby added the comment: Btw, a quick review of the 3.x trunk code for this shows that it does *not* have this problem; this is specific to 2.7 and AFAICT *only* 2.7. (This problem was introduced in r73436, btw, as of the move to urllib2 vs. httplib.) -- ___

[issue10370] py3 readlines() reports wrong offset for UnicodeDecodeError

2010-11-09 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue10370] py3 readlines() reports wrong offset for UnicodeDecodeError

2010-11-09 Thread Brian Warner
Brian Warner added the comment: > Use .readline() to locate an invalid byte is not the right algorithm. If > you would like to do that, you should open the file in binary mode and > decodes the content yourself, chunk by chunk. Or if you manipulate small > files, you can use .read() as you wrote

[issue10367] "python setup.py sdist upload --show-response" can fail with "UnboundLocalError: local variable 'result' referenced before assignment"

2010-11-09 Thread Phillip J. Eby
Phillip J. Eby added the comment: To better show what the problem is, here's a change that would fix the problem (albeit in an ugly way): --- upload.py 2010-07-07 20:16:33.0 -0400 +++ /home/pje/upload.new2010-11-09 14:30:21.0 -0500 @@ -167,6 +167,9 @@ reque

[issue10377] cProfile incorrectly labels its output

2010-11-09 Thread Jean-Paul Calderone
New submission from Jean-Paul Calderone : Consider this transcript: >>> cProfile.run("import time; time.sleep(1)") 4 function calls in 1.012 CPU seconds Ordered by: standard name ncalls tottime percall cumtime percall filename:lineno(function) 10.0110.011

[issue1926] NNTPS support in nntplib

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: I have committed the patch in r86365, and I've made usenetrc False by default in r86366. Thanks for contributing! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python

[issue7061] Improve turtle module documentation

2010-11-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed a slightly modified turtle-star-sidebar.diff in revision 86364. Note that I've included both pdf and postscript files in case someone would want to run postscript through a better distiller than the OSX preview that I used. The postscript wa

[issue10372] [REGRESSION] test_gc fails in non-debug mode.

2010-11-09 Thread STINNER Victor
STINNER Victor added the comment: Oh, I also wrote a patch for the warnings error silently ignored: import_warnings_error.patch. -- Added file: http://bugs.python.org/file19561/import_warnings_error.patch ___ Python tracker

[issue10371] Deprecate trace module undocumented API

2010-11-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: Looks good in a cursory reading. I presume trace test still passes. If you change the signature of the renamed functions, that would break the current wrappings. Would you use new private functions with different names, or change the wrappings where possible?

[issue7061] Improve turtle module documentation

2010-11-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: To me, the mini change logs are both distracting noise and contrary to the general start-fresh policy for 3.x docs, stated somewhere by Georg B, which I really like. -- ___ Python tracker

[issue10372] [REGRESSION] test_gc fails in non-debug mode.

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a patch. It moves warnings initialization after io initialization (the latter being arguably more critical than the former). Also adds two tests. -- assignee: haypo -> keywords: +patch stage: needs patch -> patch review versions: +Python 2.7,

[issue10329] trace.py and unicode in Python 3

2010-11-09 Thread Walter Dörwald
Walter Dörwald added the comment: > STINNER Victor added the comment: > >> ... it complicates handling of the output of trace.py. >> For each file you have to do the encoding detection dance again ... > > What? You just have to call one function! tokenize.open() :-) Well, ok, > it's not com

[issue10371] Deprecate trace module undocumented API

2010-11-09 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +brett.cannon, eli.bendersky, terry.reedy ___ Python tracker ___ ___ Python-bugs-list maili

[issue7061] Improve turtle module documentation

2010-11-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Nov 9, 2010 at 11:45 AM, Raymond Hettinger wrote: .. > Raymond Hettinger added the comment: > > The mini change log is harmless.  I would leave it as is. It is not entirely harmless. First, it occupies valuable easy to scroll to end-of-page rea

[issue10318] "make altinstall" installs many files with incorrect shebangs

2010-11-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I would like to add my +1 to Eric's msg120485 above. What I really find puzzling is why some scripts in Tools/ have hashbangs, but don't have execute permission. Tools/scripts/cleanfuture.py Tools/scripts/combinerefs.py Tools/scripts/db2pickle.py Tools

[issue7061] Improve turtle module documentation

2010-11-09 Thread Raymond Hettinger
Raymond Hettinger added the comment: The mini change log is harmless. I would leave it as is. -- ___ Python tracker ___ ___ Python-bu

[issue10372] [REGRESSION] test_gc fails in non-debug mode.

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: One observation is that when the -W option is used, the "warnings" module gets loaded very early and itself imports linecache which then imports tokenize. At this point, the standard IO streams have not been initialized (_io is imported later) and the builtin

[issue10374] setup.py caches outdated scripts in the build tree

2010-11-09 Thread Tarek Ziadé
Tarek Ziadé added the comment: As described in distutils-SIG, we need to work on a clever way to update the build tree. For Distutils1, removing it completely (possibly via the clean command) is what people can do. -- components: +Distutils2 -Distutils type: behavior -> feature reque

[issue9995] "setup.py register sdist upload" requires pass to be saved

2010-11-09 Thread Brian Curtin
Changes by Brian Curtin : -- type: security -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue10372] [REGRESSION] test_gc fails in non-debug mode.

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Weirdly, this patch fixes the issue, but I'm unable to say why: diff -r cd1de1ff2657 Lib/tokenize.py --- a/Lib/tokenize.py Tue Nov 09 02:08:59 2010 +0100 +++ b/Lib/tokenize.py Tue Nov 09 17:16:21 2010 +0100 @@ -24,12 +24,12 @@ __author__ = 'Ka-Ping Yee _

[issue9995] "setup.py register sdist upload" requires pass to be saved

2010-11-09 Thread Tarek Ziadé
Tarek Ziadé added the comment: Please stop changing this flag. If you want to have a more secure PyPI transaction, you should first send a feature request on Catalog-SIG so pypi.python.org forces https. -- ___ Python tracker

[issue10372] [REGRESSION] test_gc fails in non-debug mode.

2010-11-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: For some reason, this starts happening with the Lib/tokenize.py change in r86346. Resource warnings don't get enabled by -Wd: With r86345: $ ./python -Wd -c "open('LICENSE')" -c:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='LICENSE' encoding='UTF

[issue9995] "setup.py register sdist upload" requires pass to be saved

2010-11-09 Thread anatoly techtonik
anatoly techtonik added the comment: Eric, interested parties will not fill CVE or DSA requests. They will just steal the pass of PyPI uploaders and use it to inject malicious code into popular packages. If you need a CVE or DSA to evaluate if an issue imposes a security risk, then better le

[issue10376] ZipFile unzip is unbuffered

2010-11-09 Thread James Hutchison
James Hutchison added the comment: I should clarify that this is the zipfile constructor I am using: zipfile.ZipFile(filename, mode='r', allowZip64=True); -- ___ Python tracker ___

[issue7061] Improve turtle module documentation

2010-11-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Oct 30, 2010 at 8:27 PM, Terry J. Reedy wrote: .. > Sections about 2.x changes should not be in 3.x docs. I agree. Neither "Changes since Python 2.6" nor "Changes since Python 2.6" belong in this section. The first belongs to "What's new in Py

[issue10376] ZipFile unzip is unbuffered

2010-11-09 Thread James Hutchison
New submission from James Hutchison : The Unzip module is always unbuffered (tested v.3.1.2 Windows XP, 32-bit). This means that if one has to do many small reads it is a lot slower than reading a chunk of data to a buffer and then reading from that buffer. It seems logical that the unzip modu

[issue8315] ./python -m unittest test.test_importlib doesn't work

2010-11-09 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue960325] "--require " option for configure/make (fail if building not possible)

2010-11-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, this could be reopened with a patch. Someone else would have to judge its usefulness and acceptability. So no guarantees. -- ___ Python tracker

[issue7061] Improve turtle module documentation

2010-11-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: I like it! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue10070] 2to3 wishes for already-2to3'ed files

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: Hi, I'm back... I've been reading your last message a few times and I'm not sure what I'm to reconsider. We've had a way of talking past each toerh before, as far as I can remember. I think my request still now translates to: - keep the current behavior

[issue7061] Improve turtle module documentation

2010-11-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: As a follow-up to Raymond's suggestion, I am attaching a patch that will add a sidebar to the introduction section of the turtle documentation section. While it is not common to include screenshots in python documentation, I think it is very appropriat

[issue10375] 2to3 print(single argument)

2010-11-09 Thread Hallvard B Furuseth
New submission from Hallvard B Furuseth : Could 2to3 without -p notice more cases of print(single argument), to avoid slapping another () around them? For example: print(2*3) print(", ".join(dir)) print(very + long + single + argument) My internal bug detector zooms in on ((foo))

[issue960325] "--require " option for configure/make (fail if building not possible)

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: Just for the record, I think you read this a bit too fast before closing: Terry J. Reedy writes: > I am closing this as some combination of wrong, inapplicable, > out-of-date, and postponed. > > 1. (...) For bz2, there is "This module provides a > compreh

[issue10373] Setup Script example incorrect

2010-11-09 Thread Kirk Clendinning
New submission from Kirk Clendinning : In 2.7. Installing Additional Files the example shows: setup(..., data_files=[('bitmaps', ['bm/b1.gif', 'bm/b2.gif']), ('config', ['cfg/data.cfg']), ('/etc/init.d', ['init-script'])] ) However, running easy_in

[issue10374] setup.py caches outdated scripts in the build tree

2010-11-09 Thread Geoffrey Bache
New submission from Geoffrey Bache : I have the following setup.py script: #!/usr/bin/env python from distutils.core import setup scripts=["hello.py"] setup(scripts=scripts) I have two different python installations (using virtualenv) where I wish to install this program. So I do ~/tmp/test_

[issue10363] Embedded python, handle (memory) leak

2010-11-09 Thread Martin Dunschen
Martin Dunschen added the comment: Here my suggested changes in plain text (I generated these as patches from a diff to the current code): thread.c: 353a354,359 > void PyThread_fini() > { > // should assert here that nkeys == 0 > PyThread_free_lock(keymutex); > } > pystate.c: 38

[issue10359] ISO C cleanup

2010-11-09 Thread Éric Araujo
Éric Araujo added the comment: > I've used compilers where they'd be compile errors, though I found > them just with gcc -pedantic in an idle moment. If Victor accepts the patches then they’re useful :) >> If the latter, I think they won’t go into stable branches. > Not until someone has bette

[issue7061] Improve turtle module documentation

2010-11-09 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file19558/turtle-star.png ___ Python tracker ___ ___ Python-bugs-list mail

[issue7061] Improve turtle module documentation

2010-11-09 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file19559/turtle-sidebar-screenshot.png ___ Python tracker ___ ___ Python-

[issue10361] Fix issue 9995 - distutils forces developers to store password in cleartext (issue2874041)

2010-11-09 Thread Tarek Ziadé
Tarek Ziadé added the comment: Looks good to me: the upload command will get the credentials from the session instead of using the existing config at all. I remember that we changed the behavior to you'd had to set ONLY the user in the rc file, but allowing to pass the user is better since it

[issue9709] test_distutils warning: initfunc exported twice on Windows

2010-11-09 Thread Stefan Krah
Stefan Krah added the comment: This is the history of the issue: In r16757 the current version of get_export_symbols() was added to distutils. This function adds /EXPORT initfunc to the command line. In 27697 PyMODINIT_FUNC was defined as __declspec(dllexport) void. I'd suggest to remove get

[issue9857] SkipTest in tearDown is reported an as an error

2010-11-09 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue10369] tarfile requires an actual file on disc; a file-like object is insufficient

2010-11-09 Thread Lars Gustäbel
Lars Gustäbel added the comment: Hm, why don't you just do this: with stat_tarfile.open(fileobj = sys.stdout, mode = "w|") as tar: for number in xrange(100): fileobj = generate_file_content(number) tarinfo = tar.gettarinfo(fileobj=open("/etc/passwd")) tarinfo.name =

[issue9873] urllib.parse: Allow bytes in some APIs that use string literals internally

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: urlunparse(url or params = bytes object) produces a result with the repr of the bytes object if params is set. urllib.parse.urlunparse(['http', 'host', '/dir', b'params', '', '']) --> "http://host/dir;b'params'" That's confusing since urllib/parse.py goes

[issue10363] Embedded python, handle (memory) leak

2010-11-09 Thread Stefan Krah
Stefan Krah added the comment: I don't see a file attached. Could you attach your patches in plain text? It is the preferred method, since files can be easily viewed in the browser. -- nosy: +skrah ___ Python tracker

[issue10351] Add autocompletion for keys in dictionaries

2010-11-09 Thread Valery Khamenya
Valery Khamenya added the comment: Hi Éric, thanks for guiding. So, attached is the concatenation of two forward unified diffs for rlcompleter.py and test_rlcompleter.py -- both as of py3k trunk. Tested against Python 3.1.2 though. P.S. hm, py3k code appeared to be surprisingly nicer -- no

[issue10372] [REGRESSION] test_gc fails on Mac OSX 10.6

2010-11-09 Thread Ismail Donmez
New submission from Ismail Donmez : py3k r86351, == FAIL: test_garbage_at_shutdown (__main__.GCTests) -- Traceback (most recent call last): File "./Lib/test/

[issue10324] Modules/binascii.c: simplify expressions

2010-11-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: At first, I was worried if this simplification would cause any harm to readability of the algorithm. Fortunately, it didn't. Committed in r86357. -- nosy: +orsenthil resolution: -> fixed stage: commit review -> committed/rejected status: open -> clo

[issue10359] ISO C cleanup

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: Hallvard B Furuseth writes: > (...) which is what the current code actually executes. Er, I mean, that's what it does with req_type. The 'static' for req_name is an optimization of the current code. -- ___ Pyth

[issue10359] ISO C cleanup

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: STINNER Victor writes: > Python-ast.c: why do you move req_name and req_type outside PyAST_obj2mod()? Because there's no need to initialize the arrays each time PyAST_obj2mod is called. C90-friendly code inside PyAST_obj2mod would be PyAST_obj2mod(PyObje

[issue10359] ISO C cleanup

2010-11-09 Thread STINNER Victor
STINNER Victor added the comment: I commited a part of your patches: r86353 Remove ";" after function definition, invalid in ISO C r86354: [array] int => Py_UNICODE (my commit is a little bit different, but it is based on your patch) r86355: [_pickle] Remove useless comma, invalid in ISO C r86

[issue10245] Fix resource warnings in test_telnetlib

2010-11-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: conn.close() was done in the finally method in r86228 by brian.curtin. The other change in your patch in very minor space addition after comma. We can leave it to place along with some other code change. -- nosy: +brian.curtin, orsenthil resolution:

[issue10359] ISO C cleanup

2010-11-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hallvard, if it going be a rather huge diff, you may make it available at http://bugs.python.org/review, so that it is easy for review. -- nosy: +orsenthil ___ Python tracker __

[issue10361] Fix issue 9995 - distutils forces developers to store password in cleartext (issue2874041)

2010-11-09 Thread anatoly techtonik
anatoly techtonik added the comment: Fixed docstring. http://codereview.appspot.com/2874041/diff/2001/cmd.py File cmd.py (right): http://codereview.appspot.com/2874041/diff/2001/cmd.py#newcode55 cmd.py:55: :param distutils.dist.Distribution dist: distribution to work with On 2010/11/08 18:47:3

[issue10359] ISO C cleanup

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: ,AIric Araujo writes: > By the way, do these changes actually fix errors or are they just > cleanups and pedantic (not a slight) fixes? I've used compilers where they'd be compile errors, though I found them just with gcc -pedantic in an idle moment. > I

[issue10312] intcatcher() can deadlock

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: Sorry, my patch is useless if the OS calls the handler with the signal blocked. It should also unblock the signal before doing anything which can do FILE* operations. And set the handler again? Or just leave the next signal to abort the process? I dunno

[issue10325] PY_LLONG_MAX & co - preprocessor constants or not?

2010-11-09 Thread Hallvard B Furuseth
Hallvard B Furuseth added the comment: No, PY_LLONG_MAX lacks a paren. Found by the revolutionary method of actually testing it (made the previous branches #if 0's). bugs.python.org is not responding, but here's what I'm using now: Index: Include/pyport.h ==