Pierre Quentel pierre.quen...@gmail.com added the comment:
I knew the builtins hack was terrible, thanks for the replies...
I changed cgi.py with Glenn's IOMix class, and included the changes in
make_file(). The patch is attached to this message
Is it really too late to include it in 3.2 ?
Pierre Quentel pierre.quen...@gmail.com added the comment:
diff for the updated version of test_cgi.py, compatible with cgi.py
--
Added file: http://bugs.python.org/file20384/test_cgi_20111013.diff
___
Python tracker rep...@bugs.python.org
Pierre Quentel pierre.quen...@gmail.com added the comment:
zip file with the updated cgi_test.py and associated files
--
Added file: http://bugs.python.org/file20385/cgi_tests.zip
___
Python tracker rep...@bugs.python.org
Ross Lagerwall rosslagerw...@gmail.com added the comment:
How about this?
Instead of just losing the data that's been read so far in readline(), this
patch adds the data as a new field to the exception that is thrown - this way
the semantics remain exactly the same but the data is not
Glenn Linderman v+pyt...@g.nevcal.com added the comment:
Pierre,
Looking better.
I see you've retained the charset parameter, but do not pass it through to
nested calls of FieldStorage. This is good, because it wouldn't work if you
did. However, purists might still complain that FieldStorage
Éric Araujo mer...@netwok.org added the comment:
Small tip: To ease review, I recommend you work from a checkout of the
Subversion py3k branch, using svn add if you have new files and then
producing one svn diff of the whole checkout. It’s easier than looking
at multiple files, even more so if
Charles-Francois Natali neolo...@free.fr added the comment:
It's a dupe of http://bugs.python.org/issue8035.
By the way, it works with 2.7 because urllib used HTTP 1.0 by default, and in
py3k it now uses HTTP 1.1.
And from what I understood (by I'm by no means an http expert), in http 1.0 the
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20229/cgi_diff.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20235/cgi_diff.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20322/cgi_diff_20110109.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20323/cgi_tests.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20356/cgi_diff_20110111.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20382/cgi_diff_20110112.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20383/cgi_20110113.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20384/test_cgi_20111013.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Pierre Quentel pierre.quen...@gmail.com:
Removed file: http://bugs.python.org/file20244/cgi_diff.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Pierre Quentel pierre.quen...@gmail.com added the comment:
Ok Eric, thanks for the tips
I attach the diff for the 2 modified modules (cgi.py and test_cgi.py). For the
other tests, they are not in the branch and there are many test files so I
leave the zip file
I removed outdated diffs
SilentGhost ghost@gmail.com added the comment:
Here is the patch, including adjustment to the test.
--
Added file: http://bugs.python.org/file20388/issue2650.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2650
Scott Dial sc...@scottdial.com added the comment:
Raymond Hettinger wrote:
I think those annotations should be replaced with comments.
In your revisions, you didn't do anything but blow away the annotations despite
what you said here, which is an unfortunate loss of information for
David Beazley d...@dabeaz.com added the comment:
Have any other programming environments ever had a feature where a socket
timeout returns an exception containing partial data?I'm not aware of one
offhand and speaking as a systems programmer, something like this might be
somewhat
Antoine Pitrou pit...@free.fr added the comment:
This is an interesting approach. The problem is that AFAICT the issue is not
limited to readline. If you call e.g. read(1) and the socket times out
after having returned the first 5000 bytes, then those 5000 bytes might get
lost as well
Antoine Pitrou pit...@free.fr added the comment:
By the way, I recently fixed the makefile() documentation:
“The socket must be in blocking mode; it can have a timeout, but the file
object’s internal buffer may end up in a inconsistent state if a timeout
occurs.”
(in
R. David Murray rdmur...@bitdance.com added the comment:
It getting in to 3.2 would be a release manager call, so I've set it to release
blocker so Georg can make the call. My opinion is that while I would *really*
like to see this fixed in 3.2, the changes really should have a thorough
Changes by Ralf Schmitt sch...@gmail.com:
--
nosy: +schmir
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10897
___
___
Python-bugs-list mailing
Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com added the comment:
This change was backported to 2.7 (r87701) and 3.1 (r87702).
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10013
Changes by SilentGhost ghost@gmail.com:
--
resolution: - accepted
status: open - closed
versions: +Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10013
___
Pierre Quentel pierre.quen...@gmail.com added the comment:
Ok, thanks. Here is a summary of the API changes :
- the argument fp passed to FieldStorage is either an instance of (a subclass
of) io.TextIOBase with a buffer attribute for the underlying binary layer
(thus, it can't be a StringIO
Changes by SilentGhost ghost@gmail.com:
Removed file: http://bugs.python.org/file20388/issue2650.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2650
___
SilentGhost ghost@gmail.com added the comment:
The naïve version of the code proposed was about 3 times slower than existing
version. However, the test, I think, is valuable enough. So, I'm reinstating it.
--
Added file: http://bugs.python.org/file20389/test_re.diff
Changes by SilentGhost ghost@gmail.com:
--
resolution: accepted - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10013
___
___
James Y Knight f...@users.sourceforge.net added the comment:
Show your speed test? Looks 2.5x faster to me. But I'm running this on python
2.6, so I guess it's possible that the re module's speed was decimated in Py3k.
python -m timeit -s $(printf import re\ndef escape(s):\n return
Guido van Rossum gu...@python.org added the comment:
Yes, please add the lost info back to docstrings.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10899
___
Antoine Pitrou pit...@free.fr added the comment:
Ok, closing as duplicate.
--
resolution: - duplicate
status: open - closed
superseder: - urllib.request.urlretrieve hangs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10577
Antoine Pitrou pit...@free.fr added the comment:
issue10577 is a duplicate. See an URL allowing reproducing in msg122831.
--
nosy: +pitrou
priority: high - normal
stage: unit test needed - needs patch
title: urllib.request.urlretrieve hangs - urllib.request.urlretrieve hangs
waiting
SilentGhost ghost@gmail.com added the comment:
James, I think the setup statement should have been:
import re\ndef escape(s):\n return re.sub(r'([][.^$*+?{}\\|()])', r'\\\1',
s))
note the raw string literals.
The timings that I got after applying file20388
Terry J. Reedy tjre...@udel.edu added the comment:
This can be reopened if the problem ever appears in a current issue.
--
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2710
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Will do :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10899
___
___
James Y Knight f...@users.sourceforge.net added the comment:
Right you are, it seems that python's regexp implementation is terribly slow
when doing replacements with a substitution in them. (fixing the broken test,
as you pointed out changed the timing to 97.6 usec vs the in-error-reported
yeswanth swamiyeswa...@yahoo.com added the comment:
@James test results for py3k
python -m timeit -s $(printf import re\ndef escape(s):\n return
re.sub('([][.^$*+?{}\\|()])', '\\\1', s))
'escape(!@#$%^*()!@#$%^*()!@#$%^*()!@#$%^*()!@#$%^*()!@#$%^*()!@#$%^*()!@#$%^*())'
10 loops, best
New submission from wrobell wrob...@pld-linux.org:
There is problem to uncompress large files with bz2 module.
For example, please download 13GB OpenStreetMap file using following torrent
http://osm-torrent.torres.voyager.hr/files/planet-latest.osm.bz2.torrent
Try to count lines in the
New submission from Brandon Craig Rhodes bran...@rhodesmill.org:
If you try doing msg.as_string() to a MIMEMultipart message that has not been
given a boundary, then it dies with this exception:
Traceback (most recent call last):
File mime_gen_alt.py, line 40, in module
Brandon Craig Rhodes bran...@rhodesmill.org added the comment:
Here is a patch that fixes the problem. The problem probably only occurs if the
MIMEMultipart is actually given several MIME parts to use in its interior.
--
keywords: +patch
Added file:
Changes by A.M. Kuchling li...@amk.ca:
--
nosy: -akuchling
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2650
___
___
Python-bugs-list mailing
Changes by SilentGhost ghost@gmail.com:
--
nosy: +gustavo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10900
___
___
Python-bugs-list mailing
Changes by SilentGhost ghost@gmail.com:
--
nosy: +niemeyer -gustavo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10900
___
___
SilentGhost ghost@gmail.com added the comment:
It is a duplicate of #1243654. Closing.
--
nosy: +SilentGhost
resolution: - duplicate
status: open - closed
superseder: - Faster output if message already has a boundary
___
Python tracker
Gregory P. Smith g...@krypto.org added the comment:
Generally there is no guarantee that a buffered object works properly when
the raw IO object raises some exception intermittently
I disagree. EINTR is a classic case of this and is something that buffering IO
layers deal with all the time.
SilentGhost ghost@gmail.com added the comment:
Issue #10901 was closed as a duplicate of this issue.
--
nosy: +SilentGhost
versions: +Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1243654
Antoine Pitrou pit...@free.fr added the comment:
Generally there is no guarantee that a buffered object works
properly when the raw IO object raises some exception
intermittently
I disagree. EINTR is a classic case of this and is something that
buffering IO layers deal with all the time.
wrobell wrob...@pld-linux.org added the comment:
Forgot the mention the real amount of lines!
bzip2 -dc planet-110105.osm.bz2 | wc -l
2783595867
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10900
wrobell wrob...@pld-linux.org added the comment:
A use case
wget -O http://planet.openstreetmap.org/planet-110112.osm.bz2 | tee
planet.bz2 | osm2sql | psql osm
planet-*osm.bz2 files are 14GB at the moment. it would be great to read them
from stdin while downloading from a server and
Éric Araujo mer...@netwok.org added the comment:
We’ve already agreed the feature is desirable; what’s missing is a patch, not
user stories :)
--
nosy: +niemeyer
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
wrobell wrob...@pld-linux.org added the comment:
OK! :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5863
___
___
Python-bugs-list mailing
Ross Lagerwall rosslagerw...@gmail.com added the comment:
That complicates things quite a bit,
especially given that it has to be grafted on at least two layers of the
IO stack (the raw IO layer, and the buffered IO layer).
Also the TextIO layer I think.
That's my opinion too. So, instead,
Antoine Pitrou pit...@free.fr added the comment:
That's my opinion too. So, instead, of doing the above surgery inside
the IO stack, the SocketIO layer could detect the timeout and disallow
further access. What do you think?
So after a timeout occurs the file-object basically becomes
Andy Harrington ahar...@luc.edu added the comment:
I found a similar issue. If you want more simple files demonstrating the
issue, I have attached some. If I start my localCGIServer.py, then I can use
adder.html fine (uses get), but with adderpost.html (uses post) the cgi action
file,
Changes by Andy Harrington ahar...@luc.edu:
Removed file: http://bugs.python.org/file20392/localCGIServer.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Andy Harrington ahar...@luc.edu:
Added file: http://bugs.python.org/file20393/adder.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Andy Harrington ahar...@luc.edu:
Added file: http://bugs.python.org/file20394/adderpost.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: -pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
___
Python-bugs-list mailing
Changes by Andy Harrington ahar...@luc.edu:
Added file: http://bugs.python.org/file20395/localCGIServer.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Changes by Andy Harrington ahar...@luc.edu:
Added file: http://bugs.python.org/file20396/adder.cgi
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Ram Rachum cool...@cool-rr.com added the comment:
But why? What's the reason for that? Why mislabel a type as a function?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10893
___
Éric Araujo mer...@netwok.org added the comment:
staticmethod being a type or int being a function is really a CPython
implementation detail. If the docs say something is a class, it behaves as a
class, you can subclass it and everything, and the other VMs implement it as a
class, why would
Ram Rachum cool...@cool-rr.com added the comment:
I'm really confused by your comment.
int being a function is really a CPython implementation detail
I don't understand this. I should be able to do isinstance(x, int) in all
implementations of Python, no? So `int` must be a class across all
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Committed documentation changes in revision 87990.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Okay, scratch the comment about int, it’s not been accurate for quite a number
of years. Going back to staticmethod, my point still applies: Follow what the
docs say.
staticmethod is a type in CPython probably due to the way descriptors work;
Antoine Pitrou pit...@free.fr added the comment:
Ok, there are 10+ files attached, 20+ comments, no up-to-date patch. It's
really too late for 3.2 IMO.
--
nosy: +pitrou
priority: release blocker - normal
stage: patch review - needs patch
versions: -Python 3.2
Pierre Bourgault pbourga...@quazal.com added the comment:
I had the same problem with another version of python on Windows 7.
We are using python 2.4.2 for production and it is installed in
D:\Tools\Python. For experimentation purpose, I installed Python 2.7 in the
usual location. It broke a
Pierre Quentel pierre.quen...@gmail.com added the comment:
Comment ça, no up to date patch ? cgi_32.patch is up to date, the API changes
are documented, the unittests work, what else do you want ?
--
___
Python tracker rep...@bugs.python.org
Ram Rachum cool...@cool-rr.com added the comment:
So if int is officially a class, why not start doing :class:`int` instead of
:func:`int`?
they’re marked up as functions, so you should treat them as functions.
Here, I've treated staticmethod as a function:
assert
Éric Araujo mer...@netwok.org added the comment:
I don’t have enough experience to make a judgment call here. Raymond or Georg,
can you?
--
nosy: +georg.brandl
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Comment ça, no up to date patch ? cgi_32.patch is up to date, the API
changes are documented, the unittests work, what else do you want ?
The O_BINARY stuff looks obsolete to me.
--
___
Python
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
That's just the way we do our markup.
Sorry, but this is a total non-issue.
You're trying to create finer distinctions
than the markup needs to support.
Besides, the distinction between types,
objects, callables, functions,
Glenn Linderman v+pyt...@g.nevcal.com added the comment:
The O_BINARY stuff was probably necessary because issue 10841 is not yet in the
build Pierre was using? I agree it in not necessary with the fix for that
issue, but neither does it hurt.
It could be stripped out, if you think that is
Georg Brandl ge...@python.org added the comment:
Fully agreed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10893
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Can one person please
1) Sum up the discussion and its outcome briefly
2) Remove all patches and replace them with one diff with docs, tests and code
(even if you have new files, you don’t have to put them in a zip, use svn add
and they will
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file20288/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4953
___
Etienne Robillard e...@gthcfoundation.org added the comment:
+1
--
title: cgi module cannot handle POST with multipart/form-data in 3.x - cgi
module cannot handle POST with multipart/form-data in 3.x
___
Python tracker rep...@bugs.python.org
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
I am replacing issue6697-lsprof.diff with a (hopefully) more carefully written
version that addresses the issues that Victor noted.
Victor,
I take your comment as +1 for adding PyModule_GetNameObject().
I started
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file: http://bugs.python.org/file19980/issue6697-lsprof.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6697
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
anatoly techtonik techto...@gmail.com added the comment:
This one is a different issue. Even though it can not be solved without by
#9527, it is not superseded by it. So, better add to dependencies.
--
resolution: rejected -
status: pending - open
Changes by Brian Curtin cur...@acm.org:
--
nosy: -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7662
___
___
Python-bugs-list
Brett Cannon br...@python.org added the comment:
You can discuss within the comments whether this issue should be re-opened or
not, but do not take it upon yourself to change the status on your own once a
core developer has already closed an issue as their decision supersedes that of
a
Changes by Brett Cannon br...@python.org:
--
nosy: -brett.cannon
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7662
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
I tested cgi_32.patch on Windows with Apache:
- a test with a binary file works: I get a binary file instead of a text file
- a test with a non-ASCII character (a\xe9b) works: the text is correctly
decoded
I used the test script
anatoly techtonik techto...@gmail.com added the comment:
I am tired. Do as you wish.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7662
___
Changes by anatoly techtonik techto...@gmail.com:
--
nosy: -techtonik
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7662
___
___
Python-bugs-list
STINNER Victor victor.stin...@haypocalc.com added the comment:
Le jeudi 13 janvier 2011 à 23:05 +, Alexander Belopolsky a écrit :
I take your comment as +1 for adding PyModule_GetNameObject().
I wrote a similar patch to add PyModule_GetNameObject() (I am working on
another huge patch, to
Glenn Linderman v+pyt...@g.nevcal.com added the comment:
Victor, thanks for your comments, and interest in this bug. Other than the
existence of the charset parameter, and whether or not to include IOMix, I
think all of the others could be fixed later, and do not hurt at present. So I
will
Glenn Maynard glennfmayn...@gmail.com added the comment:
I agree with Victor: Python should provide a function to supply monotonic time,
which is what's really wanted for measuring time deltas. Far too many
applications incorrectly use the system clock for this, and Python makes this
worse
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Just to clarify: Anatoly changed the resolution, not status (and I agree that
was not appropriate.) The status was set to pending and that would change to
open automatically if a new comment is posted.
As for the
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Closing this in favor of #9527. See msg126064 for more details.
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Let me summarize the issue: the PyArg_ParseTuple format code 'O' returns a
borrowed reference. However, when the 'O' code appears inside parenthesis,
there may not be an object to hold the reference to borrow from. This
Eli Bendersky eli...@gmail.com added the comment:
This code is in Modules/main.c, function Py_Main.
In 2.7, only _Py_ReleaseInternedStrings is called, and this function is defined
in Objects/stringobject.c
In 3k, the two functions are called as specified above.
_Py_ReleaseInternedStrings
Ross Lagerwall rosslagerw...@gmail.com added the comment:
Attached patch disallows further reads after a timeout.
--
Added file: http://bugs.python.org/file20398/i7322.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7322
Bill Hayes bhaye...@yahoo.com added the comment:
I finally found a solution from a page on StackOverflow.
I had to add the two characters %*
to the end of the Data value for the Windows registry key:
HKEY_CLASSES_ROOT\Applications\python.exe\shell\open\command
So the Data value is now:
Eli Bendersky eli...@gmail.com added the comment:
Attaching a patch that removes the call of the non-existing function in py3k. I
ran the test suite and make patchcheck.
I don't remove the whole __INSURE__ since someone might still want it in (and I
don't have the tool to play around with
Changes by Martin v. Löwis mar...@v.loewis.de:
--
versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3 -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7936
___
1 - 100 of 110 matches
Mail list logo
