[issue13363] Many usages of dict.keys(), dict.values(), dict.items() when the iter version could be used

Martin v. Löwis added the comment: skreft: since you were asking for a reason why the code looks the way it looks - the code in many cases predates the introduction of iterkeys and friends. I personally find the names iterkeys/itervalues/iteritems fairly ugly, and rather avoid them for pretti

[issue13362] Many PEP 8 errors

Martin v. Löwis added the comment: skreft: I can see nothing wrong by having a website that lists PEP 8 violations in the standard library - feel free to create one on wiki.python.org. Your preferred solution of having automated tests is not feasible. Taking punycode.py (sic) as an example (o

[issue3932] HTMLParser cannot handle '&' and non-ascii characters in attribute names

Changes by Ezio Melotti : -- stage: -> needs patch Added file: http://bugs.python.org/file23621/issue3932-test.diff ___ Python tracker ___ ___

[issue13349] Uninformal error message in index() and remove() functions

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue13364] Duplicated Code

Mark Dickinson added the comment: How would you suggest refactoring this? For that example, I'd prefer not to remove the repetition; as it is, the code is clean and clear. Eliminating the repetition would involve adding an extra layer of indirection, making the code in one of these function

[issue12760] Add create mode to open()

David Townshend added the comment: It is already possible to write a wrapper function that does it: def create(file): fd = os.open(file, os.O_EXCL | os.O_CREAT | os.O_WRONLY) return os.fdopen(fd) The point it not that it can't be done, but that it is not straight forward. The docs sa

[issue13363] Many usages of dict.keys(), dict.values(), dict.items() when the iter version could be used

Ned Deily added the comment: Thanks for you interest in improving Python. As noted in the response to one of your other issues, we generally do not do style cleanups just for the sake of style cleanups. In addition, our policy for current maintenance branches, like Python 2.7, is to apply bu

[issue13362] Many PEP 8 errors

Raymond Hettinger added the comment: I concur with Benjamin. This is a waste of time and a potential source of new errors. -- nosy: +rhettinger ___ Python tracker ___ _

[issue13357] HTMLParser parses attributes incorrectly.

Changes by Raymond Hettinger : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue13362] Many PEP 8 errors

skreft added the comment: Hi all again: in the original posting of this issue, I asked what would be the best way to address this issue. Additionally I proposed to use existing tools to check the current code. These tools could be easily added to the tests in a non failing mode, so develope

[issue13364] Duplicated Code

New submission from skreft : By using tools like clonedigger is possible to spot some repeated code. One file that caught my attention is Lib/decimal.py. It has many portions of duplicated code. Here is an example: def logical_or(self, other, context=None): """Applies an 'or' operation

[issue13283] removal of two unused variable in locale.py

Jesús Cea Avión added the comment: Éric, thanks for paying attention to this. In this particular case, I checked the code and verified that the variables were not used anywhere. But I will comply with the policy in the future. Thanks again for pointing out. -- __

[issue13363] Many usages of dict.keys(), dict.values(), dict.items() when the iter version could be used

New submission from skreft : In Python 2.7, there are many patterns of the form for x in mapping.(keys()|values()|items()): #code when the iterator version of those method could be used. Is there any reason for using those methods? I see that in some other parts of the code the iterator ver

[issue13362] Many PEP 8 errors

Benjamin Peterson added the comment: Generally, we don't do style cleanups for the sake of style cleanups. -- nosy: +benjamin.peterson resolution: -> rejected status: open -> closed ___ Python tracker ___

[issue13362] Many PEP 8 errors

New submission from skreft : Hi all, I was reading Python's source code and was surprised to find many PEP 8 errors. The file that I found specially non PEP8 compliant is Lib/encodings/punnycode.py, but there are many others that are not compliant. I think that this issue should be addressed,

[issue583975] gethostbyaddr lag

Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue13361] getLogger does not check its argument

Changes by Florent Xicluna : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue13361] getLogger does not check its argument

New submission from Florent Xicluna : >>> import logging >>> log = logging.getLogger(any) Traceback (most recent call last): File "", line 1, in File "./Lib/logging/__init__.py", line 1730, in getLogger return Logger.manager.getLogger(name) File "./Lib/logging/__init__.py", line 1114,

[issue13356] test_logging warning on 2.7

Florent Xicluna added the comment: I suggest to use encoded string as keys in loggerDict. It should solve both issue #8201 and this one. Moreover, it seems in line with msg147191 from Martin on issue #13360. Patch attached. -- components: +Unicode dependencies: -UnicodeWarning raised

[issue13356] test_logging warning on 2.7

Vinay Sajip added the comment: Thanks, Florent. This patch was by you in response to issue #8201 - do you have any suggestion as to the best way to resolve this? I tried changing the non-ASCII logger to '\xc3\xb4\xc3\xbc', which decodes cleanly to u'\xf4\xfc' (o-circumflex u-umlaut), but it a

[issue13323] urllib2 does not correctly handle multiple www-authenticate headers in an HTTP response

David Fischer added the comment: With this patch, the AbstractBasicAuthHandler (and its subclasses) performs a regex search on the amalgamated "www-authenticate" header for basic authentication. This fixes the case where you have an HTTP response of the form: HTTP/1.1 401 Authorization Requ

[issue13360] UnicodeWarning raised on sequence and set comparisons

Martin v. Löwis added the comment: > Often sequences or sets have heterogeneous keys, mixing and > , and in this case there's no easy way to work with them > without raising this UnicodeWarning. That's a bug in the application. You must not mix byte strings and unicode strings as dictionary ke

[issue3932] HTMLParser cannot handle '&' and non-ascii characters in attribute names

Changes by Ezio Melotti : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue13353] documentation problem in logging.handlers.TimedRotatingFileHandler for 2.7

Changes by Vinay Sajip : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue13353] documentation problem in logging.handlers.TimedRotatingFileHandler for 2.7

Roundup Robot added the comment: New changeset 0b779988e8b7 by Vinay Sajip in branch '2.7': Closes issue #13353: version doumentation about utc parameter corrected. http://hg.python.org/cpython/rev/0b779988e8b7 -- nosy: +python-dev ___ Python tracker

[issue3932] HTMLParser cannot handle '&' and non-ascii characters in attribute names

Ezio Melotti added the comment: I'm not sure what is the best solution here. unescape uses a regex with replaceEntities as callback to replace the entities in attribute values. The problem is that replaceEntities currently returns unicode, and if unescape receives a str, an automatic coercion

[issue13360] UnicodeWarning raised on sequence and set comparisons

Florent Xicluna added the comment: Often sequences or sets have heterogeneous keys, mixing and , and in this case there's no easy way to work with them without raising this UnicodeWarning. The "logging" module is such an example. Of course it is only a warning, not a strong annoyance. -

[issue13360] UnicodeWarning raised on dict() and set()

Martin v. Löwis added the comment: I fail to see the issue. What exactly is the problem with the warning? It looks all consistent and helpful to me. -- nosy: +loewis ___ Python tracker ___

[issue13356] test_logging warning on 2.7

Florent Xicluna added the comment: This is the expression which raises the warning. >>> u'compiler.parser' in ['\xab\xd7\xbb', u'\u013f\xd6G'] __main__:1: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal False See also

[issue7777] Support needed for AF_RDS family

Martin v. Löwis added the comment: Not having tests for the control messages is fine with me - we don't need to test Linux, but Python. -- ___ Python tracker ___ ___

[issue10287] NNTP authentication should check capabilities

Nathan Clayton added the comment: When using Easynews, it sends a 480 error (e.g. "nntplib.NNTPTemporaryError: 480 You must log in.") -- ___ Python tracker ___

[issue13360] UnicodeWarning raised on dict() and set()

Florent Xicluna added the comment: Similar expressions where the warning is raised or not (depending on "latin-1" comparison): $ python2.7 -c "print u'd\xe9' in {'foo', 'd\xe9r'}" False $ python2.7 -c "print u'd\xe9' in {'foo', 'd\xe9'}" -c:1: UnicodeWarning: Unicode equal comparison failed t

[issue13356] test_logging warning on 2.7

Changes by Florent Xicluna : -- dependencies: +UnicodeWarning raised on dict() and set() nosy: +flox ___ Python tracker ___ ___ Python

[issue13357] HTMLParser parses attributes incorrectly.

Michael Brooks added the comment: Python 2.7.3 is still affected by both of these issues. On Sun, Nov 6, 2011 at 12:56 PM, Ezio Melotti wrote: > > Ezio Melotti added the comment: > > I mean 2.7.3 (i.e. the development version). > You need to get a clone of Python as explained here: > http://d

[issue13360] UnicodeWarning raised on dict() and set()

New submission from Florent Xicluna : The UnicodeWarning is raised on some dict or set operations. It is not very helpful, and sometimes annoying. And it is somewhat inconsistent. # ** warning not raised ** $ python2.7 -c "print u'd\xe9' in {'foo', 'bar'}" False $ python2.7 -c "print 'd\xe9' i

[issue13359] urllib2 doesn't escape spaces in http requests

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue13359] urllib2 doesn't escape spaces in http requests

New submission from Davide Rizzo : urllib2.urlopen('http://foo/url and spaces') will send a HTTP request line like this to the server: GET /url and spaces HTTP/1.1 which the server obviously does not understand. This contrasts with urllib's behaviour which replaces the spaces (' ') in the url

[issue13357] HTMLParser parses attributes incorrectly.

Ezio Melotti added the comment: I mean 2.7.3 (i.e. the development version). You need to get a clone of Python as explained here: http://docs.python.org/devguide/ -- ___ Python tracker ___

[issue13358] HTMLParser incorrectly handles cdata elements.

Michael Brooks added the comment: Yes I am running python 2.7.2. On Sun, Nov 6, 2011 at 12:52 PM, Ezio Melotti wrote: > > Ezio Melotti added the comment: > > Have you tried with the latest 2.7? (see msg147170) > > -- > nosy: +ezio.melotti > stage: -> test needed > > _

[issue13357] HTMLParser parses attributes incorrectly.

Michael Brooks added the comment: Yes, I am running the latest version, which is python 2.7.2. On Sun, Nov 6, 2011 at 12:14 PM, Ezio Melotti wrote: > > Ezio Melotti added the comment: > > Thanks for the report. > Could you try with the latest 2.7 and see if you can reproduce the > problem? (

[issue13358] HTMLParser incorrectly handles cdata elements.

Ezio Melotti added the comment: Have you tried with the latest 2.7? (see msg147170) -- nosy: +ezio.melotti stage: -> test needed ___ Python tracker ___

[issue13358] HTMLParser incorrectly handles cdata elements.

Changes by Michael Brooks : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue13358] HTMLParser incorrectly handles cdata elements.

New submission from Michael Brooks : The HTML tag at the bottom of this page correctly identified has having cdata like properties and trigger set_cdata_mode(). Due to the cdata properties of this tag, the only way to end the data segment is with a closing tag, NO OTHER tag can close this d

[issue6203] 3.x locale does not default to C, contrary to the documentation and to 2.x behavior

Petri Lehtinen added the comment: If the thread safety of setlocale() is a problem, does anybody know how portable uselocale() is? It sets the locale of the current thread only, so it's safe to temporarily change the locale and then set it back. -- nosy: +petri.lehtinen _

[issue13327] Update utime API to not require explicit None argument

Roundup Robot added the comment: New changeset 99e118951a80 by Brian Curtin in branch 'default': Fix #13327. Remove the need for an explicit None as the second argument to http://hg.python.org/cpython/rev/99e118951a80 -- nosy: +python-dev ___ Python

[issue13340] list.index does not accept None as start or stop

Petri Lehtinen added the comment: It's now reverted on all branches. I posted to python-dev alreay earlier. -- ___ Python tracker ___ ___

[issue13340] list.index does not accept None as start or stop

Roundup Robot added the comment: New changeset 19ffa12ffdd4 by Petri Lehtinen in branch '2.7': Revert "Accept None as start and stop parameters for list.index() and tuple.index()" http://hg.python.org/cpython/rev/19ffa12ffdd4 New changeset ed0e85efac47 by Petri Lehtinen in branch '3.2': Revert

[issue13357] HTMLParser parses attributes incorrectly.

Ezio Melotti added the comment: Thanks for the report. Could you try with the latest 2.7 and see if you can reproduce the problem? (see the devguide for instructions.) If you can reproduce the issue even on the latest 2.7, it would be great if you could provide a patch with a test case like t

[issue13357] HTMLParser parses attributes incorrectly.

New submission from Michael Brooks : Open the attached file "red_test.html" in a browser. The "bad" elements are blue because the style tag isn't parsed by any known browser. However, the HTMLParser library will incorrectly recognize them. -- components: Library (Lib) files: red_te

[issue10115] Support accept4() for atomic setting of flags at socket creation

Antoine Pitrou added the comment: > > The same value as for other non-blocking sockets, IMO. > There are three possible values I think: > 1. parent's current sock_timeout > 2. global default socket timeout > 3. 0 > > Can you please tell which one? I assume it should be number 3. Yes (again, IM

[issue10115] Support accept4() for atomic setting of flags at socket creation

Vetoshkin Nikita added the comment: > The same value as for other non-blocking sockets, IMO. There are three possible values I think: 1. parent's current sock_timeout 2. global default socket timeout 3. 0 Can you please tell which one? I assume it should be number 3. -- __

[issue10115] Support accept4() for atomic setting of flags at socket creation

Antoine Pitrou added the comment: > What value should we assign to sock->sock_timeout if SOCK_NONBLOCK was > specified in accept4() call? The same value as for other non-blocking sockets, IMO. > And in socket.py should we check as in original accept: > if getdefaulttimeout() is None and self.

[issue13356] test_logging warning on 2.7

New submission from Ezio Melotti : $ ./python -Wd -3 -m test.regrtest -v test_logging == CPython 2.7.2+ (2.7:39573be48b4a, Nov 6 2011, 17:13:44) [GCC 4.6.1] == Linux-3.0.0-12-generic-i686-with-debian-wheezy-sid little-endian == /home/wolf/dev/py/wide-2.7/build/test_python_6508 Testing with fl

[issue10115] Support accept4() for atomic setting of flags at socket creation

Vetoshkin Nikita added the comment: up? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13340] list.index does not accept None as start or stop

Raymond Hettinger added the comment: One other thought: the API for list.index() doesn't exist in isolation. There is also str.index, the sequence abstract base class, and tons of code that has been written to emulate lists. This is an ancient API (approx 20 years) and should only be chang

[issue13340] list.index does not accept None as start or stop

Raymond Hettinger added the comment: > There's still the question whether {list,tuple}.index() should accept None or > not. The API should not be changed for Py2.7 and Py3.2. Those changesets should be reverted. For Py3.3, it is open to discussion, but we probably don't need the change (ma

[issue13355] random.triangular error when low = mode

Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7777] Support needed for AF_RDS family

Charles-François Natali added the comment: Here's an updated patch: - address returned by recvfrom() - recv flags (MSG_PEEK) - congestion behavior I've also added a bunch of constants: - all the typical SO_ constants - CMSG flags - RDMA-related options (RDMA is probably one of the most useful f

[issue13353] documentation problem in logging.handlers.TimedRotatingFileHandler for 2.7

Changes by Ezio Melotti : -- nosy: +vinay.sajip stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue13350] Use PyUnicode_FromFomat instead of PyUnicode_Format for fixed formats

Amaury Forgeot d'Arc added the comment: Now PyUnicode_Format is only called by unicode_mod... -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue13350] Use PyUnicode_FromFomat instead of PyUnicode_Format for fixed formats

Roundup Robot added the comment: New changeset 386a319b1825 by Amaury Forgeot d'Arc in branch 'default': Issue #13350: Replace most usages of PyUnicode_Format by PyUnicode_FromFormat. http://hg.python.org/cpython/rev/386a319b1825 -- nosy: +python-dev ___

[issue10570] curses.tigetstr() returns bytes, but curses.tparm() expects a string

STINNER Victor added the comment: > The entry in Misc/NEWS mentions the change in curses.tigetstr(), > but actually curses.tparm() has been changed Woops, thanks for fixing the NEWS file :-) -- ___ Python tracker

[issue10287] NNTP authentication should check capabilities

Antoine Pitrou added the comment: > By always sending capabilities at connection, some servers immediately > throw an error. I've modified the class initialization to include an > optional parameter to indicate if this should be disabled. Which kind of error? As Julien says, we could simply cat

[issue10287] NNTP authentication should check capabilities

Julien ÉLIE added the comment: A drawback is that CAPABILITIES will still being unsent after an upgrade of the news server to a more up-to-date version supporting the command. If CAPABILITIES is not understood by the news server, it is not an issue. A 500 response code is usually answered by

[issue13355] random.triangular error when low = mode

Mark Dickinson added the comment: > it would be convenient if low=high=mode returned low (or mode or high) Yes, I agree that random.triangular should degrade gracefully, in the same way that random.uniform does. -- ___ Python tracker

[issue13350] Use PyUnicode_FromFomat instead of PyUnicode_Format for fixed formats

Petri Lehtinen added the comment: This would chop unnecessary lines of code very nicely. +1 -- ___ Python tracker ___ ___ Python-bugs

[issue13338] Not all enumerations used in _Py_ANNOTATE_MEMORY_ORDER

Changes by Petri Lehtinen : -- keywords: +needs review stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue13340] list.index does not accept None as start or stop

Petri Lehtinen added the comment: > Or am I misunderstanding? Ah, no, sorry. I wasn't aware of this. Now the error message set by _PyEval_SliceIndex() makes sense. It doesn't itself accept None, but apply_slice() and assign_slice() handle the None case. There's still the question whether {li

[issue13338] Not all enumerations used in _Py_ANNOTATE_MEMORY_ORDER

Floris Bruynooghe added the comment: Apologies for not attaching a patch, I thought it was pretty trivial. Attached it now. -- keywords: +patch Added file: http://bugs.python.org/file23616/pyatomic.diff ___ Python tracker

[issue13340] list.index does not accept None as start or stop

Mark Dickinson added the comment: > What do you suggest? Doing it in _PyEval_SliceIndex() in 2.7 is > problematic, as we don't want x[None:2], right? :) Eh? Don't we already have this? Python 2.7.2 (default, Aug 22 2011, 13:53:27) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin Type "he

[issue13355] random.triangular error when low = mode

Mark added the comment: Many thanks, Mark. I'm very new to python so apologies for my obvious mistake (you were absolutely right, I was feeding the high and mode in back to front). As a separate aside, it would be convenient if low=high=mode returned low (or mode or high) rather than error b

[issue13355] random.triangular error when low = mode

Mark Dickinson added the comment: I can't reproduce this: Python 2.7.2 |EPD 7.1-2 (32-bit)| (default, Jul 3 2011, 15:40:35) [GCC 4.0.1 (Apple Inc. build 5493)] on darwin Type "packages", "demo" or "enthought" for more information. >>> from random import triangular >>> triangular(low=1, high=2

[issue13355] random.triangular error when low = mode

New submission from Mark : When low and mode are the same in random.triangular it gives the following error: : float division args = ('float division',) message = 'float division' When high and mode are the same there is no problem. -- components: Extension Modules mess

[issue13354] tcpserver should document non-threaded long-living connections

New submission from Bas Wijnen : http://docs.python.org/py3k/library/socketserver.html says: The solution is to create a separate process or thread to handle each request; the ForkingMixIn and ThreadingMixIn mix-in classes can be used to support asynchronous behaviour. There is another way, w

[issue10570] curses.tigetstr() returns bytes, but curses.tparm() expects a string

Changes by Arfrever Frehtes Taifersar Arahesis : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue7777] Support needed for AF_RDS family

Martin v. Löwis added the comment: I think the patch currently lacks a lot of symbolic constants; see my review. -- ___ Python tracker ___ ___

[issue10570] curses.tigetstr() returns bytes, but curses.tparm() expects a string

Roundup Robot added the comment: New changeset 3a0a94797ac5 by Petri Lehtinen in branch '3.2': curses.tparm() is expecting a byte string, not curses.tigetstr() http://hg.python.org/cpython/rev/3a0a94797ac5 New changeset 626c6c7f3af6 by Petri Lehtinen in branch 'default': curses.tparm() is expec

[issue13350] Use PyUnicode_FromFomat instead of PyUnicode_Format for fixed formats

Martin v. Löwis added the comment: +1 -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://