[issue13241] llvm-gcc-4.2 miscompiles Python (XCode 4.1 on Mac OS 10.7)

2011-11-07 Thread Lucas Sinclair
Lucas Sinclair added the comment: Well the configure parameters suggested by Michael Foord worked. I was able to build cpython on a mac. But I could not have guessed how to make it work. Shouldn't these instructions be added here http://docs.python.org/devguide/ ? Shouldn't the latest version

[issue13254] maildir.items() broken

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: This is a transient failure, other builds are successful. Maybe the line "time.sleep(2.01 + self._box._skewfactor)" could be changed to "time.sleep(2.5 + self._box._skewfactor)" in test_mailbox.TestMaildir.test_reread. Closing because it's not related to th

[issue13367] PyCapsule_New's argument *must* not a NULL.

2011-11-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: In this context, "may" means "allowed to". In other words, it is equivalent to "The pointer argument is not allowed to be NULL". -- nosy: +benjamin.peterson resolution: -> works for me status: open -> closed ___

[issue13367] PyCapsule_New's argument *must* not a NULL.

2011-11-07 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13368] Possible problem in documentation of module subprocess, method send_signal

2011-11-07 Thread Eli Bendersky
New submission from Eli Bendersky : docs@ list report by Daniel Dieterle: in the documentation (http://docs.python.org/library/subprocess.html#subprocess.Popen.send_signal) is a bug. CTRL_C_EVENT can not be sent to processes started with a creationflags parameter which includes CREATE_NEW_PR

[issue11812] transient socket failure to connect to 'localhost'

2011-11-07 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: About the "support.HOST", changing from "localhost" to "127.0.0.1" could be problematic is servers without IPv4 support (servers IPv6 only). I guess this is a theorical problem so far, and that when we find this issue the exception would be pretty obvious...

[issue11812] transient socket failure to connect to 'localhost'

2011-11-07 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Checking the testsuite source code, I see several issues: The server thread only waits for 3 seconds for the connection. If a connection is not created before 3 seconds, the server suicides and when the connection is tried, it will fail. This probably explai

[issue13367] PyCapsule_New's argument *must* not a NULL.

2011-11-07 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue13367] PyCapsule_New's argument *must* not a NULL.

2011-11-07 Thread INADA Naoki
New submission from INADA Naoki : http://docs.python.org/c-api/capsule.html?highlight=capsule#PyCapsule_New > The pointer argument may not be NULL. I think "must not" is correct. -- assignee: docs@python components: Documentation messages: 147269 nosy: docs@python, naoki priority: norm

[issue9375] ElementPath parser in ElementTree 1.3 does not reject "element//" as invalid

2011-11-07 Thread Florent Xicluna
Changes by Florent Xicluna : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1200313] HTMLParser fails to handle charref in attribute value

2011-11-07 Thread Ezio Melotti
Ezio Melotti added the comment: unescape() already converts named, decimal and hexadecimal entities, so this can be closed. -- assignee: fdrake -> ezio.melotti nosy: +ezio.melotti resolution: -> out of date stage: test needed -> committed/rejected status: open -> closed _

[issue13241] llvm-gcc-4.2 miscompiles Python (XCode 4.1 on Mac OS 10.7)

2011-11-07 Thread Michael Foord
Michael Foord added the comment: Ah, it seems I have XCode 3.2.6 installed alongside XCode 4.2. -- ___ Python tracker ___ ___ Python-

[issue13309] test_time fails: time data 'LMT' does not match format '%Z'

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: LMT stands for Local Mean Time. I found a report of someone having an issue parsing timezone with Python 2.6. Looks quite similar. http://www.aczoom.com/forums/blockhosts/mar-10-151801-domains-blockhosts5599-error-failed-to-parse-date-for-ip-18911419951

[issue13241] llvm-gcc-4.2 miscompiles Python (XCode 4.1 on Mac OS 10.7)

2011-11-07 Thread Michael Foord
Michael Foord added the comment: On OS X Lion, with XCode 4.2 installed, I find the following works (no need to install macports): ./configure CC=gcc-4.2 --prefix=/dev/null --with-pydebug -- nosy: +michael.foord ___ Python tracker

[issue13313] test_time fails: tzset() do not change timezone

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: Maybe it is related. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=93810 Ambiguous timezone names (AEST vs EST) -- ___ Python tracker ___

[issue13335] Service application hang in python25.dll

2011-11-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am closing this because there is no issue for currently maintained CPython. If you have further questions, try python-list or a question-answer forum such as StackOverflow. -- resolution: -> out of date status: open -> closed _

[issue13327] Update utime API to not require explicit None argument

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5e18ff5476e8 by Brian Curtin in branch 'default': News updates for #13327. http://hg.python.org/cpython/rev/5e18ff5476e8 -- ___ Python tracker ___

[issue13327] Update utime API to not require explicit None argument

2011-11-07 Thread Brian Curtin
Brian Curtin added the comment: Changeset 045e8757f10d was also entered for this, which should conclude the changes. Everything seems to have survived the buildbots for now, so closing as fixed. Feel free to reopen if there are any other issues. -- resolution: -> fixed stage: patch r

[issue13366] test_pep277 failures under WIndows

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2cd6b417e488 by Florent Xicluna in branch 'default': Some win32 platforms raise NotADirectoryError, others FileNotFoundError. Issue #13366. http://hg.python.org/cpython/rev/2cd6b417e488 -- ___ Python tr

[issue13327] Update utime API to not require explicit None argument

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 59dca1e2363d by Brian Curtin in branch 'default': Fix #13327. utimensat now has the atime and mtime arguments set as optional, http://hg.python.org/cpython/rev/59dca1e2363d -- ___ Python tracker

[issue13211] urllib2.HTTPError does not have 'reason' attribute.

2011-11-07 Thread Jason R. Coombs
Jason R. Coombs added the comment: My initial instinct was to agree - the status code is useful. However, in looking at the FTP code, it sometimes just sets other objects (socket.error for example) as the 'reason'. The docs say 'reason' is a string or another exception. I'm tempted to leave

[issue13254] maildir.items() broken

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: test fails on x86 Windows7 2.7 buildbot (ok on 3.2 and 3.3) test_unix_mbox (test.test_mailbox.MaildirTestCase) ... D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\dbapi.py:649: DeprecationWarning: buffer() not supported in 3.x b =

[issue13345] Invisible Files in Windows 7

2011-11-07 Thread Martin v . Löwis
Martin v. Löwis added the comment: Closing the report as invalid then. -- resolution: -> invalid status: open -> closed ___ Python tracker ___ _

[issue13366] test_pep277 failures under WIndows

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 655d65bcc939 by Florent Xicluna in branch 'default': Closes #13366: fix test_pep277 failure on Windows. http://hg.python.org/cpython/rev/655d65bcc939 -- nosy: +python-dev resolution: -> fixed stage: needs patch -> committed/rejected status

[issue13361] getLogger does not check its argument

2011-11-07 Thread Eric Snow
Eric Snow added the comment: FYI, the following changesets were also for this issue. They had the wrong issue number (#13661, which doesn't actually exist so no big deal), which is why they didn't show up in this issue automatically. New changeset 5f3b7528b144 by Vinay Sajip in branch '2.7'

[issue13211] urllib2.HTTPError does not have 'reason' attribute.

2011-11-07 Thread Petri Lehtinen
Petri Lehtinen added the comment: Perhaps the reason should include the status code, too? It makes HTTP errors much more useful, as you'll immediately see what's going on from the status code. -- ___ Python tracker

[issue13173] Default values for string.Template

2011-11-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: When I need defaults, I make them part of the mapping that gets passed into .substitute() and .safe_substitute(). It doesn't feel to me like it's necessary to attach them to the Template instance. Also, couldn't you just subclass string.Template if you wan

[issue13284] email.utils.formatdate function does not handle timezones correctly.

2011-11-07 Thread R. David Murray
R. David Murray added the comment: formatdate doesn't know anything about datetimes, so it doesn't make any sense to me to say that it doesn't notice changes in tzinfo. That's why the fix for issue 665194 introduces a new method for formatting datetimes. -- _

[issue13366] test_pep277 failures under WIndows

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: I'm guilty on this one :-) -- assignee: -> flox components: +Windows -Interpreter Core keywords: +buildbot nosy: +flox ___ Python tracker ___

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2011-11-07 Thread Ross Lagerwall
Ross Lagerwall added the comment: Thanks Charles, I'll take your comments into account and take a look at making a general walker method. -- ___ Python tracker ___ _

[issue6397] Implementing Solaris "/dev/poll" in the "select" module

2011-11-07 Thread Ross Lagerwall
Changes by Ross Lagerwall : -- nosy: +rosslagerwall ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue13366] test_pep277 failures under WIndows

2011-11-07 Thread Antoine Pitrou
New submission from Antoine Pitrou : The 3.x Windows buildbots all fail in test_pep277. == FAIL: test_open (test.test_pep277.UnicodeFileTests) -- Traceback (m

[issue13284] email.utils.formatdate function does not handle timezones correctly.

2011-11-07 Thread Vitja Makarov
Vitja Makarov added the comment: I'm not quite sure. The problem is email.utils.formatdate doesn't respect TZ info changes since it uses time.timezone (or time.altzone) for utc offset. Btw it seems that issue 665194 should fix the problem. -- ___

[issue13348] test_unicode_file fails: shutil.copy2 says "same file"

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset fcff91a7b397 by Florent Xicluna in branch 'default': More assertions in test_unicode_file, to chase issue #13348. http://hg.python.org/cpython/rev/fcff91a7b397 -- nosy: +python-dev ___ Python tracker

[issue13284] email.utils.formatdate function does not handle timezones correctly.

2011-11-07 Thread R. David Murray
R. David Murray added the comment: Unless I misunderstand your concerns, this is a duplicate of issue 665194. -- nosy: +r.david.murray resolution: -> duplicate status: open -> closed superseder: -> datetime-RFC2822 roundtripping ___ Python tracker

[issue13284] email.utils.formatdate function does not handle timezones correctly.

2011-11-07 Thread Vitja Makarov
Vitja Makarov added the comment: Perhaps it's better to calculate utc-offset for each timestamp cause we never know what is correct timezone for given time. That could be done in C: localtime, utc_offset = time.localtime_ex(t) Where localtime is the same as returned by localtime() and utc_of

[issue13193] test_packaging and test_distutils failures

2011-11-07 Thread Vinay Sajip
Vinay Sajip added the comment: > > That it depends on the architecture currently baffles me. > The only explanation I can come up with is that on different machines, the order of the tests might be slightly different. That would allow the flag to be set differently on different machines, bas

[issue13322] buffered read() and write() does not raise BlockingIOError

2011-11-07 Thread sbt
sbt added the comment: Testing the patch a bit more thoroughly, I found that data received from the readable end of the pipe can be corrupted by the C implementation. This seems to be because two of the previously dormant codepaths did not properly maintain the necessary invariants. I got t

[issue13193] test_packaging and test_distutils failures

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: > By "flag" I mean _cache_generated_egg ("flag" as in Boolean value) Ah, I had forgotten this earlier message: > I get the opposite failure to Nadeem as far as > InstallDataTestCase.test_resources: it works on > Ubuntu 64-bit, but fails on 32-bit. Digging into it

[issue13364] Duplicated code in decimal module

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the report. If I may offer recommendations about submitting bugs: - Know that stable branches don’t get code cleanups, only bug fixes, so you have to target 3.3 - Focused bugs (“code duplication in packaging commands”) are much better that over-broad

[issue7252] list().index() should provide better error reporting

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: > FWIW, quickly grepping through the raises of ValueErrors in the 2.6 > stdlib doesn't bring up any other usage of repeat-with-fake-variable-x. #13349 begs to differ :) -- nosy: +eric.araujo ___ Python tracker

[issue13349] Uninformal error message in index() and remove() functions

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: > There's also documentation and tests that depend on this actual error message: > Doc/library/doctest.rst: ValueError: list.remove(x): x not in list > Lib/test>/test_xml_etree.py:ValueError: list.remove(x): x not in list That’s a well-known doctest problem.

[issue13349] Uninformal error message in index() and remove() functions

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: > The good thing about this is ease of debugging. Exactly! +1 for the idea. > On the other hand, the repr of a value might be very long: You can restrict the length with % formats. > Also, all values don't have a very informal repr: Not your problem. This chang

[issue13341] Incorrect documentation for "u" PyArg_Parse format unit

2011-11-07 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue7897] Support parametrized tests in unittest

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: Another nice API: http://feldboris.alwaysdata.net/blog/unittest-template.html -- ___ Python tracker ___ ___

[issue13283] removal of two unused variable in locale.py

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: > Éric, thanks for paying attention to this. You’re welcome. I hope that my commits get reviewed too. > In this particular case, I checked the code and verified that the > variables were not used anywhere. Yep, I can’t imagine third-party code being broken by thi

[issue13193] test_packaging and test_distutils failures

2011-11-07 Thread Vinay Sajip
Vinay Sajip added the comment: > >>  entirely deterministic: I couldn't see any other reason why the flag > would have different values >>  on different machines. > Sorry, what flag? By "flag" I mean _cache_generated_egg ("flag" as in Boolean value) > Patches for upstream cpython would be mo

[issue11610] Improved support for abstract base classes with descriptors

2011-11-07 Thread Éric Araujo
Changes by Éric Araujo : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-b

[issue13211] urllib2.HTTPError does not have 'reason' attribute.

2011-11-07 Thread Jason R. Coombs
Jason R. Coombs added the comment: I've created three changesets, addressing the issue in 2.7, 3.2, and 3.3, including tests. Please review and comment. If there are no objections, I'll push the changesets after 24 hours. -- ___ Python tracker

[issue13211] urllib2.HTTPError does not have 'reason' attribute.

2011-11-07 Thread Jason R. Coombs
Changes by Jason R. Coombs : Added file: http://bugs.python.org/file23627/fffeff7721c0.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue13211] urllib2.HTTPError does not have 'reason' attribute.

2011-11-07 Thread Jason R. Coombs
Changes by Jason R. Coombs : -- hgrepos: +88 keywords: +needs review, patch ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue13193] test_packaging and test_distutils failures

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: [global variables] > one possible approach might be: Have those bindings be instance variables in > a Database class in > database.py, and have a module-level binding to an instance of it. Then, > tests can have their > own instance which is thrown away aftereach

[issue13345] Invisible Files in Windows 7

2011-11-07 Thread Jon Bryan
Jon Bryan added the comment: Thanks for the suggestions. Since I can put the OEM-supplied DLL in another directory and everything works just fine, I'm not going to spend any more time on it. I assume that it's something to do with file permissions in Win7 that I don't have any inclination t

[issue11610] Improved support for abstract base classes with descriptors

2011-11-07 Thread Darren Dale
Darren Dale added the comment: I just double-checked that the unit tests do not raise any warnings with this patch. Can it be merged? -- ___ Python tracker ___ ___

[issue7071] distutils and IronPython compatibility

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: I think this change was wrong. Please see my rationale in http://bugs.python.org/issue12119. (BTW, I’d be surprised if byte compilation was the only compat issue with distutils and IronPython. For a start, sys.version[:3] is used to get the version number. I

[issue13193] test_packaging and test_distutils failures

2011-11-07 Thread Vinay Sajip
Vinay Sajip added the comment: Re. Paul Moore's comment - IMO he's right about the problem, but changing only packaging.manifest._translate_pattern doesn't do it. The equivalent fix has to be made in distutils.filelist.translate_pattern. I've made the change in the pythonv branch, and the tes

[issue6397] Implementing Solaris "/dev/poll" in the "select" module

2011-11-07 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue13224] Change str(class) to return only the class name

2011-11-07 Thread Éric Araujo
Éric Araujo added the comment: I misreported: dict.update is actually okay, but collections.Counter.update (a Python method) is a not an unbound method but a function (py3k-style). -- ___ Python tracker _

[issue6397] Implementing Solaris "/dev/poll" in the "select" module

2011-11-07 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Please, review. With current code, each devpoll object has capacity for managing 256 fds, by default. This is about 2048 bytes. The cost seems reasonable, since a normal program will have only a few devpoll objects around. I have considered an optional para

[issue13365] str.expandtabs documentation is wrong

2011-11-07 Thread Eli Bendersky
Eli Bendersky added the comment: Other than that, the patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue6397] Implementing Solaris "/dev/poll" in the "select" module

2011-11-07 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : Added file: http://bugs.python.org/file23626/528fdd816160.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue6397] Implementing Solaris "/dev/poll" in the "select" module

2011-11-07 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : Removed file: http://bugs.python.org/file23532/0b701eb5e9e3.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue13365] str.expandtabs documentation is wrong

2011-11-07 Thread Eli Bendersky
Eli Bendersky added the comment: While we're at it, wouldn't it be clearer to say "... where each tab character is replaced by..."? -- nosy: +eli.bendersky ___ Python tracker _

[issue13358] HTMLParser incorrectly handles cdata elements.

2011-11-07 Thread Michael Brooks
Michael Brooks added the comment: This one should also have a priority change. Tested python 2.7.3 --MIke On Sun, Nov 6, 2011 at 12:54 PM, Michael Brooks wrote: > > Michael Brooks added the comment: > > Yes I am running python 2.7.2. > > On Sun, Nov 6, 2011 at 12:52 PM, Ezio Melotti >wrote:

[issue13365] str.expandtabs documentation is wrong

2011-11-07 Thread John Feuerstein
New submission from John Feuerstein : The documentation for str.expandtabs([tabsize]) is wrong: "Return a copy of the string where all tab characters are replaced by one or more spaces, depending on the current column and the given tab size. [...]" This should read "zero or more spaces": >>>

[issue13152] textwrap: support custom tabsize

2011-11-07 Thread John Feuerstein
John Feuerstein added the comment: textwrap_tabsize_v2.diff: * Moved the tabsize parameter to the end of the parameter list * Added documentation update * Made the test case more obvious -- Added file: http://bugs.python.org/file23624/textwrap_tabsize_v2.diff _

[issue13362] Many PEP 8 errors

2011-11-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2011/11/7 skreft : > > skreft added the comment: > > Hi all again: > > in the original posting of this issue,  I asked what would be the best way to > address this issue. Additionally I proposed to use existing tools to check > the current code. These tool

[issue12567] curses implementation of Unicode is wrong in Python 3

2011-11-07 Thread John Feuerstein
Changes by John Feuerstein : -- nosy: +john.feuerstein ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue13335] Service application hang in python25.dll

2011-11-07 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Unfortunately there is not much in the process call stack: the creation of a list (PyList_New) needs to allocate some memory (not much: sizeof(PyListObject) + gc overhead, probably 32 bytes). If the system malloc() function fails and returns NULL, Pytho

[issue13335] Service application hang in python25.dll

2011-11-07 Thread Chandra Sekhar Reddy
Chandra Sekhar Reddy added the comment: Hi Amaury and Terry, Thanks for your feedback, actually the product that we have delivered to customer is now in support phase, so currently there is no development going on, so we cannot use the latest python. It would be of great help if you could p

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2011-11-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I think the best thing would be to let rmtree fail (provided it closes > all the FDs it opened) Agreed. -- ___ Python tracker ___ __

[issue13361] getLogger does not check its argument

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 60dd1568bbd1 by Vinay Sajip in branch '2.7': Closes #13361: Raise correct exception type. http://hg.python.org/cpython/rev/60dd1568bbd1 New changeset bc05c11b340e by Vinay Sajip in branch '3.2': Closes #13361: Raise correct exception type. http://h

[issue13349] Uninformal error message in index() and remove() functions

2011-11-07 Thread Petri Lehtinen
Petri Lehtinen added the comment: The good thing about this is ease of debugging. You can see which is the offending value that was not found. On the other hand, the repr of a value might be very long: >>> [].index(list(range(1000))) ValueError: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, ... (man

[issue13361] getLogger does not check its argument

2011-11-07 Thread Vinay Sajip
Vinay Sajip added the comment: @Florent: Sorry, I didn't see your patch, for some reason. But I would say: 1. I agree that where I put the check (logging.getLogger) does not catch the case where someone instantiates the logger directly (using logging.Logger(any)), but users aren't supposed to

[issue13361] getLogger does not check its argument

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: btw, changeset a3ba905447ba does not fix the case for: import logging log = logging.Logger(any) -- ___ Python tracker ___ ___

[issue13356] test_logging warning on 2.7

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8726ad774cf0 by Vinay Sajip in branch '2.7': Closes #13356. Thanks to Florent Xicluna for the patch. http://hg.python.org/cpython/rev/8726ad774cf0 -- nosy: +python-dev resolution: -> fixed stage: patch review -> committed/rejected status:

[issue13361] getLogger does not check its argument

2011-11-07 Thread Florent Xicluna
Florent Xicluna added the comment: I've uploaded two proposals: - first with isinstance(name, str) - second which is more duck-friendly Personally, I like ducks. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file23623/issue13361_dont_check.diff ___

[issue13361] getLogger does not check its argument

2011-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8c719e106694 by Vinay Sajip in branch 'default': Merged fix for #13361 from 3.2. http://hg.python.org/cpython/rev/8c719e106694 -- nosy: +python-dev ___ Python tracker

[issue13361] getLogger does not check its argument

2011-11-07 Thread Florent Xicluna
Changes by Florent Xicluna : -- keywords: +patch Added file: http://bugs.python.org/file23622/issue13361_check.diff ___ Python tracker ___ ___

[issue13364] Duplicated Code

2011-11-07 Thread skreft
skreft added the comment: One possible refactor would be. import operator def logical_or(self, other, context=None): return self._logical_op(other, operator.__or__, context) def logical_xor(self, other, context=None): return self._logical_op(other, operator.__xor__, contex