[issue14656] Add a macro for unreachable code

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: Sorry, I missed the patch. I still fail to see the problem that this solves: what compiler produces "control reaches end of non-void function without return" for the current code? ISTM that your patch has the potential of *introducing* such a warning on some

[issue14529] distutils's build_msi command ignores the data_files argument

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: Mario: would you like to work on a patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue14530] distutils's build_wininst command fails to correctly interpret the data_files argument

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: Mario: would you like to work on a patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue9123] insecure os.urandom on VMS

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: I'm closing this as "won't fix". Unless somebody is able to report that they actually tested the proposed change successfully, there is no point in adding it. Most likely, Python won't even build on VMS, in which case this is not a security issue at all. --

[issue9377] socket, PEP 383: Mishandling of non-ASCII bytes in host/domain names

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: For Windows versions that support it, we could use GetNameInfoW, available on XPSP2+, W2k3+ and Vista+. The questions then are: what to do about gethostbyaddr, and what to do about the general case? Since the problem appears to be specific to Windows, it mi

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6c9ce7e34511 by Martin v. Löwis in branch 'default': Issue #13183: Revert 0b53b70a40a0 (reenable test on windows) http://hg.python.org/cpython/rev/6c9ce7e34511 -- ___ Python tracker

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: > But it is strange behavior that "stepping through" enters print in > Windows and does not so in Unix. What's the difference in windows > that could cause this? Not sure if this was expected behavior. On Unix, the codec most likely is UTF-8, which is directly

[issue13210] Support Visual Studio 2010

2012-05-01 Thread Brian Curtin
Brian Curtin added the comment: As of a40f47cc7691, Richard's idea is now the implementation, which seems to work well and has simplified the changes quite well. Attached is code_changes.diff which shows all of the necessary code changes as of now. The test_import failure you were originally

[issue14626] os module: use keyword-only arguments for dir_fd and nofollow to reduce function count

2012-05-01 Thread Larry Hastings
Larry Hastings added the comment: > I personally think that offering mere wrappers around syscalls doesn't > make much sense: Python is a very-high level language, and so should > its library be. I very much agree. I suggest anyone who thinks the os module is a thin veneer over syscalls needs

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed again with replacing print with pass. But it is strange behavior that "stepping through" enters print in Windows and does not so in Unix. What's the difference in windows that could cause this? Not sure if this was expected behavior. -- _

[issue14632] Race condition in WatchedFileHandler leads to unhandled exception

2012-05-01 Thread Brian Curtin
Brian Curtin added the comment: The test for this issue seems to fail about half of the time on Windows. == ERROR: test_race (test.test_logging.HandlerTest) -

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3b2aa777b725 by Senthil Kumaran in branch '2.7': fix windows test failure - issue13183 http://hg.python.org/cpython/rev/3b2aa777b725 New changeset d17ecee3f752 by Senthil Kumaran in branch '3.2': fix windows test failure - issue13183 http://hg.pyth

[issue14687] Optimize str%tuple for the PEP 393

2012-05-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4b98ce6ef95e by Victor Stinner in branch 'default': Issue #14687: Optimize str%args http://hg.python.org/cpython/rev/4b98ce6ef95e New changeset a966f9311ebb by Victor Stinner in branch 'default': Issue #14687: Cleanup PyUnicode_Format() http://hg.p

[issue10376] ZipFile unzip is unbuffered

2012-05-01 Thread James Hutchison
James Hutchison added the comment: See attached, which will open a zipfile that contains one file and reads it a bunch of times using unbuffered and buffered idioms. This was tested on windows using python 3.2 You're in charge of coming up with a file to test it on. Sorry. Example output: E

[issue14704] NameError Issue in Multiprocessing

2012-05-01 Thread Mark Dickinson
Mark Dickinson added the comment: Thanks for the report. This is expected behaviour. It isn't actually anything to do with multiprocessing; it's to do with invoking exec from within a function scope. You can see the same effect with code like this: code = """\ def show_name(): print

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: That indeed makes the test pass. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue14704] NameError Issue in Multiprocessing

2012-05-01 Thread David M. Rogers
New submission from David M. Rogers : Python Devs, There is an issue relating to variable lookup using exec from within multiprocessing's fork()-ed process. I'm attempting to use the forked process as a generic remote python shell, but exec is unable to reach variables from within function

[issue14468] Update cloning guidelines in devguide

2012-05-01 Thread Éric Araujo
Changes by Éric Araujo : -- assignee: -> sandro.tosi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue14468] Update cloning guidelines in devguide

2012-05-01 Thread Sandro Tosi
Sandro Tosi added the comment: +1 It is important to note that if you have a 'cpython' as a clone (which pulls and pushed to hg.python.org) and from it you clone '2.7' and '3.2' (as I think it's the most common setup) you first have to pull from cpython and then on the other 2. Anyhow, is a

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Xavier de Gaye
Xavier de Gaye added the comment: My fault :( The call to print is useless for the test, so I suggest to replace it with a plain 'pass' statement. -- ___ Python tracker ___

[issue13183] pdb skips frames after hitting a breakpoint and running step

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: The test fails on Windows. Whereas on Unix, the two step commands produce this output: -> print('1') (Pdb) step 1 --Return-- > /net/pao/export/home/staff/loewis/work/33/bar.py(2)bar()->None -> print('1') (Pdb) step --Return-- > /net/pao/export/home/staff/loew

[issue1303434] Please include pdb with windows distribution

2012-05-01 Thread Martin v . Löwis
Martin v. Löwis added the comment: All active branches use this now. -- status: open -> closed ___ Python tracker ___ ___ Python-bu

[issue14532] multiprocessing module performs a time-dependent hmac comparison

2012-05-01 Thread Jon Oberheide
Jon Oberheide added the comment: > You should explain what you already said: it is not a risk because the > length of a HMAC is fixed. Well, that's not entirely accurate. Exposing the length of the HMAC can expose what underlying hash is being used (eg. HMAC-SHA1 has different length than HMA

[issue13959] Re-implement parts of imp in pure Python

2012-05-01 Thread Brett Cannon
Brett Cannon added the comment: That test is going to stay intermittent until issue #14657 gets resolved else the exact reason for the failure is going to be hard to debug remotely. -- ___ Python tracker

[issue13959] Re-implement parts of imp in pure Python

2012-05-01 Thread Benjamin Peterson
Benjamin Peterson added the comment: Windows is currently failing test_imp: http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%203.x/builds/214/steps/test/logs/stdio -- nosy: +benjamin.peterson ___ Python tracker

[issue14699] Calling a classmethod_descriptor directly raises a TypeError for wrong number of parameters.

2012-05-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset eab5120cc208 by Benjamin Peterson in branch '3.2': fix calling the classmethod descriptor directly (closes #14699) http://hg.python.org/cpython/rev/eab5120cc208 New changeset e1a200dfd5db by Benjamin Peterson in branch 'default': merge 3.2 (#14699)

[issue6759] zipfile.ZipExtFile.read() is missing universal newline support

2012-05-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I know how to remove universal newline support, I know how after this correct these functions (with issue14371 they partially corrected), but I don't know how to deprecate universal newline support. What should be done? Can you initiate a discussion in Python-

[issue13585] Add contextlib.ExitStack

2012-05-01 Thread Nick Coghlan
Nick Coghlan added the comment: Latest draft of API is here: http://contextlib2_dev.readthedocs.org/en/latest/index.html#contextlib2.ExitStack An updated version of the "I forgot I could use multiple context managers in a with statement" example: with ExitStack() as stack: src =

[issue9400] multiprocessing.pool.AsyncResult.get() messes up exceptions

2012-05-01 Thread Richard Oudkerk
Richard Oudkerk added the comment: There are plenty of other "bad" exception classes apart from CalledProcessError, including TimeoutExpired in the same file. In fact I suspect this is true of the majority of the exception classes in the stdlib which override __init__. So I am not sure how

[issue14669] test_multiprocessing failure on OS X Tiger

2012-05-01 Thread Charles-François Natali
Charles-François Natali added the comment: The buildbot seems happy, let's close! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker __

[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X

2012-05-01 Thread Hynek Schlawack
Changes by Hynek Schlawack : -- assignee: -> hynek title: shutil.move broken in 2.7.3 on OSX (chflags fails) -> shutil.move doesn't handle ENOTSUP raised by chflags on OS X ___ Python tracker

[issue14082] shutil doesn't copy extended attributes

2012-05-01 Thread Hynek Schlawack
Hynek Schlawack added the comment: I have answered to the (two weeks old :-/) review. There are three open questions in there we'll have to figure out before I fix the patch: - should copyxattr() remove xattrs in dst that aren't present in src? Make it an option like `remove_missing_xattr`?

[issue14694] Option to show leading zeros for bin/hex/oct

2012-05-01 Thread Eric V. Smith
Eric V. Smith added the comment: I agree with Mark. This can also be done slightly more efficiently with plain format(): >>> format(324, "016b") '000101000100' >>> format(324, "016o") '0504' >>> format(324, "016x") '0144' And with either format() or str.format(), y

[issue14694] Option to show leading zeros for bin/hex/oct

2012-05-01 Thread Mark Dickinson
Mark Dickinson added the comment: I'm rejecting this: the functionality is already there in str.format, and there's little to be gained by adding another way to do it. -- nosy: +eric.smith resolution: -> rejected status: open -> closed ___ Python t

[issue14699] Calling a classmethod_descriptor directly raises a TypeError for wrong number of parameters.

2012-05-01 Thread Mark Shannon
Mark Shannon added the comment: New patch in response to review. -- Added file: http://bugs.python.org/file25431/classmethoddescr_call.patch ___ Python tracker ___ _

[issue14532] multiprocessing module performs a time-dependent hmac comparison

2012-05-01 Thread STINNER Victor
STINNER Victor added the comment: > However, this generally is not a security risk. You should explain what you already said: it is not a risk because the length of a HMAC is fixed. -- ___ Python tracker

[issue14366] Supporting lzma compression in zip files

2012-05-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Note that the supporting of bzip2 increases the time of testing test_zipfile in 1.5x, and lzma -- 2x (total 3x). May be not all tests are needed? -- ___ Python tracker _

[issue14366] Supporting lzma compression in zip files

2012-05-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is the patch which adds support for lzma in zipfile. Later I'll move `lzma_props_encode` and `lzma_props_decode` to lzma module. -- Added file: http://bugs.python.org/file25430/lzma_in_zip.patch ___ Python tra