Martin v. Löwis mar...@v.loewis.de added the comment:
It's not an official API, as the leading underscore specifies. Changing the
comment sounds fine to me.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15213
Nick Coghlan ncogh...@gmail.com added the comment:
Correctly avoiding symlink attacks, which is the whole reason the POSIX *at
variants and the dir_fd parameters were added, is not trivial in general.
os.fwalk and shutil.rmtree went through many iterations before reaching a state
where they
Nick Coghlan ncogh...@gmail.com added the comment:
My current opinion is that this should be a PEP for 3.4, to make sure we flush
out all the corner cases and other details correctly.
--
versions: +Python 3.4 -Python 3.3
___
Python tracker
Nick Coghlan ncogh...@gmail.com added the comment:
For that matter, with the relevant codecs restored in 3.2, a transform() helper
could probably be added to six (or a new project on PyPI) to prototype the
approach.
--
___
Python tracker
New submission from Frank Ling ufwt...@gmail.com:
i use socket such as :
self.socket.setblocking(1)
self.socket.settimeout(1)
but this socket is no-block ,i find socketmodule.c sock_settimeout
s-sock_timeout = timeout;
internal_setblocking(s, timeout 0.0);
if timeout
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11959
___
___
Serhiy Storchaka storch...@gmail.com added the comment:
Here is updated patches. The type of exception thrown when specifying
mutually exclusive arguments changed from ValueError to TypeError (in
accordance with the raised in similar conflicts exceptions). Slightly
modified documentation. Taken
Hynek Schlawack h...@ox.cx added the comment:
Try running the test like:
./python[.exe] -bb -Wd -m test test_ipaddress
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14814
___
Patrick Westerhoff patrickwesterh...@gmail.com added the comment:
Hey, I just saw the release notes for 3.3 and would like a quick confirmation:
This is included in 3.3, right? ^^
--
___
Python tracker rep...@bugs.python.org
Christian Heimes li...@cheimes.de added the comment:
Am 28.06.2012 07:54, schrieb Martin v. Löwis:
Martin v. Löwis mar...@v.loewis.de added the comment:
a) my patch handles the fork() issue correctly
If the system has urandom, yes.
That's the easy and trivial case. It also handles
Antoine Pitrou pit...@free.fr added the comment:
+except Exception:
I don't think that's a good idea. You should list the specific exceptions here
(NotImplementedError, OSError perhaps?).
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka storch...@gmail.com added the comment:
Unless there are places where it is actually broken, I don't think there is a
good reason to have step 3.5, though. Just add the deprecation warning and
remove it in 4.0.
Well. In any case, the 'U' mode in most cases has no effect,
Tim Golden m...@timgolden.me.uk added the comment:
Attached is a patch against Python 2.7. It checks in a loop for SIGINT and, if
it still hasn't fired, assumed Ctrl-Z was pressed which generates the same
error.
--
assignee: - tim.golden
keywords: +patch
Added file:
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file26197/deprecate-U-mode-stage1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15204
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26198/deprecate-U-mode-stage2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15204
___
Hynek Schlawack h...@ox.cx added the comment:
Thanks you for catching that! It seems we did something really stupid: followed
symlinks.
I’ve fixed that and added regression tests. This one is a facepalm gentlepeople.
--
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset f9f798f1421e by Hynek Schlawack in branch 'default':
#4489: Don't follow ever symlinks in rmtree
http://hg.python.org/cpython/rev/f9f798f1421e
--
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
Yes, this is normal. Timeout sockets use a non-blocking fd internally:
http://docs.python.org/dev/library/socket.html#notes-on-socket-timeouts
This won't be visible to you if you only use the socket object, but it will if
you call fileno() and
Changes by Hynek Schlawack h...@ox.cx:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4489
___
Nick Coghlan ncogh...@gmail.com added the comment:
Setting as a release blocker for 3.4 - this is important.
--
priority: normal - release blocker
stage: commit review -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7475
Senthil Kumaran sent...@uthcode.com added the comment:
Right now, I do not see the problem mentioned in this report.
http://www.python.org/doc/ point to a page which has reference docs to both 2.7
and 3.0.
The left hand side, Other Resources Link are generic too.
docs.python.org pointing to
New submission from Nick Coghlan ncogh...@gmail.com:
As discussed on python-ideas, swapping out the sys.std* streams can be fraught
with peril. This can make writing code that wants to support an --encoding
option for pipeline processing difficult.
The proposal [1] is that TextIOWrapper
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c37cb11b546f by Petri Lehtinen in branch '2.7':
#9559: Append data to single-file mailbox files if messages are only added
http://hg.python.org/cpython/rev/c37cb11b546f
New changeset 5f447a005d67 by Petri Lehtinen
Petri Lehtinen pe...@digip.org added the comment:
Fixed. I removed the extra newlines.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9559
___
Petri Lehtinen pe...@digip.org added the comment:
See #15122 for always modifying single-file mailboxes in-place.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9559
___
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
versions: +Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10571
___
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Shouldn't we be using a proper synchronization primitive? What about waiting
for an event?
--
nosy: +kristjan.jonsson
___
Python tracker rep...@bugs.python.org
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
In fact, there is _PyOS_SigintEvent at the end of signalmodule.c
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Larry Hastings la...@hastings.org added the comment:
I'm not a security guy, but: shouldn't the os.unlink call when it isn't a
directory specify follow_symlinks=False? And wouldn't it be safer if the
os.rmdir() call also used dir_fd=?
Additionally, I think you missed some stuff for
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Is the ERROR_OPERATION_ABORTED set when Ctrl-Z is hit?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Hynek Schlawack h...@ox.cx added the comment:
I'm not a security guy, but: shouldn't the os.unlink call when it isn't a
directory specify follow_symlinks=False?
os.unlink has no follow_symlinks argument. Imagine what would happen if
you‘d do a os.unlink() on a link and it would just remove
Larry Hastings la...@hastings.org added the comment:
I'm pretty busy right now, please open a ticket for listdir.
_rmtree_safe_fd could remove the directory just after the recursive step using
the parent's dirfd. Of course you'd also have to add a rmdir for the
very-tippy-top after the
New submission from Hynek Schlawack h...@ox.cx:
n = os.open('/tmp', os.O_RDONLY)
l = os.listdir(n)
os.listdir in os.supports_dir_fd
False
--
assignee: larry
components: Library (Lib)
messages: 164249
nosy: hynek, larry
priority: release blocker
severity: normal
stage: needs patch
Tim Golden m...@timgolden.me.uk added the comment:
Yep.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list mailing
Hynek Schlawack h...@ox.cx added the comment:
I'm pretty busy right now, please open a ticket for listdir.
done
_rmtree_safe_fd could remove the directory just after the recursive step
using the parent's dirfd. Of course you'd also have to add a rmdir for the
very-tippy-top after the
Tim Golden m...@timgolden.me.uk added the comment:
To be clear: ERROR_OPERATION_ABORTED is set when Ctrl-Z is hit as the
only thing on a line. If it's just an extra character then it operates
like any other keypress.
--
___
Python tracker
Petri Lehtinen pe...@digip.org added the comment:
I had exactly the same error on 3.3b1 when running the test suite with
randomized order.
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13886
Petri Lehtinen pe...@digip.org added the comment:
The _pre_mailbox_hook may be called twice, like this:
babyl = mailbox.Babyl('new_file')
babyl.add('foo\n')
babyl.remove(0)
babyl.add('bar\n')
This only affects Babyl, that writes the mailbox header in _pre_mailbox_hook.
The mailbox is
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 9134bb4d0578 by Hynek Schlawack in branch 'default':
#4489: Use dir_fd in rmdir in _rmtree_safe_fd()
http://hg.python.org/cpython/rev/9134bb4d0578
--
___
Python tracker
Serhiy Storchaka storch...@gmail.com added the comment:
The proposal [1] is that TextIOWrapper support a set_encoding() method that
is only supported between creation of the stream and the first read or write
operation.
IMHO encoding, errors, buffering, line_buffering and newline should
Pankaj D p...@comcast.net added the comment:
I believe I have found the root-cause for this issue.
It is occurring due to the use of the garbage collector in another
“memMonitor” thread (we run it periodically to get stats on objects, track mem
leaks, etc). Since
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15217
___
___
Python-bugs-list
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Meador, can we close this issue?
--
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12142
___
New submission from Hynek Schlawack h...@ox.cx:
Currently not all functions are checked. As soon as #15217 is fixed, we have to
add the rest.
--
assignee: hynek
components: Library (Lib)
files: fd-protection.diff
keywords: patch
messages: 164259
nosy: hynek
priority: release blocker
Changes by Hynek Schlawack h...@ox.cx:
--
dependencies: +os.listdir is missing in os.supports_dir_fd
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15218
___
Tyler Crompton gtr...@gmail.com added the comment:
I'm in a little over my head as I can't conceptualize __cause__, so I may be
looking over things.
First, you, Ethan, said the following:
It's also not difficult to work around if you really want to toss the extra
info:
except
Tim Golden m...@timgolden.me.uk added the comment:
This patch is for 2.7 and does enough to solve the issue without a major
rework. The signal module onthe default branch has had a lot of love
recently and I'll definitely make use of that for a 3.x patch.
--
Meador Inge mead...@gmail.com added the comment:
Meador, can we close this issue?
I wanted to keep it open until the 'long double' problem is fixed as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12142
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15218
___
___
Python-bugs-list
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Thanks for the analysis!
This is quite similar to issue793822: gc.get_referrers() can access unfinished
tuples. The difference here is that what breaks is not the monitoring tool,
but the main program!
Here is a simple script
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Hm, I wonder if the test for the SIGINT event is required at all.
Could it be sufficient to simply check for the EOF state? EOF would indicate
ctrl z and distinguish it thus from ctrl-c.
--
Marc Abramowitz msabr...@gmail.com added the comment:
I don't know if I'll have time soon to do the tweaks to Ronan's test (and maybe
he wants to do them himself anyway?), but here's the correction of the size
calculation in the header (from size of bytecode to size of source -- thanks,
Nick Coghlan ncogh...@gmail.com added the comment:
Yep - note that PEP 409 was updated to say that the the implementation
discussion has been superceded by PEP 415. It may be worth making that note
more prominent, though...
--
___
Python tracker
Michael Gundlach gundl...@gmail.com added the comment:
I recently started getting what appears to be this bug in 2.6.6 and 2.7.3 when
connecting to Google.
My script does this:
while True:
get an IMAP connection to Google, if our old one timed out
fetch unread messages. if any:
Nick Coghlan ncogh...@gmail.com added the comment:
If you don't want the exception context set *at all*, just use a pass statement
to get out of the exception before trying the fallback.
try:
return windows_module.getch()
except NameError:
pass # No exception chaining
Nick Coghlan ncogh...@gmail.com added the comment:
Correction, your try block is overbroad and will suppress errors in the getch
implementation. This is better:
try:
_getch = windows_module.getch
except NameError:
_ getch = fallback_module.getch
_getch()
So I'm
Antoine Pitrou pit...@free.fr added the comment:
[...]
Should this Issue be reopened or should I file a new Issue?
I would prefer a new issue to be filed (assuming the error happens
again).
--
___
Python tracker rep...@bugs.python.org
Ethan Furman et...@stoneleaf.us added the comment:
Tyler Crompton wrote:
I'm in a little over my head as I can't conceptualize __cause__, so I may be
looking over things.
First, you, Ethan, said the following:
It's also not difficult to work around if you really want to toss the extra
Ethan Furman et...@stoneleaf.us added the comment:
Removed sample code from doc patch as it was not robust, nor recommended
practice. New patch is effectively:
Note: Because using :keyword:`from` can throw away valuable debugging
information, its use with a bare :keyword:`raise` is not
Antoine Pitrou pit...@free.fr added the comment:
I wonder why _pysqlite_fetch_one_row() releases the GIL around
sqlite3_column_type(). By its name, it doesn't sound like an expensive function.
Another workaround would be to call PyTuple_SET_ITEM instead of PyTuple_SetItem.
--
New submission from Michael Fötsch foet...@yahoo.com:
If the name argument to _hashlib.new() is not a string, the reference count
for the string argument is not decremented.
In the file Modules/_hashopenssl.c, function EVP_new(), a call to
PyBuffer_Release() is missing:
if
Tim Golden m...@timgolden.me.uk added the comment:
Nope. Ctrl-C also sets EOF
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Michael Fötsch foet...@yahoo.com added the comment:
The change is against the 2.7 branch. The 3.2 branch is not affected.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15219
___
Jesús Cea Avión j...@jcea.es added the comment:
Could you possibly provide a testcase?.
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15219
___
Tim Golden m...@timgolden.me.uk added the comment:
And here's a patch for the default branch, using the new sigint event as
Kristan suggested.
--
Added file: http://bugs.python.org/file26202/issue1677-python3x.patch
___
Python tracker
Serhiy Storchaka storch...@gmail.com added the comment:
Terry, try a large constant. I can reproduce it on all versions from 2.6 to 3.3
with eval(() * 30).
--
nosy: +storchaka
versions: +Python 2.6, Python 3.1, Python 3.2, Python 3.3, Python 3.4
Serhiy Storchaka storch...@gmail.com added the comment:
I think it's a bug. The issue can be closed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15077
___
Serhiy Storchaka storch...@gmail.com added the comment:
I think it's *not* a bug. The issue can be closed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15077
___
Matthew Barnett pyt...@mrabarnett.plus.com added the comment:
It's not a bug, it's a pathological regex (i.e. it causes catastrophic
backtracking).
It also works correctly in the regex module.
--
___
Python tracker rep...@bugs.python.org
Pankaj D p...@comcast.net added the comment:
Wondering the same thing myself, and yes sqlite3_column_type() by itself
doesn't seem expensive. I assumed in general it was to allow more
responsiveness for apps with huge number of columns (i.e. large tuple size).
But we have about 20-25
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Here is a test, which fails when I run regrtest with leak detection:
./python -m test.regrtest -R:: test_hashlib
--
keywords: +patch
nosy: +amaury.forgeotdarc
Added file: http://bugs.python.org/file26203/hashlib-leak.patch
Antoine Pitrou pit...@free.fr added the comment:
Are there any guidelines on when GIL should be released?
The GIL should be released:
- for CPU-heavy external functions (e.g. compression, cryptography)
- for external functions which wait for I/O
Re PyTuple_SET_ITEM...yes that's also a
Serhiy Storchaka storch...@gmail.com added the comment:
Does anyone know a good way to make the exception render as: must be str,
not int instead of must be str, not class 'int' ?
raise TypeError('must be str, not %s' % type(s).__name__)
--
nosy: +storchaka
Serhiy Storchaka storch...@gmail.com added the comment:
The following code prevents another prompt from appearing:
And this a more serious issue concerns 3.3.
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15217
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15216
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15218
___
Terry J. Reedy tjre...@udel.edu added the comment:
In 3.3.3a4 and b1, with original 3, I no longer get TypeError, but box
python(w).exe has stopped working. So either Win7, 64 bit, on machine with
much more memory makes a diffence, or something in code reverted. Is this
really a security
Serhiy Storchaka storch...@gmail.com added the comment:
I don't think that eval is used in security context.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5765
___
Larry Hastings la...@hastings.org added the comment:
I want to mark this as wontfix.
os.listdir in os.supports_fd
True
The concept we're struggling with here: is the fd you pass in to os.listdir a
dir_fd? I claim that it isn't. I'm trying to enforce the concept, in both
the documentation
Hynek Schlawack h...@ox.cx added the comment:
I don't really care about the name but I'd really like some way to check
whether listdir supports fds.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15217
Larry Hastings la...@hastings.org added the comment:
Like I said: use os.supports_fd.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15217
___
Patrick Westerhoff patrickwesterh...@gmail.com added the comment:
Alright, thought so but wanted a confirmation anyway – thanks a lot :D
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14133
Hynek Schlawack h...@ox.cx added the comment:
Ah sorry, that wasn't in the mail (stupid ).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15217
___
New submission from R. David Murray rdmur...@bitdance.com:
The idea for the attached patch comes from the QNX development team. In their
measurements, replacing the re.split-plus-line-reassembly code in
BufferedSubFile with str.splitlines provided a 30% reduction in email parsing
time. The
Nadeem Vawda nadeem.va...@gmail.com added the comment:
+1 for the general idea of deprecating and eventually removing the U
modes.
But I agree with David, that it doesn't make sense to have separate steps
for 3.5 and 3.6/4.0. If you make the code raise an exception when U is
used, how is that
Changes by Antoine Pitrou pit...@free.fr:
--
stage: test needed - patch review
versions: +Python 2.7 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10571
___
Changes by Antoine Pitrou pit...@free.fr:
--
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10571
___
___
Python-bugs-list
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset ef16a3db4628 by Antoine Pitrou in branch '3.2':
Issue #10571: Fix the --sign option of distutils' upload command.
http://hg.python.org/cpython/rev/ef16a3db4628
New changeset b45f105dbdfb by Antoine Pitrou in branch
Antoine Pitrou pit...@free.fr added the comment:
Committed. Thank you Jakub!
--
nosy: +pitrou
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Looks good to me.
--
assignee: - amaury.forgeotdarc
nosy: +pitrou
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15219
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 49dee01d72f9 by Amaury Forgeot d'Arc in branch '2.7':
Issue #15219: Fix a reference leak when hashlib.new() is called with
http://hg.python.org/cpython/rev/49dee01d72f9
--
nosy: +python-dev
Larry Hastings la...@hastings.org added the comment:
I'm closing this. os.listdir should not be listed in supports_dir_fd, because
it has no dir_fd parameter.
For reference, we discussed all this previously in issue #15176.
--
resolution: - invalid
stage: needs patch -
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c974c99acdf5 by Amaury Forgeot d'Arc in branch 'default':
Port tests from Issue #15219, and verify we don't have a reference leak.
http://hg.python.org/cpython/rev/c974c99acdf5
--
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Fixed in 2.7, and ported test to 3.3.
Thanks for the report and the fix!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 9854520c8200 by Antoine Pitrou in branch '3.2':
Issue #5067: improve some json error messages.
http://hg.python.org/cpython/rev/9854520c8200
New changeset 7523ab4e6e06 by Antoine Pitrou in branch 'default':
Issue
Antoine Pitrou pit...@free.fr added the comment:
Committed now. Thanks Serhiy for the patch!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15145
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15071
___
___
1 - 100 of 112 matches
Mail list logo
