Roundup Robot added the comment:
New changeset dbbf3ccf72e8 by Stefan Krah in branch '3.2':
Issue #15736: Fix overflow in _PySequence_BytesToCharpArray().
http://hg.python.org/cpython/rev/dbbf3ccf72e8
--
nosy: +python-dev
___
Python tracker
Stefan Krah added the comment:
I used the cast for gcc = 4.6 and the assert() as a courtesy to
authors of buggy sq_length() functions. Thanks for the comments!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Trent Nelson added the comment:
All my servers are set to use UTC, which affects how FreeBSD (and other BSDs)
treat the isdst param in struct tm in mktime:
#include stdio.h
#include string.h
#include time.h
int main(int argc, char **argv)
{
struct tm tm1, tm2;
time_t t1, t2;
Raymond Hettinger added the comment:
Caching based on the cursor going to be problematic because a single cursor can
be used multiple times with different descriptions:
c = conn.cursor()
c.execute('select symbol from stocks')
print c.description
c.execute('select price from
Trent Nelson added the comment:
Looks like os.readlink() is busted:
/home/trent/src/cpython/Lib/shutil.py(107)copyfile()
- os.symlink(os.readlink(src), dst)
(Pdb) s
TypeError: embedded NUL character
/home/trent/src/cpython/Lib/shutil.py(107)copyfile()
- os.symlink(os.readlink(src), dst)
New submission from Jeff Knupp:
patch to test_json to not use assert(Raises)Regexp, which has been deprecated
in favor of assert(Raises)Regex.
--
components: Tests
files: json_deprecated.patch
keywords: patch
messages: 168750
nosy: Jeff.Knupp
priority: normal
severity: normal
status:
Roundup Robot added the comment:
New changeset 3a02a1f7d069 by Ezio Melotti in branch '3.2':
#15752: s/assertRaisesRegexp/assertRaisesRegex/g
http://hg.python.org/cpython/rev/3a02a1f7d069
New changeset b36ce0a3a844 by Ezio Melotti in branch 'default':
#15752: merge with 3.2.
Ezio Melotti added the comment:
Fixed, thanks for the patch!
--
assignee: - ezio.melotti
nosy: +ezio.melotti
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
versions: +Python 3.2
___
Python tracker
Ned Deily added the comment:
The patch as it stands causes _ctypes build failures when using the 10.4u SDK
as in the traditional 10.3+ 32-bit-only installer configuration. Apparently,
in ppc-ffi_darwin.c, the skip that the patch removes was because
OSCacheControl.h doesn't exist in the 10.4u
George-Cristian Bîrzan added the comment:
This patch introduced a regression. Before, parse_args would take a tuple as an
argument, and in _get_values it was converted to a list via list comprehension,
which meant it was working with tuples too. In the current version, that raises
an
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +belopolsky, haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15750
___
___
STINNER Victor added the comment:
email.utils.localtime() may reuse the new datetime.datetime.timestamp() method,
except that this method doesn't support setting isdst (it is set to -1).
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Copy of the test:
def test_alias_nofallback(self):
if _have_soundcard():
# Note that this is not the same as asserting RuntimeError
# will get raised: you cannot convert this to
# self.assertRaises(...) form.
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15745
___
___
Python-bugs-list
New submission from James:
For example:
Python 3.2.2 (default, Feb 10 2012, 09:23:17)
[GCC 4.4.5 20110214 (Red Hat 4.4.5-6)] on linux2
Type help, copyright, credits or license for more information.
class A:
... def f(*args):
... print(super().__repr__())
...
A().f()
Steven Bethard added the comment:
@gcbirzan: Could you please open up a new issue? The current issue is fixed -
it's just that the fix caused a new issue.
I would say that the `args` parameter was never intended to be anything but a
list, so currently there's a documentation bug since that
R. David Murray added the comment:
This is 3.3 only, as those tests and the function they test were only
introduced in 3.3.
--
components: +email
nosy: +barry, r.david.murray
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
Russell Sim added the comment:
Raymond, Thanks for the comprehensive feedback! It's fantastic! I have updated
the patch with most of you feedback... but there was one part that I couldn't
follow entirely. I am now using the _make method but I have had to use star
unpacking to allow the
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15753
___
___
Nick Coghlan added the comment:
You should be able to just use tuple(col[0] for col in cursor.description)
instead of the current list comprehension in order to make the argument
hashable.
--
___
Python tracker rep...@bugs.python.org
Russell Sim added the comment:
Nick, Thanks for the tip. I have removed the star unpacking.
--
Added file: http://bugs.python.org/file26946/issue_13299.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13299
Antoine Pitrou added the comment:
a function that mod_wsgi can call to set the interpreter used by the
GIL state APIs to implicitly create new thread states.
How would it work?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15745
___
___
Python-bugs-list mailing
Antoine Pitrou added the comment:
The attached (crufty) patch sets the environment variable during
test_ssl.NetworkedTests and that also avoids the test failure. It might
be useful to add this functionality to the test case (but less crufty,
and with a comment that explains why this is
Nick Coghlan added the comment:
It would twiddle the autoInterpreterState and autoTLSkey entries in the
pystate.c global variables to point to a different subinterpreter.
As I understand the situation, mod_wsgi doesn't need arbitrary externally
created threads to be able to call back into
Jeremy Kloth added the comment:
Here is the patch implementing option #2
--
keywords: +patch
nosy: +jkloth
Added file: http://bugs.python.org/file26947/test_startfile.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15526
Nick Coghlan added the comment:
Graham, even better would be if you could try the following combination:
_PyGILState_Fini();
_PyGILState_Init(si, st);
(where si and st are the interpreter state and thread state for the target
subinterpreter)
If a new PyGILState_SwitchInterpreter API is going
Antoine Pitrou added the comment:
As I understand the situation, mod_wsgi doesn't need arbitrary
externally created threads to be able to call back into arbitrary
subinterpreters, it just needs to be able to direct externally created
threads in a process to a subinterpreter other than the
Stefan Krah added the comment:
Looks like a ZFS/nanosecond issue. My FreeBSD buildbot uses FFS and does not
have the failures.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15745
___
Nick Coghlan added the comment:
Just as they do today, all externally created threads will still go to *one*
interpreter when they hit PyGILState_Ensure(). It's just that interpreter won't
be the main one.
Since the whole point of the PyGILState API is to support threads that don't
have a
Antoine Pitrou added the comment:
Just as they do today, all externally created threads will still go to
*one* interpreter when they hit PyGILState_Ensure(). It's just that
interpreter won't be the main one.
Uh but how does it solve the issue? (unless you create a mod_wsgi app
with only a
Amaury Forgeot d'Arc added the comment:
The example script has two errors IMO:
- XOpenDisplay accepts a char*, but display_url is certainly a unicode string;
it should be converted to a bytes string::
xlib.XOpenDisplay(display_url.encode('utf-8'))
- XOpenDisplay.restype is not set, so it
Ronald Oussoren added the comment:
Attached cleaner version of the test:
* use self.addCleanup instead of a tearDown method
* add comment that explains why the code is present
* setUp method is only active on OSX
--
Added file: http://bugs.python.org/file26948/issue15740-2.txt
Antoine Pitrou added the comment:
Attached cleaner version of the test:
* use self.addCleanup instead of a tearDown method
* add comment that explains why the code is present
* setUp method is only active on OSX
Looks good to me, thank you.
--
Nick Coghlan added the comment:
My understanding of the mod_wsgi architecture is that it uses subinterpreters
to maintain a persistent process, while still providing a relatively pristine
interpreter state to handle each new request. This means even when you're using
multiple processes with a
New submission from John Taylor:
According to:
http://www.sqlite.org/releaselog/3_7_12.html
SQLite has the ability to, Report the name of specific CHECK constraints that
fail.
CPython 3.3.0b2 which uses SQLite version 3.7.12 does not report which
constraint failed.
--
import platform,
John Taylor added the comment:
When I run this under Windows 7:
Platform : CPython 3.3.0b2
SQLite : 3.7.12
Traceback (most recent call last):
File C:bug.py, line 34, in module
c.execute(query, (2012-18-20, ) )
sqlite3.IntegrityError: constraint failed
--
Nick Coghlan added the comment:
Sorry, I mischaracterised the way mod_wsgi works slightly. However, my
understanding is still that the scope of this particular fix is merely to allow
all external threads to be redirected to a different subinterpreter at various
times over the life of a
Antoine Pitrou added the comment:
My understanding of the mod_wsgi architecture is that it uses
subinterpreters to maintain a persistent process, while still
providing a relatively pristine interpreter state to handle each new
request.
I don't think that's true. On hg.python.org, the
Changes by danblack daniel.bl...@openquery.com:
Removed file:
http://bugs.python.org/file26918/issue_10852_pop-smtp-imap-nntp.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
___
danblack added the comment:
previous patch had dumb error and even failed test suit. Now fixed.
--
Added file: http://bugs.python.org/file26949/issue10852-sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
R. David Murray added the comment:
This is a new feature (ie: adding support for a new feature of sqlite).
Would you like to propose a patch?
--
nosy: +r.david.murray
stage: - needs patch
type: behavior - enhancement
versions: +Python 3.4 -Python 3.3
Antoine Pitrou added the comment:
Thanks for the patch, Daniel. 3.3 is nearing the release candidate phase, so
I'm re-targetting to 3.4. I'll take a detailed look soon.
(I suppose there's no easy way to write automated tests for this, unfortunately)
--
stage: - patch review
versions:
Antoine Pitrou added the comment:
By the way, could you sign a contributor agreement? You can find instructions
at http://www.python.org/psf/contrib/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
Changes by Jody McIntyre scj...@modernduck.com:
--
nosy: +scjody
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14452
___
___
Python-bugs-list
R. David Murray added the comment:
Having said this is a feature, since it would only affect the error message,
I'm actually open to it as a bug fix. It won't make it into 3.3.0 even if
someone proposes a patch, though, given that we are so late in the release
process.
--
Alberto Milone added the comment:
I can confirm that the suggested changes solve the problem here. Thanks
everyone!
--
resolution: - invalid
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15637
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
___
___
Nick Coghlan added the comment:
s/slightly/completely/ (I believe my description of the core problem was right,
but my description of why that problem exists was wrong - it actually has to do
with the way mod_wsgi handles virtual hosts and endpoints)
If we expose an official way to switch the
John Taylor added the comment:
I believe patching Python is beyond my programming capability. I would be very
interested in seeing this in 3.3.1. How else could I assist in making this
happen? Thanks!
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
If we expose an official way to switch the destination of the
PyGILState APIs, then what it means is that mod_wsgi can, over the
lifecycle of a single process in the pool, *switch* the virtual host
and WSGI endpoint that process is handling by changing the
Nick Coghlan added the comment:
Umm, no. The whole point of the GILState API is that you can call it from a
thread which knows *nothing* about Python.
It will then use the *process global* state in the pystate.c statics to
initialise that thread with a Python thread state. Currently, that
R. David Murray added the comment:
Well, it would be patching the sqlite extension module. Not that that is much
different :)
Hopefully the current sqlite extension maintainer will think this is worthwhile
doing. Short of waiting for that, you could perhaps ask on the python-list
email
Antoine Pitrou added the comment:
Umm, no. The whole point of the GILState API is that you can call it
from a thread which knows *nothing* about Python.
No to what? Any sane callback API allows to pass it some user data, that
user data can just as well include the pointer to the desired
danblack added the comment:
test_sni not working. getpeercert() not returning a certificate.
--
keywords: +patch
nosy: +daniel-black
Added file: http://bugs.python.org/file26950/issue8109_server_side_sni.patch
___
Python tracker
Chris Jerdonek added the comment:
I would be happy to take a look at this and propose a patch.
--
nosy: +cjerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15754
___
Ned Deily added the comment:
Keep in mind that Python itself does not release with nor mandate a specific
version of sqlite3. When building CPython yourself, it will use what version
is found on your system. Distributors of built Pythons, including the
python.org Windows and OS X
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6422
___
___
Python-bugs-list
Antoine Pitrou added the comment:
In #5442, I proposed leaving the architecture of the module alone, and
simply exposing the main module functionality as a high level helper
function:
Agreed with Nick's approach above.
Victor, if you want to improve timeit's reliability, please open a
New submission from Todd Whiteman:
In the case of a errno.ECHILD exception - Python's subprocess module misses
the fact that the process has already ended.
The following code will wait indefinitely, even though the launched process is
quickly ended:
import subprocess, signal
Changes by Todd Whiteman twhit...@yahoo.com.au:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15756
___
___
Todd Whiteman added the comment:
The attached patch handles errno.ECHILD in the _internal_poll() method and I've
updated the existing sigchild_ignore.py test file to perform polling as well.
An unpatched version of Pyhton would normally hang on this particular test,
whilst the patched version
Ezio Melotti added the comment:
Ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
I haven't been able to test this via Python because my system sqlite3 version
isn't new enough. But I was able to test this against sqlite3 directly. I
suspect there may be no issue.
John, have you tried naming your constraint?
Changes by Georg Brandl ge...@python.org:
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15748
___
___
Python-bugs-list mailing
John Taylor added the comment:
Chris,
I will try naming the constraints and will then follow-up.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15754
___
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15637
___
Éric Araujo added the comment:
FWIW I agree with Antoine’s comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14468
___
___
Larry Hastings added the comment:
I'll ask the obvious: was that an optimized build? Not that that explains the
bug--but that might explain why length appeared to contain 24.
It's hard to believe this is really an OS bug...
--
___
Python tracker
New submission from Trent Nelson:
All the FreeBSD build slaves seem to be experiencing the same symptom:
./configure --with-pydebug eventually results in this:
gcc -pthread -c -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes -O2
-pipe -fno-strict-aliasing -Wall -march=native -I.
Trent Nelson added the comment:
Hi Larry,
Funnily enough, I just tried to step through a heavily hacked version of
posix_readlink again, only to get gdb telling me I couldn't 'print' the
variables I had added in.
Turns out, `./configure --with-pydebug` on FreeBSD ends up with '-O2' being
Trent Nelson added the comment:
Ah!
% gmake
gcc -pthread -c -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes-I.
-I./Include-DPy_BUILD_CORE -o Modules/python.o ./Modules/python.c
gcc -pthread -c -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes-I.
-I./Include
Larry Hastings added the comment:
Can you tell me which code path it took? Either by walking through the code as
it runs, or by telling me about the preprocessor defines used by utime
(HAVE_FUTIMES, HAVE_FUTIMENS, HAVE_FUTIMESAT, HAVE_UTIMENSAT, HAVE_UTIMES,
HAVE_UTIME_H). The easy way to
Alexandre Vassalotti added the comment:
Some quick thoughts about the new implicit memoization scheme in Stefan's
implementation.
- The new scheme will need to be documented in PEP 3154 before we can accept
the change.
- I don't really like the idea of changing the semantics of the PUT and
Trent Nelson added the comment:
So, looks like FreeBSD's /usr/share/mk/sys.mk is to blame here. It
unconditionally sets CFLAGS to `-O2 -pipe`.
[trent@hydrogen/ttypts/1(~s/cpython)%] uname -a
FreeBSD hydrogen.snakebite.net 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r0: Mon
Jul 16 06:28:19 UTC
Trent Nelson added the comment:
print(_have_functions)
['HAVE_FACCESSAT', 'HAVE_FCHDIR', 'HAVE_FCHMOD', 'HAVE_FCHMODAT',
'HAVE_FCHOWN', 'HAVE_FEXECVE', 'HAVE_FDOPENDIR', 'HAVE_FPATHCONF',
'HAVE_FSTATAT', 'HAVE_FSTATVFS', 'HAVE_FTRUNCATE', 'HAVE_FUTIMES',
'HAVE_FUTIMESAT', 'HAVE_LINKAT',
Graham Dumpleton added the comment:
In both embedded mode and daemon mode of mod_wsgi, albeit how thread pool is
managed is different, there is a fixed number of threads with those being
dedicated to handling web requests.
On a request arriving next available thread from the thread pool
New submission from Richard Oudkerk:
Piping significant amounts of data through a subprocess using
Popen.communicate() is crazily slow on Windows.
The attached program just pushes data through mingw's cat.exe.
Python 3.3:
amount = 1 MB; time taken = 0.07 secs; rate = 13.51 MB/s
amount = 2 MB;
Changes by Richard Oudkerk shibt...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file26953/popen_communicate.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15758
Trent Nelson added the comment:
Well, bugger me, check this out:
import os
import stat
import tempfile
d = tempfile.mkdtemp()
src = os.path.join(d, 'foo')
dst = os.path.join(d, 'bar')
src_link = os.path.join(d, 'baz')
dst_link = os.path.join(d, 'qux')
sf = open(dst, 'w')
sf.write('foo')
Antoine Pitrou added the comment:
Le mardi 21 août 2012 à 22:14 +, Graham Dumpleton a écrit :
Any third party module then which uses the simplistic calling sequence
of calling PyGILState_Release() on exiting Python code and thence
within the same thread calling PyGILState_Ensure() when
Graham Dumpleton added the comment:
Those macros only work for general GIL releasing and pop straight away, not for
the case where released, calls into some non Python C library, which then calls
back into Python.
My recollection is, and so unless they have changed it, SWIG generated calls
Chris Jerdonek added the comment:
When building CPython yourself, it will use what version is found on your
system.
Ned, this is somewhat off-topic to the issue, but do you know of any ways to
tell CPython to use a particular version of sqlite3 at compile time if a system
has different
Antoine Pitrou added the comment:
Those macros only work for general GIL releasing and pop straight
away, not for the case where released, calls into some non Python C
library, which then calls back into Python.
I see, so you are right that this new API could be useful. However, we
should
Antoine Pitrou added the comment:
Yes, I think FileIO.readall() should be fixed rather than avoided.
--
nosy: +pitrou
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15758
Richard Oudkerk added the comment:
There is a cute way to use operator.attrgetter to produce backwards compatible
pickles using the qualname:
import pickle, copyreg, operator, sys, pickletools, types
class AttrGetter(object):
def __init__(self, name):
self.name = name
def
Ned Deily added the comment:
The magic for building the standard library's dynamically loaded extensions is
in the top-level setup.py. It uses Distutils to do the work with a lot of
hacking around in setup.py. Without modifying setup.py, it can be a little
tricky to override the search
Larry Hastings added the comment:
mtime is never converted into a decimal. Do you perhaps mean double?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15745
___
Roundup Robot added the comment:
New changeset 019a2390b014 by Trent Nelson in branch '3.2':
Issue #15747: skip chflags UF_IMMUTABLE tests if EOPNOTSUPP is raised.
http://hg.python.org/cpython/rev/019a2390b014
--
nosy: +python-dev
___
Python tracker
John Taylor added the comment:
Please close this ticket. This is not a bug.
As per cjerdonek's suggestion, defining a constraint as follows:
constraint my_name check (...)
returns the actual name of the constraint, when it fails:
sqlite3.IntegrityError: constraint my_name failed
--
Richard Oudkerk added the comment:
RawIOBase.readall() does the sensible thing already. Maybe FileIO should be
allowed to inherit it.
The alternative patch (which probably only works for raw unbuffered case)
diff -r ca54c27a9045 Lib/subprocess.py
--- a/Lib/subprocess.py Tue Aug 21 14:54:22
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
resolution: works for me - invalid
stage: needs patch - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15754
___
Antoine Pitrou added the comment:
FileIO.readall() already has an overallocation mechanism which should yield
linear complexity. Perhaps it needs to be tweaked a bit?
(look at new_buffersize in Modules/_io/fileio.c)
By the way, your results are bit weird. Why does the data rate increase with
Roundup Robot added the comment:
New changeset f986d523e93d by Trent Nelson in branch 'default':
Issue #15747: skip chflags UF_IMMUTABLE tests if EOPNOTSUPP is raised.
http://hg.python.org/cpython/rev/f986d523e93d
--
___
Python tracker
Changes by Trent Nelson tr...@snakebite.org:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15747
___
Trent Nelson added the comment:
Oh, heh, yes, I meant double :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15745
___
___
Python-bugs-list
Richard Oudkerk added the comment:
FileIO.readall() already has an overallocation mechanism which should
yield linear complexity. Perhaps it needs to be tweaked a bit?
(look at new_buffersize in Modules/_io/fileio.c)
I think it needs a bit more than a tweak;-) Looks like it increases by
Chris Jerdonek added the comment:
I randomly ran into this issue again. I'm not sure this was ever resolved
(i.e. I think it may always have been different from issue 15111).
I still get the above behavior in the default branch.
And here is what I get in the 3.2 branch (the error information
Chris Jerdonek added the comment:
I ran into this again because an error while running `./python.exe -m test` was
getting masked. The use of __main__.py in the package may be the
distinguishing characteristic.
--
___
Python tracker
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
___
1 - 100 of 112 matches
Mail list logo