Éric Araujo added the comment:
Cool change. I assume when you use mock.patch as decorator the mock name is
set to the mocked object?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15323
Roundup Robot added the comment:
New changeset f1094697d7dc by Stefan Krah in branch 'default':
Closes #16080: The decorator ignores failed attempts to set the required
http://hg.python.org/cpython/rev/f1094697d7dc
--
resolution: - fixed
stage: - committed/rejected
status: open -
Ezio Melotti added the comment:
testing irker
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2771
___
___
Python-bugs-list mailing list
James Salt added the comment:
This diff shows a correction of the documentation to reflect the name for the
csv file used in the implementation - this change seemed like the easiest and
simplest thing to do and avoids potential backwards incompatibility issues.
--
nosy: +James.Salt
Michael Foord added the comment:
Eric: yes, patch sets the name on the mock objects it creates. A mock only
knows its direct name, not its full 'dotted' name (i.e. a mock knows it is
called 'time' but not that it is 'time.time'). It is possible (but harder) to
deduce that name (follow the
Larry Hastings added the comment:
Eric, iirc you're the de facto csv guy? Does this seem reasonable to you?
--
nosy: +eric.araujo, larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16026
Éric Araujo added the comment:
I’m not a dedicated maintainer for csv (for one thing I don’t know C :), I just
happen to reply to many bug reports.
This doc patch looks good to me.
--
nosy: +sandro.tosi
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
Another irker test
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2771
___
___
Python-bugs-list mailing list
Chris Jerdonek added the comment:
Thanks a lot, Georg.
FYI, though, the page linked to in the original e-mail still seems to show up
for me:
http://docs.python.org/dev/library/packaging.html
Is this change something that won't necessarily take effect right away?
--
Georg Brandl added the comment:
Ah yes, I missed those as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16069
___
___
Python-bugs-list
Éric Araujo added the comment:
Nice feature to do without adding a dependency on a lint tool!
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16079
___
Éric Araujo added the comment:
Well there is
http://docs.python.org/reference/datamodel.html#special-method-names (even
thought we have a lot of evidence people miss that).
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
Éric Araujo added the comment:
Agreed.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16049
___
___
Python-bugs-list mailing
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +easy
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
___
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +arschficker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9674
___
___
Python-bugs-list
Éric Araujo added the comment:
Thanks for the report. This bug was already known, but I haven’t had the time
yet to fix it. I’m adding you to the nosy list on the other bug so that you
can follow progress and maybe help testing the fix.
--
assignee: - eric.araujo
components:
Roger Serwy added the comment:
With Python 2.7.3 on Win7, I tried the following:
C:\Python27set HOME=H:\
C:\Python27python -m idlelib.idle
I do receive the same warning messages described by Cemal, since I don't have a
valid H:\ drive. However, IDLE is responsive. Running IDLE using
Benjamin Peterson added the comment:
Can't you test the PyLong_FromString code path by passing bytes to int()?
int(b42)
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16055
Chris Jerdonek added the comment:
I would like to see this written in a way that would let one run it globally or
on a single file independent of a patch (e.g. an independent script from which
patchcheck could import certain functions). Or is that what you explicitly
didn't want Éric? :)
Chris Jerdonek added the comment:
Benjamin, unless I'm overlooking something, long_new() does its own check of
the base argument before calling PyLong_FromString():
http://hg.python.org/cpython/file/default/Objects/longobject.c#l4251
So long_new() won't let you pass a bad base to
Serhiy Storchaka added the comment:
It is not consistent with reader and writer.
I propose to close the issue as won't fix or change the argument name in the
sources. Unfortunately, Python syntax does not allow to specify the
positional-only arguments.
--
keywords: +patch
nosy:
Benjamin Peterson added the comment:
Ah, sorry, I misread what you wanted to be testing.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16055
___
Ezio Melotti added the comment:
I would like to see this written in a way that would let one
run it globally or on a single file independent of a patch
+1
It can be added to Tools/scripts and imported by patchcheck.
I'm pretty sure we have some tests that don't start with 'test_'.
IIRC
Éric Araujo added the comment:
I don’t understand the proposal. Changing the code has a high bar; here it
would break code without benefit. Fixing the doc so that it reflects the code
accurately is a no-cost improvement. (Inconsistency is unfortunate, but we’ll
have to live with that.)
Chris Jerdonek added the comment:
Here are a couple examples of test method names that don't begin with test_:
def testLoadTk(self):
def testLoadTkFailure(self):
http://hg.python.org/cpython/file/f1094697d7dc/Lib/tkinter/test/test_tkinter/test_loadtk.py#l9
--
Éric Araujo added the comment:
sqlite3 tests use CheckThing style (urgh).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16079
___
___
Ezio Melotti added the comment:
Here are a couple examples of test method names that don't begin with test_:
I thought you were talking about test files. I still don't see why looking for
test_* methods, every class might contain duplicate method names, so they
should all be checked.
Kushal Das added the comment:
csv.Dialect.strict is now documented.
--
keywords: +patch
nosy: +kushaldas
Added file: http://bugs.python.org/file27340/csv_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
Terry J. Reedy added the comment:
Could you give a specific example of the message you got, why it is wrong, and
what you think it should be?
Is there any reason to think that this is Windows-specific?
--
components: +Library (Lib) -Windows
nosy: +terry.reedy
stage: - needs patch
Serhiy Storchaka added the comment:
Changing the documentation is changing the specification, it has the higher bar
than changing the implementation. It can break the alternative implementations.
This is unlikely to break somebody's existing code, because the one who used
the argument as a
Kushal Das added the comment:
The implementation clearly says that default method should return a
serializable object or calls the base implementation to raise TypeError. So I
don't think any of the examples is a bug.
--
nosy: +kushaldas
___
Python
Serhiy Storchaka added the comment:
I confirm the bug.
import os
os.rename('non-existent-name', 'new-name')
Traceback (most recent call last):
File stdin, line 1, in module
FileNotFoundError: [Errno 2] No such file or directory: 'new-name'
It obviously should be No such file or directory:
Chris Jerdonek added the comment:
I thought you were talking about test files.
Oh, I see why you said that then. To find the test files themselves, this
logic was used in the patch:
+ fn.startswith(os.path.join('Lib', 'test'))]
Regarding your question for the general case,
Kushal Das added the comment:
But the whole 18.4.2 is mount mailbox.Message so, it seems to be correct
documentation.
email.Message.Message is properly mentioned in the 4th line properly.
I don't think it is bug.
--
nosy: +kushaldas
___
Python
Éric Araujo added the comment:
I disagree that we can never fix argument names in the docs, as we have done it
already. You raise a good point however, that we should check what other VMs
do. I would not be surprised if they followed the code instead of the docs.
--
keywords:
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +needs review, patch -3.3regression
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16026
___
Éric Araujo added the comment:
Please use ``True`` instead of :const: (this is explained in the doc about the
docs in the devguide).
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
Chris Jerdonek added the comment:
But the whole 18.4.2 is mount mailbox.Message
But the first reference is a reference to email.Message's Message, so that word
should link to email.Message.Message. Sphinx lets you to link to classes, etc.
outside the current scope. It's a simple one word
Serhiy Storchaka added the comment:
Error in argument of path_error in function internal_rename.
For some errcode it should be dst, for some src, for some both, for some none,
and for some it is unknown. And this can be platform-specific.
I suggest rollback this enhancement.
--
nosy:
Serhiy Storchaka added the comment:
Error in argument of path_error in function internal_rename.
In file Modules/posixmodule.c.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16074
___
Serhiy Storchaka added the comment:
Can native speakers review the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
___
___
Éric Araujo added the comment:
LGTM, except for my previous remark and a missing period after the first line.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
___
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
assignee: docs@python - chris.jerdonek
versions: +Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16071
___
Glenn Linderman added the comment:
Terry, I thought the test case would demonstrate the error details.
As far as Windows, I encountered it there, and it seemed like the sort of error
that could be in a Windows-specific module.
Serhiy, thanks for confirming, and analyzing. At this point in the
Kushal Das added the comment:
Updated with new patch
--
Added file: http://bugs.python.org/file27341/csv_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
___
Roundup Robot added the comment:
New changeset be94d100f846 by R David Murray in branch '3.2':
#16071: fix links to email.message.Message in mailbox docs.
http://hg.python.org/cpython/rev/be94d100f846
New changeset 2a14542371b7 by R David Murray in branch 'default':
Merge #16071: fix links to
Roundup Robot added the comment:
New changeset aad3cec524f9 by R David Murray in branch '2.7':
#16071: fix email.message links in the mailbox docs.
http://hg.python.org/cpython/rev/aad3cec524f9
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Two words and a tilde. But there were also a number of other places where the
links were broken. Hopefully I caught them all.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
assignee: chris.jerdonek -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16071
___
___
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13886
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset bff269ee7288 by Mark Dickinson in branch '2.7':
Issues #16029, #16030: Fix pickling and repr of large xranges.
http://hg.python.org/cpython/rev/bff269ee7288
--
nosy: +python-dev
___
Python tracker
Roundup Robot added the comment:
New changeset bff269ee7288 by Mark Dickinson in branch '2.7':
Issues #16029, #16030: Fix pickling and repr of large xranges.
http://hg.python.org/cpython/rev/bff269ee7288
--
nosy: +python-dev
___
Python tracker
Mark Dickinson added the comment:
Now fixed. Thanks for the report!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16029
___
Changes by Mark Dickinson dicki...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16030
___
Éric Araujo added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16053
___
___
Python-bugs-list mailing list
Unsubscribe:
Kushal Das added the comment:
Just for record the same issue can be seen in a Linux box also. I tested in a
Fedora 17 system.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16074
___
Larry Hastings added the comment:
As Serhiy says, which filename to display is wholly context-sensitive to which
errno it is. And there's no cheap way to display both. The cheap fix is to
call path_error with a nulled-out path object; this will display the error
without a filename.
Patch
Changes by Kushal Das kushal...@gmail.com:
Removed file: http://bugs.python.org/file27342/os_rename.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16074
___
Justin Lebar added the comment:
Ah, I see. The examples do what you think they should do, but not for the
reason you think they should do it -- the JSON encoding logic calls the
encoder's encode() method before calling its default() method.
I still think the examples could be improved,
Kushal Das added the comment:
Ok, I will submit a patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16057
___
___
Python-bugs-list mailing
Larry Hastings added the comment:
New patch, just calling posix_error directly.
--
Added file: http://bugs.python.org/file27344/larry.rename_error.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16074
Xavier de Gaye added the comment:
Using the python class browser (pyclbr.py) in conjunction with the
search for duplicates in the module code object would allow to
restrict the listing of duplicates to functions and methods or even
just to methods (depending on the feature requirements), without
Ezio Melotti added the comment:
Another irker test
--
nosy: -eric.araujo, r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2771
___
Serhiy Storchaka added the comment:
Ideally, this proposed deprecation should be mentioned on python-dev so that
those folks will have an opportunity to respond.
http://comments.gmane.org/gmane.comp.python.devel/134996
--
___
Python tracker
Serhiy Storchaka added the comment:
Chris, you did a great job on improving the documentation (including about
universal newlines). Can you help with this issue?
For the first stage should be clearly shown that U mode is not only should
not be used in new code, but must be removed from the
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file26197/deprecate-U-mode-stage1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15204
___
Ezio Melotti added the comment:
It doesn't necessary have to be limited to methods, anything duplicate might
turn out to be a bug. If the script doesn't mix scopes there shouldn't be too
many false positives, and if they are it shouldn't be a big deal if they are
reported on the changed file
Chris Jerdonek added the comment:
Thanks, Serhiy. :) Sure, I should be able to help with the documentation
portion of this issue if the community is in agreement. Would the deprecation
need to be moved up to 3.4 though now?
--
___
Python tracker
Chris Jerdonek added the comment:
Attaching first version of patch. Interestingly, not all of these pass when I
tried applying to 2.7. For example,
int(base='foo')
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: an integer is required
So at least one
Tim Chase added the comment:
http://docs.python.org/library/mailbox.html#mailbox.Message still points to
mailbox.Message instead of email.Message A subclass of the email.Message
module’s {bad link}Message{/bad link}
Not sure if this is a matter of changes that haven't yet been deployed, or
Chris Jerdonek added the comment:
It can take up to 24 hours for the changes to show up on the web site. They
are regenerated at least once per day.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16071
101 - 171 of 171 matches
Mail list logo