Jens Lechtenboerger added the comment:
Loads and stores are both atomic. But += is made up of two operations, a
load followed by a store, and the lock is dropped between the two.
I see. Then this is a documentation bug. The examples in the documentation
use such non-thread-safe
Roundup Robot added the comment:
New changeset 260a9afd999a by Ezio Melotti in branch '3.2':
#4153: update the Unicode howto.
http://hg.python.org/cpython/rev/260a9afd999a
New changeset 572ca3d35c2f by Ezio Melotti in branch '3.3':
#4153: merge with 3.2.
Ezio Melotti added the comment:
I committed the attached patch with some minor modifications, but there are
still comments that should be addressed on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4153
New submission from Cillian de Róiste:
I guess it should be wrapped in a try, except:
try:
from html.entities import name2codepoint
except ImportError:
from htmlentitydefs import name2codepoint
This works locally
Here's a sample traceback:
Traceback (most recent call last):
File
Richard Oudkerk added the comment:
I see. Then this is a documentation bug. The examples in the
documentation use such non-thread-safe assignments (combined with the
statement These shared objects will be process and thread safe.).
Are you talking about this documentation:
If lock is
Ezio Melotti added the comment:
htmlentitydefs was renamed to html.entities in Python 3.
If this is supposed to run with Python 2 it should use the former, otherwise
the latter (unless it has the same codebase on both).
--
nosy: +ezio.melotti
type: crash - behavior
Serhiy Storchaka added the comment:
Here is an updated patch addressing Nadeem Vawda's comments. Thank you.
--
Added file: http://bugs.python.org/file28795/gzip_eof-3.4_2.patch
___
Python tracker rep...@bugs.python.org
Nadeem Vawda added the comment:
The updated patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1159051
___
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16997
___
Vinay Sajip added the comment:
Looking at Phil Elson's patch:
I didn't see a test case relating to the example in his comment, namely
f.format({0:{}}, 'foo', 5)
Did I miss it? The documentation also needs to be updated.
--
___
Python tracker
Changes by Ramchandra Apte maniandra...@gmail.com:
Removed file: http://bugs.python.org/file28794/issue-v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17001
___
Ramchandra Apte added the comment:
Oh darn, I included another bugs changes in it.
I unlinked the v2 patch and have attached issue17001-v2.patch
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17001
Serhiy Storchaka added the comment:
Except for mistakenly included functional.rst changes, the patch looks good for
me.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17001
Roundup Robot added the comment:
New changeset e0de6e6e992e by Ezio Melotti in branch '3.3':
#16557: update functional howto -- return value is valid after PEP 380.
Initial patch by Ramchandra Apte.
http://hg.python.org/cpython/rev/e0de6e6e992e
New changeset 81b2a30da853 by Ezio Melotti in
Ezio Melotti added the comment:
Fixed, thanks for the report and the patch!
--
assignee: docs@python - ezio.melotti
nosy: +ezio.melotti
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker
Christian Heimes added the comment:
Yes, I'm going to work on this issue for 2.7 and 3.3.
--
assignee: - christian.heimes
priority: normal - critical
stage: - needs patch
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
Changes by Christian Heimes li...@cheimes.de:
--
assignee: - christian.heimes
priority: normal - critical
stage: - needs patch
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16041
Changes by Christian Heimes li...@cheimes.de:
--
assignee: - christian.heimes
priority: normal - critical
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16040
___
Changes by Christian Heimes li...@cheimes.de:
--
assignee: - christian.heimes
priority: normal - critical
stage: - needs patch
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
Changes by Christian Heimes li...@cheimes.de:
--
assignee: - christian.heimes
priority: normal - critical
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16038
___
Changes by Christian Heimes li...@cheimes.de:
--
assignee: - christian.heimes
priority: normal - critical
stage: - needs patch
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16037
Christian Heimes added the comment:
The attached patch adds a limitation to xmlrpclib.gzip_decode().
--
assignee: - christian.heimes
dependencies: -gzip, bz2, lzma: add option to limit output size
keywords: +patch
priority: normal - critical
stage: - patch review
versions: +Python
Serhiy Storchaka added the comment:
Patch updated. Now I get rid of __del__ to prevent hanging on reference cicles
as Antoine suggested on IRC. Added test for check that XMLGenerator doesn't
close the file passed as argument.
--
Added file:
New submission from Serhiy Storchaka:
read() and readline() optional parameter which limit the amount of read data
has different names in different classes. All this classes mimic (less or more)
io classes. Keyword parameter name is a part of method specification. Therefore
it will be good
Christian Heimes added the comment:
Go ahead!
The intobject header file used to make porting to Python 3 easier. Nowadays
it's no longer required.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7353
Serhiy Storchaka added the comment:
Looks as size is most common parameter name for both read() and readline().
First, we can change the io documentation and _pyio signatures (it shouldn't
break anything because _io doesn't support keyword arguments).
--
Catalin Iacob added the comment:
Could it be that Raymond's file had Unix line endings?
I tried to reproduce this, picked a file on my disk and indeed I got a negative
number, but that file has Unix line endings. This is documented at
http://docs.python.org/2/library/stdtypes.html#file.tell
Antoine Pitrou added the comment:
n is the best choice IMO. size is ok too, although it may be confused with
the byte-size of the result.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17003
Serhiy Storchaka added the comment:
Here is a patch which changes name of optional parameter of read(), read1(),
peek(), and readline() methods to most common name size in the documentation
and _pyio module. truncate() in _pyio fixed to conform with documentation. This
changes are safe.
Serhiy Storchaka added the comment:
n is the best choice IMO.
Unfortunately most stdlib modules vote for size.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17003
___
Tres Seaver added the comment:
I can reproduce the bug against the 2.7 tip.
Reviewing the 2.7 patch:
- The 2.7 tip has 'Misc/ACKS' instead of 'Doc/ACKS.txt'.
- In 'Misc/ACKS', the line adding 'Chris McDonough' should add it in alpha
order.
- The remainder of the patch looks correct, and
Serhiy Storchaka added the comment:
mock_socket violates readline() contract. It can return more than size bytes,
and this can break SMTP.readline().
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16042
New submission from Raymond Hettinger:
Only a little of the existing logic is tied to the zipfile format. Consider
adding support for xz, tar, tar.gz, tar.bz2, etc.
In particular, xz has better compression, resulting in both space savings and
faster load times.
--
messages: 180307
Changes by Brian Curtin br...@python.org:
--
components: +Library (Lib)
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17004
___
Éric Araujo added the comment:
Good call. All function-level imports are avoided in d2 unless absolutely
necessary, and this one slipped through the cracks. distutils2 went from
Python 2 to 3 to 2 and 3 again, so these things happen (and it’s one of the
reasons why I’ve always insisted on
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8745
___
___
Guido van Rossum added the comment:
Oh, it needs a new patch -- the patch fails to apply in the 3.4
(default) branch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16507
___
Serhiy Storchaka added the comment:
tar.* is not a good choice because it doesn't allow random access. Bare tar
better than zip only in case when you need to save additional file attributes
(Unix file access mode, times, owner, group, links). ZIP format supports all
this too, but not zipfile
Serhiy Storchaka added the comment:
Here are some tests.
time 7z a -tzip -mx=0 python-0.zip $(find Lib -type f -name '*.py') /dev/null
time 7z a -tzip python.zip $(find Lib -type f -name '*.py') /dev/null
time 7z a -tzip -mx=9 python-9.zip $(find Lib -type f -name '*.py') /dev/null
time 7z a
Serhiy Storchaka added the comment:
Sorry, Brian. Raymond is an initiator of issue17004.
--
nosy: +rhettinger -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8745
___
Changes by Trent Nelson tr...@snakebite.org:
--
nosy: +trent
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13405
___
___
Python-bugs-list mailing
Antoine Pitrou added the comment:
Here are some tests.
I think you want to put pyc files in the zip file as well.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17004
___
Raymond Hettinger added the comment:
xz will likely be the best win -- it is purported to compress smaller than bz2
while retaining the decompression speed of zip.
As Antoine says, the usual practice is to add py, pyc, and pyo files to the
compressed library; otherwise, there is an added cost
Guido van Rossum added the comment:
Here's a new version of the patch. (Will test on Windows next.)
--
Added file: http://bugs.python.org/file28799/runtime_wsapoll.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16507
Raymond Hettinger added the comment:
I recommend against this patch. The code generated by functools.total_ordering
is less efficient than the existing code and it doesn't handle the
NotImplemented logic very well.
total_ordering() is a shortcut, not a best practice.
--
nosy:
Guido van Rossum added the comment:
That compiles (after hacking the line endings). One Tulip test fails,
PollEventLooptests.testSockClientFail. But that's probably because the
PollSelector class hasn't been adjusted for Windows yet (need to dig this out
of the Pollster code that was
Guido van Rossum added the comment:
That compiles (after hacking the line endings). One Tulip test fails,
PollEventLooptests.testSockClientFail. But that's probably because the
PollSelector class hasn't been adjusted for Windows yet (need to dig this out
of the Pollster code that was
New submission from Raymond Hettinger:
I suggest adding a topological sort algorithm to the standard library.
In addition to being a fundamental algorithm, it is immediately useful in
demonstrating how the MRO computation works and for pure Python implementations
of MRO logic. IIRC, the
Ezio Melotti added the comment:
I'm going to close this as out of date. Feel free to reopen if it turns out
that this is indeed a Python issue.
--
nosy: +ezio.melotti
resolution: - out of date
stage: - committed/rejected
status: open - closed
___
Christian Heimes added the comment:
Good idea!
I'm using http://pypi.python.org/pypi/topsort/0.9 for a couple of years. The
initial code was written by Tim Peters.
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
Richard Oudkerk added the comment:
That compiles (after hacking the line endings). One Tulip test fails,
PollEventLooptests.testSockClientFail. But that's probably because the
PollSelector class hasn't been adjusted for Windows yet (need to dig this
out of the Pollster code that was
Serhiy Storchaka added the comment:
Well.
./python -m compileall $(find Lib -type f -name '*.py')
./python -O -m compileall $(find Lib -type f -name '*.py')
Tests:
FILES=$(find Lib -name '*.py' -o -name '*.py[co]')
time 7z a -tzip -mx=0 python-0.zip $FILES /dev/null
time 7z a -tzip python.zip
Antoine Pitrou added the comment:
Agreed it doesn't look very promising.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17004
___
___
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15881
___
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
Ow. How painful. I'll leave this for you to do. Note that this also
requires separating EVENT_WRITE from EVENT_CONNECT -- I am looking
into this now, but I am not sure how far I will get with this.
--
___
Python
Roundup Robot added the comment:
New changeset 6df456f8fc6d by Stefan Krah in branch '3.3':
Issue #7353: Remove references to Include/intobject.h in the C-porting howto.
http://hg.python.org/cpython/rev/6df456f8fc6d
--
nosy: +python-dev
___
Python
Changes by Stefan Krah stefan-use...@bytereef.org:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
versions: +Python 2.7, Python 3.3, Python 3.4 -Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
(FWIW, I've got the EVENT_CONNECT separation done.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16507
___
Charles-François Natali added the comment:
Time for a stupid question from someone who doesn't know anything about
Windows: if WSAPoll() is really terminally broken, is it really worth the
hassle exposing it and warping the API?
AFAICT, FD_SETSIZE is already bumped to 512 on Windows, and
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17005
___
___
Eric V. Smith added the comment:
+1
I'll note (by inspection only) your example code doesn't work under Python 3.x!
:)
(print as a statement)
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17005
61 matches
Mail list logo
