[issue17006] Warn users about hashing secrets?

2013-01-21 Thread Christian Heimes
New submission from Christian Heimes: Lot's of people still think that something like sha512(secret + message), sha1(password + salt) or even sha1(password) is secure. Except it isn't. Most crypto hash functions like md5, sha1, sha2 family (sha256, sha384, sha512) use a Merkle–Damgård

[issue17006] Warn users about hashing secrets?

2013-01-21 Thread Hynek Schlawack
Hynek Schlawack added the comment: I think since we ship cryptographic functions, we should take responsibility and warn against the most common mistakes people do. -- nosy: +hynek ___ Python tracker rep...@bugs.python.org

[issue17006] Warn users about hashing secrets?

2013-01-21 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17006 ___

[issue16335] Integer overflow in unicode-escape decoder

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7625866f8127 by Serhiy Storchaka in branch '3.2': Issue #16335: Fix integer overflow in unicode-escape decoder. http://hg.python.org/cpython/rev/7625866f8127 New changeset 494d341e9143 by Serhiy Storchaka in branch '3.3': Issue #16335: Fix integer

[issue16335] Integer overflow in unicode-escape decoder

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset f4d30d1a529e by Serhiy Storchaka in branch '2.7': Issue #16335: Fix integer overflow in unicode-escape decoder. http://hg.python.org/cpython/rev/f4d30d1a529e -- ___ Python tracker rep...@bugs.python.org

[issue16335] Integer overflow in unicode-escape decoder

2013-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I rewrote the test in EAFP style. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16335

[issue16957] shutil.which() shouldn't look in working directory on unix-y systems

2013-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16957 ___ ___ Python-bugs-list mailing list

[issue16335] Integer overflow in unicode-escape decoder

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset f84a6c89ccbc by Serhiy Storchaka in branch '3.2': Fix memory error in test_ucn. http://hg.python.org/cpython/rev/f84a6c89ccbc New changeset 7c2aae472b27 by Serhiy Storchaka in branch '3.3': Fix memory error in test_ucn.

[issue17006] Warn users about hashing secrets?

2013-01-21 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17006 ___ ___

[issue16038] ftplib: unlimited readline() from connection

2013-01-21 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16038 ___ ___

[issue16042] smtplib: unlimited readline() from connection

2013-01-21 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16042 ___ ___

[issue16039] imaplib: unlimited readline() from connection

2013-01-21 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16039 ___ ___

[issue16040] nntplib: unlimited readline() from connection

2013-01-21 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16040 ___ ___

[issue16041] poplib: unlimited readline() from connection

2013-01-21 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16041 ___ ___

[issue16822] execv (et al.) should invoke atexit handlers before executing new code

2013-01-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: I agree with Charles-François, this is a too risky change. However, we could definitely have a separate atexec handler, like the atfork handlers which are proposed in issue16500. -- ___ Python tracker

[issue16993] shutil.which() should preserve path case

2013-01-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16993 ___ ___

[issue16993] shutil.which() should preserve path case

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset d2db601a53b3 by Serhiy Storchaka in branch '3.3': Issue #16993: shutil.which() now preserves the case of the path and extension http://hg.python.org/cpython/rev/d2db601a53b3 New changeset 5faae2bdf1e0 by Serhiy Storchaka in branch 'default': Issue

[issue16993] shutil.which() should preserve path case

2013-01-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16993

[issue17001] Make uuid.UUID use functools.total_ordering

2013-01-21 Thread Ramchandra Apte
Ramchandra Apte added the comment: Performance info using the attached program: ~2.5 sec, original ~3.5 sec, patched (patched version is 40% slower) Is anybody doing the comparison in performance-critical cases? -- ___ Python tracker

[issue17001] Make uuid.UUID use functools.total_ordering

2013-01-21 Thread Ramchandra Apte
Ramchandra Apte added the comment: On 21 January 2013 02:42, Raymond Hettinger rep...@bugs.python.org wrote: NotImplemented Can you please elaborate on it doesn't handle the NotImplemented logic very well. AFAIK both will give NotImplemented for the same values. --

[issue17006] Warn users about hashing secrets?

2013-01-21 Thread Ramchandra Apte
Ramchandra Apte added the comment: +1 Better to be safe than sorry -- nosy: +ramchandra.apte ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17006 ___

[issue17006] Warn users about hashing secrets?

2013-01-21 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17006 ___ ___

[issue16699] Mountain Lion buildbot lacks disk space

2013-01-21 Thread Ramchandra Apte
Ramchandra Apte added the comment: Invalid. -- nosy: +ramchandra.apte ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16699 ___ ___ Python-bugs-list

[issue16998] Lost updates with multiprocessing.Value

2013-01-21 Thread Jens Lechtenboerger
Jens Lechtenboerger added the comment: It only says that accesses are synchronized. The problem is that you were assuming that += involves a single access -- but that is not how python works. Yes, I understand that by now (actually since your first comment). Where in the examples is

[issue17007] logging documentation clarifications

2013-01-21 Thread Chris Jerdonek
New submission from Chris Jerdonek: Here are some suggestions of things to clarify in the logging documentation after consulting it as an end-user: 1. Clarify in Logger.filter(), Handler.filter(), and probably also in the Filter section that the case of more than filter behaves as follows:

[issue16507] Patch selectmodule.c to support WSAPoll on Windows

2013-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: This is a very good question to which I have no good answer. If it weren't for this, we could probably do away with the distinction between add_writer and add_connector, and a lot of code could be simpler. (Or is that distinction also needed for IOCP?)

[issue17008] Descriptor __get__() invoke is bypassed in the class context

2013-01-21 Thread stuart
New submission from stuart: I emulated a real classmethod using python: class cm(object): def __init__(self, o): self.o = o def __get__(self, obj, type=None): return self.o.__get__(obj, type) then I check whether it is workable in the interactive mode and it is working:

[issue17004] Expand zipimport to include other compression methods

2013-01-21 Thread Brett Cannon
Brett Cannon added the comment: So this seems like a confluence of both supporting compressed files for loading source code as well as supporting new archive formats (e.g. xz vs. tar); zip just happens to do both implicitly. And there is also the question of if you explicitly plan to do this

[issue16335] Integer overflow in unicode-escape decoder

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset ec3a35ab3659 by Serhiy Storchaka in branch '2.7': Add bigmemtest decorator to test of issue #16335. http://hg.python.org/cpython/rev/ec3a35ab3659 New changeset 6e0c3e4136b1 by Serhiy Storchaka in branch '3.2': Add bigmemtest decorator to test of

[issue16507] Patch selectmodule.c to support WSAPoll on Windows

2013-01-21 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 21/01/2013 5:38pm, Guido van Rossum wrote: This is a very good question to which I have no good answer. If it weren't for this, we could probably do away with the distinction between add_writer and add_connector, and a lot of code could be simpler. (Or

[issue16507] Patch selectmodule.c to support WSAPoll on Windows

2013-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks -- I am now close to rejecting the WSAPoll() patch, and even closer to rejecting its use for Tulip on Windows. That would in turn mean that we should kill add/remove_connector() and also the EVENT_CONNECT flag in selector.py. Anyone not in favor please

[issue17008] Descriptor __get__() invoke is bypassed in the class context

2013-01-21 Thread Benjamin Peterson
Benjamin Peterson added the comment: If you want to emulate classmethod, calling __get__() on the function is the wrong thing to do. f.__get__(None, X) - f You need to create a bound yourself instead. -- nosy: +benjamin.peterson resolution: - invalid status: open - closed

[issue17007] logging documentation clarifications

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 871519e1f146 by Vinay Sajip in branch '2.7': Issue #17007: Improved logging documentation based on suggestions in the issue. http://hg.python.org/cpython/rev/871519e1f146 New changeset 029785354dbc by Vinay Sajip in branch '3.2': Issue #17007:

[issue16507] Patch selectmodule.c to support WSAPoll on Windows

2013-01-21 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 21/01/2013 7:00pm, Guido van Rossum wrote: Regarding your IOCP changes, that sounds pretty exciting. Richard, could you check those into the Tulip as a branch? (Maybe a new branch named 'iocp'.) OK. It may take me a while to rebase them. --

[issue17007] logging documentation clarifications

2013-01-21 Thread Vinay Sajip
Vinay Sajip added the comment: Your suggestions are good, and I implemented them more or less as you suggested. Additional comments: it never makes sense to add more than one filter Except for readability. Although in theory one filter could do the work of several, it may be that different

[issue17009] Thread Programming With Python should be removed

2013-01-21 Thread Ned Batchelder
New submission from Ned Batchelder: Sorry if this is the wrong bug tracker for this issue. Someone just asked in #python what they should do about the fact that Python has no threads on the Mac. When asked why they thought that, they pointed to this:

[issue17009] Thread Programming With Python should be removed

2013-01-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think these files are outside of the CPython doc tree, they are probably static files on the server. That said, I agree it would be good to either add the deprecated, kept only for historical purposes note at the top of every file there, or simply remove

[issue16993] shutil.which() should preserve path case

2013-01-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Test broken on Windows because PATHEXT contains uppercased extension .EXT. Proposed solutions: 1. Fix the test: expect uppercased extension, or do case-insensitive extension comparison, or get extension from PATHEXT. 2. Rollback the part of previous changes

[issue16507] Patch selectmodule.c to support WSAPoll on Windows

2013-01-21 Thread Richard Oudkerk
Richard Oudkerk added the comment: I have created an iocp branch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16507 ___ ___ Python-bugs-list

[issue17007] logging documentation clarifications

2013-01-21 Thread Chris Jerdonek
Chris Jerdonek added the comment: Great, that looks a lot better. Thanks! A couple comments though: + .. note:: If you attach a handler to several loggers, it may emit the same + record multiple times. In general, you should not need to attach a + handler to more than one logger -

[issue16507] Patch selectmodule.c to support WSAPoll on Windows

2013-01-21 Thread Charles-François Natali
Charles-François Natali added the comment: I have created an iocp branch. You could probably report the fixes for spurious notifications in the default branch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16507

[issue17007] logging documentation clarifications

2013-01-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8de6f92c89e6 by Vinay Sajip in branch '2.7': Issue #17007: Made minor changes to documentation wording. http://hg.python.org/cpython/rev/8de6f92c89e6 New changeset c8614ec54a63 by Vinay Sajip in branch '3.2': Issue #17007: Made minor changes to

[issue17010] Windows launcher ignores active virtual environment

2013-01-21 Thread Bryan G. Olson
New submission from Bryan G. Olson: Python 3.3 includes PEP 397, a Python launcher for Windows, and PEP 405, virtual environment support in core. Unfortunately the Windows launcher does not respect virtual environments. Even with with a virtual environment activated and the current directory

[issue17009] Thread Programming With Python should be removed

2013-01-21 Thread Ezio Melotti
Ezio Melotti added the comment: Given that the note at the top says that it's an unfinished draft, I think removing it would be fine. It might be nice to see if there's anything still relevant that could be moved to the official docs, and possibly find out who wrote it and if he's ok with

[issue17009] Thread Programming With Python should be removed

2013-01-21 Thread Ned Deily
Ned Deily added the comment: It's included in a directory of Guido's essays (http://www.python.org/doc/essays/). Guido, any thoughts about this and the others? -- nosy: +gvanrossum, ned.deily ___ Python tracker rep...@bugs.python.org

[issue17009] Thread Programming With Python should be removed

2013-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: I'd like to keep the essay around as a permalink, but I don't object against putting some red text at the top warning people is is horribly out of date, and linking to a better tutorial. -- ___ Python tracker

[issue17001] Make uuid.UUID use functools.total_ordering

2013-01-21 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - invalid status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17001 ___

[issue17011] ElementPath ignores different namespace mappings for the same path expression

2013-01-21 Thread Stefan Behnel
New submission from Stefan Behnel: There's a bug originally report for lxml that also applies to ElementTree: https://github.com/lxml/lxml/issues/95 Passing different namespace mappings into the Element.find*() methods will always reuse the first one due to incorrect caching based only on the

[issue17011] ElementPath ignores different namespace mappings for the same path expression

2013-01-21 Thread Stefan Behnel
Changes by Stefan Behnel sco...@users.sourceforge.net: -- components: +Library (Lib) -XML ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17011 ___

[issue17011] ElementPath ignores different namespace mappings for the same path expression

2013-01-21 Thread Stefan Behnel
Changes by Stefan Behnel sco...@users.sourceforge.net: -- components: +XML ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17011 ___ ___

[issue17011] ElementPath ignores different namespace mappings for the same path expression

2013-01-21 Thread Stefan Behnel
Stefan Behnel added the comment: Here is a test case (for lxml): https://github.com/lxml/lxml/commit/76f2ee991afd15d4f8c98cee3e095967bbf9937f -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17011

[issue11379] Remove lightweight from minidom description

2013-01-21 Thread Stefan Behnel
Stefan Behnel added the comment: I'm not sure if it's a good idea to keep bikeshedding about this for another two years. Personally, I would prefer having someone with commit rights fix this and be done with it. Eric's last patch looks ok and parts of it went in already, so it's mostly just

[issue8858] socket.getaddrinfo returns wrong results for IPv6 addresses

2013-01-21 Thread Marc Schlaich
Marc Schlaich added the comment: I get the same result from `getaddrinfo` if Python is compiled with `--disable-ipv6`. Is this the correct behaviour? I would expect no IP v6 address at all. Python 2.5.6 (r256:88840, Jan 22 2013, 08:41:04) [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2 Type