[issue17204] argparser's subparsers.add_parser() should accept an ArgumentParser

2013-02-13 Thread Chris Jerdonek
New submission from Chris Jerdonek: Currently, argparser's subparsers.add_parser() method (for adding sub-commands) takes the following input: "This object has a single method, add_parser(), which takes a command name and any ArgumentParser constructor arguments, and returns an ArgumentParser

[issue1285086] urllib.quote is too slow

2013-02-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: I wrongly minutes. Here is actual data of execution speeds. There is magnitude of difference (almost 130x faster). Measured on macbook pro with 2 cores and 4 Gig mem. Before Patch: $ ./python.exe -m timeit -s "import urllib.parse; x='a%20' * 10" "urllib.

Re: [issue1285086] urllib.quote is too slow

2013-02-13 Thread Senthil Kumaran
Applying this patch - I tried this hypothetical test. $ ./python.exe -m timeit -s "import urllib.parse; x='a%20' * 10" "urllib.parse.unquote(x)" 10 loops, best of 3: 205 msec per loop Without the patch, the above test will run for minutes! This creates a significant difference for extremely

[issue17203] add long option names to unittest discovery docs

2013-02-13 Thread Chris Jerdonek
New submission from Chris Jerdonek: Currently, unittest's discovery command-line documentation: http://docs.python.org/dev/library/unittest.html#test-discovery does not include the long option names (--start-directory, --pattern, and --top-level-directory): http://hg.python.org/cpython/file/0

[issue17202] Add .bat line to .hgeol

2013-02-13 Thread Zachary Ware
New submission from Zachary Ware: Most times (though not all, for some reason) I try to use Doc\make.bat update, it fails with "The system cannot find the batch label specified - update" even though it is obviously there. The reason for this appears to be the fact that the file uses UNIX line

[issue17200] telnetlib.read_until() timeout uses the wrong units

2013-02-13 Thread Reuben D'Netto
Reuben D'Netto added the comment: Sure, no problem. I'll upload the completed patch once I've got it working. -- ___ Python tracker ___ __

[issue9822] windows batch files are dependent on cmd current directory

2013-02-13 Thread Zachary Ware
Zachary Ware added the comment: Here's the patch that moves external*.bat into PCbuild. I also took the opportunity to give the three files more descriptive names: external.bat -> get_externals.bat, external-common.bat -> get_common_externals.bat, and external-amd64.bat -> get_externals-amd64

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: "directory name.Yet a" needs spaces after '.'. The text is decent English and clear enough sentence by sentence, but the reality and hence the text as a whole is confusing. I wonder if it would be possible to make a little table dest

[issue9822] windows batch files are dependent on cmd current directory

2013-02-13 Thread Zachary Ware
Zachary Ware added the comment: I just stumbled across this issue in looking for another issue, and this turns out to be of interest to me as well. As such, I've updated sorin's patch to apply to the current default branch, added the same kind of change to the new-since-then clean-amd64.bat,

[issue17145] memoryview(array.array)

2013-02-13 Thread Demian Brecht
Demian Brecht added the comment: I've given this some more thought and quite a bit more work and reorganization. I think this clarifies the usage of memoryviews and buffers as well as the C-level API for each. This is my first run at contributing a patch of any sort, so please let me know if

[issue15220] Reduce parsing overhead in email.feedparser.BufferedSubFile

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0f827775f7b7 by R David Murray in branch 'default': #15220: simplify and speed up feedparser's line splitting. http://hg.python.org/cpython/rev/0f827775f7b7 -- nosy: +python-dev ___ Python tracker

[issue17198] dbm.whichdb references unitialized 'ndbm' variable

2013-02-13 Thread R. David Murray
R. David Murray added the comment: Well, that test works only on 3.2/3.3, because by 3.4 the ndbm variable is only referenced in the second try; make it 'touch foo.db' instead for 3.4. -- ___ Python tracker __

[issue17198] dbm.whichdb references unitialized 'ndbm' variable

2013-02-13 Thread R. David Murray
R. David Murray added the comment: By the way, this will demonstrate the bug: touch foo.pag python -m dbm.__init__ foo Perhaps that could be the basis for the test (using subprocess). -- stage: -> needs patch title: dbm.whichdbm references non-existent 'ndbm' -> dbm.whichdb refere

[issue17198] dbm.whichdbm references non-existent 'ndbm'

2013-02-13 Thread R. David Murray
R. David Murray added the comment: The code appears to be correct, but I think we need to add an explicit import for ndbm in the __init__ file. Right now I think it is only passing the tests because the test infrastructure imports all the dbm modules, including ndbm. (I did not realize that d

[issue15220] Reduce parsing overhead in email.feedparser.BufferedSubFile

2013-02-13 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue17198] dbm.whichdbm references non-existent 'ndbm'

2013-02-13 Thread Éric Araujo
Changes by Éric Araujo : -- keywords: +easy nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Nick Coghlan
Nick Coghlan added the comment: Stefan, would you be willing to write up your version as a PEP? (FWIW, I personally favour your suggested C'ish style for the preprocessor, since my brain would be in that mode anyway when hacking on C code) -- title: Integrate "Argument Clinic" specialize

[issue17192] libffi-3.0.12 import

2013-02-13 Thread Éric Araujo
Éric Araujo added the comment: Sound like a large change for stable releases. Usually we would not do that. -- nosy: +eric.araujo ___ Python tracker ___

[issue17179] Incorrect use of type function in types.new_class

2013-02-13 Thread Éric Araujo
Éric Araujo added the comment: > I'm guessing ns and kwds should be combined before being passed through to > meta? Possibly; can you try that? > surely this is a bugfix candidate for 3.3.1? If we get a patch with a test in time, otherwise 3.3.2. -- ___

[issue17179] Incorrect use of type function in types.new_class

2013-02-13 Thread Éric Araujo
Changes by Éric Araujo : -- keywords: +easy nosy: +eric.araujo stage: -> needs patch title: TypeError: type() takes 1 or 3 arguments -> Incorrect use of type function in types.new_class versions: +Python 3.4 ___ Python tracker

[issue17179] Incorrect use of type function in types.new_class

2013-02-13 Thread Chris Withers
Chris Withers added the comment: Eric, surely this is a bugfix candidate for 3.3.1? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue16692] Support TLS 1.1 and TLS 1.2

2013-02-13 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: -eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue16692] Support TLS 1.1 and TLS 1.2

2013-02-13 Thread Michele Orrù
Changes by Michele Orrù : Added file: http://bugs.python.org/file29066/issue16692.1.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue2175] Expat sax parser silently ignores the InputSource protocol

2013-02-13 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17201] Use allowZip64=True by default

2013-02-13 Thread William Mallard
William Mallard added the comment: Enabling ZIP64 seems like a reasonable default. The documentation justifies the current 32-bit default with outdated information: """ ZIP64 extensions are disabled by default because the default 'zip' and 'unzip' commands on Unix (the InfoZIP utilities) don't

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Shouldn't you try to make the permission removal atomic? Otherwise there's a window of opportunity to exploit the suid bit. -- nosy: +pitrou ___ Python tracker ___

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Richard Oudkerk
Changes by Richard Oudkerk : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue1285086] urllib.quote is too slow

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: needs patch -> patch review versions: +Python 3.3, Python 3.4 Added file: http://bugs.python.org/file29065/urllib_faster_unquote-2.7.patch ___ Python tracker __

[issue1285086] urllib.quote is too slow

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Proposed patches not only get rid of the refcount hack, but make unquote() and unquote_to_bytes() even significant faster for large strings. -- nosy: +serhiy.storchaka Added file: http://bugs.python.org/file29064/urllib_faster_unquote.patch _

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Stefan Krah
Stefan Krah added the comment: Jim Jewett wrote: > (1) The first several lines ( "/* pymacro.h */" until "/* could go into a > separate header file */" ) would not be written at all, and are just there to > help reviewers understand. Yes, they should ultimately go into Include/pymacro.h. >

[issue17189] Add zip64 support to shutil

2013-02-13 Thread William Mallard
William Mallard added the comment: Documentation added. See attached. -- Added file: http://bugs.python.org/file29063/shutil_zip64_by_default.patch ___ Python tracker ___ ___

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: The number of test cases isn't the problem. Having more but finer-grained test cases is usually preferred in fact. It's just that the test cases should be sharing code where possible so that they're shorter and easy to see how they differ from one another.

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Todd Rovito
Todd Rovito added the comment: Chris, Thanks for the clarification. I thought you were telling me my test cases were dry as in dry humorI will read-up on the dry concept and see what I can do to consolidate plus I will combine the patches. Initially I am thinking I could collapse all t

[issue1285086] urllib.quote is too slow

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: fixed -> stage: committed/rejected -> needs patch status: closed -> open ___ Python tracker ___ __

[issue1285086] urllib.quote is too slow

2013-02-13 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: As per discussion on python-dev, this bug should probably be reopened and the patch maybe reverted as relying on the refcounting hack is both dodgy and hurts other implementations, like PyPy. -- nosy: +fijall __

[issue15258] argparse documentation: Improve optparse section regarding allow_interspersed_args

2013-02-13 Thread Andrew McNabb
Changes by Andrew McNabb : -- nosy: +amcnabb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue14191] argparse doesn't allow optionals within positionals

2013-02-13 Thread Andrew McNabb
Changes by Andrew McNabb : -- nosy: +amcnabb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue10590] Parameter type error for xml.sax.parseString(string, ...)

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Expat sax parser silently ignores the InputSource protocol ___ Python tracker ___ ___

[issue2175] Expat sax parser silently ignores the InputSource protocol

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This patch is rather complicated and I doubt whether it is necessary to apply it to the older version. Can anyone review it? -- ___ Python tracker ___

[issue2175] Expat sax parser silently ignores the InputSource protocol

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file29062/sax_character_stream-2.7.patch ___ Python tracker ___ ___ Python-bug

[issue2175] Expat sax parser silently ignores the InputSource protocol

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file29061/sax_character_stream.patch ___ Python tracker ___ ___ Python-bugs-li

[issue2175] Expat sax parser silently ignores the InputSource protocol

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28954/sax_character_stream.patch ___ Python tracker ___ ___ Python-bugs-

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Jim Jewett
Jim Jewett added the comment: I'm not sure I correctly understand skrah's proposal. If I do, then (1) The first several lines ( "/* pymacro.h */" until "/* could go into a separate header file */" ) would not be written at all, and are just there to help reviewers understand. (2) The "#def

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Bradley Froehle
Bradley Froehle added the comment: > As for the docstring: I would like it better if I could avoid typing > the cumbersome "\n\"s. I agree with Stefan that the file is a lot more readable if the docstring is not repeated twice. It's unfortunate that C doesn't have a notion of a raw string (as op

[issue17189] Add zip64 support to shutil

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This should be reflected in the documentation. -- dependencies: +Use allowZip64=True by default ___ Python tracker ___ ___

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: > If it would help I could submit a single patch. Yes, a single patch is best. One way to make code more DRY is refactoring to use helper functions as needed (i.e. same code in multiple places -> one helper function). --

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Senthil, in my experience, whenever documentation is added that documents new aspects of behavior (e.g. is not just a rewording of existing documentation), tests are always added simultaneously (if not already present) to ensure that the code doesn't regress a

[issue17193] Use binary prefixes

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Then I'll apply this to 3.3 too. This will facilitate support of both versions. -- assignee: docs@python -> serhiy.storchaka versions: +Python 3.3, Python 3.4 ___ Python tracker

[issue17201] Use allowZip64=True by default

2013-02-13 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Python supports ZIP64 extension since 2.5 (more 6 years ago). May be it is time to use it by default, leaving the option to disable it by specifying allowZip64=False. -- components: Library (Lib) messages: 182048 nosy: alanmcintyre, loewis, pitrou,

[issue17192] libffi-3.0.12 import

2013-02-13 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Maybe Modules/_ctypes/libffi in 2.7, 3.2 and 3.3 branches should be updated? -- nosy: +Arfrever ___ Python tracker ___

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Here's a proposal for an alternative without parameter docstrings and > a > different DSL (see os_stat.c). I guess it's easiest to present my > thoughts > in list form. It's a bit difficult to give an opinion without a more formal definition. For example it se

[issue7279] decimal.py: == and != comparisons involving NaNs

2013-02-13 Thread Sebastian Berg
Sebastian Berg added the comment: Thanks, yes, you are right, should have googled a bit more anyway. Though I did not find much on the hashable vs unhashable itself, so if I ever stumble across it again, I will write a mail... -- ___ Python tracker

[issue7279] decimal.py: == and != comparisons involving NaNs

2013-02-13 Thread Mark Dickinson
Mark Dickinson added the comment: Sebastian: I think this discussion is a bit off-topic for this particular bug; you might want to raise it on python-dev or python-ideas instead. Bear in mind, though, that the behaviour of NaNs and containers has been discussed to death many times in the p

[issue17189] Add zip64 support to shutil

2013-02-13 Thread William Mallard
William Mallard added the comment: Ok, here's a patch that makes zip64 the default in make_archive() when format='zip'. I also agree that ZipFile should set allowZip64=True by default. (PKZIP has supported zip64 since 2001!) -- Added file: http://bugs.python.org/file29060/shutil_zip64

[issue17193] Use binary prefixes

2013-02-13 Thread Brett Cannon
Brett Cannon added the comment: IMO I say just do 3.4 since it isn't really a bug fix but a cleanup, but I wouldn't object if it was backported. -- ___ Python tracker ___ __

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Todd Rovito
Todd Rovito added the comment: Chris, I first verified the issue then created some wording and you pointed out that we needed test cases so I created a bunch of test cases. As you pointed out "I count 2*3*2=12 possibilities to check (excluding src and dst being on different filesystems):"

[issue7279] decimal.py: == and != comparisons involving NaNs

2013-02-13 Thread Sebastian Berg
Sebastian Berg added the comment: This is closed, and maybe I am missing something. But from a general point of view, why does hashing of NaN not raise an error as it did for decimals, i.e. why was this not resolved exactly the other way around? I am mostly just wondering about this it is not

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Richard Oudkerk
Richard Oudkerk added the comment: > Perhaps NEWS item needed for this change. Done. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 82db097cd2e0 by Richard Oudkerk in branch '2.7': Add Misc/NEWS entry for Issue #16743 http://hg.python.org/cpython/rev/82db097cd2e0 New changeset efe489f87881 by Richard Oudkerk in branch '3.2': Add Misc/NEWS entry for Issue #16743 http://hg.python.

[issue17170] string method lookup is too slow

2013-02-13 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17199] Slightly wrong behavior of logging.StrFormatStyle.usesTime

2013-02-13 Thread R. David Murray
R. David Murray added the comment: I would still consider it a bug myself, but I understand and accept that you feel it is not worth fixing. -- nosy: +r.david.murray ___ Python tracker

[issue17199] Slightly wrong behavior of logging.StrFormatStyle.usesTime

2013-02-13 Thread Enrique A Tobis
Enrique A Tobis added the comment: Thanks! Got it. Sorry for the noise. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue17199] Slightly wrong behavior of logging.StrFormatStyle.usesTime

2013-02-13 Thread Vinay Sajip
Vinay Sajip added the comment: It's not a bug - the reason it's like that is that it allows conversion and format specifiers to be given - {field_name!conversion:format_spec}. Of course a more robust solution using regular expressions could be implemented, but it's not really worth it. If ther

[issue17061] tokenize unconditionally emits NL after comment lines & blank lines

2013-02-13 Thread Thomas Kluyver
Thomas Kluyver added the comment: Hmm, that's interesting. For our purposes, a blank line or a comment line shouldn't result in a continuation prompt. This is consistent with what the plain Python shell does. As part of this, we're tokenizing the code, and if the final \n results in a NL toke

[issue17089] Expat parser parses strings only when XML encoding is UTF-8

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps NEWS item needed for this change. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17189] Add zip64 support to shutil

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agree. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Hynek Schlawack
Hynek Schlawack added the comment: SGTM. I’d like an explicit warning on the security implications in the docs though. -- ___ Python tracker ___

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Stefan Krah
Stefan Krah added the comment: Here's a proposal for an alternative without parameter docstrings and a different DSL (see os_stat.c). I guess it's easiest to present my thoughts in list form. Changes and rationale: == Split docstring into function header and rest --

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Christian Heimes
Christian Heimes added the comment: Here is a new patch with a new keyword argument preserve_sbits. Perhaps we use `True` as default for Python 2.6 to 3.3 and switch to False in Python 3.4? -- Added file: http://bugs.python.org/file29058/17180_preserve_sbits.patch _

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset b1bbe519770b by Richard Oudkerk in branch '2.7': Issue #16743: Fix mmap overflow check on 32 bit Windows http://hg.python.org/cpython/rev/b1bbe519770b New changeset c2c84d3ab393 by Richard Oudkerk in branch '3.2': Issue #16743: Fix mmap overflow che

[issue17189] Add zip64 support to shutil

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Yes, there is a special flag for this in zipfile. It is named > allowZip64. Then I think shutil should set allowZip64 to True by default. People who want fine-grained control over the zipfile's characteristics can still use the zipfile module directly. -

[issue17197] c/profile refactoring

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > No, it's the other way around. It's from cProfile which I import > profile. > > diff --git a/Lib/cProfile.py b/Lib/cProfile.py > --- a/Lib/cProfile.py > +++ b/Lib/cProfile.py > ... > +import profile as _pyprofile That's exactly what I'm saying. Once you impor

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Hynek Schlawack
Hynek Schlawack added the comment: Yeah, I’m thinking about backup scripts etc. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Christian Heimes
Christian Heimes added the comment: Sorry for the extra noise. I got into a comment conflict with Hynek. Hynek, I don't think it's going to break lots of apps. setuid/setgid programs are rare these days. Most operating system ignore sticky bits on files, too. It may break system scripts that c

[issue17199] Slightly wrong behavior of logging.StrFormatStyle.usesTime

2013-02-13 Thread R. David Murray
Changes by R. David Murray : -- type: enhancement -> behavior versions: +Python 3.2, Python 3.4 ___ Python tracker ___ ___ Python-bugs

[issue17199] Slightly wrong behavior of logging.StrFormatStyle.usesTime

2013-02-13 Thread R. David Murray
Changes by R. David Murray : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Christian Heimes
Changes by Christian Heimes : -- keywords: +patch Added file: http://bugs.python.org/file29057/17180.patch ___ Python tracker ___ ___

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Christian Heimes
Christian Heimes added the comment: Here is a patch for the issue with test and doc updates. I'm escalating the bug to release blocker to draw the attention of our RMs. -- ___ Python tracker __

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Hynek Schlawack
Hynek Schlawack added the comment: While I agree that it’s a problem, I’m a bit uneasy about changing that back to 2.7. I’m pretty sure this would break numerous programs. -- ___ Python tracker ___

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Christian Heimes
Christian Heimes added the comment: cp removes three bits unless preserve ownership is enabled and some additional things are true. mode &= ~ (S_ISUID | S_ISGID | S_ISVTX) S_ISVTX is the sticky bit. -- ___ Python tracker

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Christian Heimes
Christian Heimes added the comment: Thanks for the report. I agree with your analysis. We should follow the behavior of cp and always strip off the suid/sgid bits in shutil.copy(). coreutil's cp removes the bits and doesn't handle source owner = destination owner special. There are other bits

[issue17193] Use binary prefixes

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: For what versions can I apply this patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue16996] Reuse shutil.which() in webbrowser module

2013-02-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue17189] Add zip64 support to shutil

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Would there be a way to automatically switch the flag as necessary? > (i.e. when writing more than 2GB, I guess) Yes, there is a special flag for this in zipfile. It is named allowZip64. The only reason to use allowZip64=False is when you expect to unzip a

[issue16692] Support TLS 1.1 and TLS 1.2

2013-02-13 Thread Michele Orrù
Changes by Michele Orrù : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue16996] Reuse shutil.which() in webbrowser module

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you, Senthil. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue11311] StringIO.readline(0) returns incorrect results

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Fixed. Thank you for the report, Ville. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue5308] cannot marshal objects with more than 2**31 elements

2013-02-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Perhaps you could add a bigmem test for this? > (assuming you have enough memory somewhere to test it) Some tests require more than 252 GiB of memory. -- ___ Python tracker ___

[issue5308] cannot marshal objects with more than 2**31 elements

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 72e75ea25d00 by Serhiy Storchaka in branch '2.7': Fix tests for issue #5308. http://hg.python.org/cpython/rev/72e75ea25d00 New changeset 0407e5e5915e by Serhiy Storchaka in branch '3.3': Cleanup a test for issue #5308. http://hg.python.org/cpython/r

[issue11311] StringIO.readline(0) returns incorrect results

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7513bd184a01 by Serhiy Storchaka in branch '2.7': Issue #11311: StringIO.readline(0) now returns an empty string as all other http://hg.python.org/cpython/rev/7513bd184a01 -- nosy: +python-dev ___ Python

[issue16996] Reuse shutil.which() in webbrowser module

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 050c94f5f72c by Serhiy Storchaka in branch 'default': Issue #16996: webbrowser module now uses shutil.which() to find a http://hg.python.org/cpython/rev/050c94f5f72c -- nosy: +python-dev ___ Python tracke

[issue5308] cannot marshal objects with more than 2**31 elements

2013-02-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 385d982ce641 by Serhiy Storchaka in branch '2.7': Issue #5308: Raise ValueError when marshalling too large object (a sequence http://hg.python.org/cpython/rev/385d982ce641 New changeset e0464fa28c85 by Serhiy Storchaka in branch '3.2': Issue #5308:

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2013-02-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +christian.heimes, hynek, tarek priority: normal -> high type: -> security versions: +Python 3.3, Python 3.4 -Python 2.6, Python 3.1 ___ Python tracker

[issue17197] c/profile refactoring

2013-02-13 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: No, it's the other way around. It's from cProfile which I import profile. diff --git a/Lib/cProfile.py b/Lib/cProfile.py --- a/Lib/cProfile.py +++ b/Lib/cProfile.py ... +import profile as _pyprofile -- ___ Python

[issue17189] Add zip64 support to shutil

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Would there be a way to automatically switch the flag as necessary? (i.e. when writing more than 2GB, I guess) -- nosy: +hynek, pitrou, tarek ___ Python tracker ___

[issue17197] c/profile refactoring

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: The patch doesn't look right to me. If you import cProfile, profile will always invoke the cProfile profiler. -- ___ Python tracker ___ ___

[issue17170] string method lookup is too slow

2013-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Truthfully I was hoping someone else would pick up the gauntlet once it > was checked in and make a new argument processing API / hack up the > Argument Clinic output to make it faster. Argument Clinic's preprocessing would be a very nice building block to ge

[issue17170] string method lookup is too slow

2013-02-13 Thread Larry Hastings
Larry Hastings added the comment: Oh, and, as to whether Argument Clinic would solve this problem, the answer is "not yet". Right now Argument Clinic literally generates calls to PyArg_ParseTupleAndKeywords. (In special cases it switches to PyArg_ParseTuple.) I'm more interested in Argument

[issue16278] os.rename documentation slightly inaccurate

2013-02-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: Chris: The patch is for the docs. the test code I believe, is for reference. It would be to run it on different OS and verify the documentation matches the behavior.I am okay with more than one person verifying this and I shall do on OS'es I have. --

  1   2   >