[issue17331] namedtuple raises a SyntaxError instead of ValueError on invalid identifier

Roundup Robot added the comment: New changeset 80bcc98bf939 by Raymond Hettinger in branch '3.3': Issue #17331: Use isidentifier() instead of isalnum() to check for valid identifiers. http://hg.python.org/cpython/rev/80bcc98bf939 -- nosy: +python-dev __

[issue17331] namedtuple raises a SyntaxError instead of ValueError on invalid identifier

Changes by Raymond Hettinger : -- assignee: -> rhettinger priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailin

[issue17331] namedtuple raises a SyntaxError instead of ValueError on invalid identifier

Ramchandra Apte added the comment: > namedtuple should simply use isidentifier(), rather than isalnum(). +2 -- nosy: +Ramchandra Apte ___ Python tracker ___ _

[issue17330] Stop checking for directory cache invalidation in importlib

Erik Bray added the comment: Dropping the implicit invalidation altogether works for me. I was hoping to find a better solution because for the majority of use cases I personally care about the existing behavior is preferable. That said I have to support OSX users as possibly the majority of

[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: Fine, I asked python-dev, but I said it's going to take a lot to convince me not to rip out the cache invalidation code. -- ___ Python tracker __

[issue17335] FieldStorageClass is messed up

New submission from Neal Norwitz: This problem goes back to 2.6 at least. In Lib/cgi.py FieldStorageClass = None def read_multi(self, environ, keep_blank_values, strict_parsing): """Internal: read a part that is itself multipart.""" ib = self.innerboundary if no

[issue17330] Stop checking for directory cache invalidation in importlib

Antoine Pitrou added the comment: I would suggest checking on python-dev before removing the cache freshness check. Some people may rely on it. -- ___ Python tracker ___

[issue17331] namedtuple raises a SyntaxError instead of ValueError on invalid identifier

Antoine Pitrou added the comment: namedtuple should simply use isidentifier(), rather than isalnum(). -- nosy: +pitrou ___ Python tracker ___

[issue17330] Stop checking for directory cache invalidation in importlib

Eric Snow added the comment: Yanking the implicit cache validation does seem to be the simplest solution here. Perhaps we could come up with a complex way of making this work, but I don't think it's worth it. What may be worth it is making the admonition of "use invalidate_caches()" easier t

[issue10716] Modernize pydoc to use better HTML and separate CSS

Ron Adam added the comment: I'm going to go over this issue again with fresh eyes after having been away for some time. Recent experience with another project has helped answer some of the questions I had earlier. Particulary, how not to over specifying class names and id's. This should lea

[issue17331] namedtuple raises a SyntaxError instead of ValueError on invalid identifier

Florent Xicluna added the comment: This is consistent: >>> '¹'.isnumeric(), '¹'.isdigit(), '¹'.isdecimal() (True, True, False) >>> unicodedata.numeric('¹') 1.0 >>> unicodedata.digit('¹') 1 >>> unicodedata.decimal('¹') Traceback (most recent call last): File "", line 1, in ValueError: not a d

[issue17301] An in-place version of many bytearray methods is needed

Gregory P. Smith added the comment: Translate isn't a text operation. (That's the api I wanted). The others I only lists for completeness because someone else would complain if I hadn't. ;) On Mar 1, 2013 12:57 PM, "Terry J. Reedy" wrote: > > Terry J. Reedy added the comment: > > I think you n

[issue17310] Ctypes callbacks shows problem on Windows Python (64bit)

Changes by Terry J. Reedy : -- nosy: +amaury.forgeotdarc, meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue17309] __bytes__ doesn't work in subclass of int and str

Terry J. Reedy added the comment: More data: class myit(list): def __bytes__(self): return b'hello' print (bytes(b'a')) class myit(list): def __bytes__(self): return b'hello' print (bytearray (myit([1,2,3]))) # bytearray(b'a') # bytearray(b'\x01\x02\x03') class by: def __bytes__(s

[issue17285] subprocess.check_output incorrectly state that output is always bytes

Changes by Terry J. Reedy : -- nosy: +terry.reedy versions: +Python 3.4 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue17309] __bytes__ doesn't work in subclass of int and str

Terry J. Reedy added the comment: The library doc says that if the source argument for bytes() or bytearray() is a string or integer it is treated a certain way. I believe 'string' and 'integer' are meant to include subclasses of str and int, else it should have said str or int. You have verif

[issue17334] Fix test discovery for test_index.py

New submission from Zachary Ware: Just subclassing issues in this one. -- components: Tests files: test_index_discovery.diff keywords: patch messages: 183299 nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_inde

[issue17331] Fix str methods for detecting digits with unicode

Mathieu Pasquet added the comment: I understand the reasoning behind the feature, and the will to be unicode-compliant, but I think this might still break a lot of code (though it may never be detected). I understand that isdecimal() is the safe way, because anything that is a decimal (Nd) ca

[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: So let's see what options we have on the table. Status quo: picks up mutated modules as long as the mtime is granular enough. Fails in the face of added fails under the same conditions. Need to call importlib.invalidate_caches() to avoid this problem. Add st_nl

[issue17331] Fix str methods for detecting digits with unicode

Florent Xicluna added the comment: Actually, the character is SUPERSCRIPT ONE, in the category No (Number other). http://www.fileformat.info/info/unicode/char/b9/index.htm This is not a valid category for the identifiers, only "Nd" Number decimal is accepted. The issue is probably in namedtupl

[issue17331] Fix str methods for detecting digits with unicode

R. David Murray added the comment: I think this is working as designed, and can't be changed (at least not easily) because of backward compatibility even if there are bits of the design that are deemed buggy. The issue, I believe, is what is considered a number by the Unicode consortium. See

[issue17333] Fix test discovery for test_imaplib.py

New submission from Zachary Ware: Here's a patch for test_imaplib.py that converts test_main into load_tests. -- components: Tests files: test_imaplib_discovery.diff keywords: patch messages: 183294 nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: ope

[issue17332] typo in json docs - "convered" should be "converted"

New submission from Ernie Hershey: Hi, On these pages: http://docs.python.org/3.4/library/json.html http://docs.python.org/3.3/library/json.html http://docs.python.org/3.2/library/json.html http://docs.python.org/2/library/json.html http://docs.python.org/2.6/library/json.html This line says "

[issue17302] HTTP/2.0 - Implementations/Testing efforts

Changes by Terry J. Reedy : -- resolution: -> postponed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue17301] An in-place version of many bytearray methods is needed

Terry J. Reedy added the comment: I think you need to make more of a case for 'should'. Bytearrays are, well, byte arrays, not text arrays. I could just as well claim that the ascii text operations should not even be there. They are certainly not needed for typical mixed binary-ascii protocol

[issue17331] Fix str methods for detecting digits with unicode

New submission from Mathieu Pasquet: In py3k, str.isalnum(), str.isdigit(), and str.isdecimal() are broken because they take into account various unicode numbers. A common case is doing something like that: num = -1 while num == -1: num_in = input('Enter a number> ') if num_in.isdigit(

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Antoine Pitrou added the comment: > I should add, Antoine's counter-example of a file that's renamed or > replaced already doesn't work either under OSX. So while this > solution won't address that (even more narrow) use case, it would at > least improve the existing situation for what I would l

[issue16997] subtests

Antoine Pitrou added the comment: > That means there's a part of Antoine's patch I disagree with: the > change to eliminate the derived "overall" result attached to the > aggregate test. The patch doesn't eliminate it, there are even tests for it. (see the various call order tests) > The comple

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Erik Bray added the comment: I should add, Antoine's counter-example of a file that's renamed or replaced already doesn't work either under OSX. So while this solution won't address that (even more narrow) use case, it would at least improve the existing situation for what I would like to thi

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Erik Bray added the comment: Fair enough, but then I would propose removing the automatic cache invalidation based on mtime altogether. It's just not reliable enough--this caused previously working code to break unexpectedly, and only on a single platform at that. I'm fine with "importlib.in

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Antoine Pitrou added the comment: > Put another way, the cache associated with a FileFinder only keeps > track of the filenames in a directory, and not their individual > mtimes. So if a new file is added to the directory the cache should > be invalided. Likewise if a file is removed. True, bu

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Erik Bray added the comment: Put another way, the cache associated with a FileFinder only keeps track of the filenames in a directory, and not their individual mtimes. So if a new file is added to the directory the cache should be invalided. Likewise if a file is removed. If a file is modif

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Erik Bray added the comment: Why should modifying the file in place be expected to do anything with respect to the directory cache? If that module has already been imported then modifying it should not require the cache to be invalidated. If the file is modified *before* it's imported that's

[issue17298] Twisted test failure triggered by change in 2.7 branch

Ezio Melotti added the comment: Thank you for finding and reporting it! -- stage: needs patch -> committed/rejected ___ Python tracker ___ ___

[issue17298] Twisted test failure triggered by change in 2.7 branch

Glyph Lefkowitz added the comment: Confirmed. Thanks very much for addressing it promptly. -- resolution: -> duplicate status: pending -> closed ___ Python tracker ___

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Brett Cannon added the comment: Antoine does make a good point: adding st_nlink could lead to some hard-to-discover bugs because something will work the first time when the file is added but then subsequently fail if you are modifying the new file in-place. I'm going to go with Antoine's think

[issue17328] Fix reference leak in dict_setdefault() in case of resize failure

Changes by Ezio Melotti : -- nosy: +serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17315] test_posixpath doesn't clean up after itself

Chris Jerdonek added the comment: Thanks, I confirmed the fix. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue17312] test_aifc doesn't clean up after itself

Chris Jerdonek added the comment: Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17312] test_aifc doesn't clean up after itself

Ezio Melotti added the comment: Should be fixed now. -- assignee: -> ezio.melotti resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue17312] test_aifc doesn't clean up after itself

Roundup Robot added the comment: New changeset 10909360a11d by Ezio Melotti in branch 'default': #17312: unlink a file that test_aifc was leaving around. http://hg.python.org/cpython/rev/10909360a11d -- nosy: +python-dev ___ Python tracker

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Antoine Pitrou added the comment: Well, importlib.invalidate_caches() is not a workaround, it's really the right way to solve your issue (for example if instead of writing a new module, you modify an existing one: st_nlink will then remain the same). -- ___

[issue17315] test_posixpath doesn't clean up after itself

Ezio Melotti added the comment: Should be fixed now. -- assignee: -> ezio.melotti resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed versions: +Python 2.7, Python 3.2, Python 3.3 ___ Python tracker

[issue17315] test_posixpath doesn't clean up after itself

Roundup Robot added the comment: New changeset ed3ca7298055 by Ezio Melotti in branch '2.7': #17315: unlink a file that test_posixpath was leaving around. http://hg.python.org/cpython/rev/ed3ca7298055 New changeset c65e98ce1a05 by Ezio Melotti in branch '3.2': #17315: unlink a file that test_pos

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Brett Cannon added the comment: [for anyone else who doesn't know what st_nlink is for: http://docs.python.org/3/library/stat.html#stat.ST_NLINK] Since it doesn't add stat overhead as it's just part of what os.path.stats() returns I'm fine with adding it to part of the invalidation scheme. Wha

[issue17312] test_aifc doesn't clean up after itself

Chris Jerdonek added the comment: Similar to as I stated in issue 17315, you won't see it when using regrtest since regrtest creates and then deletes a temp working directory. The file gets created and is left behind in the current working directory. Try running using unittest, e.g. ./python

[issue17306] Improve the way abstract base classes are shown in help()

Changes by Éric Araujo : -- nosy: +eric.araujo versions: +Python 3.4 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Éric Araujo added the comment: > This is a possible additional example for set_tunnel, Thanks. In general, our tooling expects unified diffs, such as produced by hg diff. > modification of python3.3/html/_sources/library/http.client.txt That’s a copy for web hosting, the real source is in Doc

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

Changes by Erik Bray : -- keywords: +patch Added file: http://bugs.python.org/file29286/94e671589c0e.diff ___ Python tracker ___ ___ P

[issue17330] Check st_nlink in addition to st_mtime to invalidate FileFinder cache

New submission from Erik Bray: This is vaguely related to issue14067, though the patch suggested there would make this problem worse, not better. This addresses a problem that cropped up on OSX in which some code that, for Good Reasons, generates a module in a package directory and then expect

[issue17315] test_posixpath doesn't clean up after itself

Chris Jerdonek added the comment: The file gets created in the current working directory. You won't see it when using regrtest since regrtest creates and then deletes a temp working directory. To see it easier, try running instead: ./python.exe -m unittest test.test_posixpath -- ___

[issue17281] Broken links at pypi

Éric Araujo added the comment: First link is broken because the distutils2 project in its current form is stopped and the doc is nowhere. (Obsolete versions can be found in a few places :/) Second link is broken due to Python wiki config changes. I will update the PyPI metadata to explain th

[issue17312] test_aifc doesn't clean up after itself

Ezio Melotti added the comment: On Linux it looks OK. Does it always happen? Where is the file located? -- nosy: +ezio.melotti ___ Python tracker ___ __

[issue17315] test_posixpath doesn't clean up after itself

Ezio Melotti added the comment: On Linux it looks OK. Does it always happen? Where is the file located? -- nosy: +ezio.melotti ___ Python tracker ___ __

[issue17298] Twisted test failure triggered by change in 2.7 branch

Ezio Melotti added the comment: That buildbot seems to be green again: https://buildbot.twistedmatrix.com/builders/lucid32-py2.7maint/builds/2359/ Glyph, can you confirm that the problem has been fixed and that this issue can be closed? -- nosy: +ezio.melotti status: open -> pending

[issue15795] Zipfile.extractall does not preserve file permissions

Changes by Cédric de Saint Martin : -- nosy: +desaintmartin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue17288] cannot jump from a return after setting f_lineno

Xavier de Gaye added the comment: Must add for completeness that f_lineno must be valid within a return trace function for the reasons explained in the last paragraph of Objects/lnotab_notes.txt. -- ___ Python tracker

[issue17288] cannot jump from a return after setting f_lineno

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue17324] SimpleHTTPServer serves files even if the URL has a trailing slash

Senthil Kumaran added the comment: I thought this was fixed (recently). Shall look again. Having the tests is the only hard part here. -- nosy: +orsenthil ___ Python tracker ___

[issue17329] Document unittest.SkipTest

New submission from Brett Cannon: -- assignee: docs@python components: Documentation messages: 183262 nosy: brett.cannon, docs@python, ezio.melotti, michael.foord, zach.ware priority: normal severity: normal stage: needs patch status: open title: Document unittest.SkipTest versions: Pyt

[issue17328] Fix reference leak in dict_setdefault() in case of resize failure

New submission from Stefan Behnel: While writing the patch for issue 17327, I noticed that there is a double reference leak in dict_setdefault() under the rare condition that resizing fails. I'm not 100% sure that it's ok to move the increfs behind the resizing, but considering that the resizi

[issue17327] Add PyDict_GetItemSetDefault() as C-API for dict.setdefault()

New submission from Stefan Behnel: The functionality of dict.setdefault() is not currently available through the C-API. Specfically, there is no way to test for a key and insert a fallback value for it without evaluating the hash function twice. The attached patch adds a new C-API function PyD

[issue17326] Windows build docs still referring to VS 2008 in 3.3

Changes by Ezio Melotti : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue17326] Windows build docs still referring to VS 2008 in 3.3

New submission from Christoph Zwerschke: The first paragraph in PCbuild/readme.txt of Python 3.3 still talks about Visual C++ 2008 Express and Visual Studio 2008. It says that VS 2008 is required at the very least (which may be still true, I'm not sure), but then it also says "the official Pyt

[issue16935] unittest should understand SkipTest at import time during test discovery

Roundup Robot added the comment: New changeset 22b6b59c70e6 by Ezio Melotti in branch 'default': #16935: update test_crypt now that unittest discover understands SkipTest. http://hg.python.org/cpython/rev/22b6b59c70e6 -- ___ Python tracker

[issue16935] unittest should understand SkipTest at import time during test discovery

Ezio Melotti added the comment: Applied, thanks for the patch! SkipTest should probably be documented, but that's a separate issue :) -- assignee: michael.foord -> ezio.melotti keywords: -gsoc resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___

[issue16935] unittest should understand SkipTest at import time during test discovery

Roundup Robot added the comment: New changeset 61ce6deb4577 by Ezio Melotti in branch 'default': #16935: unittest now counts the module as skipped if it raises SkipTest, instead of counting it as an error. Patch by Zachary Ware. http://hg.python.org/cpython/rev/61ce6deb4577 -- nosy: +p

[issue17288] cannot jump from a return after setting f_lineno

Xavier de Gaye added the comment: The proposed patch fixes the problem: * f_lineno cannot be set now from an exception trace function or from a return trace function. * The broken arithmetic involving a null pointer (f->f_stacktop, at the end of frame_setlineno when popping blocks that are be

[issue17288] cannot jump from a return after setting f_lineno

Xavier de Gaye added the comment: Nosying Benjamin Peterson who knows frame_setlineno (issue 14612) and nosying Jesús Cea Avión. Hoping they don't mind. This problem occurs also when setting f_lineno from an exception debug event. One may crash the interpreter (or get a "SystemError: unknown op

[issue17323] Disable [X refs, Y blocks] ouput in debug builds

Chris Jerdonek added the comment: The "refs" output also complicates testing in some cases, e.g. http://hg.python.org/cpython/file/bc4458493024/Lib/test/test_subprocess.py#l61 http://hg.python.org/cpython/file/bc4458493024/Lib/test/test_subprocess.py#l786 -- nosy: +chris.jerdonek _

[issue17325] improve organization of the PyPI distutils docs

New submission from Chris Jerdonek: This issue is to improve the organization of the PyPI section of the Distutils documentation, now that the information has been combined into one page. A patch is attached. Improvements include: (1) Creating a section for command options common to both regi

[issue17082] Fix test discovery for test_dbm*.py

Ezio Melotti added the comment: Fixed, thanks for the patch! There are still two "failures", but they will be addressed in #16935. -- assignee: -> ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python trac

[issue17082] Fix test discovery for test_dbm*.py

Roundup Robot added the comment: New changeset b62317fe1a22 by Ezio Melotti in branch '3.3': #17082: test_dbm* now work with unittest test discovery. Patch by Zachary Ware. http://hg.python.org/cpython/rev/b62317fe1a22 New changeset e35c053cc4ec by Ezio Melotti in branch 'default': #17082: merg

[issue17079] Fix test discovery for test_ctypes.py

Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker _

[issue17079] Fix test discovery for test_ctypes.py

Roundup Robot added the comment: New changeset 42d4a29509c4 by Ezio Melotti in branch '3.3': #17079: test_ctypes now works with unittest test discovery. Patch by Zachary Ware. http://hg.python.org/cpython/rev/42d4a29509c4 New changeset e222f24837dd by Ezio Melotti in branch 'default': #17079:

[issue17324] SimpleHTTPServer serves files even if the URL has a trailing slash

Changes by Larry Hastings : -- stage: -> test needed type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue17324] SimpleHTTPServer serves files even if the URL has a trailing slash

New submission from Larry Hastings: To reproduce: 1) Create a file called "foo.txt" in the local directory, put whatever you like in it. 2) Run "python -m SimpleHTTPServer" or "python3 -m http.server". 3) Point your web browser at "http://127.0.0.1:8000/foo.txt/";. 4) Note that the server has s

[issue14468] Update cloning guidelines in devguide

Ezio Melotti added the comment: Yes, it should be added back in the FAQs. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11955] 3.3 : test_argparse.py fails 'make test'

Ezio Melotti added the comment: The attached patch adds the list of args to the output of assertRaises in case of error, e.g.: FAIL: test_failures_one_group_sysargs (test.test_argparse.TestPositionalsNargsZeroOrMoreNone) -- Tra

[issue17323] Disable [X refs, Y blocks] ouput in debug builds

New submission from Ezio Melotti: I suggest to disable the [X refs, Y blocks] ouput in debug builds by default, and provide an option to enable it if/when necessary. Most of the time these values are not necessary, and they end up getting in the way while copy/pasting code from the interpreter