[issue17206] Py_XDECREF() expands its argument multiple times

Illia Polosukhin added the comment: Command used for benchmarking was: python perf.py -b 2n3 -f ../cpython/baseline-clang/python.exe ../cpython/experiment-clang/python.exe | tee perf.log -- ___ Python tracker ___

[issue17206] Py_XDECREF() expands its argument multiple times

Illia Polosukhin added the comment: Benchmark run on Clang Mac OS X 10.7 attached of comparison with and without patch 17206.diff. -- Added file: http://bugs.python.org/file29440/perf.log ___ Python tracker __

[issue17206] Py_XDECREF() expands its argument multiple times

Illia Polosukhin added the comment: Additionally, in macros Py_XINCREF and Py_XDECREF we've took an opportunity to increase readability by changing expression: > if (item == NULL) ; else action(item); to more natural inverted condition: > if (item != NULL) action(item); There is a chance that t

[issue17206] Py_XDECREF() expands its argument multiple times

Illia Polosukhin added the comment: I've worked on this with Dave Malcolm @PyCon2013 sprints. This patch is work in progress to make Py_XDECREF() and Py_XINCREF() expands their arguments once instead of multiple times. Because patch is work in progress, it contains old version for ease of ben

[issue17452] ftplib raises exception if ssl module is not available

New submission from Russell Kackley: On a system with no ssl module the following test failure occurs: == ERROR: test_dir (test.test_ftplib.TestFTPClass) -- Tra

[issue17445] Return the type you accept

Terry J. Reedy added the comment: Changing behavior that already matches the docs is an enhancement, not a bugfix, and one that will almost certainly break code. It is therefore one that would normally require a deprecation period. I think the most you should ask for is to skip the deprecation

[issue17451] Test to splitdoc in pydoc.py

New submission from Matt Bachmann: Found a line in splitdoc that was not being exercised. I added a test for it. -- components: Library (Lib) files: splitdoc_description_test.patch keywords: patch messages: 184427 nosy: Matt.Bachmann priority: normal severity: normal status: open title:

[issue17450] Failed to build _sqlite3

New submission from Christina Chan: Tried to install python 2.7.3 on Linux 2.6.18-194.8.1.el5 x86_64 with the following steps:- 1. after gunzip, did ./configure in Python-2.7.3 directory 2. make here is the error I ran into when executing make:- Python build finished, but the necessary bits t

[issue9334] argparse does not accept options taking arguments beginning with dash (regression from optparse)

paul j3 added the comment: I think the `re.compile(r'^-.+$')` behavior could be better achieved by inserting a simple test in `_parse_optional` before the `_negative_number_matcher` test. # behave more like optparse even if the argument looks like a option if self.args_default_to_posit

[issue17445] Return the type you accept

R. David Murray added the comment: That looks like a bug in difflib (regardless of what type it returns). But note that I'm agreeing that returning the same type you are given is generally preferrable. -- ___ Python tracker

[issue17415] Clarify docs of os.path.normpath()

Changes by Terry J. Reedy : -- assignee: docs@python -> terry.reedy stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue17448] test_sax should skip when no xml parsers are found

R. David Murray added the comment: Thanks, Rafael. -- nosy: +r.david.murray resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.2, Python 3.4 ___ Python tracker __

[issue17448] test_sax should skip when no xml parsers are found

Roundup Robot added the comment: New changeset 114e363ebf83 by R David Murray in branch '3.2': #17448: Make test_sax skip if there are no xml parsers. http://hg.python.org/cpython/rev/114e363ebf83 New changeset 3ab80610b2a2 by R David Murray in branch '3.3': Merge #17448: Make test_sax skip if t

[issue17449] dev guide appears not to cover the benchmarking suite

New submission from Dave Malcolm: Does the devguide document the benchmarking suite anywhere? I can't see it anywhere in the index on http://docs.python.org/devguide/ and google doesn't seem to show anything. suggested content: * how to run the benchmarks for a Python 2 implementation * h

[issue10560] Fixes for Windows sources

Martin v. Löwis added the comment: I'm rejecting the patch, on grounds of PEP 11. We only support MSVC compilers up to 3 years after the extended support by Microsoft has expired. For MSC 5, this is long past. For MSC 6, extended support was discontinued in 2005, for MSVC 2002, in 2009. For al

[issue17448] test_sax should skip when no xml parsers are found

Changes by Rafael Santos : -- title: test_xml should skip when no xml parsers are found -> test_sax should skip when no xml parsers are found ___ Python tracker ___

[issue17448] test_xml should skip when no xml parsers are found

Changes by Rafael Santos : -- keywords: +patch Added file: http://bugs.python.org/file29435/skiptestsax.patch ___ Python tracker ___ _

[issue17448] test_xml should skip when no xml parsers are found

New submission from Rafael Santos: When running test_xml, an exception is thrown if no SAXReader is available, but the test is not skipped. [1/1] test_sax test test_sax crashed -- Traceback (most recent call last): File "/Users/tucif/Documents/dev/cpython/cpython/Lib/test/test_sax.py", line

[issue3840] if TESTFN == "/tmp/@test", some tests fail

Colin Su added the comment: TESTFN will be in format "@test_{pid}_tmp" instead of "@test" right now. So it's not easy to have exactly the same name "@test_{pid}_tmp" in case if you put "@test_{X}_tmp" (for X in range(1,10)) so many files into the top folder. does it need to keep open anym

[issue17443] imaplib.IMAP4_stream subprocess is opened unbuffered but ignores short reads

Diane Trout added the comment: So as a first stab at fixing this. I modified imaplib to wrap the process.stdin / process.stdout from with io.BufferedWriter / io.BufferedReader. I didn't use the TextIOWrapper as the imaplib wanted to work with the raw \r\n. The change seems to have fixed the p

[issue7720] Errors in tests and C implementation of raw FileIO

R. David Murray added the comment: Looks to me like this issue is out of date. -- nosy: +r.david.murray resolution: -> out of date stage: test needed -> committed/rejected status: open -> closed ___ Python tracker

[issue15927] csv.reader() does not support escaped newline when quoting=csv.QUOTE_NONE

Kalon Mills added the comment: Serhiy, sorry I'm not sure I understand your question. But if you take a look at the script that exhibits the problem I think the bug that I'm reporting becomes more clear. Namely, using the dialect configuration shown in the script, the round trip conversion

[issue16057] Subclasses of JSONEncoder should not be insturcted to call JSONEncoder.decode

R. David Murray added the comment: Thanks Kushal. -- nosy: +r.david.murray resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue16057] Subclasses of JSONEncoder should not be insturcted to call JSONEncoder.decode

Roundup Robot added the comment: New changeset 5d56e1214e95 by R David Murray in branch '3.2': #16057: Clarify why the base method default is called in custom encoders. http://hg.python.org/cpython/rev/5d56e1214e95 New changeset 5f76e7db97ac by R David Murray in branch '3.3': Merge #16057: Clari

[issue17447] str.identifier shouldn't accept Python keywords

Matthew Barnett added the comment: I already use it in the regex module for named groups. I don't think it would ever be a problem in practice because the names are invariably handled as strings. -- nosy: +mrabarnett ___ Python tracker

[issue17409] resource.setrlimit doesn't respect -1

Kushal Das added the comment: On Fedora 17, x86_64 ./python Python 3.4.0a0 (default:fb50eb64e097, Feb 22 2013, 11:43:18) [GCC 4.7.2 20120921 (Red Hat 4.7.2-2)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import resource [92450 refs, 32257 blocks] >>> res

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

Kevin Barry added the comment: One additional issue, which my patch doesn't address, is that PyRun_InteractiveLoop should really take *two* FILE* arguments, with the second one being optional. This is because on Linux (and presumably on other *nixes) if a read operation is blocked on a file de

[issue17445] Return the type you accept

Greg Ward added the comment: The particular use case that triggered this: Mercurial's test suite. It runs "hg blah blah" and compares the output against known good output. But Mercurial's output is just bytes, because pretty much everything in a Mercurial repo is just bytes (file data of cours

[issue17416] Clarify docs of os.walk()

Terry J. Reedy added the comment: I considered your point, re-read the walk entry, and still wish to leave it as it is. First, we are not in the business of providing synonyms for everything. Second, The abbreviations BFS and DFS did not immediately register with me, even though I am quite fam

[issue16880] Importing "imp" will fail if dynamic loading not supported

Brett Cannon added the comment: And this was merged into default in http://hg.python.org/cpython/rev/3c3c9ad7c297 but for some reason it didn't show up attached to this issue. -- ___ Python tracker __

[issue16880] Importing "imp" will fail if dynamic loading not supported

Brett Cannon added the comment: In honour of Jeffrey's lightning talk at PyCon 2013, I just committed the fix! -- assignee: christian.heimes -> brett.cannon resolution: -> fixed stage: commit review -> committed/rejected ___ Python tracker

[issue17415] Clarify docs of os.path.normpath()

Terry J. Reedy added the comment: The top of the os doc makes it clear that path = byte string or unicode string and I meant 'string' in that generalized sense. I think 'string' is used that way elsewhere in the 3.x docs. I though of 'text manipulation', but as the doc again makes clear, unix

[issue16880] Importing "imp" will fail if dynamic loading not supported

Roundup Robot added the comment: New changeset d5aa922f97f9 by Brett Cannon in branch '3.3': Issue #16880: _imp.load_dynamic() is not defined on a platform that http://hg.python.org/cpython/rev/d5aa922f97f9 -- nosy: +python-dev ___ Python tracker

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

emmanuel added the comment: Kevin, Indeed the code I submitted can be written entirely in C using pipe fork execl dup2 etc. as you suggest. The only purpose of mixing bash and C is to have a short self-contained file showing the problem. Anyway, whether in C or bash the workaround is less tha

[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors

Changes by Christian Theune : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17299] Test cPickle with real files

Antoine Pitrou added the comment: I think you want to open the files in binary mode, not text mode. -- ___ Python tracker ___ ___ Pyth

[issue17320] os.path.abspath in window7, return error

Amaury Forgeot d'Arc added the comment: There may be an issue with the GetFullPathName system call. Could you copy the result of these functions: import sys, locale print(locale.getdefaultlocale()) print(sys.getdefaultencoding()) -- nosy: +amaury.forgeotdarc ___

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: I'm not sure what is wrong and can't check on Windows, but it is possible that this patch fixes tests. Please check it if you can. -- Added file: http://bugs.python.org/file29433/test_cpickle_fileio.patch ___ Pytho

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

Kevin Barry added the comment: emmanuel, Thanks for the suggestion. Your workaround is exactly the same as using dup2 (in C) to replace stdin/stdout/stderr with the pty, however. If you added the following lines to your C code, it would have the same effect as the command-line redirection in

[issue17299] Test cPickle with real files

Changes by Serhiy Storchaka : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

Changes by emmanuel : Removed file: http://bugs.python.org/file29431/bug.sh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

Changes by emmanuel : Added file: http://bugs.python.org/file29432/bug.sh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue17447] str.identifier shouldn't accept Python keywords

Serhiy Storchaka added the comment: Hmm. I were going to use this method for re's named group (see issue14462). There is a possibility that some third-party code uses it for checking on general Unicode-aware identifiers. The language specifification says that keywords is a subset of identifier

[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors

Christian Theune added the comment: I feel unsure how to help this move along. I agree that making it possible for applications to carefully work with MemoryErrors is a good idea. I don't think heuristics to determine which situation we are in will solve this but make it more spooky. (This is

[issue17415] Clarify docs of os.path.normpath()

Serhiy Storchaka added the comment: os.path.normpath() works not only with strings but with bytes objects too. -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

emmanuel added the comment: run the attached shell script to observe the bug ./bug.sh 0 -> shows the bug ./bug.sh 1 -> shows the expected behaviour (using a workaround) tested on linux with python 2.7 -- Added file: http://bugs.python.org/file29431/bug.sh ___

[issue17447] str.identifier shouldn't accept Python keywords

R. David Murray added the comment: Or maybe 'is_usable_identifier' :) -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-

[issue17446] doctest test finder doesnt find line numbers of properties

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue17415] Clarify docs of os.path.normpath()

Terry J. Reedy added the comment: If foo is a symbolic link, changing A/foo/../B to A/B could change the meaning, so I am sure the rewrite is correct. I used Ezio's version with a few more changes. I particular, I changed 'This collapsing', which is slightly awkward anyway, to 'This string ma

[issue17415] Clarify docs of os.path.normpath()

Roundup Robot added the comment: New changeset ff9636af9505 by Terry Jan Reedy in branch '3.2': Issue #17415: Clarify 'this' referent by moving containing sentence just after http://hg.python.org/cpython/rev/ff9636af9505 New changeset bceb81b0016e by Terry Jan Reedy in branch '2.7': Issue #17415

[issue17447] str.identifier shouldn't accept Python keywords

Florent Xicluna added the comment: According to the documentation, the reserved words are classified as identifiers: http://docs.python.org/3/reference/lexical_analysis.html#keywords There's an easy workaround: >>> from keyword import iskeyword >>> def is_valid_identifier(s): ... return s.

[issue9090] Error code 10035 calling socket.recv() on a socket with a timeout (WSAEWOULDBLOCK - A non-blocking socket operation could not be completed immediately)

Kristján Valur Jónsson added the comment: I will backport this. I have recently seen this happening in 2.7 in our company and it would make sense to fix this before 2.7.4 is released. -- nosy: +kristjan.jonsson ___ Python tracker

[issue17444] multiprocessing.cpu_count() should use hw.availcpu on Mac OS X

Changes by Ned Deily : -- nosy: +ned.deily, ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue17447] str.identifier shouldn't accept Python keywords

New submission from Raymond Hettinger: >>> 'def'.isidentifier() True -- components: Interpreter Core messages: 184389 nosy: rhettinger priority: normal severity: normal status: open title: str.identifier shouldn't accept Python keywords type: behavior versions: Python 3.2, Python 3.3, Py

[issue17443] imaplib.IMAP4_stream subprocess is opened unbuffered but ignores short reads

Gregory P. Smith added the comment: Yes imaplib can be fixed pretty easily and should use buffered IO regardless. I'm pondering if the default behavior of subprocess needs fixing as existing python 2.x code being ported to 3 doesn't expect this changed behavior of the PIPE file objects. It prob

[issue17239] XML vulnerabilities in Python

Antoine Pitrou added the comment: > Since this has dragged on for quite a while, I'm probably just going to > release 2.7.4 with a pointer to defusedxml in the release notes. (docs, > though, perhaps) +1 too. -- nosy: +pitrou ___ Python tracker

[issue17440] Some IO related problems on x86 windows

Antoine Pitrou added the comment: Anyway, I'm now closing the issue as invalid. -- status: open -> closed ___ Python tracker ___ ___ P

[issue17440] Some IO related problems on x86 windows

Antoine Pitrou added the comment: > The time of line 7 was much greater than line 13. Well, yes, reading 70 MB is much longer than reading a single byte :-) > I feel that the underlying system call takes the size argument Indeed it does. It would be totally inefficient if it didn't. > so I gu

[issue17446] doctest test finder doesnt find line numbers of properties

New submission from Ronny Pfannschmidt: examples that are found on a property dont detect the line number class example(object): @property def me(self): """ >>> 1/0 """ pass -- messages: 184384 nosy: Ronny.Pfannschmidt priority: normal severity: normal status: open title

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: Thanks for letting me know about the optimization. I trusted you that the system call is made once, though I looked up code to see if size of the read in buffer is being passed to the C routine. I should apologize though for raising this issue - since it is in

[issue17445] Return the type you accept

Barry A. Warsaw added the comment: On Mar 17, 2013, at 03:10 PM, R. David Murray wrote: >There was a long thread about this on python-dev that might be worth going >back over, where I had the same misconception (that functions should always >return the same type as their arguments). While I thi

[issue17445] Return the type you accept

R. David Murray added the comment: There was a long thread about this on python-dev that might be worth going back over, where I had the same misconception (that functions should always return the same type as their arguments). While I think that should be the default design, it isn't always

[issue17440] Some IO related problems on x86 windows

Antoine Pitrou added the comment: Bytes objects are immutable, so trying to "copy" them doesn't copy anything actually (it's an optimization): >>> b = b"x" *10 >>> id(b) 139720033059920 >>> b2 = b[:] >>> id(b2) 139720033059920 FileIO.read() only calls the underlying read() once, you can check

[issue17094] sys._current_frames() reports too many/wrong stack frames

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16997] subtests

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17445] Return the type you accept

New submission from Barry A. Warsaw: This came up at the Pycon 2013 Python 3 porting clinic. There are many cases in the stdlib that claim (either explicitly or implicitly) to accept bytes or strings, but that don't return the type of the arguments they accept. An example is urllib.parse.quo

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: Sorry, typo in the last post - I meant "in memory - memory copy" not "in place memory copy". -- ___ Python tracker ___ _

[issue17436] pass a file object to hashlib.update

STINNER Victor added the comment: > obj.update(buffer[:size]) This code does an useless memory copy: obj.update(memoryview(buffer)[:size]) can be used instead. -- ___ Python tracker __

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: I did the following to understand time taken for in memory copy: 1>>> fl = io.FileIO('c:/temp9/Capability/Analyzing Data.mp4', 'rb') 2>>> byt = fl.read(70934549) 3>>> byt2 = None 4>>> byt2 = byt[:] 5>>> fl.close() 6>>> fl = io.FileIO('c:/temp9/Capability/Analyzing

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

Changes by emmanuel : -- nosy: +emmanuel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue17440] Some IO related problems on x86 windows

Antoine Pitrou added the comment: > If only one system call is being made, then I think that > fl.read(256) and fl.read(70934549) should take same amount of time to > complete - assuming disk I/O is the time consuming factor in this > operation (as compared to memory processing). What do you me

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: @Antoine It worked. I was wrong to say read1() was not implemented. Sorry. But please do consider other issues. -- ___ Python tracker ___ _

[issue17443] imaplib.IMAP4_stream subprocess is opened unbuffered but ignores short reads

Antoine Pitrou added the comment: I don't think there's any reason to open the subprocess in unbuffered mode (you aren't sharing the stdio streams with anyone else). Just be careful to call flush() on stdin before attempting to read any response from stdout. -- ___

[issue17443] imaplib.IMAP4_stream subprocess is opened unbuffered but ignores short reads

Antoine Pitrou added the comment: os.fdopen() in 2.x would always create a FILE*, and therefore inherit fread()'s semantics even in "unbuffered" mode. In 3.x, unbuffered I/O instead calls read() directly, and happily returns partial reads; this is by design. So, I guess imaplib should be fixed

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: @Antoine - wait I will do it -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: Please consider following before making a decision: >> io.FileIO does not implements single OS system call on read() - instead >> reads a file until EOF i.e. ignores the arguments supplied to read() >Your experiments show otherwise, the argument supplied to rea

[issue17440] Some IO related problems on x86 windows

Antoine Pitrou added the comment: You called read1() on fl (a FileIO object) and not cfl (a BufferedReader object). Your fault for choosing confusing variable names :-) >>> len(fl.read1(70934549)) Traceback (most recent call last): File "", line 1, in len(fl.read1(70934549)) AttributeErr

[issue17444] multiprocessing.cpu_count() should use hw.availcpu on Mac OS X

Changes by Antoine Pitrou : -- stage: -> patch review versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___ __

[issue17440] Some IO related problems on x86 windows

Gurmeet Singh added the comment: Please consider following before making a decision: __ > io.BufferedReader does not implement read1 (the last lines of trace > below) >It does. You made a mistake in your experiment (you called read1() on a FileIO >object, not a BufferedReader object).

[issue17444] multiprocessing.cpu_count() should use hw.availcpu on Mac OS X

Changes by Richard Oudkerk : -- nosy: +sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue17444] multiprocessing.cpu_count() should use hw.availcpu on Mac OS X

New submission from John Szakmeister: While trying to test a fix for Nose, I discovered that multiprocessing is picking up the CPU count incorrectly. It should be using hw.availcpu instead of hw.ncpu. The latter is the number of cpus installed in the system, but the former is the number that

[issue17439] insufficient error message for failed unicode conversion

R. David Murray added the comment: No. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue17439] insufficient error message for failed unicode conversion

anatoly techtonik added the comment: Ok. Does the data (string literals) has a scope? Does Python know at runtime that a string literal stored in its memory was defined in the input stream or a file? -- ___ Python tracker