[issue13742] Add a key parameter (like sorted) to heapq.merge

Raymond Hettinger added the comment: Attaching a rough draft implementation for a fully encapsulated Heap() class that is thread-safe, supports minheaps and maxheaps, and efficiently implements key-functions (called no more than once per key). -- Added file: http://bugs.python.org/file

[issue17538] Document XML Vulnerabilties

Éric Araujo added the comment: LGTM. -- nosy: +eric.araujo versions: +Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17526] inspect.findsource raises undocumented error for code objects with empty filename

Tyler Doyle added the comment: Patch and test to accompany. -- Added file: http://bugs.python.org/file29577/test_inspect.patch ___ Python tracker ___

[issue17526] inspect.findsource raises undocumented error for code objects with empty filename

Changes by Tyler Doyle : -- keywords: +patch Added file: http://bugs.python.org/file29576/inspect.patch ___ Python tracker ___ ___ Pyt

[issue5135] Expose simplegeneric function in functools module

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue15575] Tutorial is unclear on multiple imports of a module.

jamesob added the comment: Howdy; attached is a patch containing the doc changes. I figured that some elaboration was in addition to what r.david.murray recommended, so I've included a brief allusion to the problem of equivalent paths. -- keywords: +patch nosy: +jamesob Added file: htt

[issue17120] Mishandled _POSIX_C_SOURCE and _XOPEN_SOURCE in pyconfig.h

Changes by RAW : -- status: languishing -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17516] Dead code should be removed

STINNER Victor added the comment: Thanks for the different reviews. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

Kevin Barry added the comment: emmanuel, The Python interpreter isn't reentrant, so you could only run two interactive sessions connected to the same Python environment if you implemented your own REPL function that unlocked the GIL when waiting for input, then lock it just long enough to int

[issue17548] unittest.mock: test_create_autospec_unbound_methods is skipped

STINNER Victor added the comment: Oh, there is another skipped test in Lib/unittest/test/testmock/testpatch.py: def test_patch_descriptor(self): # would be some effort to fix this - we could special case the # builtin descriptors: classmethod, property, staticmethod r

[issue17323] Disable [X refs, Y blocks] ouput in debug builds

Roundup Robot added the comment: New changeset 367167f93c30 by Ezio Melotti in branch 'default': #17323: The "[X refs, Y blocks]" printed by debug builds has been disabled by default. It can be re-enabled with the `-X showrefcount` option. http://hg.python.org/cpython/rev/367167f93c30

[issue12718] Logical mistake of importer method in logging.config.BaseConfigurator

Roundup Robot added the comment: New changeset e35eafc872cd by Vinay Sajip in branch '2.7': Issue #12718: Set importer on instance if Python function, to avoid bad interaction with winpdb. http://hg.python.org/cpython/rev/e35eafc872cd -- ___ Python t

[issue17516] Dead code should be removed

STINNER Victor added the comment: test_create_autospec_unbound_methods() of Lib/unittest/test/testmock/testhelpers.py contains dead code because of a known issue. I created issue #17548 to track this function. -- ___ Python tracker

[issue17548] unittest.mock: test_create_autospec_unbound_methods is skipped

New submission from STINNER Victor: While working on #17516, I saw that test_create_autospec_unbound_methods() of Lib/unittest/test/testmock/testhelpers.py is skipped: def test_create_autospec_unbound_methods(self): # see mock issue 128 # this is expected to fail until the i

[issue17516] Dead code should be removed

Roundup Robot added the comment: New changeset 313bcff51900 by Victor Stinner in branch 'default': Issue #17516: use comment syntax for comments, instead of multiline string http://hg.python.org/cpython/rev/313bcff51900 New changeset 33bdd0a985b9 by Victor Stinner in branch 'default': Issue #175

[issue17120] Mishandled _POSIX_C_SOURCE and _XOPEN_SOURCE in pyconfig.h

RAW added the comment: Does anyone ever respond to reported issues here? -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue17120] Mishandled _POSIX_C_SOURCE and _XOPEN_SOURCE in pyconfig.h

Changes by Ezio Melotti : -- stage: -> needs patch versions: -Python 2.6, Python 3.1, Python 3.5 ___ Python tracker ___ ___ Python-b

[issue17120] Mishandled _POSIX_C_SOURCE and _XOPEN_SOURCE in pyconfig.h

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue5445] codecs.StreamWriter.writelines problem when passed generator

Benjamin Peterson added the comment: Agreed. Modern consumers can use the io module. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___

[issue5445] codecs.StreamWriter.writelines problem when passed generator

Marc-Andre Lemburg added the comment: On 25.03.2013 23:11, Terry J. Reedy wrote: > 2. The codecs.writelines entry says "Writes the concatenated list of strings > to the stream (possibly by reusing the write() method)." For the base class, > that is overly restrictive, but I gather that Marc-An

[issue17046] test_subprocess test_executable_without_cwd fails when run with installed python

Ned Deily added the comment: Test is still failing for 3.3.1rc1 and 3.2.4rc1. -- stage: -> needs patch ___ Python tracker ___ ___ Pyt

[issue5445] codecs.StreamWriter.writelines problem when passed generator

Terry J. Reedy added the comment: I find this to be a confusing issue. 1. The arg for .join is any iterable of strings, not just a list. (I think Daniel got that.) Since codecs.py still has "self.write(''.join(list))": a) calling the arg 'list' is doubly wrong. b) there is no iterable featu

[issue17316] Add Django 1.5 to benchmarks

Changes by Brett Cannon : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue17316] Add Django 1.5 to benchmarks

Roundup Robot added the comment: New changeset f4e99b589c5f by Brett Cannon in branch 'default': Issue #17316: Add Django 1.5 to the benchmark suite since it works on http://hg.python.org/benchmarks/rev/f4e99b589c5f -- nosy: +python-dev ___ Python tra

[issue17516] Dead code should be removed

Georg Brandl added the comment: The instance in reindent.py uses the "docstring for attributes" feature that some documentation tools supports, which is a unused string *after* the attribute. When you turn that into a comment, put the comment *before* the attribute. -- nosy: +georg.br

[issue17516] Dead code should be removed

STINNER Victor added the comment: For the dead code in test_posix.py, see issue #9246. -- ___ Python tracker ___ ___ Python-bugs-list

[issue9246] os.getcwd() hardcodes max path len

STINNER Victor added the comment: test_posix.py of Python 3 contains the test, but the test is "disabled" (dead code): def test_getcwd_long_pathnames(self): if hasattr(posix, 'getcwd'): dirname = 'getcwd-test-directory-0123456789abcdef-01234567890abcdef' curdir = os.getcwd()

[issue16880] Importing "imp" will fail if dynamic loading not supported

Changes by Brett Cannon : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Brett Cannon added the comment: Thanks for being so patient, Anuj! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Roundup Robot added the comment: New changeset 3be9e07a2df4 by Brett Cannon in branch 'default': Issue #17317: Have the benchmark count from -h properly reflect the http://hg.python.org/benchmarks/rev/3be9e07a2df4 -- nosy: +python-dev ___ Python track

[issue9246] os.getcwd() hardcodes max path len

STINNER Victor added the comment: For the record, os.getcwd() of Python 2 was improved by 96adf96d861a (issue #2722) to use a dynamic buffer. -- ___ Python tracker ___ __

[issue5135] Expose simplegeneric function in functools module

Changes by Terry J. Reedy : -- stage: -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue5135] Expose simplegeneric function in functools module

Terry J. Reedy added the comment: Guido said "Please don't introduce this without a PEP." and that has not happened and if it did, the result would probably look quite different from the patches. So this is 'unripe' and no current action here is possible. -- nosy: +terry.reedy resoluti

[issue14916] PyRun_InteractiveLoop fails to run interactively when using a Linux pty that's not tied to stdin/stdout

emmanuel added the comment: Kevin, I now fully agree with you. Regarding points 2 & 3 I dismissed modifying sys.stdin/out in python out of hand because it still would not allow to have a proper behaviour with two concurrent consoles on the same interpreter. Anyway this is not a very meaningful

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Gabi Davar added the comment: possibly better patch - uses subprocess' quoting logic for argument handling: diff -r 6fc9103d55f0 PCbuild/build_ssl.py --- a/PCbuild/build_ssl.py Sun Mar 24 14:54:25 2013 -0700 +++ b/PCbuild/build_ssl.py Mon Mar 25 17:28:19 2013 +0200 @@ -47,10 +47,10 @@

[issue886488] popen2 on Windows does not check _fdopen return value

Terry J. Reedy added the comment: In particular, the popen2 entry says " "Deprecated since version 2.6: This module is obsolete. Use the subprocess module. Check especially the Replacing Older Functions with the subprocess Module section." On core-mentorship list, Guido answered 'Sure'. [clo

[issue17544] regex code re-raises exceptions on success

Amaury Forgeot d'Arc added the comment: The returned value and the global indicator are not independent. C functions should not set an error while returning a valid value. The same behavior will occur in random places -- for example, "for x in range(2): pass" also triggers the issue, this is

[issue708007] TelnetPopen3, TelnetBase, Expect split

Terry J. Reedy added the comment: As per Guido's core-mentorship list post: "Please close" -- nosy: +terry.reedy resolution: -> rejected stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue9420] gdbm with /usr/include/ndbm.h

Eric Wald added the comment: The approach used in 2.7.4rc1 also works, building cleanly on LFS 7.2; thank you. -- nosy: +eswald ___ Python tracker ___ ___

[issue17544] regex code re-raises exceptions on success

Zdeněk Pavlas added the comment: static PyObject* foo(PyObject *, PyObject *arg) { void *buf; Py_ssize_t size; if (PyObject_AsReadBuffer(arg, &buf, &size)) size = -1; return PyInt_FromLong(size); } >>> import tst, re >>> re.search("a", "a") <_sre.SRE_Match object at 0xb76

[issue17547] "checking whether gcc supports ParseTuple __format__... " erroneously returns yes with gcc 4.8

New submission from Dave Malcolm: It appears that gcc's -Wformat warning changed from being on by default in gcc 4.7 and earlier to being off by default in gcc 4.8, needing to be enabled with -Wformat (or -Wall), if I'm reading: http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=193304 corre

[issue17429] platform.platform() can throw Unicode error

Toshio Kuratomi added the comment: Patch fixing the issues raised in r.david.murray's review: * Merged _find_linux_release_file() back into linux_distribution() and broke out _UNIXCONFDIR module level variable to enable mocking of the unittest data * Fix already present style issue in linux_dis

[issue17538] Document XML Vulnerabilties

Donald Stufft added the comment: Update looks fine to me, I'm not the best at docs I just wanted to get at least a jumping off point. -- ___ Python tracker ___ _

[issue17544] regex code re-raises exceptions on success

Ezio Melotti added the comment: Can you provide an actual example to reproduce the error? -- ___ Python tracker ___ ___ Python-bugs-li

[issue17538] Document XML Vulnerabilties

Christian Heimes added the comment: Updated patch with more infos and also a link to defusedexpat. -- Added file: http://bugs.python.org/file29572/xmldocs2.diff ___ Python tracker __

[issue10079] idlelib for Python 3 with Guilherme Polo GSoC enhancements

Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue444582] Finding programs in PATH, adding shutil.which

Éric Araujo added the comment: It’s probably too late to address Georg’s comment about reusing os.get_exec_path, so everything is done. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue4630] IDLE: add cursor noblink option

Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue444582] Finding programs in PATH, adding shutil.which

Thomas Kluyver added the comment: Yes, I opened that as issue 16957, and it has been dealt with. So no objection from me to closing this. -- ___ Python tracker ___

[issue17526] inspect.findsource raises undocumented error for code objects with empty filename

Nils Bruin added the comment: The most straightforward change I can think of is to change the line if not sourcefile and file[0] + file[-1] != '<>': to if not sourcefile and (not file or file[0] + file[-1] != '<>'): That solves the problem in the cases I have observed. -- __

[issue444582] Finding programs in PATH, adding shutil.which

Mark Lawrence added the comment: Was a separate issue opened? Is anything outstanding here or can this issue be closed? -- nosy: +BreamoreBoy ___ Python tracker ___ __

[issue17025] reduce multiprocessing.Queue contention

Charles-François Natali added the comment: Committed, thanks! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue17546] rename type returned by locals() to livedict

Eric Snow added the comment: Sorry, didn't mean to change the attributed version. However the 2.7 documentation says the same thing. -- versions: +Python 2.7 -Python 3.4 ___ Python tracker ___

[issue17546] rename type returned by locals() to livedict

Eric Snow added the comment: The documentation seems pretty clear on the nature of the dict returned by locals(). [1] What documentation are you referring to? [1] http://docs.python.org/3.4/library/functions.html#locals -- nosy: +eric.snow type: -> enhancement versions: -Python 2.7,

[issue17025] reduce multiprocessing.Queue contention

Roundup Robot added the comment: New changeset 5022ee7e13a2 by Charles-François Natali in branch 'default': Issue #17025: multiprocessing: Reduce Queue and SimpleQueue contention. http://hg.python.org/cpython/rev/5022ee7e13a2 -- ___ Python tracker

[issue17546] rename type returned by locals() to livedict

New submission from anatoly techtonik: -locals() returns object that does't walk like a duck. +locals() returns object that does't work like a dict. Much of the confusion with locals() comes from the fact that returned object is labelled a dict, but this heisendict changes its behavior when you

[issue6699] IDLE: Warn user about overwriting a file that has a newer version on filesystem

Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17239] XML vulnerabilities in Python

Changes by Raynard Sandwick : -- nosy: +rsandwick3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue17545] os.listdir and os.path.join inconsistent on empty path

R. David Murray added the comment: By the way, you could write this as: localist = os.listdir(path if path else '.') -- ___ Python tracker ___

[issue2771] Test issue

Ezio Melotti added the comment: test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue2771] Test issue

Ezio Melotti added the comment: test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue17545] os.listdir and os.path.join inconsistent on empty path

R. David Murray added the comment: See also issue 6095. However: rdmurray@hey:~>ls '' ls: cannot access : No such file or directory So, the behavior is consistent with the shell. The shell has no equivalent to os.path.join. -- nosy: +r.david.murray _

[issue17540] logging formatter support 'style' key in dictionary config

Changes by R. David Murray : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue12718] Logical mistake of importer method in logging.config.BaseConfigurator

R. David Murray added the comment: See also issue 11470. I admit that this topic confuses me; I'm not sure where the bug is, but it seems to me from reading that issue that assuming the behavior of a builtin is not correct. -- ___ Python tracker <

[issue17545] os.listdir and os.path.join inconsistent on empty path

New submission from Bernard Lang: The empty path '' is considered as an acceptable path in os.path.join, and works as a neutral prefix: print os.path.join('','aaa') ===> aaa which seems rather natural. But it raises an exception when used as a parameter to os.listdir. Logically, it should then

[issue16145] Abort in _csv module

R. David Murray added the comment: It won't be too much longer. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue13802] IDLE Prefernces/Fonts: use multiple alphabets in examples

Changes by Todd Rovito : -- nosy: +roger.serwy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17544] regex code re-raises exceptions on success

New submission from Zdeněk Pavlas: There is a global indicator (per thread) of the last error that occurred. Most functions do not clear this on success, but will set it to indicate the cause of the error on failure. Most functions also return an error indicator, usually NULL if they are supp

[issue12718] Logical mistake of importer method in logging.config.BaseConfigurator

Vinay Sajip added the comment: As suggested in the documentation, you could assign the importer as an attribute of the configurator *instance*, in which case it shouldn't be treated as a bound method. What happens if you use the suggestion in the documentation change referred to here? ---

[issue17541] Importing `webbrowser` module gives NameError in Python 2.7.4rc1

Changes by Ezio Melotti : -- nosy: +benjamin.peterson resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue12718] Logical mistake of importer method in logging.config.BaseConfigurator

Bluebird75 added the comment: This issue is closed, but the problems remain that the current version of winpdb is incompatible with django + python 2.7 . I don't really understsand why the issue is closed without any change to python logging library itself. To sum-up the issue: 1. django uses

[issue17541] Importing `webbrowser` module gives NameError in Python 2.7.4rc1

Gökcen Eraslan added the comment: Yeah, it seems Debian guys forgot to backport these classes: https://github.com/akheron/cpython/blob/master/Lib/webbrowser.py#L275 -- nosy: +gkcn ___ Python tracker __

[issue17538] Document XML Vulnerabilties

Christian Heimes added the comment: Donald: Thanks! I'm going to look at your patch later today. Hynek: Because the preferred way is another: use patched expat and pyexpat C modules of defusedexpat. It's a fix on C level and still allows a sane amount of entity expansions. defusedxml disallows

[issue16475] Support object instancing and recursion in marshal

Ezio Melotti added the comment: > I am unsure about how whatsnew is handled these days. > Is it incrementally updated or managed by someone? It's better to add at least a stub to the whatsnew, even if someone will eventually go through it before the release. -- ___

[issue17541] Importing `webbrowser` module gives NameError in Python 2.7.4rc1

Martin added the comment: This looks like a downstream issue in a patch Debian is applying: -- nosy: +gz _

[issue17538] Document XML Vulnerabilties

Hynek Schlawack added the comment: I feel like there should be a warning in Doc/library/xml.rst too. Is there any actual reason why we don’t ship defusedxml with Python and add an easy way to monkeypatch so there’s as little passive barriers as possible to use XML “safely”? I’m sorry I didn’t

[issue17534] unittest keeps references to test cases alive

Michael Foord added the comment: Issue 11798 is somewhat related. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue17541] Importing `webbrowser` module gives NameError in Python 2.7.4rc1

New submission from Aditya: Python 2.7.4rc1 (default, Mar 25 2013, 00:32:18) [GCC 4.7.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import webbrowser Traceback (most recent call last): File "", line 1, in File "/usr/lib/python2.7/webbrowser.py", lin

[issue16475] Support object instancing and recursion in marshal

Kristján Valur Jónsson added the comment: Thanks, Martin, for clarifying this. Glad you are seeing improvements Amaury. In fact, large modules can get additional improvements by identifying identical generated constructs from the compiler, like tuples and strings. The compiler isn't very good

[issue17514] Add the license to argparse.py

Antoine Pitrou added the comment: > > I'm not sure that's correct, unless only Steven has ever contributed > > to it. To be correct, you'd have to list all significant contributors. > > Well, then add "and contributors" :) But we have quite a few files > with such a header (one person), which w

[issue17514] Add the license to argparse.py

Georg Brandl added the comment: > I'm not sure that's correct, unless only Steven has ever contributed > to it. To be correct, you'd have to list all significant contributors. Well, then add "and contributors" :) But we have quite a few files with such a header (one person), which would be wro

[issue17526] inspect.findsource raises undocumented error for code objects with empty filename

Tyler Doyle added the comment: It looks like file is getting set to '' and then indexed on line 553 below, hitting the IndexError before we ever get to IOError. --550--- file = getfile(object) <-- file = '' sourcefile = getsourcefile(object) if not sourcefile an

[issue17514] Add the license to argparse.py

Antoine Pitrou added the comment: I'm not sure that's correct, unless only Steven has ever contributed to it. To be correct, you'd have to list all significant contributors. But still, the maintenance burden of per-file copyright headers (including the need to bump dates now and then) is non-n