[issue17649] Python/Python-ast.c: No such file or directory

2013-04-07 Thread Ramchandra Apte
Ramchandra Apte added the comment: if the Python/Python-ast.c file does not exist in the Python source directory, try re-extracting it (if the file still doesn't exist then you probably have a corrupt compressed file) -- nosy: +Ramchandra Apte ___

[issue17649] Python/Python-ast.c: No such file or directory

2013-04-07 Thread Ned Deily
Ned Deily added the comment: Python-ast.c is a generated file. As released, a Python source tarball should contain an up-to-date version that does not need to be regenerated. However, if the timestamps of the source files are not preserved, the Makefile may think it is out of date and try to

[issue17585] IDLE - regression with exit() and quit()

2013-04-07 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17585 ___ ___ Python-bugs-list

[issue6649] idlelib/rpc.py missing exit status on exithook

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Congratulation with your first CPython commit, Roger! -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6649 ___

[issue17626] set's __isub__ doesn't support non-sets.

2013-04-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Intentional and documented. 5.7. Set Types — set, frozenset ... Note, the non-operator versions of union(), intersection(), difference(), and symmetric_difference(), issubset(), and issuperset() methods will accept any iterable as an argument. In contrast,

[issue17585] IDLE - regression with exit() and quit()

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps PseudoInputFile.close() should call super().close() to set closed flag. Perhaps close() should be even implemented in PseudoFile. It's my fault in this regression. I deliberately have not implemented PseudoFile.close(), because I saw no sense in

[issue17645] assert fails in _Py_Mangle

2013-04-07 Thread Armin Rigo
Armin Rigo added the comment: You may want to add a test. This might help notice that comparing an integer of type Py_ssize_t to check if it's greater than PY_SSIZE_T_MAX is bogus in C :-( -- resolution: fixed - stage: committed/rejected - test needed

[issue17570] Improve devguide Windows instructions

2013-04-07 Thread Volodymyr Bezkostnyy
Volodymyr Bezkostnyy added the comment: Deleted ./ before python.exe -- keywords: +patch nosy: +asvetlov, webwin Added file: http://bugs.python.org/file29703/issue17570.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570

[issue13249] argparse.ArgumentParser() lists arguments in the wrong order

2013-04-07 Thread Kostyantyn Leschenko
Kostyantyn Leschenko added the comment: I've updated patch to work with current trunk. -- nosy: +Kostyantyn.Leschenko, asvetlov versions: +Python 3.4 -Python 3.2 Added file: http://bugs.python.org/file29704/Issue13249-5.patch ___ Python tracker

[issue17650] There is no exception correspond to errno EROFS

2013-04-07 Thread Андрій Тихонов
New submission from Андрій Тихонов: I found errno.EROFS in Lib/mailbox.py but didn't find exception correspond to this errno. Is it need to be created? -- messages: 186185 nosy: pitrou, Андрій.Тихонов priority: normal severity: normal status: open title: There is no exception

[issue17206] Py_XDECREF() expands its argument multiple times

2013-04-07 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17206 ___ ___

[issue17645] assert fails in _Py_Mangle

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: The crash is very obscure, I don't think we want to bother with a unit test for that (it took 14 seconds to crash or pass here). This might help notice that comparing an integer of type Py_ssize_t to check if it's greater than PY_SSIZE_T_MAX is bogus in C

[issue1521051] Allow passing DocTestRunner and DocTestCase in doctest

2013-04-07 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1521051 ___ ___

[issue2756] urllib2 add_header fails with existing unredirected_header

2013-04-07 Thread Volodymyr Antonevych
Volodymyr Antonevych added the comment: Test urllib2 file -- nosy: +volodyaa Added file: http://bugs.python.org/file29705/1.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2756 ___

[issue2756] urllib2 add_header fails with existing unredirected_header

2013-04-07 Thread Volodymyr Antonevych
Volodymyr Antonevych added the comment: Test HTTP server -- Added file: http://bugs.python.org/file29706/s.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2756 ___

[issue6640] urlparse should parse mailto: URL headers as query parameters

2013-04-07 Thread Volodymyr Bezkostnyy
Volodymyr Bezkostnyy added the comment: Tested on 3.4 urllib.parse.urlparse(mailto:f...@example.com?subject=hi;) ParseResult(scheme='mailto', netloc='', path='f...@example.com', params='', query='subject=hi', fragment='') Work as expected. -- nosy: +asvetlov, webwin

[issue17343] Add a version of str.split which returns an iterator

2013-04-07 Thread Georg Brandl
Georg Brandl added the comment: I'm guessing Terry wanted to say os.listdir instead of os.walk. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17343 ___

[issue17610] Qsort function misuse in typeobject.c

2013-04-07 Thread Georg Brandl
Changes by Georg Brandl ge...@python.org: -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17610 ___ ___ Python-bugs-list

[issue17570] Improve devguide Windows instructions

2013-04-07 Thread Georg Brandl
Georg Brandl added the comment: At least two of the changes in the patch are incorrect because they refer to the Mac OS X python.exe. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570

[issue16658] Missing return in HTTPConnection.send()

2013-04-07 Thread Evgen Koval
Evgen Koval added the comment: I reviewed and verified this patch, and it looks correct to me. -- nosy: +Evgen.Koval, asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16658 ___

[issue900112] cgi.fieldStorage doesn't grok standards env. variables

2013-04-07 Thread Evgen Koval
Evgen Koval added the comment: Patch for 3.3 is uploaded. -- nosy: +Evgen.Koval, asvetlov Added file: http://bugs.python.org/file29708/issue900112.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue900112

[issue13249] argparse.ArgumentParser() lists arguments in the wrong order

2013-04-07 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixed in 4712f9f8a90d, 5e5081cdc086, e4beda7cca2f. Thanks. -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue13355] random.triangular error when low = high=mode

2013-04-07 Thread Yuriy Senko
Yuriy Senko added the comment: Added validation of input data. Check whether low = mode = high. If low == high return low as a result. -- nosy: +Chaka_bum, asvetlov Added file: http://bugs.python.org/file29709/issue_13355.patch ___ Python tracker

[issue17570] Improve devguide Windows instructions

2013-04-07 Thread Volodymyr Bezkostnyy
Volodymyr Bezkostnyy added the comment: Revert changes for Mac OS X -- Added file: http://bugs.python.org/file29710/issue17570.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17570 ___

[issue17221] Resort Misc/NEWS

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you, Terry. Here is a new version of a patch for 3.4. New entries move, IDLE section resorted in a chronological order, duplicates removed, some minor things fixed. -- Added file: http://bugs.python.org/file29711/NEWS-3.4_5.patch

[issue17221] Resort Misc/NEWS

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And here is a patch for 3.3. -- Added file: http://bugs.python.org/file29712/NEWS-3.3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17221 ___

[issue17221] Resort Misc/NEWS

2013-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17221 ___ ___

[issue16895] Batch file to mimic 'make' on Windows

2013-04-07 Thread Richard Oudkerk
Richard Oudkerk added the comment: You seem to end your subroutines (or whatever they are called) using goto end rather than exit /b. Since popd follows the end label, does this mean that you get a popd after calling each subroutine? Is this intended and can it cause unmatched pushd/popd-s?

[issue17502] unittest.mock: side_effect iterators ignore DEFAULT

2013-04-07 Thread Yuriy Senko
Yuriy Senko added the comment: Patch ported from http://code.google.com/p/mock/issues/attachmentText?id=190aid=19name=mock.patchtoken=6pDNkNBcNLDftg-PsUE8roPb6T4%3A1363712167613 -- keywords: +patch nosy: +Chaka_bum, asvetlov Added file:

[issue17343] Add a version of str.split which returns an iterator

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: May be str.iter_indices() or even just str.indices()? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17343 ___

[issue1521051] Allow passing DocTestRunner and DocTestCase in doctest

2013-04-07 Thread Kostyantyn Leschenko
Kostyantyn Leschenko added the comment: I've updated patch to work with current trunk and added new params to doctest documentation. -- nosy: +Kostyantyn.Leschenko Added file: http://bugs.python.org/file29714/doctest-configuration-1.diff ___ Python

[issue16551] Cleanup the pure Python pickle implementation

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In response to Alexandre's comment on Rietveld. Access to a local variable is faster than to a global one and the current implementation uses this for struct.pack. I just use same trick for struct.unpack. Here is a microbenchmark which demonstrate some

[issue17552] socket.sendfile()

2013-04-07 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17552 ___ ___

[issue17650] There is no exception correspond to errno EROFS

2013-04-07 Thread Andrey Tykhonov
Andrey Tykhonov added the comment: Also: errno.EXDEV in Lib/distutils/file_util.py errno.ENOTCONN in Lib/poplib.py errno.EINVAL in Lib/subprocess.py errno.ENOTCONN in Lib/smtpd.py, Lib/ssl.py, Lib/imaplib.py errno.EOPNOTSUPP, errno.ENOTSUP, errno.ENOTSUP, errno.ENODATA in Lib/shutil.py

[issue17651] Errno checking replaced by concrete classes inherited from OSError

2013-04-07 Thread Andrey Tykhonov
Changes by Andrey Tykhonov atykho...@gmail.com: -- components: Library (Lib) nosy: asvetlov, atykhonov priority: normal severity: normal status: open title: Errno checking replaced by concrete classes inherited from OSError type: enhancement versions: Python 3.4

[issue17651] Errno checking replaced by concrete classes inherited from OSError

2013-04-07 Thread Andrey Tykhonov
Changes by Andrey Tykhonov atykho...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file29716/issue17651.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17651 ___

[issue17502] unittest.mock: side_effect iterators ignore DEFAULT

2013-04-07 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixed. Thanks -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17502 ___

[issue17650] There is no exception correspond to errno EROFS

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: The rationale for not creating dedicated exception classes is that those errors are not common enough. Since the range of possible errno values is basically unbounded (each system can create their own system-specific errors), trying to cover them all is a

[issue17650] There is no exception correspond to errno EROFS

2013-04-07 Thread Andrey Tykhonov
Changes by Andrey Tykhonov atykho...@gmail.com: -- components: +Library (Lib) type: - enhancement versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17650 ___

[issue16705] Use concrete classes inherited from OSError instead of errno check

2013-04-07 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- dependencies: +Errno checking replaced by concrete classes inherited from OSError ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16705

[issue17650] There is no exception correspond to errno EROFS

2013-04-07 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17650 ___ ___

[issue16705] Use concrete classes inherited from OSError instead of errno check

2013-04-07 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- dependencies: +There is no exception correspond to errno EROFS ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16705 ___

[issue17610] Qsort function misuse in typeobject.c

2013-04-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset eaff15532b3c by Benjamin Peterson in branch '2.7': list slotdefs in offset order rather than sorting them (closes #17610) http://hg.python.org/cpython/rev/eaff15532b3c -- status: open - closed ___ Python

[issue17094] sys._current_frames() reports too many/wrong stack frames

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: if a thread ends up being created/destroyed, I think we can get a deadlock when trying to acquire the head lock. I think it should be turned into an open call if possible. How would you do that in a simple way? Also, as noted by Stefan, shouldn't we also

[issue17644] str.format() crashes

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The first patch looks better for me. It is simpler and I do not sure the thing is worth a complication. -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org

[issue17644] str.format() crashes

2013-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +3.3regression ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17644 ___ ___

[issue13477] tarfile module should have a command line

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Then I propose to add an alternative tarfile command-line interface as Tools/scripts/tar.py for those who prefer a well-known and well-tested traditional interface. -- ___ Python tracker rep...@bugs.python.org

[issue17343] Add a version of str.split which returns an iterator

2013-04-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: I'm guessing Terry wanted to say os.listdir instead of os.walk. yes, sorry. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17343 ___

[issue17618] base85 encoding

2013-04-07 Thread Sijin Joseph
Sijin Joseph added the comment: Is anyone working on this? I'd like to include this in a CPython sprint @MIT on 4/13. -- nosy: +sijinjoseph ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17618

[issue2953] _zip_directory_cache untested and undocumented

2013-04-07 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.3 -Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2953 ___

[issue17618] base85 encoding

2013-04-07 Thread R. David Murray
R. David Murray added the comment: Antoine is talking to Mercurial about relicensing, and I believe at this point it is just a matter of working out the mechanical details (that is, he has an agreement-in-principal from them). -- nosy: +r.david.murray

[issue1875] if 0: return not raising SyntaxError

2013-04-07 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1875 ___

[issue17618] base85 encoding

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: The Mercurial authors have given their informal agreement for a relicensing. OTOH, they must still sign a contributor's agreement. The relicensing would allow us to use their pure Python implementation (in mercurial/pure/base85.py). OTOH, the C implementation

[issue17615] String comparison performance regression

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: On big-endian platform we can use memcmp for 2:2 and 4:4 comparison. I do not sure it will be faster. ;) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17615

[issue15596] pickle: Faster serialization of Unicode strings

2013-04-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 09a84091ae96 by Antoine Pitrou in branch 'default': Issue #15596: Faster pickling of unicode strings. http://hg.python.org/cpython/rev/09a84091ae96 -- nosy: +python-dev ___ Python tracker

[issue15596] pickle: Faster serialization of Unicode strings

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've applied the review comments and committed the patch. Thank you! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue17618] base85 encoding

2013-04-07 Thread Martin Morrison
Martin Morrison added the comment: I wrote an implementation from scratch (based on the wikipedia article; I've not looked at any existing implementations) in pure Python in the attached diff. It includes tests. Feel free to use it as the pure Python implementation if desired, though I won't

[issue17618] base85 encoding

2013-04-07 Thread Martin Morrison
Martin Morrison added the comment: (sorry for spam) Forgot to mention, I included an optional keyword argument to support the 'btoa' shortcut for sequences of space characters as described in the Wikipedia article. However, I'm unsure if any other implementation supports this, so might not

[issue17618] base85 encoding

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Forgot to mention, I included an optional keyword argument to support the 'btoa' shortcut for sequences of space characters as described in the Wikipedia article. However, I'm unsure if any other implementation supports this, so might not be worth including

[issue17618] base85 encoding

2013-04-07 Thread Martin Morrison
Martin Morrison added the comment: Ok, having now looked at mercurial's implementation... it looks like they implemented the RFC1924 version, whereas my implementation is the Ascii85 version (and I verified it against, amongst others: http://www.tools4noobs.com/online_tools/ascii85_encode/ ).

[issue17618] base85 encoding

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: The Ascii85 version is what is used with PDF, and the default output format for the equivalent Ruby library, so seems useful to have. So I guess what might be desirable is to have both in the codebase? Yes, it could be useful to have both. --

[issue17618] base85 encoding

2013-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17618 ___ ___

[issue17618] base85 encoding

2013-04-07 Thread Martin Morrison
Martin Morrison added the comment: Ok, I'm not even sure that Mercurial follows RFC1924! That RFC is specifically for encoding IPv6 addresses, and mandates that the calculations be performed on a 128bit integer. The Mercurial implementation seems to follow the Ascii85 policy of taking each 4

[issue17652] Add skip_on_windows decorator to test.support

2013-04-07 Thread Berker Peksag
New submission from Berker Peksag: I saw a conversation about adding a @skip_on_windows decorator on #python-dev a couple of months ago. Attached a patch with a documentation update. (Added the participants of the conversation to nosy list.) -- components: Tests files:

[issue17650] There is no exception correspond to errno EROFS

2013-04-07 Thread Georg Brandl
Changes by Georg Brandl ge...@python.org: -- resolution: - wont fix status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17650 ___

[issue17651] Errno checking replaced by concrete classes inherited from OSError

2013-04-07 Thread Georg Brandl
New submission from Georg Brandl: Why not attach this to #16705 directly? -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17651 ___

[issue1207589] IDLE: Right Click Context Menu

2013-04-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3fad938e9d4e by Roger Serwy in branch '2.7': #1207589: Backwards-compatibility patch for right-click menu in IDLE. http://hg.python.org/cpython/rev/3fad938e9d4e New changeset c26ec5897c5a by Roger Serwy in branch '3.3': #1207589:

[issue17618] base85 encoding

2013-04-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: So I'm not sure what you want to do. I would suggest a standard Ascii85 encoder is definitely useful, and provides feature parity with Ruby. If we want the standard library to be able to read/write Mercurial/Git base64 encoded files, then I guess that can be

[issue17390] display python version on idle title bar

2013-04-07 Thread Roger Serwy
Roger Serwy added the comment: Issue10747 is tangentially related. It is about adding the python version to the short cuts on Windows. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17390

[issue17628] str==str: compare the first and last character before calling memcmp()

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Note that unicode_eq() always called after identity check and hash check. I.e. identity check in Victor's patch is redundant and unicode_eq() called only for strings which have the same hash. The probability to have the same first byte and be equal is a

[issue17613] IDLE AttributeError: 'NoneType' object has no attribute 'index' from Delegator.py

2013-04-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset ae05d841bea1 by Roger Serwy in branch '2.7': #17613: Prevent traceback when removing syntax colorizer in IDLE. http://hg.python.org/cpython/rev/ae05d841bea1 New changeset 8b793a946acb by Roger Serwy in branch '3.3': #17613: Prevent traceback when

[issue17613] IDLE AttributeError: 'NoneType' object has no attribute 'index' from Delegator.py

2013-04-07 Thread Roger Serwy
Roger Serwy added the comment: Thank you everyone for your patience. I am closing this issue as fixed. -- assignee: - roger.serwy resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17613

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread Richard Oudkerk
Richard Oudkerk added the comment: I don't see how this is a subprocess problem, or could be fixed in subprocess. IIUC, SetConsoleTextAttribute() only has an effect if the output is connected to a console. But that is not the case if you redirect the output to a pipe (which is presumably

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread R. David Murray
R. David Murray added the comment: Oh, good, I thought that was probably the case but I don't know Windows enough to have been sure. Caitlin: if you can prove sbt and me wrong by writing a patch that works (without breaking anything else :), I think it would be considered. Certainly on unix

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 07/04/2013 7:21pm, R. David Murray wrote: Certainly on unix if you write ANSI color codes to stdout and the reader doesn't strip them, they will be preserved and can be redisplayed, so being able to do something similar on Windows would be nice. Although

[issue8523] shutil.rmtree and os.listdir cannot recover on error conditions

2013-04-07 Thread R. David Murray
R. David Murray added the comment: I think this patch looks good, but it needs a documentation update to go with it. Do you want to work on that, Andrew? It also seems as though there's no bug that it is practical to fix here, so I'm changing this to a pure enhancement request. If anyone

[issue16551] Cleanup the pure Python pickle implementation

2013-04-07 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: My point is I would prefer that we keep all optimizations to only the _pickle C module and keep the Python implementation as simple as possible. Also, I doubt the slight speedup shown by your microbenchmark will actually result in any significant

[issue17649] Python/Python-ast.c: No such file or directory

2013-04-07 Thread pfg
pfg added the comment: I looked and the file exists: $ file Python/Python-ast.c Python/Python-ast.c: C source, ASCII text The file appears valid. I touched the files as suggested but I still I get the same error message when running configure. FWIW, the Makefile.pre.in target exists but it

[issue17649] Python/Python-ast.c: No such file or directory

2013-04-07 Thread pfg
pfg added the comment: Correction: The problem does arise during the build process (not configure). Still specifying the touch target for the build or touching manually the files doesn't help :( -- ___ Python tracker rep...@bugs.python.org

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread Caitlin Potter
Caitlin Potter added the comment: I'm not entirely positive that it would be doable, but looking at the subprocess code, it looks like we do have an open handle to the windows stdout buffer, including buffer attributes, so it should be possible to translate coloured attributes into ANSI codes,

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread Caitlin Potter
Caitlin Potter added the comment: however I've tested this same test program in a development environment, *unix* development environment (xterm, ubuntu 12.04), rather. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17647

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

2013-04-07 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10945 ___

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

2013-04-07 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- title: bdist_wininst depends on MBCS codec, unavailable on non-Windows - bdist_wininst depends on MBCS codec, unavailable on non-Windows ___ Python tracker

[issue17649] Python/Python-ast.c: No such file or directory

2013-04-07 Thread Ned Deily
Ned Deily added the comment: I'm afraid it's not likely we'll be able to further resolve this issue without more specific information about exactly the steps you are using to try to build Python, including exactly what version or hg rev id (you say 2.7.2 but the path name says 2.7.4), any

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 07/04/2013 9:02pm, Caitlin Potter wrote: I'm not entirely positive that it would be doable, but looking at the subprocess code, it looks like we do have an open handle to the windows stdout buffer, including buffer attributes, so it should be possible to

[issue12463] Calling SocketServer.shutdown() when server_forever() was not called will hang

2013-04-07 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12463 ___ ___

[issue17653] fix typo in socketserver.rst

2013-04-07 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- assignee: docs@python components: Documentation files: fix.diff keywords: patch nosy: docs@python, tshepang priority: normal severity: normal status: open title: fix typo in socketserver.rst versions: Python 3.3, Python 3.4 Added

[issue17647] subprocess.communicate() should preserve colored output on Windows

2013-04-07 Thread Caitlin Potter
Caitlin Potter added the comment: Then perhaps nothing can be done from the python side of things, that's too bad. On Sun, Apr 7, 2013 at 4:38 PM, Richard Oudkerk rep...@bugs.python.orgwrote: Richard Oudkerk added the comment: On 07/04/2013 9:02pm, Caitlin Potter wrote: I'm not entirely

[issue17649] Python/Python-ast.c: No such file or directory

2013-04-07 Thread pfg
pfg added the comment: Oops.. I am sorry I reported the wrong version, I am using python-2.7.4 just released SHA256 (python/Python-2.7.4.tar.xz) = b6626eb6d07d72351f251116ab14427fc934b5f24e6ebc751356a44a7d23b62d SIZE (python/Python-2.7.4.tar.xz) = 10250644 And I am running something similar

[issue15596] pickle: Faster serialization of Unicode strings

2013-04-07 Thread STINNER Victor
STINNER Victor added the comment: Hi Antoine, I prefer your patch. Great job! 2013/4/7 Antoine Pitrou rep...@bugs.python.org: Antoine Pitrou added the comment: I've applied the review comments and committed the patch. Thank you! -- resolution: - fixed stage: patch review -

[issue16061] performance regression in string replace for 3.3

2013-04-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is an updated patch. Some comments added (I will be grateful for help in the improvement of these comments), an implementation moved to stringlib (a new file Objects/stringlib/replace.h added). unicode_2.patch optimizes only too special case and I

[issue16061] performance regression in string replace for 3.3

2013-04-07 Thread STINNER Victor
STINNER Victor added the comment: str_replace_1char_2.patch looks good to me. Just one nit: please add a reference to this issue in the comment (in replace.h). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16061

[issue15092] Using enum PyUnicode_Kind

2013-04-07 Thread STINNER Victor
STINNER Victor added the comment: Python 3.3 has been released. I'm not sure that we can change the type of PyUnicode_Kind because of the stable API. By the way, I already tried to write a similar patch (use enum). I expected better performances, but it did not change anything. Can we close

[issue13126] find() slower than rfind()

2013-04-07 Thread STINNER Victor
STINNER Victor added the comment: I still see a difference between find and rfind, even if the different is low (11%). $ ./python -m timeit -s 's=ABC*33; a=((s+D)*500+s+E); b=s+E' 'a.find(b)' 1 loops, best of 3: 93.6 usec per loop $ ./python -m timeit -s 's=ABC*33; a=(E+s+(D+s)*500);

[issue15092] Using enum PyUnicode_Kind

2013-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - rejected stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15092

[issue17615] String comparison performance regression

2013-04-07 Thread STINNER Victor
STINNER Victor added the comment: Here is a patch specializing unicode_compare() for each combinaison of (kind1, kind2), to avoid the expensive PyUnicode_READ() macro (2 if). On Linux using GCC -O3 (GCC 4.7), there is no difference since GCC already specialize the loops. It may help other

[issue13126] find() slower than rfind()

2013-04-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset c5e2ea9e3aa7 by Victor Stinner in branch 'default': Close #13126: Simplify FASTSEARCH() code to help the compiler to emit more http://hg.python.org/cpython/rev/c5e2ea9e3aa7 -- nosy: +python-dev resolution: - fixed stage: patch review -

[issue10401] Globals / builtins cache

2013-04-07 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10401 ___ ___ Python-bugs-list

[issue16286] Use hash if available to optimize a==b and a!=b for bytes and str

2013-04-07 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- title: Optimize a==b and a!=b for bytes and str - Use hash if available to optimize a==b and a!=b for bytes and str ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16286

[issue16427] Faster hash implementation

2013-04-07 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16427 ___ ___ Python-bugs-list

  1   2   >